141647 2015-02-16 08:07:34 -0800 REGRESSION(r180050): It broke the !ENABLE(CSS_GRID_LAYOUT) build 2015-02-17 04:02:36 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 141465 1 ossy changseok changseok commit-queue esprehn+autocc kangil.han ossy rniwa oldest_to_newest 1069434 0 ossy 2015-02-16 08:07:34 -0800 error: ../../Source/WebCore/dom/Position.cpp: In member function 'bool WebCore::Position::isCandidate() const': ../../Source/WebCore/dom/Position.cpp:940:82: error: 'RenderGrid' was not declared in this scope 1069441 1 changseok 2015-02-16 08:22:21 -0800 Oops. Sorry for the inconvenience. If nobody is touching on this, let me fix it soon. 1069504 2 246664 changseok 2015-02-16 11:15:19 -0800 Created attachment 246664 Patch 1069505 3 commit-queue 2015-02-16 11:17:58 -0800 Attachment 246664 did not pass style-queue: ERROR: Source/WebCore/dom/Position.cpp:943: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1069525 4 246664 ossy 2015-02-16 12:07:16 -0800 Comment on attachment 246664 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246664&action=review > Source/WebCore/dom/Position.cpp:56 > + No need to guard the include, RenderGrid.h is already guarded. > Source/WebCore/dom/Position.cpp:947 > - if (is<RenderBlockFlow>(*renderer) || is<RenderFlexibleBox>(*renderer) || is<RenderGrid>(*renderer)) { > + if (is<RenderBlockFlow>(*renderer) || is<RenderFlexibleBox>(*renderer) > +#if ENABLE(CSS_GRID_LAYOUT) > + || is<RenderGrid>(*renderer) > +#endif > + ) { Ouch, it is so bad looking. Maybe this one would be a little bit better, but still ugly: if (is<RenderBlockFlow>(*renderer) || #if ENABLE(CSS_GRID_LAYOUT) is<RenderGrid>(*renderer) || #endif is<RenderFlexibleBox>(*renderer)) { ... 1069728 5 246664 changseok 2015-02-16 19:26:32 -0800 Comment on attachment 246664 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246664&action=review Thanks for your comments. =) >> Source/WebCore/dom/Position.cpp:56 >> + > > No need to guard the include, RenderGrid.h is already guarded. O.K Removed. >> Source/WebCore/dom/Position.cpp:947 >> + ) { > > Ouch, it is so bad looking. > > Maybe this one would be a little bit better, but still ugly: > > if (is<RenderBlockFlow>(*renderer) || > #if ENABLE(CSS_GRID_LAYOUT) > is<RenderGrid>(*renderer) || > #endif > is<RenderFlexibleBox>(*renderer)) { > ... Indeed. However a similar ugly look already exists. https://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderBox.cpp#L2373 :P Let me update the patch as you noted. 1069729 6 246717 changseok 2015-02-16 19:28:53 -0800 Created attachment 246717 Patch 1069784 7 246717 ossy 2015-02-16 23:36:38 -0800 Comment on attachment 246717 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246717&action=review r=me > Source/WebCore/ChangeLog:10 > + * dom/Position.cpp: Add a build gard ENABLE(CSS_GRID_LAYOUT) for RenderGrid. typo: gard -> guard 1069798 8 246734 changseok 2015-02-17 00:32:00 -0800 Created attachment 246734 Patch 1069799 9 246735 changseok 2015-02-17 00:35:43 -0800 Created attachment 246735 Patch 1069806 10 246735 commit-queue 2015-02-17 01:42:24 -0800 Comment on attachment 246735 Patch Clearing flags on attachment: 246735 Committed r180213: <http://trac.webkit.org/changeset/180213> 246664 2015-02-16 11:15:19 -0800 2015-02-16 19:28:47 -0800 Patch bug-141647-20150217041513.patch text/plain 2167 changseok U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwMTQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTdkNjVjMTEyMWUyMmVl OTgyZDUxYTRmM2FjMjllOGUwOThmNjBiYy4uNDFkN2I0MTk5YTNkNTFhZDVlNmE2MDQwZThhMjlm ODg1NTNjMzBiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAyLTE2ICBDaGFu Z1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNvbT4KKworICAgICAgICBSRUdSRVNT SU9OKHIxODAwNTApOiBJdCBicm9rZSB0aGUgIUVOQUJMRShDU1NfR1JJRF9MQVlPVVQpIGJ1aWxk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDE2NDcK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcg dGVzdHMgc2luY2UgdGhpcyBqdXN0IGZpeGVzIGEgYnVpbGQgYnJlYWsuCisKKyAgICAgICAgKiBk b20vUG9zaXRpb24uY3BwOiBBZGQgYSBidWlsZCBnYXJkIEVOQUJMRShDU1NfR1JJRF9MQVlPVVQp IGZvciBSZW5kZXJHcmlkLgorICAgICAgICAoV2ViQ29yZTo6UG9zaXRpb246OmlzQ2FuZGlkYXRl KToKKwogMjAxNS0wMi0xNiAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAog ICAgICAgICBGRUdhdXNzaWFuQmx1cjo6Y2FsY3VsYXRlVW5zY2FsZWRLZXJuZWxTaXplIGRvZXMg dW5zcGVha2FibGUgdGhpbmdzIHdpdGggc2lnbmVkIGFuZCB1bnNpZ25lZCB2YWx1ZXMKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Qb3NpdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9k b20vUG9zaXRpb24uY3BwCmluZGV4IDg2NGYwMzFjNDI2NWE4ZGU5YWE3YTE5YmJhMjU2OWE1YmI0 N2ZmNTcuLjhhZDc5ZWRhZmMzZDk5ZWFmMzhmM2IzNmU4YTVmOTk1NWQzYWFkMmUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Qb3NpdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv ZG9tL1Bvc2l0aW9uLmNwcApAQCAtMzYsNyArMzYsNiBAQAogI2luY2x1ZGUgIlBvc2l0aW9uSXRl cmF0b3IuaCIKICNpbmNsdWRlICJSZW5kZXJCbG9jay5oIgogI2luY2x1ZGUgIlJlbmRlckZsZXhp YmxlQm94LmgiCi0jaW5jbHVkZSAiUmVuZGVyR3JpZC5oIgogI2luY2x1ZGUgIlJlbmRlcklubGlu ZS5oIgogI2luY2x1ZGUgIlJlbmRlckl0ZXJhdG9yLmgiCiAjaW5jbHVkZSAiUmVuZGVyTGluZUJy ZWFrLmgiCkBAIC01MCw3ICs0OSwxMSBAQAogI2luY2x1ZGUgPHN0ZGlvLmg+CiAjaW5jbHVkZSA8 d3RmL3RleHQvQ1N0cmluZy5oPgogI2luY2x1ZGUgPHd0Zi91bmljb2RlL0NoYXJhY3Rlck5hbWVz Lmg+Ci0gIAorCisjaWYgRU5BQkxFKENTU19HUklEX0xBWU9VVCkKKyNpbmNsdWRlICJSZW5kZXJH cmlkLmgiCisjZW5kaWYKKwogbmFtZXNwYWNlIFdlYkNvcmUgewogCiB1c2luZyBuYW1lc3BhY2Ug SFRNTE5hbWVzOwpAQCAtOTM3LDcgKzk0MCwxMSBAQCBib29sIFBvc2l0aW9uOjppc0NhbmRpZGF0 ZSgpIGNvbnN0CiAgICAgaWYgKG1fYW5jaG9yTm9kZS0+aGFzVGFnTmFtZShodG1sVGFnKSkKICAg ICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgaWYgKGlzPFJlbmRlckJsb2NrRmxvdz4oKnJlbmRl cmVyKSB8fCBpczxSZW5kZXJGbGV4aWJsZUJveD4oKnJlbmRlcmVyKSB8fCBpczxSZW5kZXJHcmlk PigqcmVuZGVyZXIpKSB7CisgICAgaWYgKGlzPFJlbmRlckJsb2NrRmxvdz4oKnJlbmRlcmVyKSB8 fCBpczxSZW5kZXJGbGV4aWJsZUJveD4oKnJlbmRlcmVyKQorI2lmIEVOQUJMRShDU1NfR1JJRF9M QVlPVVQpCisgICAgICAgIHx8IGlzPFJlbmRlckdyaWQ+KCpyZW5kZXJlcikKKyNlbmRpZgorICAg ICAgICApIHsKICAgICAgICAgUmVuZGVyQmxvY2smIGJsb2NrID0gZG93bmNhc3Q8UmVuZGVyQmxv Y2s+KCpyZW5kZXJlcik7CiAgICAgICAgIGlmIChibG9jay5sb2dpY2FsSGVpZ2h0KCkgfHwgbV9h bmNob3JOb2RlLT5oYXNUYWdOYW1lKGJvZHlUYWcpKSB7CiAgICAgICAgICAgICBpZiAoIVBvc2l0 aW9uOjpoYXNSZW5kZXJlZE5vbkFub255bW91c0Rlc2NlbmRhbnRzV2l0aEhlaWdodChibG9jaykp Cg== 246717 2015-02-16 19:28:53 -0800 2015-02-17 04:02:26 -0800 Patch bug-141647-20150217122847.patch text/plain 1883 changseok U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwMTQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTdkNjVjMTEyMWUyMmVl OTgyZDUxYTRmM2FjMjllOGUwOThmNjBiYy4uNDFkN2I0MTk5YTNkNTFhZDVlNmE2MDQwZThhMjlm ODg1NTNjMzBiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAyLTE2ICBDaGFu Z1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNvbT4KKworICAgICAgICBSRUdSRVNT SU9OKHIxODAwNTApOiBJdCBicm9rZSB0aGUgIUVOQUJMRShDU1NfR1JJRF9MQVlPVVQpIGJ1aWxk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDE2NDcK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcg dGVzdHMgc2luY2UgdGhpcyBqdXN0IGZpeGVzIGEgYnVpbGQgYnJlYWsuCisKKyAgICAgICAgKiBk b20vUG9zaXRpb24uY3BwOiBBZGQgYSBidWlsZCBnYXJkIEVOQUJMRShDU1NfR1JJRF9MQVlPVVQp IGZvciBSZW5kZXJHcmlkLgorICAgICAgICAoV2ViQ29yZTo6UG9zaXRpb246OmlzQ2FuZGlkYXRl KToKKwogMjAxNS0wMi0xNiAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAog ICAgICAgICBGRUdhdXNzaWFuQmx1cjo6Y2FsY3VsYXRlVW5zY2FsZWRLZXJuZWxTaXplIGRvZXMg dW5zcGVha2FibGUgdGhpbmdzIHdpdGggc2lnbmVkIGFuZCB1bnNpZ25lZCB2YWx1ZXMKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Qb3NpdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9k b20vUG9zaXRpb24uY3BwCmluZGV4IDg2NGYwMzFjNDI2NWE4ZGU5YWE3YTE5YmJhMjU2OWE1YmI0 N2ZmNTcuLjk2MmJiMGU4OTlkNWU3Yjg4NDllZWY1ZGFlOTg4ZjI5OTIyZDU1YTMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Qb3NpdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv ZG9tL1Bvc2l0aW9uLmNwcApAQCAtNTAsNyArNTAsNyBAQAogI2luY2x1ZGUgPHN0ZGlvLmg+CiAj aW5jbHVkZSA8d3RmL3RleHQvQ1N0cmluZy5oPgogI2luY2x1ZGUgPHd0Zi91bmljb2RlL0NoYXJh Y3Rlck5hbWVzLmg+Ci0gIAorCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIHVzaW5nIG5hbWVzcGFj ZSBIVE1MTmFtZXM7CkBAIC05MzcsNyArOTM3LDExIEBAIGJvb2wgUG9zaXRpb246OmlzQ2FuZGlk YXRlKCkgY29uc3QKICAgICBpZiAobV9hbmNob3JOb2RlLT5oYXNUYWdOYW1lKGh0bWxUYWcpKQog ICAgICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICBpZiAoaXM8UmVuZGVyQmxvY2tGbG93PigqcmVu ZGVyZXIpIHx8IGlzPFJlbmRlckZsZXhpYmxlQm94PigqcmVuZGVyZXIpIHx8IGlzPFJlbmRlckdy aWQ+KCpyZW5kZXJlcikpIHsKKyAgICBpZiAoaXM8UmVuZGVyQmxvY2tGbG93PigqcmVuZGVyZXIp CisjaWYgRU5BQkxFKENTU19HUklEX0xBWU9VVCkKKyAgICAgICAgfHwgaXM8UmVuZGVyR3JpZD4o KnJlbmRlcmVyKQorI2VuZGlmCisgICAgICAgIHx8IGlzPFJlbmRlckZsZXhpYmxlQm94PigqcmVu ZGVyZXIpKSB7CiAgICAgICAgIFJlbmRlckJsb2NrJiBibG9jayA9IGRvd25jYXN0PFJlbmRlckJs b2NrPigqcmVuZGVyZXIpOwogICAgICAgICBpZiAoYmxvY2subG9naWNhbEhlaWdodCgpIHx8IG1f YW5jaG9yTm9kZS0+aGFzVGFnTmFtZShib2R5VGFnKSkgewogICAgICAgICAgICAgaWYgKCFQb3Np dGlvbjo6aGFzUmVuZGVyZWROb25Bbm9ueW1vdXNEZXNjZW5kYW50c1dpdGhIZWlnaHQoYmxvY2sp KQo= 246734 2015-02-17 00:32:00 -0800 2015-02-17 04:02:36 -0800 Patch bug-141647-20150217173153.patch text/plain 1884 changseok U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwMTQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTdkNjVjMTEyMWUyMmVl OTgyZDUxYTRmM2FjMjllOGUwOThmNjBiYy4uNjdhMzdiZWE1ODBmZTlhY2VkZTBmODg1YTViZDgz NTIyMTI3YTI2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAyLTE2ICBDaGFu Z1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNvbT4KKworICAgICAgICBSRUdSRVNT SU9OKHIxODAwNTApOiBJdCBicm9rZSB0aGUgIUVOQUJMRShDU1NfR1JJRF9MQVlPVVQpIGJ1aWxk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDE2NDcK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcg dGVzdHMgc2luY2UgdGhpcyBqdXN0IGZpeGVzIGEgYnVpbGQgYnJlYWsuCisKKyAgICAgICAgKiBk b20vUG9zaXRpb24uY3BwOiBBZGQgYSBidWlsZCBndWFyZCBFTkFCTEUoQ1NTX0dSSURfTEFZT1VU KSBmb3IgUmVuZGVyR3JpZC4KKyAgICAgICAgKFdlYkNvcmU6OlBvc2l0aW9uOjppc0NhbmRpZGF0 ZSk6CisKIDIwMTUtMDItMTYgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAK ICAgICAgICAgRkVHYXVzc2lhbkJsdXI6OmNhbGN1bGF0ZVVuc2NhbGVkS2VybmVsU2l6ZSBkb2Vz IHVuc3BlYWthYmxlIHRoaW5ncyB3aXRoIHNpZ25lZCBhbmQgdW5zaWduZWQgdmFsdWVzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vUG9zaXRpb24uY3BwIGIvU291cmNlL1dlYkNvcmUv ZG9tL1Bvc2l0aW9uLmNwcAppbmRleCA4NjRmMDMxYzQyNjVhOGRlOWFhN2ExOWJiYTI1NjlhNWJi NDdmZjU3Li45NjJiYjBlODk5ZDVlN2I4ODQ5ZWVmNWRhZTk4OGYyOTkyMmQ1NWEzIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vUG9zaXRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2RvbS9Qb3NpdGlvbi5jcHAKQEAgLTUwLDcgKzUwLDcgQEAKICNpbmNsdWRlIDxzdGRpby5oPgog I2luY2x1ZGUgPHd0Zi90ZXh0L0NTdHJpbmcuaD4KICNpbmNsdWRlIDx3dGYvdW5pY29kZS9DaGFy YWN0ZXJOYW1lcy5oPgotICAKKwogbmFtZXNwYWNlIFdlYkNvcmUgewogCiB1c2luZyBuYW1lc3Bh Y2UgSFRNTE5hbWVzOwpAQCAtOTM3LDcgKzkzNywxMSBAQCBib29sIFBvc2l0aW9uOjppc0NhbmRp ZGF0ZSgpIGNvbnN0CiAgICAgaWYgKG1fYW5jaG9yTm9kZS0+aGFzVGFnTmFtZShodG1sVGFnKSkK ICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgaWYgKGlzPFJlbmRlckJsb2NrRmxvdz4oKnJl bmRlcmVyKSB8fCBpczxSZW5kZXJGbGV4aWJsZUJveD4oKnJlbmRlcmVyKSB8fCBpczxSZW5kZXJH cmlkPigqcmVuZGVyZXIpKSB7CisgICAgaWYgKGlzPFJlbmRlckJsb2NrRmxvdz4oKnJlbmRlcmVy KQorI2lmIEVOQUJMRShDU1NfR1JJRF9MQVlPVVQpCisgICAgICAgIHx8IGlzPFJlbmRlckdyaWQ+ KCpyZW5kZXJlcikKKyNlbmRpZgorICAgICAgICB8fCBpczxSZW5kZXJGbGV4aWJsZUJveD4oKnJl bmRlcmVyKSkgewogICAgICAgICBSZW5kZXJCbG9jayYgYmxvY2sgPSBkb3duY2FzdDxSZW5kZXJC bG9jaz4oKnJlbmRlcmVyKTsKICAgICAgICAgaWYgKGJsb2NrLmxvZ2ljYWxIZWlnaHQoKSB8fCBt X2FuY2hvck5vZGUtPmhhc1RhZ05hbWUoYm9keVRhZykpIHsKICAgICAgICAgICAgIGlmICghUG9z aXRpb246Omhhc1JlbmRlcmVkTm9uQW5vbnltb3VzRGVzY2VuZGFudHNXaXRoSGVpZ2h0KGJsb2Nr KSkK 246735 2015-02-17 00:35:43 -0800 2015-02-17 01:42:24 -0800 Patch bug-141647-20150217173537.patch text/plain 1832 changseok U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwMjExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzVkZmYzYWFhZTRlMGYy NjMxMmQ1ZDc2ZGQ4ZTIxMmRmYTUyMWE4MS4uYTdkNTg1NTdkMzMxMjQyOWJkMDBmZjEyMzBiOTQw MDY3MDIxYTIzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAyLTE3ICBDaGFu Z1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNvbT4KKworICAgICAgICBSRUdSRVNT SU9OKHIxODAwNTApOiBJdCBicm9rZSB0aGUgIUVOQUJMRShDU1NfR1JJRF9MQVlPVVQpIGJ1aWxk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDE2NDcK KworICAgICAgICBSZXZpZXdlZCBieSBDc2FiYSBPc3p0cm9nb27DoWMuCisKKyAgICAgICAgTm8g bmV3IHRlc3RzIHNpbmNlIHRoaXMganVzdCBmaXhlcyBhIGJ1aWxkIGJyZWFrLgorCisgICAgICAg ICogZG9tL1Bvc2l0aW9uLmNwcDogQWRkIGEgYnVpbGQgZ3VhcmQgRU5BQkxFKENTU19HUklEX0xB WU9VVCkgZm9yIFJlbmRlckdyaWQuCisgICAgICAgIChXZWJDb3JlOjpQb3NpdGlvbjo6aXNDYW5k aWRhdGUpOgorCiAyMDE1LTAyLTE2ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAK ICAgICAgICAgS2VlcCBhbGwgbWVtb3J5IGNhY2hlIHJlc291cmNlcyBpbiBMaXN0SGFzaFNldHMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Qb3NpdGlvbi5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9kb20vUG9zaXRpb24uY3BwCmluZGV4IDg2NGYwMzFjNDI2NWE4ZGU5YWE3YTE5YmJhMjU2 OWE1YmI0N2ZmNTcuLjk2MmJiMGU4OTlkNWU3Yjg4NDllZWY1ZGFlOTg4ZjI5OTIyZDU1YTMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Qb3NpdGlvbi5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvZG9tL1Bvc2l0aW9uLmNwcApAQCAtNTAsNyArNTAsNyBAQAogI2luY2x1ZGUgPHN0ZGlv Lmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvQ1N0cmluZy5oPgogI2luY2x1ZGUgPHd0Zi91bmljb2Rl L0NoYXJhY3Rlck5hbWVzLmg+Ci0gIAorCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIHVzaW5nIG5h bWVzcGFjZSBIVE1MTmFtZXM7CkBAIC05MzcsNyArOTM3LDExIEBAIGJvb2wgUG9zaXRpb246Omlz Q2FuZGlkYXRlKCkgY29uc3QKICAgICBpZiAobV9hbmNob3JOb2RlLT5oYXNUYWdOYW1lKGh0bWxU YWcpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICBpZiAoaXM8UmVuZGVyQmxvY2tGbG93 PigqcmVuZGVyZXIpIHx8IGlzPFJlbmRlckZsZXhpYmxlQm94PigqcmVuZGVyZXIpIHx8IGlzPFJl bmRlckdyaWQ+KCpyZW5kZXJlcikpIHsKKyAgICBpZiAoaXM8UmVuZGVyQmxvY2tGbG93PigqcmVu ZGVyZXIpCisjaWYgRU5BQkxFKENTU19HUklEX0xBWU9VVCkKKyAgICAgICAgfHwgaXM8UmVuZGVy R3JpZD4oKnJlbmRlcmVyKQorI2VuZGlmCisgICAgICAgIHx8IGlzPFJlbmRlckZsZXhpYmxlQm94 PigqcmVuZGVyZXIpKSB7CiAgICAgICAgIFJlbmRlckJsb2NrJiBibG9jayA9IGRvd25jYXN0PFJl bmRlckJsb2NrPigqcmVuZGVyZXIpOwogICAgICAgICBpZiAoYmxvY2subG9naWNhbEhlaWdodCgp IHx8IG1fYW5jaG9yTm9kZS0+aGFzVGFnTmFtZShib2R5VGFnKSkgewogICAgICAgICAgICAgaWYg KCFQb3NpdGlvbjo6aGFzUmVuZGVyZWROb25Bbm9ueW1vdXNEZXNjZW5kYW50c1dpdGhIZWlnaHQo YmxvY2spKQo=