141645 2015-02-16 07:16:29 -0800 ASSERTION FAILED: !length.isUndefined() in WebCore::GridLength::GridLength 2015-02-26 02:58:39 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 116980 1 rhodovan.u-szeged svillar andersca cdumez darin jfernandez kling rego simon.fraser svillar oldest_to_newest 1069426 0 246651 rhodovan.u-szeged 2015-02-16 07:16:29 -0800 Created attachment 246651 Test case Load this with debug WK: <!DOCTYPE html> <style> title { -webkit-grid: dense row 755ex; } </style> <title> Backtrace: ASSERTION FAILED: !length.isUndefined() ../../Source/WebCore/rendering/style/GridLength.h(51) : WebCore::GridLength::GridLength(const WebCore::Length&) Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7fff94ed1700 (LWP 10281)] 0x00007fffed74709f in WTFCrash () at ../../Source/WTF/wtf/Assertions.cpp:321 321 *(int *)(uintptr_t)0xbbadbeef = 0; #0 0x00007fffed74709f in WTFCrash () at ../../Source/WTF/wtf/Assertions.cpp:321 #1 0x00007ffff2d08544 in WebCore::GridLength::GridLength (this=0x7fffffff5390, length=...) at ../../Source/WebCore/rendering/style/GridLength.h:51 #2 0x00007ffff3e01f9c in WebCore::StyleBuilderConverter::createGridTrackBreadth (primitiveValue=..., styleResolver=...) at ../../Source/WebCore/css/StyleBuilderConverter.h:769 #3 0x00007ffff3e02062 in WebCore::StyleBuilderConverter::createGridTrackSize (value=..., styleResolver=...) at ../../Source/WebCore/css/StyleBuilderConverter.h:775 #4 0x00007ffff3e02d21 in WebCore::StyleBuilderConverter::convertGridTrackSize (styleResolver=..., value=...) at ../../Source/WebCore/css/StyleBuilderConverter.h:886 #5 0x00007ffff3e1fa22 in WebCore::StyleBuilderFunctions::applyValueWebkitGridAutoColumns (styleResolver=..., value=...) at DerivedSources/WebCore/StyleBuilder.cpp:3902 #6 0x00007ffff3df399d in WebCore::StyleBuilder::applyProperty (property=WebCore::CSSPropertyWebkitGridAutoColumns, styleResolver=..., value=..., isInitial=false, isInherit=false) at DerivedSources/WebCore/StyleBuilder.cpp:7612 #7 0x00007ffff2e358f1 in WebCore::StyleResolver::applyProperty (this=0x7fffd97e5750, id=WebCore::CSSPropertyWebkitGridAutoColumns, value=0x7fffd9fc1138) at ../../Source/WebCore/css/StyleResolver.cpp:1958 #8 0x00007ffff2e38de5 in WebCore::StyleResolver::CascadedProperties::Property::apply (this=0x7fffffffb3a0, resolver=...) at ../../Source/WebCore/css/StyleResolver.cpp:2684 #9 0x00007ffff2e38f5a in WebCore::StyleResolver::applyCascadedProperties (this=0x7fffd97e5750, cascade=..., firstProperty=18, lastProperty=429) at ../../Source/WebCore/css/StyleResolver.cpp:2714 #10 0x00007ffff2e35352 in WebCore::StyleResolver::applyMatchedProperties (this=0x7fffd97e5750, matchResult=..., element=0x7fffd9ff9528, shouldUseMatchedPropertiesCache=WebCore::StyleResolver::UseMatchedPropertiesCache) at ../../Source/WebCore/css/StyleResolver.cpp:1795 #11 0x00007ffff2e305e2 in WebCore::StyleResolver::styleForElement (this=0x7fffd97e5750, element=0x7fffd9ff9528, defaultParent=0x7fffd9fe7c60, sharingBehavior=WebCore::AllowStyleSharing, matchingBehavior=WebCore::MatchAllRules, regionForStyling=0x0) at ../../Source/WebCore/css/StyleResolver.cpp:803 #12 0x00007ffff2ecf332 in WebCore::Document::styleForElementIgnoringPendingStylesheets (this=0x7fffd8040fc0, element=0x7fffd9ff9528) at ../../Source/WebCore/dom/Document.cpp:1886 #13 0x00007ffff2f396e7 in WebCore::Element::computedStyle (this=0x7fffd9ff9528, pseudoElementSpecifier=WebCore::NOPSEUDO) at ../../Source/WebCore/dom/Element.cpp:2242 #14 0x00007ffff31b3e42 in WebCore::HTMLTitleElement::textWithDirection (this=0x7fffd9ff9528) at ../../Source/WebCore/html/HTMLTitleElement.cpp:87 #15 0x00007ffff31b3d31 in WebCore::HTMLTitleElement::childrenChanged (this=0x7fffd9ff9528, change=...) at ../../Source/WebCore/html/HTMLTitleElement.cpp:70 #16 0x00007ffff2eac2c3 in WebCore::ContainerNode::notifyChildInserted (this=0x7fffd9ff9528, child=..., source=WebCore::ContainerNode::ChildChangeSourceParser) at ../../Source/WebCore/dom/ContainerNode.cpp:338 #17 0x00007ffff2eadfeb in WebCore::ContainerNode::parserAppendChild (this=0x7fffd9ff9528, newChild=...) at ../../Source/WebCore/dom/ContainerNode.cpp:753 #18 0x00007ffff324b54f in WebCore::insert (task=...) at ../../Source/WebCore/html/parser/HTMLConstructionSite.cpp:107 #19 0x00007ffff324b5de in WebCore::executeInsertTask (task=...) at ../../Source/WebCore/html/parser/HTMLConstructionSite.cpp:114 #20 0x00007ffff324b806 in WebCore::executeTask (task=...) at ../../Source/WebCore/html/parser/HTMLConstructionSite.cpp:152 #21 0x00007ffff324e50d in WebCore::HTMLConstructionSite::insertTextNode (this=0x7fffd97e74a0, characters=..., whitespaceMode=WebCore::WhitespaceUnknown) at ../../Source/WebCore/html/parser/HTMLConstructionSite.cpp:576 #22 0x00007ffff328775b in WebCore::HTMLTreeBuilder::processCharacterBuffer (this=0x7fffd97e7480, buffer=...) at ../../Source/WebCore/html/parser/HTMLTreeBuilder.cpp:2478 #23 0x00007ffff3287156 in WebCore::HTMLTreeBuilder::processCharacter (this=0x7fffd97e7480, token=...) at ../../Source/WebCore/html/parser/HTMLTreeBuilder.cpp:2272 #24 0x00007ffff327d183 in WebCore::HTMLTreeBuilder::processToken (this=0x7fffd97e7480, token=...) at ../../Source/WebCore/html/parser/HTMLTreeBuilder.cpp:382 #25 0x00007ffff327cf83 in WebCore::HTMLTreeBuilder::constructTree (this=0x7fffd97e7480, token=...) at ../../Source/WebCore/html/parser/HTMLTreeBuilder.cpp:341 #26 0x00007ffff3255048 in WebCore::HTMLDocumentParser::constructTreeFromHTMLToken (this=0x7fffd8017c80, rawToken=...) at ../../Source/WebCore/html/parser/HTMLDocumentParser.cpp:321 #27 0x00007ffff3254c77 in WebCore::HTMLDocumentParser::pumpTokenizer (this=0x7fffd8017c80, mode=WebCore::HTMLDocumentParser::AllowYield) at ../../Source/WebCore/html/parser/HTMLDocumentParser.cpp:276 #28 0x00007ffff3254597 in WebCore::HTMLDocumentParser::pumpTokenizerIfPossible (this=0x7fffd8017c80, mode=WebCore::HTMLDocumentParser::AllowYield) at ../../Source/WebCore/html/parser/HTMLDocumentParser.cpp:166 #29 0x00007ffff325558b in WebCore::HTMLDocumentParser::append (this=0x7fffd8017c80, inputSource=...) at ../../Source/WebCore/html/parser/HTMLDocumentParser.cpp:391 #30 0x00007ffff2ec47d9 in WebCore::DecodedDataDocumentParser::flush (this=0x7fffd8017c80, writer=...) at ../../Source/WebCore/dom/DecodedDataDocumentParser.cpp:60 #31 0x00007ffff33c1537 in WebCore::DocumentWriter::end (this=0x7fffd801ac20) at ../../Source/WebCore/loader/DocumentWriter.cpp:244 #32 0x00007ffff33acbd1 in WebCore::DocumentLoader::finishedLoading (this=0x7fffd801ab80, finishTime=0) at ../../Source/WebCore/loader/DocumentLoader.cpp:441 #33 0x00007ffff33ac93a in WebCore::DocumentLoader::notifyFinished (this=0x7fffd801ab80, resource=0x7fffd803ca40) at ../../Source/WebCore/loader/DocumentLoader.cpp:375 #34 0x00007ffff3461090 in WebCore::CachedResource::checkNotify (this=0x7fffd803ca40) at ../../Source/WebCore/loader/cache/CachedResource.cpp:293 #35 0x00007ffff346118e in WebCore::CachedResource::finishLoading (this=0x7fffd803ca40) at ../../Source/WebCore/loader/cache/CachedResource.cpp:309 #36 0x00007ffff345d6f5 in WebCore::CachedRawResource::finishLoading (this=0x7fffd803ca40, data=0x7fffd9fc8330) at ../../Source/WebCore/loader/cache/CachedRawResource.cpp:104 #37 0x00007ffff340feb9 in WebCore::SubresourceLoader::didFinishLoading (this=0x7fffd8011000, finishTime=0) at ../../Source/WebCore/loader/SubresourceLoader.cpp:364 #38 0x00007ffff340b7f3 in WebCore::ResourceLoader::didFinishLoading (this=0x7fffd8011000, finishTime=0) at ../../Source/WebCore/loader/ResourceLoader.cpp:542 #39 0x00007ffff3dbe10f in WebCore::readCallback (asyncResult=0x6b31f0, data=0x7fffd9fc4000) at ../../Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:1295 #40 0x00007fffeb27c7e6 in async_ready_callback_wrapper (source_object=0x7c72d0, res=0x6b31f0, user_data=user_data@entry=0x7fffd9fc4000) at ginputstream.c:523 #41 0x00007fffeb2a20e5 in g_task_return_now (task=0x6b31f0) at gtask.c:1077 #42 0x00007fffeb2a2109 in complete_in_idle_cb (task=0x6b31f0) at gtask.c:1086 #43 0x00007fffea55aa1d in g_main_dispatch (context=0x478b00) at gmain.c:3064 #44 g_main_context_dispatch (context=context@entry=0x478b00) at gmain.c:3663 #45 0x00007fffea55ad88 in g_main_context_iterate (context=0x478b00, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at gmain.c:3734 #46 0x00007fffea55b04a in g_main_loop_run (loop=0x901d10) at gmain.c:3928 #47 0x00007ffff44b7750 in WTF::RunLoop::run () at ../../Source/WTF/wtf/gtk/RunLoopGtk.cpp:59 #48 0x00007ffff29a854c in WebKit::ChildProcessMain<WebKit::WebProcess, WebKit::WebProcessMain> (argc=2, argv=0x7fffffffd948) at ../../Source/WebKit2/Shared/unix/ChildProcessMain.h:61 #49 0x00007ffff29a83b1 in WebKit::WebProcessMainUnix (argc=2, argv=0x7fffffffd948) at ../../Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp:77 #50 0x00000000004008d1 in main (argc=2, argv=0x7fffffffd948) at ../../Source/WebKit2/WebProcess/EntryPoint/unix/WebProcessMain.cpp:44 1069803 1 svillar 2015-02-17 01:21:37 -0800 I'll take a look 1069847 2 246742 svillar 2015-02-17 08:57:00 -0800 Created attachment 246742 Patch 1071657 3 svillar 2015-02-24 08:03:41 -0800 Ping reviewers. 1071665 4 246742 cdumez 2015-02-24 08:45:48 -0800 Comment on attachment 246742 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246742&action=review > Source/WebCore/css/CSSPrimitiveValueMappings.h:4590 > + if ((supported & (FixedIntegerConversion | FixedFloatConversion)) && isFontRelativeLength() && convertFontRelativeLengthToLengthRequiresNotNullStyle() && !conversionData.style()) Would "&& !isLength()" be identical? If so, I would prefer this rather than adding than adding a new method with a rather obscure check. 1072043 5 246742 svillar 2015-02-25 04:12:57 -0800 Comment on attachment 246742 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246742&action=review >> Source/WebCore/css/CSSPrimitiveValueMappings.h:4590 >> + if ((supported & (FixedIntegerConversion | FixedFloatConversion)) && isFontRelativeLength() && convertFontRelativeLengthToLengthRequiresNotNullStyle() && !conversionData.style()) > > Would "&& !isLength()" be identical? If so, I would prefer this rather than adding than adding a new method with a rather obscure check. No it wouldn't because for a CSS_EMS the result of !isLength() would be false while the new method would return true. The point is that the last check "!conversionData.style()" only makes sense if the relative length is not CSS_REMS, because the conversion from CSS_REMS to double does not require accessing the style(). 1072100 6 246742 cdumez 2015-02-25 11:14:00 -0800 Comment on attachment 246742 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246742&action=review r=me with nits. > Source/WebCore/ChangeLog:8 > + This bug has been here since r110848 but was uncovered by Are you sure about this revision number? It looks unrelated. > Source/WebCore/css/CSSPrimitiveValue.h:294 > + bool convertFontRelativeLengthToLengthRequiresNotNullStyle() const How about moving all the checks to this utility function? Also, I would move this outside the class and mark it as inline. e.g. inline bool CSSPrimitiveValue::convertingToLengthRequiresNonNullStyle(int lengthConversion) const { // This matches the implementation in CSSPrimitiveValue::computeLengthDouble(). switch (m_primitiveUnitType) { case CSS_EMS: case CSS_EXS: case CSS_CHS: return lengthConversion & (FixedIntegerConversion | FixedFloatConversion); default: return false; } } >>> Source/WebCore/css/CSSPrimitiveValueMappings.h:4590 >>> + if ((supported & (FixedIntegerConversion | FixedFloatConversion)) && isFontRelativeLength() && convertFontRelativeLengthToLengthRequiresNotNullStyle() && !conversionData.style()) >> >> Would "&& !isLength()" be identical? If so, I would prefer this rather than adding than adding a new method with a rather obscure check. > > No it wouldn't because for a CSS_EMS the result of !isLength() would be false while the new method would return true. The point is that the last check "!conversionData.style()" only makes sense if the relative length is not CSS_REMS, because the conversion from CSS_REMS to double does not require accessing the style(). Right, I understand now. I still think this should be refactored somehow to make this less error prone but I don't have a better proposal right now so let's land this with minor changes for now. However, if you update the method above as suggested. This would be: if (convertingToLengthRequiresNonNullStyle(supported) && !conversionData.style()) return Length(Undefined); 1072316 7 svillar 2015-02-26 00:38:33 -0800 (In reply to comment #6) > Comment on attachment 246742 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=246742&action=review > > r=me with nits. > > > Source/WebCore/ChangeLog:8 > > + This bug has been here since r110848 but was uncovered by > > Are you sure about this revision number? It looks unrelated. Indeed it's 110484, the 4 and the 8 were dancing apparently :) > > Source/WebCore/css/CSSPrimitiveValue.h:294 > > + bool convertFontRelativeLengthToLengthRequiresNotNullStyle() const > > How about moving all the checks to this utility function? Also, I would move > this outside the class and mark it as inline. > > e.g. OK makes sense. 1072331 8 svillar 2015-02-26 02:58:39 -0800 Committed r180669: <http://trac.webkit.org/changeset/180669> 246651 2015-02-16 07:16:29 -0800 2015-02-16 07:16:29 -0800 Test case crash.html text/html 86 rhodovan.u-szeged PCFET0NUWVBFIGh0bWw+CjxzdHlsZT4KdGl0bGUgewogICAgLXdlYmtpdC1ncmlkOiBkZW5zZSBy b3cgNzU1ZXg7Cn0KPC9zdHlsZT4KPHRpdGxlPgo= 246742 2015-02-17 08:57:00 -0800 2015-02-25 11:14:00 -0800 Patch bug-141645-20150217175653.patch text/plain 5653 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwMTQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjQ5YjY5ZGExMjViY2Fk ZWZmYmE2NzU3NTE2ZTUxM2M0OWNmNmE5MS4uNDg4ZmVjMzA2MDRkOGQ0MzdmNmY3ZDQ4MTI5NDc4 YTQ1MzAzYzA3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM3IEBACisyMDE1LTAyLTE3ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIEFTU0VSVElP TiBGQUlMRUQ6ICFsZW5ndGguaXNVbmRlZmluZWQoKSBpbiBXZWJDb3JlOjpHcmlkTGVuZ3RoOjpH cmlkTGVuZ3RoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNDE2NDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGlzIGJ1ZyBoYXMgYmVlbiBoZXJlIHNpbmNlIHIxMTA4NDggYnV0IHdhcyB1bmNvdmVyZWQg YnkKKyAgICAgICAgcjE4MDE0MC4gVGhlIHByb2JsZW0gcjExMDg0OCB3YXMgdHJ5aW5nIHRvIGZp eCB3YXMgdGhhdAorICAgICAgICBDU1NQcmltaXRpdmVWYWx1ZTo6Y29udmVydFRvTGVuZ3RoPExl bmd0aD4gZW5kZWQgdXAgY2FsbGluZworICAgICAgICBDU1NQcmltaXRpdmVWYWx1ZTo6Y29tcHV0 ZUxlbmd0aERvdWJsZSgpIHdoaWNoIHdhcyBhcHBhcmVudGx5CisgICAgICAgIGRlcmVmZXJlbmNp bmcgY29udmVyc2lvbkRhdGEuc3R5bGUoKSBhbmQKKyAgICAgICAgY29udmVyc2lvbkRhdGEucm9v dFN0eWxlKCkgcG9pbnRlcnMgd2l0aG91dCBjaGVja2luZyB0aGVtLiBUaGF0J3MKKyAgICAgICAg d2h5IHRoYXQgZml4IGFkZGVkIHRoaXMgY29uZGl0aW9uIHRvIGNvbnZlcnRUb0xlbmd0aCgpOgor CisgICAgICAgIGlzRm9udFJlbGF0aXZlTGVuZ3RoKCkgJiYgKCFjb252ZXJzaW9uRGF0YS5zdHls ZSgpIHx8ICFjb252ZXJzaW9uRGF0YS5yb290U3R5bGUoKSkKKworICAgICAgICB3aGljaCBpcyBu b3QgY29ycmVjdCwgYmVjYXVzZSBmb3IgdGhlIDQgcG9zc2libGUgZm9udCByZWxhdGl2ZQorICAg ICAgICBsZW5ndGggdHlwZXMsIDMgb2YgdGhlbSBqdXN0IHVzZSB0aGUgc3R5bGUoKSBwb2ludGVy IGFuZCB0aGUgb3RoZXIKKyAgICAgICAgb25lIGp1c3QgdXNlcyByb290U3R5bGUoKSB3aGljaCBC VFcgY291bGQgYmUgTlVMTC4gVGhpcyBlcnJvbmVvdXMKKyAgICAgICAgY29uZGl0aW9uIG1ha2Vz IHRoYXQgZnVuY3Rpb24gdG8gcmV0dXJuIExlbmd0aChVbmRlZmluZWQpIG1vcmUKKyAgICAgICAg b2Z0ZW4gdGhhbiBpdCBzaG91bGQuCisKKyAgICAgICAgRnJvbSBub3cgb24gaXQgb25seSByZXR1 cm5zIExlbmd0aChVbmRlZmluZWQpIGlmIHRoZSBzdHlsZSgpCisgICAgICAgIHBvaW50ZXIgaXMg TlVMTCBhbmQgdGhlIGZvbnQgcmVsYXRpdmUgbGVuZ3RoIHR5cGUgaXMgb25lIGluIHRoZQorICAg ICAgICBzZXQgKENTU19FTVMsIENTU19FWFMsIENTU19DSFMpOworCisgICAgICAgIFRlc3Q6IGZh c3QvY3NzLWdyaWQtbGF5b3V0L2dyaWQtd2l0aC1yZWxhdGl2ZS1mb250LWxlbmd0aC1jcmFzaC5o dG1sCisKKyAgICAgICAgKiBjc3MvQ1NTUHJpbWl0aXZlVmFsdWUuaDoKKyAgICAgICAgKFdlYkNv cmU6OkNTU1ByaW1pdGl2ZVZhbHVlOjpjb252ZXJ0Rm9udFJlbGF0aXZlTGVuZ3RoVG9MZW5ndGhS ZXF1aXJlc05vdE51bGxTdHlsZSk6CisgICAgICAgICogY3NzL0NTU1ByaW1pdGl2ZVZhbHVlTWFw cGluZ3MuaDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1ByaW1pdGl2ZVZhbHVlOjpjb252ZXJ0VG9M ZW5ndGgpOgorCiAyMDE1LTAyLTEzICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFtDU1MgR3JpZCBMYXlvdXRdIEludmFsaWQgaW5pdGlhbGl6YXRp b24gb2YgdHJhY2sgc2l6ZXMgd2l0aCBub24gc3Bhbm5pbmcgZ3JpZCBpdGVtcwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlLmggYi9Tb3VyY2UvV2ViQ29y ZS9jc3MvQ1NTUHJpbWl0aXZlVmFsdWUuaAppbmRleCA1MDg3NGVlZDRhOTAwOTNiOTc4YWRlYWFl MDNiZmNlMjZmNzQ0MGFiLi4yM2M3NTU0ODY0MzNjZDZjODUwNDM4ZjEzN2U5NDE1YjEzN2Y5MzYx IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJpbWl0aXZlVmFsdWUuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJpbWl0aXZlVmFsdWUuaApAQCAtMjkxLDYgKzI5MSwx MiBAQCBwdWJsaWM6CiAgICAgLy8gQ29udmVydHMgdG8gYSBMZW5ndGgsIG1hcHBpbmcgdmFyaW91 cyB1bml0IHR5cGVzIGFwcHJvcHJpYXRlbHkuCiAgICAgdGVtcGxhdGU8aW50PiBMZW5ndGggY29u dmVydFRvTGVuZ3RoKGNvbnN0IENTU1RvTGVuZ3RoQ29udmVyc2lvbkRhdGEmKSBjb25zdDsKIAor ICAgIGJvb2wgY29udmVydEZvbnRSZWxhdGl2ZUxlbmd0aFRvTGVuZ3RoUmVxdWlyZXNOb3ROdWxs U3R5bGUoKSBjb25zdAorICAgIHsKKyAgICAgICAgQVNTRVJUKGlzRm9udFJlbGF0aXZlTGVuZ3Ro KCkpOworICAgICAgICByZXR1cm4gbV9wcmltaXRpdmVVbml0VHlwZSAhPSBDU1NfUkVNUzsKKyAg ICB9CisKICAgICAvLyB1c2Ugd2l0aCBjYXJlISEhCiAgICAgdm9pZCBzZXRQcmltaXRpdmVUeXBl KHVuc2lnbmVkIHNob3J0IHR5cGUpIHsgbV9wcmltaXRpdmVVbml0VHlwZSA9IHR5cGU7IH0KIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlTWFwcGluZ3Mu aCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1ZU1hcHBpbmdzLmgKaW5kZXgg ZDcyMzM3N2JlYTU1M2M3Njg3MzNhOTk2NzQwNTU5YjJhNzZiNDE2OC4uODEwNzhlOGZmMDBkZWMw MDlhMTYzMmI3MzZlY2UxMDBlYmNkY2U0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3Nz L0NTU1ByaW1pdGl2ZVZhbHVlTWFwcGluZ3MuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NT UHJpbWl0aXZlVmFsdWVNYXBwaW5ncy5oCkBAIC00NTg3LDcgKzQ1ODcsNyBAQCBlbnVtIExlbmd0 aENvbnZlcnNpb24gewogCiB0ZW1wbGF0ZTxpbnQgc3VwcG9ydGVkPiBMZW5ndGggQ1NTUHJpbWl0 aXZlVmFsdWU6OmNvbnZlcnRUb0xlbmd0aChjb25zdCBDU1NUb0xlbmd0aENvbnZlcnNpb25EYXRh JiBjb252ZXJzaW9uRGF0YSkgY29uc3QKIHsKLSAgICBpZiAoKHN1cHBvcnRlZCAmIChGaXhlZElu dGVnZXJDb252ZXJzaW9uIHwgRml4ZWRGbG9hdENvbnZlcnNpb24pKSAmJiBpc0ZvbnRSZWxhdGl2 ZUxlbmd0aCgpICYmICghY29udmVyc2lvbkRhdGEuc3R5bGUoKSB8fCAhY29udmVyc2lvbkRhdGEu cm9vdFN0eWxlKCkpKQorICAgIGlmICgoc3VwcG9ydGVkICYgKEZpeGVkSW50ZWdlckNvbnZlcnNp b24gfCBGaXhlZEZsb2F0Q29udmVyc2lvbikpICYmIGlzRm9udFJlbGF0aXZlTGVuZ3RoKCkgJiYg Y29udmVydEZvbnRSZWxhdGl2ZUxlbmd0aFRvTGVuZ3RoUmVxdWlyZXNOb3ROdWxsU3R5bGUoKSAm JiAhY29udmVyc2lvbkRhdGEuc3R5bGUoKSkKICAgICAgICAgcmV0dXJuIExlbmd0aChVbmRlZmlu ZWQpOwogICAgIGlmICgoc3VwcG9ydGVkICYgRml4ZWRJbnRlZ2VyQ29udmVyc2lvbikgJiYgaXNM ZW5ndGgoKSkKICAgICAgICAgcmV0dXJuIGNvbXB1dGVMZW5ndGg8TGVuZ3RoPihjb252ZXJzaW9u RGF0YSk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKaW5kZXggY2ZhNzQxZmQ0MzEwODQ3ZDBlMDEzMzE2ZjBhYTRkNDBhNzM3OTBiMi4u N2JiNGUyMTYwZDgzMDk0ZWEwMDljMTdiN2Q0YTNiMWE1ODg4M2MyMiAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsx LDEzIEBACisyMDE1LTAyLTE3ICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEu Y29tPgorCisgICAgICAgIEFTU0VSVElPTiBGQUlMRUQ6ICFsZW5ndGguaXNVbmRlZmluZWQoKSBp biBXZWJDb3JlOjpHcmlkTGVuZ3RoOjpHcmlkTGVuZ3RoCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDE2NDUKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvY3NzLWdyaWQtbGF5b3V0L2dyaWQtd2l0 aC1yZWxhdGl2ZS1mb250LWxlbmd0aC1jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAg ICAqIGZhc3QvY3NzLWdyaWQtbGF5b3V0L2dyaWQtd2l0aC1yZWxhdGl2ZS1mb250LWxlbmd0aC1j cmFzaC5odG1sOiBBZGRlZC4KKwogMjAxNS0wMi0xNiAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2 aWxsYXJAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBVcGxvYWRpbmcgYSBuZXcg dGVzdCB0aGF0IHNob3VsZCBoYXZlIGJlZW4gdXBsb2FkZWQgYXMKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2Zhc3QvY3NzLWdyaWQtbGF5b3V0L2dyaWQtd2l0aC1yZWxhdGl2ZS1mb250LWxlbmd0 aC1jcmFzaC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9n cmlkLXdpdGgtcmVsYXRpdmUtZm9udC1sZW5ndGgtY3Jhc2gtZXhwZWN0ZWQudHh0Cm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAuLjcyZjYyMThhZjg2ODkxNDdhODVkOWQyYjc4M2U0YzhjYmNlYjJlNTIKLS0tIC9kZXYvbnVs bAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9ncmlkLXdpdGgtcmVsYXRp dmUtZm9udC1sZW5ndGgtY3Jhc2gtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEgQEAKK1RoZSB0ZXN0 IFBBU1NFUyBpZiBpdCBkb2VzIG5vdCBjcmFzaCBvbiBEZWJ1ZyBidWlsZHMuCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9ncmlkLXdpdGgtcmVsYXRpdmUtZm9u dC1sZW5ndGgtY3Jhc2guaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzLWdyaWQtbGF5b3V0L2dy aWQtd2l0aC1yZWxhdGl2ZS1mb250LWxlbmd0aC1jcmFzaC5odG1sCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjNkNzYy YTcxN2EzODhkNzA5ZmUzMDg1ZDM5MzMzMjE3NGI5OWY4ZTIKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9ncmlkLXdpdGgtcmVsYXRpdmUtZm9udC1s ZW5ndGgtY3Jhc2guaHRtbApAQCAtMCwwICsxLDEzIEBACis8IURPQ1RZUEUgaHRtbD4KKzxzdHls ZT4KK3RpdGxlIHsKKyAgICAtd2Via2l0LWdyaWQ6IGRlbnNlIHJvdyAxZXg7Cit9Cis8L3N0eWxl PgorPHRpdGxlPgorPC90aXRsZT4KKzxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KK2lm ICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKzwvc2Ny aXB0PgorPHA+VGhlIHRlc3QgUEFTU0VTIGlmIGl0IGRvZXMgbm90IGNyYXNoIG9uIERlYnVnIGJ1 aWxkcy48L3A+Cg==