141644 2015-02-16 06:53:18 -0800 Assertion in disk cache code with redirect to a non-http resource 2015-02-16 12:52:44 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned ap commit-queue oldest_to_newest 1069423 0 koivisto 2015-02-16 06:53:18 -0800 ASSERTION FAILED: response.url().protocolIsInHTTPFamily() /Users/antti/webkit/OpenSource/Source/WebCore/loader/cache/CacheValidation.cpp(106) : double WebCore::computeFreshnessLifetimeForHTTPFamily(const WebCore::ResourceResponse &, double) 1 0x107b7cad0 WTFCrash 2 0x1093b4751 WebCore::computeFreshnessLifetimeForHTTPFamily(WebCore::ResourceResponse const&, double) 3 0x10453d6a7 WebKit::NetworkResourceLoader::didFinishLoading(WebCore::ResourceHandle*, double) 4 0x10b1c6293 __76-[WebCoreResourceHandleAsOperationQueueDelegate connectionDidFinishLoading:]_block_invoke 5 0x7fff92371323 _dispatch_call_block_and_release 6 0x7fff9236cc13 _dispatch_client_callout 1069424 1 koivisto 2015-02-16 06:54:44 -0800 rdar://problem/19751042 1069425 2 246650 koivisto 2015-02-16 07:09:06 -0800 Created attachment 246650 patch 1069450 3 246650 commit-queue 2015-02-16 09:16:27 -0800 Comment on attachment 246650 patch Clearing flags on attachment: 246650 Committed r180148: <http://trac.webkit.org/changeset/180148> 1069451 4 commit-queue 2015-02-16 09:16:30 -0800 All reviewed patches have been landed. Closing bug. 1069455 5 246650 ap 2015-02-16 09:22:43 -0800 Comment on attachment 246650 patch View in context: https://bugs.webkit.org/attachment.cgi?id=246650&action=review > Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:265 > + if (!originalRequest.url().protocolIsInHTTPFamily() || !response.isHTTP()) { This "in HTTP family" vs. "HTTP" naming is quite misleading. 1069496 6 koivisto 2015-02-16 10:57:33 -0800 How so? 1069523 7 ap 2015-02-16 11:48:15 -0800 The reason for the lengthy "protocolIsInHTTPFamily" name is that it makes it clearer that it includes HTTPS. "isHTTP" doesn't make that clear, and when in the same line with "protocolIsInHTTPFamily" in particular, it actively hints that it doesn't include https, which is untrue. 1069524 8 koivisto 2015-02-16 12:04:09 -0800 URLs and responses are quite different types of objects though. To me it seems clear that an "HTTP response" covers HTTPS too (there is no NSHTTPSURLResponse either). 1069527 9 ap 2015-02-16 12:35:07 -0800 > URLs and responses are quite different types of objects though What is the difference? Both are used for arbitrary URLs, there is no difference at all. I see your reference to Foundation naming scheme, however it's not a fair comparison, those names are ancient, and they don't need to play well with naming in WebKit. 1069535 10 koivisto 2015-02-16 12:52:44 -0800 In any case, patches are welcome if you have naming improvements. 246650 2015-02-16 07:09:06 -0800 2015-02-16 09:16:27 -0800 patch disk-cache-redirect-to-data.patch text/plain 5136 koivisto SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MDE0MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE1LTAyLTE2ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBBc3NlcnRpb24gaW4gZGlzayBj YWNoZSBjb2RlIHdpdGggcmVkaXJlY3QgdG8gYSBub24taHR0cCByZXNvdXJjZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxNjQ0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9O ZXR3b3JrUmVzb3VyY2VMb2FkZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrUmVzb3Vy Y2VMb2FkZXI6OmRpZEZpbmlzaExvYWRpbmcpOgorCisgICAgICAgICAgICBDaGVjayB0aGF0IHJl c3BvbnNlIGlzIEhUVFAgYmVmb3JlIGNhbGxpbmcgY29tcHV0ZUZyZXNobmVzc0xpZmV0aW1lRm9y SFRUUEZhbWlseS4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNo ZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OmNhblN0b3JlKToKKworICAgICAgICAgICAgRGVueSBz dG9yaW5nIG5vbi1IVFRQIHJlc3BvbnNlcyB0byBjYWNoZSAodGhvdWdoIHRoZSBhYm92ZSBhbHJl YWR5IGNvdmVycyB0aGlzKS4KKwogMjAxNS0wMi0xNCAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFw QGFwcGxlLmNvbT4KIAogICAgICAgICBCdWlsZCBmaXggYWZ0ZXIgPGh0dHA6Ly90cmFjLndlYmtp dC5vcmcvY2hhbmdlc2V0LzE4MDEyMj4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9j ZXNzL05ldHdvcmtSZXNvdXJjZUxvYWRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcAkocmV2aXNpb24gMTgw MTI2KQorKysgU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9h ZGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzI3LDcgKzMyNyw3IEBAIHZvaWQgTmV0d29ya1Jl c291cmNlTG9hZGVyOjpkaWRGaW5pc2hMb2EKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAg fQogICAgICAgICBib29sIGFsbG93U3RhbGUgPSBvcmlnaW5hbFJlcXVlc3QoKS5jYWNoZVBvbGlj eSgpID49IFJldHVybkNhY2hlRGF0YUVsc2VMb2FkOwotICAgICAgICBib29sIGhhc0NhY2hlYWJs ZVJlZGlyZWN0ID0gV2ViQ29yZTo6cmVkaXJlY3RDaGFpbkFsbG93c1JldXNlKG1fcmVkaXJlY3RD aGFpbkNhY2hlU3RhdHVzLCBhbGxvd1N0YWxlID8gV2ViQ29yZTo6UmV1c2VFeHBpcmVkUmVkaXJl Y3Rpb24gOiBXZWJDb3JlOjpEb05vdFJldXNlRXhwaXJlZFJlZGlyZWN0aW9uKTsKKyAgICAgICAg Ym9vbCBoYXNDYWNoZWFibGVSZWRpcmVjdCA9IG1fcmVzcG9uc2UuaXNIVFRQKCkgJiYgV2ViQ29y ZTo6cmVkaXJlY3RDaGFpbkFsbG93c1JldXNlKG1fcmVkaXJlY3RDaGFpbkNhY2hlU3RhdHVzLCBh bGxvd1N0YWxlID8gV2ViQ29yZTo6UmV1c2VFeHBpcmVkUmVkaXJlY3Rpb24gOiBXZWJDb3JlOjpE b05vdFJldXNlRXhwaXJlZFJlZGlyZWN0aW9uKTsKICAgICAgICAgaWYgKGhhc0NhY2hlYWJsZVJl ZGlyZWN0ICYmIG1fcmVkaXJlY3RDaGFpbkNhY2hlU3RhdHVzLnN0YXR1cyA9PSBSZWRpcmVjdENo YWluQ2FjaGVTdGF0dXM6OkNhY2hlZFJlZGlyZWN0aW9uKSB7CiAgICAgICAgICAgICAvLyBGSVhN RTogQ2FjaGUgdGhlIGFjdHVhbCByZWRpcmVjdHMgaW5zdGVhZCBvZiB0aGUgZW5kIHJlc3VsdC4K ICAgICAgICAgICAgIGRvdWJsZSBub3cgPSBjdXJyZW50VGltZSgpOwpJbmRleDogU291cmNlL1dl YktpdDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUuY3BwCShy ZXZpc2lvbiAxODAxMjYpCisrKyBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9O ZXR3b3JrQ2FjaGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNjIsNyArMjYyLDcgQEAgdm9pZCBO ZXR3b3JrQ2FjaGU6OnJldHJpZXZlKGNvbnN0IFdlYkNvcgogCiBzdGF0aWMgYm9vbCBjYW5TdG9y ZShjb25zdCBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmIG9yaWdpbmFsUmVxdWVzdCwgY29uc3Qg V2ViQ29yZTo6UmVzb3VyY2VSZXNwb25zZSYgcmVzcG9uc2UpCiB7Ci0gICAgaWYgKCFvcmlnaW5h bFJlcXVlc3QudXJsKCkucHJvdG9jb2xJc0luSFRUUEZhbWlseSgpKSB7CisgICAgaWYgKCFvcmln aW5hbFJlcXVlc3QudXJsKCkucHJvdG9jb2xJc0luSFRUUEZhbWlseSgpIHx8ICFyZXNwb25zZS5p c0hUVFAoKSkgewogICAgICAgICBMT0coTmV0d29ya0NhY2hlLCAiKE5ldHdvcmtQcm9jZXNzKSBu b3QgSFRUUCIpOwogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQpJbmRleDogTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNp b24gMTgwMTQzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTQgQEAKKzIwMTUtMDItMTYgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29t PgorCisgICAgICAgIEFzc2VydGlvbiBpbiBkaXNrIGNhY2hlIGNvZGUgd2l0aCByZWRpcmVjdCB0 byBhIG5vbi1odHRwIHJlc291cmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDE2NDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIGh0dHAvdGVzdHMvY2FjaGUvZGlzay1jYWNoZS1yZWRpcmVjdC10by1k YXRhLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogaHR0cC90ZXN0cy9jYWNoZS9kaXNr LWNhY2hlLXJlZGlyZWN0LXRvLWRhdGEuaHRtbDogQWRkZWQuCisgICAgICAgICogaHR0cC90ZXN0 cy9jYWNoZS9yZXNvdXJjZXMvcmVkaXJlY3QtdG8tZGF0YS5waHA6IEFkZGVkLgorCiAyMDE1LTAy LTE2ICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAg IFVucmV2aWV3ZWQuIFVwbG9hZGluZyBhIG5ldyB0ZXN0IHRoYXQgc2hvdWxkIGhhdmUgYmVlbiB1 cGxvYWRlZCBhcwpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9jYWNoZS9kaXNrLWNhY2hl LXJlZGlyZWN0LXRvLWRhdGEtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L2h0dHAvdGVzdHMvY2FjaGUvZGlzay1jYWNoZS1yZWRpcmVjdC10by1kYXRhLWV4cGVjdGVkLnR4 dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMvY2FjaGUvZGlzay1jYWNo ZS1yZWRpcmVjdC10by1kYXRhLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsx LDEwIEBACitUZXN0IHRoYXQgSFRUUCByZWRpcmVjdCB0byBhIGRhdGEgVVJMIGRvZXMgbm90IGNy YXNoIG9yIGFzc2VydCBpbiB0aGUgbmV0d29yayBwcm9jZXNzLgorCitPbiBzdWNjZXNzLCB5b3Ug d2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBD T01QTEVURSIuCisKKworUEFTUyBzdWNjZXNzIGlzIHRydWUKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFy c2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rl c3RzL2NhY2hlL2Rpc2stY2FjaGUtcmVkaXJlY3QtdG8tZGF0YS5odG1sCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL2h0dHAvdGVzdHMvY2FjaGUvZGlzay1jYWNoZS1yZWRpcmVjdC10by1kYXRh Lmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2NhY2hlL2Rpc2st Y2FjaGUtcmVkaXJlY3QtdG8tZGF0YS5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsNyBA QAorPHNjcmlwdCBzcmM9Ii9qcy10ZXN0LXJlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3Jp cHQ+Cis8c2NyaXB0IHNyYz1yZXNvdXJjZXMvcmVkaXJlY3QtdG8tZGF0YS5waHA+PC9zY3JpcHQ+ Cis8c2NyaXB0PgorZGVzY3JpcHRpb24oIlRlc3QgdGhhdCBIVFRQIHJlZGlyZWN0IHRvIGEgZGF0 YSBVUkwgZG9lcyBub3QgY3Jhc2ggb3IgYXNzZXJ0IGluIHRoZSBuZXR3b3JrIHByb2Nlc3MuIik7 CitzaG91bGRCZVRydWUoInN1Y2Nlc3MiKTsKKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii9qcy10 ZXN0LXJlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgpJbmRleDogTGF5b3V0VGVz dHMvaHR0cC90ZXN0cy9jYWNoZS9yZXNvdXJjZXMvcmVkaXJlY3QtdG8tZGF0YS5waHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9jYWNoZS9yZXNvdXJjZXMvcmVkaXJlY3Qt dG8tZGF0YS5waHAJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2NhY2hl L3Jlc291cmNlcy9yZWRpcmVjdC10by1kYXRhLnBocAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsx LDQgQEAKKzw/CitoZWFkZXIoJ1N0YXR1czogMzAxIE1vdmVkIFBlcm1hbmVudGx5Jyk7CitoZWFk ZXIoJ0xvY2F0aW9uOiBkYXRhOmFwcGxpY2F0aW9uL2phdmFzY3JpcHQsc3VjY2Vzcz10cnVlOycp OworPz4K