141632 2015-02-15 21:18:46 -0800 Rare case profiling should actually work 2015-02-15 22:19:45 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo oldest_to_newest 1069370 0 fpizlo 2015-02-15 21:18:46 -0800 Currently, the "likelyToTakeSlowCaseMinimumCount" threshold is 100, which is larger than the number of times a typical bytecode instruction will execute before being DFG compiled (that threshold averages around 1000/15 ~ 66). This means that the rare case profiling doesn't actually help us avoid overspeculating. 1069372 1 246634 fpizlo 2015-02-15 22:13:35 -0800 Created attachment 246634 the patch 1069373 2 246634 msaboff 2015-02-15 22:15:22 -0800 Comment on attachment 246634 the patch r=me 1069377 3 fpizlo 2015-02-15 22:19:45 -0800 Landed in http://trac.webkit.org/changeset/180137 246634 2015-02-15 22:13:35 -0800 2015-02-15 22:15:22 -0800 the patch blah.patch text/plain 1879 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTgwMTM2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDE1LTAyLTE1ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg UmFyZSBjYXNlIHByb2ZpbGluZyBzaG91bGQgYWN0dWFsbHkgd29yaworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxNjMyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBUaGlzIHNpbXBsZSBhZGp1 c3RtZW50IGFwcGVhcnMgdG8gYmUgYSAyJSBzcGVlZC11cCBvbiBPY3RhbmUuIE92ZXIgdGltZSwg dGhlIHNsb3cgY2FzZQorICAgICAgICBoZXVyaXN0aWMgaGFzIGVzc2VudGlhbGx5IHN0b3BwZWQg d29ya2luZyBiZWNhdXNlIHRoZSB0eXBpY2FsIGV4ZWN1dGlvbiBjb3VudCB0aHJlc2hvbGQgZm9y IGEKKyAgICAgICAgYnl0ZWNvZGUgaW5zdHJ1Y3Rpb24gaXMgYXJvdW5kIDY2IHdoaWxlIHRoZSBz bG93IGNhc2UgdGhyZXNob2xkIGlzIDEwMDogdmlydHVhbGx5CisgICAgICAgIGd1YXJhbnRlZWlu ZyB0aGF0IHRoZSBERkcgd2lsbCBuZXZlciB0aGluayB0aGF0IGEgYnl0ZWNvZGUgaW5zdHJ1Y3Rp b24gaGFzIHRha2VuIHRoZSBzbG93CisgICAgICAgIGNhc2UgZXZlbiBpZiBpdCB0b29rIGl0IGV2 ZXJ5IHNpbmdsZSB0aW1lLiBTbywgdGhpcyBjaGFuZ2VzIHRoZSBzbG93IGNhc2UgdGhyZXNob2xk IHRvIDIwLgorICAgICAgICAKKyAgICAgICAgSSBjaGVja2VkIGlmIHdlIGNvdWxkIGxvd2VyIHRo aXMgZG93biBmdXJ0aGVyLCBsaWtlIHRvIDEwLiBUaGF0IGlzIHdvcnNlIHRoYW4gMjAsIGFuZCBh Ym91dAorICAgICAgICBhcyBiYWQgYXMgMTAwLgorCisgICAgICAgICogcnVudGltZS9PcHRpb25z Lmg6CisKIDIwMTUtMDItMTUgIEJyaWFuIEouIEJ1cmcgIDxidXJnQGNzLndhc2hpbmd0b24uZWR1 PgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IHJlbW92ZSB1bnVzZWQgWEhSIHJlcGxheSBjb2Rl CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9PcHRpb25zLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9ucy5oCShyZXZpc2lvbiAx ODAxMjcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9PcHRpb25zLmgJKHdvcmtp bmcgY29weSkKQEAgLTIzOSw3ICsyMzksNyBAQCB0eXBlZGVmIGNvbnN0IGNoYXIqIG9wdGlvblN0 cmluZzsKICAgICB2KGludDMyLCBtYXhpbXVtRXhlY3V0aW9uQ291bnRzQmV0d2VlbkNoZWNrcG9p bnRzRm9yQmFzZWxpbmUsIDEwMDApIFwKICAgICB2KGludDMyLCBtYXhpbXVtRXhlY3V0aW9uQ291 bnRzQmV0d2VlbkNoZWNrcG9pbnRzRm9yVXBwZXJUaWVycywgNTAwMDApIFwKICAgICBcCi0gICAg dih1bnNpZ25lZCwgbGlrZWx5VG9UYWtlU2xvd0Nhc2VNaW5pbXVtQ291bnQsIDEwMCkgXAorICAg IHYodW5zaWduZWQsIGxpa2VseVRvVGFrZVNsb3dDYXNlTWluaW11bUNvdW50LCAyMCkgXAogICAg IHYodW5zaWduZWQsIGNvdWxkVGFrZVNsb3dDYXNlTWluaW11bUNvdW50LCAxMCkgXAogICAgIFwK ICAgICB2KHVuc2lnbmVkLCBvc3JFeGl0Q291bnRGb3JSZW9wdGltaXphdGlvbiwgMTAwKSBcCg==