141625 2015-02-15 15:18:23 -0800 UMBRELLA: Consolidate duplicate soft-linked functions 2019-01-18 03:20:23 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 141655 141791 141816 141849 141870 141872 142176 142177 142434 193568 1 ddkilzer webkit-unassigned achristensen benjamin bfulgham eric.carlson jeremyj-wk jer.noble jonlee kling oldest_to_newest 1069330 0 ddkilzer 2015-02-15 15:18:23 -0800 Consolidating duplicate soft-linked functions would remove duplicate code created for each function, and remove/consolidate some static pointers that would cause dirty pages when the soft-linked method is used. Here's a rough estimation of the current duplicate functions: $ grep -r 'SOFT_LINK(' Source/WebCore | cut -d, -f2 | sed -e 's/^ *//' -e 's/ *$//' | sort | uniq -c | sort -n 2 CMNotificationCenterAddListener 2 CMNotificationCenterGetDefaultLocalCenter 2 CMNotificationCenterRemoveListener 2 CMTimeCompare 2 CMTimeCopyAsDictionary 2 CMTimeRangeGetEnd 2 CloseThemeData 2 DrawThemeBackground 2 IsThemeActive 2 IsThemeBackgroundPartiallyTransparent 2 OpenThemeData 2 QTMakeTime 2 paintThemePart 3 CMSampleBufferGetPresentationTimeStamp 3 CMTimeMake 3 CMTimebaseGetTime 4 CMSampleBufferGetFormatDescription 4 CMTimeGetSeconds 4 CMTimeMakeWithSeconds 4 UTTypeCopyPreferredTagWithClass 4 UTTypeCreatePreferredIdentifierForTag I'm not sure how much code space each method takes, though. 1069371 1 ddkilzer 2015-02-15 21:37:31 -0800 This strategy also saves redundant code from duplicate statements like this: SOFT_LINK_FRAMEWORK(CoreMedia) 1069543 2 ddkilzer 2015-02-16 13:05:09 -0800 First pass at consolidating one function: Bug 141655: Consolidate soft-linked CMTimeMakeWithSeconds() function 1075001 3 ddkilzer 2015-03-06 10:17:34 -0800 All the dependent bugs are complete. Moving to RESOLVED/FIXED.