141617 2015-02-14 19:51:08 -0800 [CMAKE] Remove CMakeLists.txt in WK1 port 2015-02-17 08:31:16 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim commit-queue ossy oldest_to_newest 1069263 0 gyuyoung.kim 2015-02-14 19:51:08 -0800 AFAIK, nobody uses cmake in WK1 port. So let's remove it. 1069264 1 246612 gyuyoung.kim 2015-02-14 19:52:17 -0800 Created attachment 246612 Patch 1069298 2 ossy 2015-02-15 01:08:24 -0800 There were some plans to add cmake build system to Apple Mac and Windows ports. Maybe they will need it once. Alex, Peavo? But if they dropped this plan, we could get rid of all these crufts. 1069301 3 gyuyoung.kim 2015-02-15 01:18:28 -0800 (In reply to comment #2) > There were some plans to add cmake build system to Apple Mac > and Windows ports. Maybe they will need it once. Alex, Peavo? If they have a plan to add cmake build system to their WK1 ports, I will drop this removal. 1069349 4 gyuyoung.kim 2015-02-15 18:18:35 -0800 If there is no feedback till tomorrow, I would like to land this patch. If they need to use this removal, feel free to revert this commit then. 1069843 5 246612 commit-queue 2015-02-17 08:31:11 -0800 Comment on attachment 246612 Patch Clearing flags on attachment: 246612 Committed r180220: <http://trac.webkit.org/changeset/180220> 1069844 6 commit-queue 2015-02-17 08:31:16 -0800 All reviewed patches have been landed. Closing bug. 246612 2015-02-14 19:52:17 -0800 2015-02-17 08:31:11 -0800 Patch bug-141617-20150215125213.patch text/plain 6160 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwMTE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDBkYTgyZGE3MTNmZDIwOTcy ZmI0MzJjNDFjOTRlM2M4MmFjZGRhMWMuLjBhNGZkZDc1YzMzY2YwMzViNzBjMTA3NWVjZGJmNGEz N2ZmMzVjMGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTUtMDItMTQgIEd5dXlvdW5n IEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbQ01BS0VdIFJlbW92 ZSBDTWFrZUxpc3RzLnR4dCBpbiBXSzEgcG9ydAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxNjE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDogUmVtb3ZlZC4KKwogMjAxNS0w Mi0wOSAgQnJpYW4gSi4gQnVyZyAgPGJ1cmdAY3Mud2FzaGluZ3Rvbi5lZHU+CiAKICAgICAgICAg V2ViIEluc3BlY3RvcjogcmVtb3ZlIHNvbWUgdW5uZWNlc3NhcnkgSW5zcGVjdG9yIHByZWZpeGVz IGZyb20gY2xhc3MgbmFtZXMgaW4gSW5zcGVjdG9yIG5hbWVzcGFjZQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9DTWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9XZWJLaXQvQ01ha2VMaXN0cy50eHQK ZGVsZXRlZCBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IGU4ZDY5MmVhZTNmMTgxODk3ZGE1NWFmZWY2 NDVlZDAwYzlhNTNkNzQuLjAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAK LS0tIGEvU291cmNlL1dlYktpdC9DTWFrZUxpc3RzLnR4dAorKysgL2Rldi9udWxsCkBAIC0xLDEy NSArMCwwIEBACi1zZXQoV2ViS2l0X0lOQ0xVREVfRElSRUNUT1JJRVMKLSAgICAiJHtDTUFLRV9T T1VSQ0VfRElSfS9Tb3VyY2UiCi0gICAgIiR7SkFWQVNDUklQVENPUkVfRElSfS9Gb3J3YXJkaW5n SGVhZGVycyIKLSAgICAiJHtXRUJLSVRfRElSfSIKLSAgICAiJHtXRUJDT1JFX0RJUn0iCi0gICAg IiR7V0VCQ09SRV9ESVJ9L0ZvcndhcmRpbmdIZWFkZXJzIgotICAgICIke1dFQkNPUkVfRElSfS9N b2R1bGVzL2dlb2xvY2F0aW9uIgotICAgICIke1dFQkNPUkVfRElSfS9Nb2R1bGVzL2ZpbGVzeXN0 ZW0iCi0gICAgIiR7V0VCQ09SRV9ESVJ9L01vZHVsZXMvbWVkaWFzdHJlYW0iCi0gICAgIiR7V0VC Q09SRV9ESVJ9L01vZHVsZXMvbmF2aWdhdG9yY29udGVudHV0aWxzIgotICAgICIke1dFQkNPUkVf RElSfS9Nb2R1bGVzL25ldHdvcmtpbmZvIgotICAgICIke1dFQkNPUkVfRElSfS9Nb2R1bGVzL3dl YmRhdGFiYXNlIgotICAgICIke1dFQkNPUkVfRElSfS9Nb2R1bGVzL3dlYnNvY2tldHMiCi0gICAg IiR7V0VCQ09SRV9ESVJ9L2FjY2Vzc2liaWxpdHkiCi0gICAgIiR7V0VCQ09SRV9ESVJ9L2JpbmRp bmdzL2dlbmVyaWMiCi0gICAgIiR7V0VCQ09SRV9ESVJ9L2JpbmRpbmdzL2pzIgotICAgICIke1dF QkNPUkVfRElSfS9iaW5kaW5ncyIKLSAgICAiJHtXRUJDT1JFX0RJUn0vYnJpZGdlIgotICAgICIk e1dFQkNPUkVfRElSfS9icmlkZ2UvYyIKLSAgICAiJHtXRUJDT1JFX0RJUn0vYnJpZGdlL2pzYyIK LSAgICAiJHtXRUJDT1JFX0RJUn0vY3NzIgotICAgICIke1dFQkNPUkVfRElSfS9kb20iCi0gICAg IiR7V0VCQ09SRV9ESVJ9L2RvbS9kZWZhdWx0IgotICAgICIke1dFQkNPUkVfRElSfS9lZGl0aW5n IgotICAgICIke1dFQkNPUkVfRElSfS9maWxlYXBpIgotICAgICIke1dFQkNPUkVfRElSfS9oaXN0 b3J5IgotICAgICIke1dFQkNPUkVfRElSfS9odG1sIgotICAgICIke1dFQkNPUkVfRElSfS9odG1s L2Zvcm1zIgotICAgICIke1dFQkNPUkVfRElSfS9odG1sL3NoYWRvdyIKLSAgICAiJHtXRUJDT1JF X0RJUn0vaW5zcGVjdG9yIgotICAgICIke1dFQkNPUkVfRElSfS9sb2FkZXIiCi0gICAgIiR7V0VC Q09SRV9ESVJ9L2xvYWRlci9hcmNoaXZlIgotICAgICIke1dFQkNPUkVfRElSfS9sb2FkZXIvYXBw Y2FjaGUiCi0gICAgIiR7V0VCQ09SRV9ESVJ9L2xvYWRlci9pY29uIgotICAgICIke1dFQkNPUkVf RElSfS9sb2FkZXIvY2FjaGUiCi0gICAgIiR7V0VCQ09SRV9ESVJ9L3BhZ2UiCi0gICAgIiR7V0VC Q09SRV9ESVJ9L3BhZ2UvYW5pbWF0aW9uIgotICAgICIke1dFQkNPUkVfRElSfS9wYWdlL3Njcm9s bGluZyIKLSAgICAiJHtXRUJDT1JFX0RJUn0vcGxhdGZvcm0iCi0gICAgIiR7V0VCQ09SRV9ESVJ9 L3BsYXRmb3JtL2FuaW1hdGlvbiIKLSAgICAiJHtXRUJDT1JFX0RJUn0vcGxhdGZvcm0vYXVkaW8i Ci0gICAgIiR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL2dyYXBoaWNzIgotICAgICIke1dFQkNPUkVf RElSfS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzIgotICAgICIke1dFQkNPUkVfRElSfS9wbGF0 Zm9ybS9ncmFwaGljcy9oYXJmYnV6eiIKLSAgICAiJHtXRUJDT1JFX0RJUn0vcGxhdGZvcm0vZ3Jh cGhpY3MvaGFyZmJ1enovbmciCi0gICAgIiR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL2dyYXBoaWNz L29wZW5nbCIKLSAgICAiJHtXRUJDT1JFX0RJUn0vcGxhdGZvcm0vZ3JhcGhpY3MvdHJhbnNmb3Jt cyIKLSAgICAiJHtXRUJDT1JFX0RJUn0vcGxhdGZvcm0vbWVkaWFzdHJlYW0iCi0gICAgIiR7V0VC Q09SRV9ESVJ9L3BsYXRmb3JtL21vY2siCi0gICAgIiR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL25l dHdvcmsiCi0gICAgIiR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL3NxbCIKLSAgICAiJHtXRUJDT1JF X0RJUn0vcGxhdGZvcm0vdGV4dCIKLSAgICAiJHtXRUJDT1JFX0RJUn0vcGx1Z2lucyIKLSAgICAi JHtXRUJDT1JFX0RJUn0vcmVuZGVyaW5nIgotICAgICIke1dFQkNPUkVfRElSfS9yZW5kZXJpbmcv bGluZSIKLSAgICAiJHtXRUJDT1JFX0RJUn0vcmVuZGVyaW5nL3NoYXBlcyIKLSAgICAiJHtXRUJD T1JFX0RJUn0vcmVuZGVyaW5nL3N0eWxlIgotICAgICIke1dFQkNPUkVfRElSfS9zdG9yYWdlIgot ICAgICIke1dFQkNPUkVfRElSfS9zdHlsZSIKLSAgICAiJHtXRUJDT1JFX0RJUn0vc3ZnIgotICAg ICIke1dFQkNPUkVfRElSfS9zdmcvYW5pbWF0aW9uIgotICAgICIke1dFQkNPUkVfRElSfS9zdmcv Z3JhcGhpY3MiCi0gICAgIiR7V0VCQ09SRV9ESVJ9L3N2Zy9wcm9wZXJ0aWVzIgotICAgICIke1dF QkNPUkVfRElSfS93b3JrZXJzIgotICAgICIke0pBVkFTQ1JJUFRDT1JFX0RJUn0iCi0gICAgIiR7 SkFWQVNDUklQVENPUkVfRElSfS9BUEkiCi0gICAgIiR7SkFWQVNDUklQVENPUkVfRElSfS9hc3Nl bWJsZXIiCi0gICAgIiR7SkFWQVNDUklQVENPUkVfRElSfS9ieXRlY29kZSIKLSAgICAiJHtKQVZB U0NSSVBUQ09SRV9ESVJ9L2J5dGVjb21waWxlciIKLSAgICAiJHtKQVZBU0NSSVBUQ09SRV9ESVJ9 L2Rpc2Fzc2VtYmxlciIKLSAgICAiJHtKQVZBU0NSSVBUQ09SRV9ESVJ9L2RmZyIKLSAgICAiJHtK QVZBU0NSSVBUQ09SRV9ESVJ9L2hlYXAiCi0gICAgIiR7SkFWQVNDUklQVENPUkVfRElSfS9kZWJ1 Z2dlciIKLSAgICAiJHtKQVZBU0NSSVBUQ09SRV9ESVJ9L2ludGVycHJldGVyIgotICAgICIke0pB VkFTQ1JJUFRDT1JFX0RJUn0vaml0IgotICAgICIke0pBVkFTQ1JJUFRDT1JFX0RJUn0vbGxpbnQi Ci0gICAgIiR7SkFWQVNDUklQVENPUkVfRElSfS9wYXJzZXIiCi0gICAgIiR7SkFWQVNDUklQVENP UkVfRElSfS9wcm9maWxlciIKLSAgICAiJHtKQVZBU0NSSVBUQ09SRV9ESVJ9L3J1bnRpbWUiCi0g ICAgIiR7V1RGX0RJUn0iCi0gICAgIiR7REVSSVZFRF9TT1VSQ0VTX0pBVkFTQ1JJUFRDT1JFX0RJ Un0iCi0gICAgIiR7REVSSVZFRF9TT1VSQ0VTX1dFQkNPUkVfRElSfSIKLSAgICAiJHtERVJJVkVE X1NPVVJDRVNfRElSfS9Gb3J3YXJkaW5nSGVhZGVycyIKLSAgICAiJHtDTUFLRV9CSU5BUllfRElS fSIKLSkKLQotaWYgKFdURl9VU0VfU09VUCkKLSAgbGlzdChBUFBFTkQgV2ViS2l0X0lOQ0xVREVf RElSRUNUT1JJRVMgIiR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL25ldHdvcmsvc291cCIpCi1lbmRp ZiAoKQotCi1pZiAoV1RGX1VTRV9DVVJMKQotICBsaXN0KEFQUEVORCBXZWJLaXRfSU5DTFVERV9E SVJFQ1RPUklFUyAiJHtXRUJDT1JFX0RJUn0vcGxhdGZvcm0vbmV0d29yay9jdXJsIikKLWVuZGlm ICgpCi0KLXNldChXZWJLaXRfTElCUkFSSUVTCi0gICAgSmF2YVNjcmlwdENvcmUKLSAgICBXVEYK LSAgICBXZWJDb3JlCi0pCi0KLVdFQktJVF9JTkNMVURFX0NPTkZJR19GSUxFU19JRl9FWElTVFMo KQotCi1pbmNsdWRlX2RpcmVjdG9yaWVzKCR7V2ViS2l0X0lOQ0xVREVfRElSRUNUT1JJRVN9KQot YWRkX2xpYnJhcnkoV2ViS2l0ICR7V2ViS2l0X0xJQlJBUllfVFlQRX0gJHtXZWJLaXRfU09VUkNF U30pCi1hZGRfZGVwZW5kZW5jaWVzKFdlYktpdCBXZWJDb3JlKQotdGFyZ2V0X2xpbmtfbGlicmFy aWVzKFdlYktpdCAke1dlYktpdF9MSUJSQVJJRVN9KQotc2V0X3RhcmdldF9wcm9wZXJ0aWVzKFdl YktpdCBQUk9QRVJUSUVTIENPTVBJTEVfREVGSU5JVElPTlMgIkJVSUxESU5HX1dlYktpdDtCVUlM RElOR19XRUJLSVQiKQotc2V0X3RhcmdldF9wcm9wZXJ0aWVzKFdlYktpdCBQUk9QRVJUSUVTIEZP TERFUiAiV2ViS2l0IikKLXNldF90YXJnZXRfcHJvcGVydGllcyhXZWJLaXQgUFJPUEVSVElFUyBM SU5LX0lOVEVSRkFDRV9MSUJSQVJJRVMgIiIpCi0KLWlmIChXZWJLaXRfTElOS19GTEFHUykKLSAg ICBBRERfVEFSR0VUX1BST1BFUlRJRVMoV2ViS2l0IExJTktfRkxBR1MgIiR7V2ViS2l0X0xJTktf RkxBR1N9IikKLWVuZGlmICgpCi0KLWlmIChWRVJTSU9OX1NDUklQVCkKLSAgICBBRERfVEFSR0VU X1BST1BFUlRJRVMoV2ViS2l0IExJTktfRkxBR1MgIiR7VkVSU0lPTl9TQ1JJUFR9IikKLWVuZGlm ICgpCi0KLWlmIChXZWJLaXRfT1VUUFVUX05BTUUpCi0gICAgc2V0X3RhcmdldF9wcm9wZXJ0aWVz KFdlYktpdCBQUk9QRVJUSUVTIE9VVFBVVF9OQU1FICR7V2ViS2l0X09VVFBVVF9OQU1FfSkKLWVu ZGlmICgpCi0KLVBPUFVMQVRFX0xJQlJBUllfVkVSU0lPTihXRUJLSVQpCi1zZXRfdGFyZ2V0X3By b3BlcnRpZXMoV2ViS2l0IFBST1BFUlRJRVMgVkVSU0lPTiAke1dFQktJVF9WRVJTSU9OfSBTT1ZF UlNJT04gJHtXRUJLSVRfVkVSU0lPTl9NQUpPUn0pCi1pbnN0YWxsKFRBUkdFVFMgV2ViS2l0IERF U1RJTkFUSU9OICIke0xJQl9JTlNUQUxMX0RJUn0iKQpkaWZmIC0tZ2l0IGEvQ01ha2VMaXN0cy50 eHQgYi9DTWFrZUxpc3RzLnR4dAppbmRleCAwYTk2MmUzOWYxYjI3MTUyNzk1NjcyZTNiNTQyNmE2 YzdiZmNmNjAwLi5jMGRmMmNmYzE4ZDJhYTc2M2RkZTE0ZGE3NGM0MzZlOTU5MmExNDllIDEwMDY0 NAotLS0gYS9DTWFrZUxpc3RzLnR4dAorKysgYi9DTWFrZUxpc3RzLnR4dApAQCAtMTMyLDcgKzEz Miw2IEBAIGVsc2UgKCkKICAgICBzZXQoV2ViQ29yZV9MSUJSQVJZX1RZUEUgU1RBVElDKQogZW5k aWYgKCkKIAotc2V0KFdlYktpdF9MSUJSQVJZX1RZUEUgU0hBUkVEKQogc2V0KFdlYktpdDJfTElC UkFSWV9UWVBFIFNIQVJFRCkKIHNldChXZWJDb3JlVGVzdFN1cHBvcnRfTElCUkFSWV9UWVBFIFNU QVRJQykKIApkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IGRhMTg1YzUy Yjc3MzkzN2IzMDc0YjUxYmFhZTg4ZTNkNDA2ODdhN2MuLjYyYTNjMWE0OGFkZmQwM2ZhZDYxY2Zi Y2Y1MjY5OWFhYzE2ZmVjMzMgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNCBAQAorMjAxNS0wMi0xNCAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2lt QHNhbXN1bmcuY29tPgorCisgICAgICAgIFtDTUFLRV0gUmVtb3ZlIENNYWtlTGlzdHMudHh0IGlu IFdLMSBwb3J0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNDE2MTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBOb2JvZHkgdXNlcyBDTWFrZSBpbiBXSzEgcG9ydC4gUmVtb3ZlIGl0LgorCisgICAgICAgICog Q01ha2VMaXN0cy50eHQ6CisKIDIwMTUtMDItMTMgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lA d2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByZW1vdmUgZW1wdHkgZGlyZWN0b3Jp ZXMuCg==