141616 2015-02-14 19:28:41 -0800 [Mac] RetainPtr member cleanup, possible leaks 2015-02-14 21:14:48 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned commit-queue darin oldest_to_newest 1069259 0 joepeck 2015-02-14 19:28:41 -0800 * SUMMARY RetainPtr member cleanup, possible leaks. Searching and auditing cases of 'm_.*?=.*?alloc\]' finds some unexpected RetainPtr uses. 1069261 1 246611 joepeck 2015-02-14 19:30:13 -0800 Created attachment 246611 [PATCH] Proposed Fix 1069279 2 246611 kling 2015-02-14 21:09:43 -0800 Comment on attachment 246611 [PATCH] Proposed Fix Nice! r=me 1069280 3 246611 commit-queue 2015-02-14 21:14:41 -0800 Comment on attachment 246611 [PATCH] Proposed Fix Clearing flags on attachment: 246611 Committed r180121: <http://trac.webkit.org/changeset/180121> 1069281 4 commit-queue 2015-02-14 21:14:48 -0800 All reviewed patches have been landed. Closing bug. 246611 2015-02-14 19:30:13 -0800 2015-02-14 21:14:41 -0800 [PATCH] Proposed Fix cleanup-2.patch text/plain 2568 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjZDRlYjY3Li5lOGRkOTAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTUtMDItMTQgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBbTWFjXSBSZXRhaW5QdHIgbWVtYmVyIGNsZWFudXAsIHBvc3NpYmxlIGxlYWtzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDE2MTYKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3Jt L21hYy9QbGF0Zm9ybVNwZWVjaFN5bnRoZXNpemVyTWFjLm1tOgorICAgICAgICAoLVtXZWJTcGVl Y2hTeW50aGVzaXNXcmFwcGVyIHNwZWFrVXR0ZXJhbmNlOl0pOgorICAgICAgICBBZG9wdCB0aGUg YWxsb2NhdGVkIG9iamVjdCB0byBhdm9pZCBhIHBvc3NpYmxlIGxlYWsuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9tYWMvU2Nyb2xsQW5pbWF0b3JNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpTY3Jv bGxBbmltYXRvck1hYzo6U2Nyb2xsQW5pbWF0b3JNYWMpOgorICAgICAgICBBZG9wdCB0byBhdm9p ZCB1bm5lY2Vzc2FyeSByZXRhaW4vYXV0b3JlbGVhc2UuCisKIDIwMTUtMDItMDkgIEJyaWFuIEou IEJ1cmcgIDxidXJnQGNzLndhc2hpbmd0b24uZWR1PgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6 IHJlbW92ZSBzb21lIHVubmVjZXNzYXJ5IEluc3BlY3RvciBwcmVmaXhlcyBmcm9tIGNsYXNzIG5h bWVzIGluIEluc3BlY3RvciBuYW1lc3BhY2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL21hYy9QbGF0Zm9ybVNwZWVjaFN5bnRoZXNpemVyTWFjLm1tIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbWFjL1BsYXRmb3JtU3BlZWNoU3ludGhlc2l6ZXJNYWMubW0KaW5kZXggODZl OGJjOS4uODY4YThlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Bs YXRmb3JtU3BlZWNoU3ludGhlc2l6ZXJNYWMubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbWFjL1BsYXRmb3JtU3BlZWNoU3ludGhlc2l6ZXJNYWMubW0KQEAgLTkwLDcgKzkwLDcgQEAg LSAodm9pZClzcGVha1V0dGVyYW5jZTooV2ViQ29yZTo6UGxhdGZvcm1TcGVlY2hTeW50aGVzaXNV dHRlcmFuY2UgKil1dHRlcmFuY2UKICAgICBBU1NFUlQodXR0ZXJhbmNlKTsKICAgICAKICAgICBp ZiAoIW1fc3ludGhlc2l6ZXIpIHsKLSAgICAgICAgbV9zeW50aGVzaXplciA9IFtbTlNTcGVlY2hT eW50aGVzaXplciBhbGxvY10gaW5pdFdpdGhWb2ljZTpuaWxdOworICAgICAgICBtX3N5bnRoZXNp emVyID0gYWRvcHROUyhbW05TU3BlZWNoU3ludGhlc2l6ZXIgYWxsb2NdIGluaXRXaXRoVm9pY2U6 bmlsXSk7CiAgICAgICAgIFttX3N5bnRoZXNpemVyIHNldERlbGVnYXRlOnNlbGZdOwogICAgIH0K ICAgICAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxBbmlt YXRvck1hYy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxBbmltYXRvck1h Yy5tbQppbmRleCA3MmUwNGZiLi40NDA3NjIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9tYWMvU2Nyb2xsQW5pbWF0b3JNYWMubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbWFjL1Njcm9sbEFuaW1hdG9yTWFjLm1tCkBAIC02NTQsNyArNjU0LDcgQEAgU2Nyb2xs QW5pbWF0b3JNYWM6OlNjcm9sbEFuaW1hdG9yTWFjKFNjcm9sbGFibGVBcmVhKiBzY3JvbGxhYmxl QXJlYSkKICAgICBtX3Njcm9sbEFuaW1hdGlvbkhlbHBlciA9IGFkb3B0TlMoW1tOU0NsYXNzRnJv bVN0cmluZyhAIk5TU2Nyb2xsQW5pbWF0aW9uSGVscGVyIikgYWxsb2NdIGluaXRXaXRoRGVsZWdh dGU6bV9zY3JvbGxBbmltYXRpb25IZWxwZXJEZWxlZ2F0ZS5nZXQoKV0pOwogCiAgICAgbV9zY3Jv bGxiYXJQYWludGVyQ29udHJvbGxlckRlbGVnYXRlID0gYWRvcHROUyhbW1dlYlNjcm9sbGJhclBh aW50ZXJDb250cm9sbGVyRGVsZWdhdGUgYWxsb2NdIGluaXRXaXRoU2Nyb2xsYWJsZUFyZWE6c2Ny b2xsYWJsZUFyZWFdKTsKLSAgICBtX3Njcm9sbGJhclBhaW50ZXJDb250cm9sbGVyID0gW1tbTlND bGFzc0Zyb21TdHJpbmcoQCJOU1Njcm9sbGVySW1wUGFpciIpIGFsbG9jXSBpbml0XSBhdXRvcmVs ZWFzZV07CisgICAgbV9zY3JvbGxiYXJQYWludGVyQ29udHJvbGxlciA9IGFkb3B0TlMoW1tOU0Ns YXNzRnJvbVN0cmluZyhAIk5TU2Nyb2xsZXJJbXBQYWlyIikgYWxsb2NdIGluaXRdKTsKICAgICBb bV9zY3JvbGxiYXJQYWludGVyQ29udHJvbGxlciBzZXREZWxlZ2F0ZTooaWQpbV9zY3JvbGxiYXJQ YWludGVyQ29udHJvbGxlckRlbGVnYXRlLmdldCgpXTsKICAgICBbbV9zY3JvbGxiYXJQYWludGVy Q29udHJvbGxlciBzZXRTY3JvbGxlclN0eWxlOnJlY29tbWVuZGVkU2Nyb2xsZXJTdHlsZSgpXTsK IH0K