141611 2015-02-14 17:39:08 -0800 IncompleteMetaDataCue leak seen on leaks bot 2015-02-14 20:45:02 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned commit-queue darin eric.carlson oldest_to_newest 1069246 0 joepeck 2015-02-14 17:39:08 -0800 IncompleteMetaDataCue leak seen on leaks bot: Leak: 0x7fbb20e7a360 size=32 zone: DefaultMallocZone_0x1082d9000 0x296a4040 0x00007fbb 0x0000d2f0 0x00000000 @@j)............ 0x00015f90 0x00000001 0xb296f800 0x000207fb ._.............. Call stack: [thread 0x7fff7d157300]: | 0x2 | start | main DumpRenderTreeMain.mm:30 | DumpRenderTreeMain(int, char const**) DumpRenderTree.mm:1301 | dumpRenderTree(int, char const**) DumpRenderTree.mm:1179 | runTestingServerLoop() DumpRenderTree.mm:1070 | runTest(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) DumpRenderTree.mm:1886 | CFRunLoopRunSpecific | __CFRunLoopRun | __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ | _dispatch_main_queue_callback_4CF | _dispatch_client_callout | _dispatch_call_block_and_release | __avplayer_fpNotificationCallback_block_invoke | -[AVPlayerItem didChangeValueForKey:] | -[NSObject(NSKeyValueObserverNotification) didChangeValueForKey:] | NSKeyValueDidChange | NSKeyValueNotifyObserver | -[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:] MediaPlayerPrivateAVFoundationObjC.mm:3124 | WebCore::MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification(WebCore::MediaPlayerPrivateAVFoundation::Notification) MediaPlayerPrivateAVFoundation.cpp:811 | WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification() MediaPlayerPrivateAVFoundation.cpp:902 | std::__1::function<void ()>::operator()() const functional:1755 | std::__1::__function::__func<-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]::$_6, std::__1::allocator<-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]::$_6>, void ()>::operator()() functional:1370 | -[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]::$_6::operator()() const MediaPlayerPrivateAVFoundationObjC.mm:3130 | WTF::Function<void ()>::operator()() const Functional.h:704 | WTF::BoundFunctionImpl<WTF::FunctionWrapper<void (WebCore::MediaPlayerPrivateAVFoundationObjC::*)(WTF::RetainPtr<NSArray>, WTF::MediaTime const&)>, void (WebCore::MediaPlayerPrivateAVFoundationObjC*, WTF::RetainPtr<NSArray>, WTF::MediaTime)>::operator()() Functional.h:550 | WTF::FunctionWrapper<void (WebCore::MediaPlayerPrivateAVFoundationObjC::*)(WTF::RetainPtr<NSArray>, WTF::MediaTime const&)>::operator()(WebCore::MediaPlayerPrivateAVFoundationObjC*, WTF::RetainPtr<NSArray>, WTF::MediaTime const&) Functional.h:274 | WebCore::MediaPlayerPrivateAVFoundationObjC::metadataDidArrive(WTF::RetainPtr<NSArray>, WTF::MediaTime const&) MediaPlayerPrivateAVFoundationObjC.mm:2853 | WebCore::InbandMetadataTextTrackPrivateAVF::addDataCue(WTF::MediaTime const&, WTF::MediaTime const&, WTF::PassRefPtr<WebCore::SerializedPlatformRepresentation>, WTF::String const&) InbandMetadataTextTrackPrivateAVF.cpp:67 | operator new(unsigned long) | malloc | malloc_zone_malloc 1069247 1 246606 joepeck 2015-02-14 17:41:42 -0800 Created attachment 246606 [PATCH] Proposed Fix 1069271 2 246606 commit-queue 2015-02-14 20:44:58 -0800 Comment on attachment 246606 [PATCH] Proposed Fix Clearing flags on attachment: 246606 Committed r180118: <http://trac.webkit.org/changeset/180118> 1069272 3 commit-queue 2015-02-14 20:45:02 -0800 All reviewed patches have been landed. Closing bug. 246606 2015-02-14 17:41:42 -0800 2015-02-14 20:44:58 -0800 [PATCH] Proposed Fix leak-1.patch text/plain 5404 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0OWE5MTIxLi41MmJmMjkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTUtMDItMTQgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBJbmNvbXBsZXRlTWV0YURhdGFDdWUgbGVhayBzZWVuIG9uIGxlYWtzIGJvdAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxNjExCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuICAgICAgICAKKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9JbmJhbmRNZXRhZGF0YVRleHRUcmFja1ByaXZh dGVBVkYuaDoKKyAgICAgICAgKFdlYkNvcmU6OkluY29tcGxldGVNZXRhRGF0YUN1ZTo6SW5jb21w bGV0ZU1ldGFEYXRhQ3VlKTogRGVsZXRlZC4KKyAgICAgICAgKFdlYkNvcmU6OkluY29tcGxldGVN ZXRhRGF0YUN1ZTo6fkluY29tcGxldGVNZXRhRGF0YUN1ZSk6IERlbGV0ZWQuCisgICAgICAgIChX ZWJDb3JlOjpJbmNvbXBsZXRlTWV0YURhdGFDdWU6OmN1ZURhdGEpOiBEZWxldGVkLgorICAgICAg ICAoV2ViQ29yZTo6SW5jb21wbGV0ZU1ldGFEYXRhQ3VlOjpzdGFydFRpbWUpOiBEZWxldGVkLgor ICAgICAgICBDb252ZXJ0IHRvIGEgc3RydWN0IGFuZCBob2xkIGEgbGlzdCBvZiBzdHJ1Y3RzIGlu c3RlYWQgb2YgcG9pbnRlcnMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5k YXRpb24vSW5iYW5kTWV0YWRhdGFUZXh0VHJhY2tQcml2YXRlQVZGLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkluYmFuZE1ldGFkYXRhVGV4dFRyYWNrUHJpdmF0ZUFWRjo6YWRkRGF0YUN1ZSk6Cisg ICAgICAgIChXZWJDb3JlOjpJbmJhbmRNZXRhZGF0YVRleHRUcmFja1ByaXZhdGVBVkY6OnVwZGF0 ZVBlbmRpbmdDdWVFbmRUaW1lcyk6CisgICAgICAgIChXZWJDb3JlOjpJbmJhbmRNZXRhZGF0YVRl eHRUcmFja1ByaXZhdGVBVkY6OmZsdXNoUGFydGlhbEN1ZXMpOgorICAgICAgICBVcGRhdGUgdXNl IG9mIEluY29tcGxldGVNZXRhRGF0YUN1ZSBhbmQgbW9kZXJuaXplIHJlbGF0ZWQgY29kZS4KKwog MjAxNS0wMi0xMCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAg ICAgIFdlYiBJbnNwZWN0b3I6IENyYXNoIGluc3BlY3Rpbmcgc3R5bGVzIG9mIGVsZW1lbnQgd2l0 aCBtdXRhdGVkIHN0eWxlc2hlZXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9JbmJhbmRNZXRhZGF0YVRleHRUcmFja1ByaXZhdGVBVkYu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL0luYmFu ZE1ldGFkYXRhVGV4dFRyYWNrUHJpdmF0ZUFWRi5jcHAKaW5kZXggNTI5MDQ5NC4uNzgxMzVmZCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9u L0luYmFuZE1ldGFkYXRhVGV4dFRyYWNrUHJpdmF0ZUFWRi5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL0luYmFuZE1ldGFkYXRhVGV4dFRyYWNr UHJpdmF0ZUFWRi5jcHAKQEAgLTY0LDE4ICs2NCwxNiBAQCB2b2lkIEluYmFuZE1ldGFkYXRhVGV4 dFRyYWNrUHJpdmF0ZUFWRjo6YWRkRGF0YUN1ZShjb25zdCBNZWRpYVRpbWUmIHN0YXJ0LCBjb25z dAogICAgIFJlZlB0cjxTZXJpYWxpemVkUGxhdGZvcm1SZXByZXNlbnRhdGlvbj4gY3VlRGF0YSA9 IHBycEN1ZURhdGE7CiAgICAgbV9jdXJyZW50Q3VlU3RhcnRUaW1lID0gc3RhcnQ7CiAgICAgaWYg KGVuZC5pc1Bvc2l0aXZlSW5maW5pdGUoKSkKLSAgICAgICAgbV9pbmNvbXBsZXRlQ3Vlcy5hcHBl bmQobmV3IEluY29tcGxldGVNZXRhRGF0YUN1ZShzdGFydCwgY3VlRGF0YSkpOworICAgICAgICBt X2luY29tcGxldGVDdWVzLmFwcGVuZChJbmNvbXBsZXRlTWV0YURhdGFDdWUgeyBjdWVEYXRhLmdl dCgpLCBzdGFydCB9KTsKICAgICBjbGllbnQoKS0+YWRkRGF0YUN1ZSh0aGlzLCBzdGFydCwgZW5k LCBjdWVEYXRhLCB0eXBlKTsKIH0KIAogdm9pZCBJbmJhbmRNZXRhZGF0YVRleHRUcmFja1ByaXZh dGVBVkY6OnVwZGF0ZVBlbmRpbmdDdWVFbmRUaW1lcyhjb25zdCBNZWRpYVRpbWUmIHRpbWUpCiB7 CiAgICAgaWYgKHRpbWUgPj0gbV9jdXJyZW50Q3VlU3RhcnRUaW1lKSB7Ci0gICAgICAgIGZvciAo c2l6ZV90IGkgPSAwOyBpIDwgbV9pbmNvbXBsZXRlQ3Vlcy5zaXplKCk7IGkrKykgewotICAgICAg ICAgICAgSW5jb21wbGV0ZU1ldGFEYXRhQ3VlKiBwYXJ0aWFsQ3VlID0gbV9pbmNvbXBsZXRlQ3Vl c1tpXTsKLQotICAgICAgICAgICAgTE9HKE1lZGlhLCAiSW5iYW5kTWV0YWRhdGFUZXh0VHJhY2tQ cml2YXRlQVZGOjphZGREYXRhQ3VlKCVwKSAtIHVwZGF0aW5nIGN1ZTogc3RhcnQ9JXMsIGVuZD0l cyIsIHRoaXMsIHRvU3RyaW5nKHBhcnRpYWxDdWUtPnN0YXJ0VGltZSgpKS51dGY4KCkuZGF0YSgp LCB0b1N0cmluZyh0aW1lKS51dGY4KCkuZGF0YSgpKTsKLSAgICAgICAgICAgIGNsaWVudCgpLT51 cGRhdGVEYXRhQ3VlKHRoaXMsIHBhcnRpYWxDdWUtPnN0YXJ0VGltZSgpLCB0aW1lLCBwYXJ0aWFs Q3VlLT5jdWVEYXRhKCkpOworICAgICAgICBmb3IgKGF1dG8mIHBhcnRpYWxDdWUgOiBtX2luY29t cGxldGVDdWVzKSB7CisgICAgICAgICAgICBMT0coTWVkaWEsICJJbmJhbmRNZXRhZGF0YVRleHRU cmFja1ByaXZhdGVBVkY6OmFkZERhdGFDdWUoJXApIC0gdXBkYXRpbmcgY3VlOiBzdGFydD0lcywg ZW5kPSVzIiwgdGhpcywgdG9TdHJpbmcocGFydGlhbEN1ZS5zdGFydFRpbWUpLnV0ZjgoKS5kYXRh KCksIHRvU3RyaW5nKHRpbWUpLnV0ZjgoKS5kYXRhKCkpOworICAgICAgICAgICAgY2xpZW50KCkt PnVwZGF0ZURhdGFDdWUodGhpcywgcGFydGlhbEN1ZS5zdGFydFRpbWUsIHRpbWUsIHBhcnRpYWxD dWUuY3VlRGF0YSk7CiAgICAgICAgIH0KICAgICB9IGVsc2UKICAgICAgICAgTE9HKE1lZGlhLCAi SW5iYW5kTWV0YWRhdGFUZXh0VHJhY2tQcml2YXRlQVZGOjphZGREYXRhQ3VlIG5lZ2F0aXZlIGxl bmd0aCBjdWUocykgaWdub3JlZDogc3RhcnQ9JXMsIGVuZD0lc1xuIiwgdG9TdHJpbmcobV9jdXJy ZW50Q3VlU3RhcnRUaW1lKS51dGY4KCkuZGF0YSgpLCB0b1N0cmluZyh0aW1lKS51dGY4KCkuZGF0 YSgpKTsKQEAgLTkxLDEwICs4OSw4IEBAIHZvaWQgSW5iYW5kTWV0YWRhdGFUZXh0VHJhY2tQcml2 YXRlQVZGOjpmbHVzaFBhcnRpYWxDdWVzKCkKICAgICAgICAgTE9HKE1lZGlhLCAiSW5iYW5kTWV0 YWRhdGFUZXh0VHJhY2tQcml2YXRlQVZGOjpyZXNldEN1ZVZhbHVlcyBmbHVzaGluZyBpbmNvbXBs ZXRlIGRhdGEgZm9yIGN1ZXM6IHN0YXJ0PSVzXG4iLCB0b1N0cmluZyhtX2N1cnJlbnRDdWVTdGFy dFRpbWUpLnV0ZjgoKS5kYXRhKCkpOwogCiAgICAgaWYgKGNsaWVudCgpKSB7Ci0gICAgICAgIGZv ciAoc2l6ZV90IGkgPSAwOyBpIDwgbV9pbmNvbXBsZXRlQ3Vlcy5zaXplKCk7IGkrKykgewotICAg ICAgICAgICAgSW5jb21wbGV0ZU1ldGFEYXRhQ3VlKiBwYXJ0aWFsQ3VlID0gbV9pbmNvbXBsZXRl Q3Vlc1tpXTsKLSAgICAgICAgICAgIGNsaWVudCgpLT5yZW1vdmVEYXRhQ3VlKHRoaXMsIHBhcnRp YWxDdWUtPnN0YXJ0VGltZSgpLCBNZWRpYVRpbWU6OnBvc2l0aXZlSW5maW5pdGVUaW1lKCksIHBh cnRpYWxDdWUtPmN1ZURhdGEoKSk7Ci0gICAgICAgIH0KKyAgICAgICAgZm9yIChhdXRvJiBwYXJ0 aWFsQ3VlIDogbV9pbmNvbXBsZXRlQ3VlcykKKyAgICAgICAgICAgIGNsaWVudCgpLT5yZW1vdmVE YXRhQ3VlKHRoaXMsIHBhcnRpYWxDdWUuc3RhcnRUaW1lLCBNZWRpYVRpbWU6OnBvc2l0aXZlSW5m aW5pdGVUaW1lKCksIHBhcnRpYWxDdWUuY3VlRGF0YSk7CiAgICAgfQogCiAgICAgbV9pbmNvbXBs ZXRlQ3Vlcy5yZXNpemUoMCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9hdmZvdW5kYXRpb24vSW5iYW5kTWV0YWRhdGFUZXh0VHJhY2tQcml2YXRlQVZGLmgg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vSW5iYW5kTWV0 YWRhdGFUZXh0VHJhY2tQcml2YXRlQVZGLmgKaW5kZXggNTU0MzYwZi4uZTQ2MGE5NiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL0luYmFu ZE1ldGFkYXRhVGV4dFRyYWNrUHJpdmF0ZUFWRi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9JbmJhbmRNZXRhZGF0YVRleHRUcmFja1ByaXZhdGVB VkYuaApAQCAtMzMsMjEgKzMzLDkgQEAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogI2lmIEVOQUJM RShEQVRBQ1VFX1ZBTFVFKQotY2xhc3MgSW5jb21wbGV0ZU1ldGFEYXRhQ3VlIHsKLXB1YmxpYzoK LSAgICBJbmNvbXBsZXRlTWV0YURhdGFDdWUoY29uc3QgTWVkaWFUaW1lJiB0aW1lLCBQYXNzUmVm UHRyPFNlcmlhbGl6ZWRQbGF0Zm9ybVJlcHJlc2VudGF0aW9uPiBjdWVEYXRhKQotICAgICAgICA6 IG1fY3VlRGF0YShjdWVEYXRhKQotICAgICAgICAsIG1fc3RhcnRUaW1lKHRpbWUpCi0gICAgewot ICAgIH0KLSAgICB+SW5jb21wbGV0ZU1ldGFEYXRhQ3VlKCkgeyB9Ci0KLSAgICBSZWZQdHI8U2Vy aWFsaXplZFBsYXRmb3JtUmVwcmVzZW50YXRpb24+IGN1ZURhdGEoKSBjb25zdCB7IHJldHVybiBt X2N1ZURhdGE7IH0KLSAgICBNZWRpYVRpbWUgc3RhcnRUaW1lKCkgY29uc3QgeyByZXR1cm4gbV9z dGFydFRpbWU7IH0KLQotcHJpdmF0ZToKLSAgICBSZWZQdHI8U2VyaWFsaXplZFBsYXRmb3JtUmVw cmVzZW50YXRpb24+IG1fY3VlRGF0YTsKLSAgICBNZWRpYVRpbWUgbV9zdGFydFRpbWU7CitzdHJ1 Y3QgSW5jb21wbGV0ZU1ldGFEYXRhQ3VlIHsKKyAgICBSZWZQdHI8U2VyaWFsaXplZFBsYXRmb3Jt UmVwcmVzZW50YXRpb24+IGN1ZURhdGE7CisgICAgTWVkaWFUaW1lIHN0YXJ0VGltZTsKIH07CiAj ZW5kaWYKIApAQCAtNzcsNyArNjUsNyBAQCBwcml2YXRlOgogICAgIEF0b21pY1N0cmluZyBtX2lu QmFuZE1ldGFkYXRhVHJhY2tEaXNwYXRjaFR5cGU7CiAgICAgTWVkaWFUaW1lIG1fY3VycmVudEN1 ZVN0YXJ0VGltZTsKICNpZiBFTkFCTEUoREFUQUNVRV9WQUxVRSkKLSAgICBWZWN0b3I8SW5jb21w bGV0ZU1ldGFEYXRhQ3VlKj4gbV9pbmNvbXBsZXRlQ3VlczsKKyAgICBWZWN0b3I8SW5jb21wbGV0 ZU1ldGFEYXRhQ3VlPiBtX2luY29tcGxldGVDdWVzOwogI2VuZGlmCiB9OwogCg==