141589 2015-02-13 20:08:16 -0800 JSContext Inspector: Do not stash console messages for non-debuggable JSContext 2015-02-13 21:00:09 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue ggaren graouts joepeck jonowells mark.lam mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1069099 0 joepeck 2015-02-13 20:08:16 -0800 * SUMMARY Do not stash console messages for non-debuggable JSContext. For a JSContext in an application not inspectable, or a JSContext where remote debugging has been explicitly disabled (it is enabled by default), do not stash any console messages. 1069100 1 joepeck 2015-02-13 20:08:34 -0800 <rdar://problem/19752014> 1069101 2 246571 joepeck 2015-02-13 20:11:42 -0800 Created attachment 246571 [PATCH] Proposed Fix 1069103 3 commit-queue 2015-02-13 20:13:05 -0800 Attachment 246571 did not pass style-queue: ERROR: Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp:52: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1069105 4 246572 joepeck 2015-02-13 20:15:40 -0800 Created attachment 246572 [PATCH] Proposed Fix 1069114 5 246572 commit-queue 2015-02-13 21:00:04 -0800 Comment on attachment 246572 [PATCH] Proposed Fix Clearing flags on attachment: 246572 Committed r180101: <http://trac.webkit.org/changeset/180101> 1069115 6 commit-queue 2015-02-13 21:00:09 -0800 All reviewed patches have been landed. Closing bug. 246571 2015-02-13 20:11:42 -0800 2015-02-13 20:15:40 -0800 [PATCH] Proposed Fix dev-extras.patch text/plain 3008 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGNhNTQ2OTMuLjMwZGE1NTQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDE1LTAyLTEzICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgSlNDb250ZXh0IEluc3BlY3Rvcjog RG8gbm90IHN0YXNoIGNvbnNvbGUgbWVzc2FnZXMgZm9yIG5vbi1kZWJ1Z2dhYmxlIEpTQ29udGV4 dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxNTg5 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29uc2lk ZXIgZGV2ZWxvcGVyIGV4dHJhcyBkaXNhYmxlZCBmb3IgSlNDb250ZXh0IGluc3BlY3Rpb24gaWYg dGhlCisgICAgICAgIFJlbW90ZUluc3BlY3RvciBzZXJ2ZXIgaXMgbm90IGVuYWJsZWQgKHR5cGlj YWxseSBhIG5vbi1kZWJ1Z2dhYmxlCisgICAgICAgIHByb2Nlc3MgcmVqZWN0ZWQgYnkgd2ViaW5z cGVjdG9yZCkgb3IgaWYgcmVtb3RlIGRlYnVnZ2luZyBvbiB0aGUKKyAgICAgICAgSlNDb250ZXh0 IHdhcyBleHBsaWNpdGx5IGRpc2FibGVkIHZpYSBTUEkuCisKKyAgICAgICAgV2hlbiBkZXZlbG9w ZXIgZXh0cmFzIGFyZSBkaXNhYmxlZCwgY29uc29sZSBtZXNzYWdlIHdpbGwgbm90IGJlIHN0YXNo ZWQuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSlNHbG9iYWxPYmplY3RJbnNwZWN0b3JDb250cm9s bGVyLmNwcDoKKyAgICAgICAgKEluc3BlY3Rvcjo6SlNHbG9iYWxPYmplY3RJbnNwZWN0b3JDb250 cm9sbGVyOjpkZXZlbG9wZXJFeHRyYXNFbmFibGVkKToKKyAgICAgICAgKiBpbnNwZWN0b3IvSlNH bG9iYWxPYmplY3RJbnNwZWN0b3JDb250cm9sbGVyLmg6CisKKzIwMTUtMDItMTMgIEpvc2VwaCBQ ZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBOYXRpdmUgQmluZGluZ3Mg RGVzY3JpcHRvcnMgYXJlIEluY29tcGxldGUKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0MDU3NQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvaW5zcGVjdG9yL0pTR2xvYmFsT2JqZWN0SW5zcGVjdG9yQ29udHJvbGxlci5jcHAgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0pTR2xvYmFsT2JqZWN0SW5zcGVjdG9yQ29u dHJvbGxlci5jcHAKaW5kZXggNjU1M2Q1Ni4uMDQ2OTMyOSAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2luc3BlY3Rvci9KU0dsb2JhbE9iamVjdEluc3BlY3RvckNvbnRyb2xsZXIu Y3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSlNHbG9iYWxPYmplY3RJ bnNwZWN0b3JDb250cm9sbGVyLmNwcApAQCAtNDksNiArNDksNyBAQAogI2luY2x1ZGUgPGV4ZWNp bmZvLmg+CiAKICNpZiBFTkFCTEUoUkVNT1RFX0lOU1BFQ1RPUikKKyNpbmNsdWRlICJSZW1vdGVJ bnNwZWN0b3IuaCIKICNpbmNsdWRlICJKU0dsb2JhbE9iamVjdERlYnVnZ2FibGUuaCIKICNlbmRp ZgogCkBAIC0yMDMsNiArMjA0LDE5IEBAIENvbnNvbGVDbGllbnQqIEpTR2xvYmFsT2JqZWN0SW5z cGVjdG9yQ29udHJvbGxlcjo6Y29uc29sZUNsaWVudCgpIGNvbnN0CiAgICAgcmV0dXJuIG1fY29u c29sZUNsaWVudC5nZXQoKTsKIH0KIAorYm9vbCBKU0dsb2JhbE9iamVjdEluc3BlY3RvckNvbnRy b2xsZXI6OmRldmVsb3BlckV4dHJhc0VuYWJsZWQoKSBjb25zdAoreworI2lmIEVOQUJMRShSRU1P VEVfSU5TUEVDVE9SKQorICAgIGlmICghUmVtb3RlSW5zcGVjdG9yOjpzaW5nbGV0b24oKS5lbmFi bGVkKCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIGlmICghbV9nbG9iYWxPYmplY3Qu aW5zcGVjdG9yRGVidWdnYWJsZSgpLnJlbW90ZURlYnVnZ2luZ0FsbG93ZWQoKSkKKyAgICAgICAg cmV0dXJuIGZhbHNlOworI2VuZGlmCisKKyAgICByZXR1cm4gdHJ1ZTsKK30KKwogSW5zcGVjdG9y RnVuY3Rpb25DYWxsSGFuZGxlciBKU0dsb2JhbE9iamVjdEluc3BlY3RvckNvbnRyb2xsZXI6OmZ1 bmN0aW9uQ2FsbEhhbmRsZXIoKSBjb25zdAogewogICAgIHJldHVybiBKU0M6OmNhbGw7CmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0pTR2xvYmFsT2JqZWN0SW5z cGVjdG9yQ29udHJvbGxlci5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9KU0ds b2JhbE9iamVjdEluc3BlY3RvckNvbnRyb2xsZXIuaAppbmRleCA3NjBmNzBmLi5iNjkzZTI4IDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0pTR2xvYmFsT2JqZWN0 SW5zcGVjdG9yQ29udHJvbGxlci5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0 b3IvSlNHbG9iYWxPYmplY3RJbnNwZWN0b3JDb250cm9sbGVyLmgKQEAgLTg0LDcgKzg0LDcgQEAg cHVibGljOgogCiAgICAgSlNDOjpDb25zb2xlQ2xpZW50KiBjb25zb2xlQ2xpZW50KCkgY29uc3Q7 CiAKLSAgICB2aXJ0dWFsIGJvb2wgZGV2ZWxvcGVyRXh0cmFzRW5hYmxlZCgpIGNvbnN0IG92ZXJy aWRlIHsgcmV0dXJuIHRydWU7IH0KKyAgICB2aXJ0dWFsIGJvb2wgZGV2ZWxvcGVyRXh0cmFzRW5h YmxlZCgpIGNvbnN0IG92ZXJyaWRlOwogICAgIHZpcnR1YWwgYm9vbCBjYW5BY2Nlc3NJbnNwZWN0 ZWRTY3JpcHRTdGF0ZShKU0M6OkV4ZWNTdGF0ZSopIGNvbnN0IG92ZXJyaWRlIHsgcmV0dXJuIHRy dWU7IH0KICAgICB2aXJ0dWFsIEluc3BlY3RvckZ1bmN0aW9uQ2FsbEhhbmRsZXIgZnVuY3Rpb25D YWxsSGFuZGxlcigpIGNvbnN0IG92ZXJyaWRlOwogICAgIHZpcnR1YWwgSW5zcGVjdG9yRXZhbHVh dGVIYW5kbGVyIGV2YWx1YXRlSGFuZGxlcigpIGNvbnN0IG92ZXJyaWRlOwo= 246572 2015-02-13 20:15:40 -0800 2015-02-13 21:00:04 -0800 [PATCH] Proposed Fix even-better.patch text/plain 3007 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGNhNTQ2OTMuLjMwZGE1NTQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDE1LTAyLTEzICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgSlNDb250ZXh0IEluc3BlY3Rvcjog RG8gbm90IHN0YXNoIGNvbnNvbGUgbWVzc2FnZXMgZm9yIG5vbi1kZWJ1Z2dhYmxlIEpTQ29udGV4 dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxNTg5 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29uc2lk ZXIgZGV2ZWxvcGVyIGV4dHJhcyBkaXNhYmxlZCBmb3IgSlNDb250ZXh0IGluc3BlY3Rpb24gaWYg dGhlCisgICAgICAgIFJlbW90ZUluc3BlY3RvciBzZXJ2ZXIgaXMgbm90IGVuYWJsZWQgKHR5cGlj YWxseSBhIG5vbi1kZWJ1Z2dhYmxlCisgICAgICAgIHByb2Nlc3MgcmVqZWN0ZWQgYnkgd2ViaW5z cGVjdG9yZCkgb3IgaWYgcmVtb3RlIGRlYnVnZ2luZyBvbiB0aGUKKyAgICAgICAgSlNDb250ZXh0 IHdhcyBleHBsaWNpdGx5IGRpc2FibGVkIHZpYSBTUEkuCisKKyAgICAgICAgV2hlbiBkZXZlbG9w ZXIgZXh0cmFzIGFyZSBkaXNhYmxlZCwgY29uc29sZSBtZXNzYWdlIHdpbGwgbm90IGJlIHN0YXNo ZWQuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSlNHbG9iYWxPYmplY3RJbnNwZWN0b3JDb250cm9s bGVyLmNwcDoKKyAgICAgICAgKEluc3BlY3Rvcjo6SlNHbG9iYWxPYmplY3RJbnNwZWN0b3JDb250 cm9sbGVyOjpkZXZlbG9wZXJFeHRyYXNFbmFibGVkKToKKyAgICAgICAgKiBpbnNwZWN0b3IvSlNH bG9iYWxPYmplY3RJbnNwZWN0b3JDb250cm9sbGVyLmg6CisKKzIwMTUtMDItMTMgIEpvc2VwaCBQ ZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBOYXRpdmUgQmluZGluZ3Mg RGVzY3JpcHRvcnMgYXJlIEluY29tcGxldGUKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0MDU3NQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvaW5zcGVjdG9yL0pTR2xvYmFsT2JqZWN0SW5zcGVjdG9yQ29udHJvbGxlci5jcHAgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0pTR2xvYmFsT2JqZWN0SW5zcGVjdG9yQ29u dHJvbGxlci5jcHAKaW5kZXggNjU1M2Q1Ni4uODUwOTNhMyAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2luc3BlY3Rvci9KU0dsb2JhbE9iamVjdEluc3BlY3RvckNvbnRyb2xsZXIu Y3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSlNHbG9iYWxPYmplY3RJ bnNwZWN0b3JDb250cm9sbGVyLmNwcApAQCAtNTAsNiArNTAsNyBAQAogCiAjaWYgRU5BQkxFKFJF TU9URV9JTlNQRUNUT1IpCiAjaW5jbHVkZSAiSlNHbG9iYWxPYmplY3REZWJ1Z2dhYmxlLmgiCisj aW5jbHVkZSAiUmVtb3RlSW5zcGVjdG9yLmgiCiAjZW5kaWYKIAogdXNpbmcgbmFtZXNwYWNlIEpT QzsKQEAgLTIwMyw2ICsyMDQsMTkgQEAgQ29uc29sZUNsaWVudCogSlNHbG9iYWxPYmplY3RJbnNw ZWN0b3JDb250cm9sbGVyOjpjb25zb2xlQ2xpZW50KCkgY29uc3QKICAgICByZXR1cm4gbV9jb25z b2xlQ2xpZW50LmdldCgpOwogfQogCitib29sIEpTR2xvYmFsT2JqZWN0SW5zcGVjdG9yQ29udHJv bGxlcjo6ZGV2ZWxvcGVyRXh0cmFzRW5hYmxlZCgpIGNvbnN0Cit7CisjaWYgRU5BQkxFKFJFTU9U RV9JTlNQRUNUT1IpCisgICAgaWYgKCFSZW1vdGVJbnNwZWN0b3I6OnNpbmdsZXRvbigpLmVuYWJs ZWQoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgaWYgKCFtX2dsb2JhbE9iamVjdC5p bnNwZWN0b3JEZWJ1Z2dhYmxlKCkucmVtb3RlRGVidWdnaW5nQWxsb3dlZCgpKQorICAgICAgICBy ZXR1cm4gZmFsc2U7CisjZW5kaWYKKworICAgIHJldHVybiB0cnVlOworfQorCiBJbnNwZWN0b3JG dW5jdGlvbkNhbGxIYW5kbGVyIEpTR2xvYmFsT2JqZWN0SW5zcGVjdG9yQ29udHJvbGxlcjo6ZnVu Y3Rpb25DYWxsSGFuZGxlcigpIGNvbnN0CiB7CiAgICAgcmV0dXJuIEpTQzo6Y2FsbDsKZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSlNHbG9iYWxPYmplY3RJbnNw ZWN0b3JDb250cm9sbGVyLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0pTR2xv YmFsT2JqZWN0SW5zcGVjdG9yQ29udHJvbGxlci5oCmluZGV4IDc2MGY3MGYuLmI2OTNlMjggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSlNHbG9iYWxPYmplY3RJ bnNwZWN0b3JDb250cm9sbGVyLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rv ci9KU0dsb2JhbE9iamVjdEluc3BlY3RvckNvbnRyb2xsZXIuaApAQCAtODQsNyArODQsNyBAQCBw dWJsaWM6CiAKICAgICBKU0M6OkNvbnNvbGVDbGllbnQqIGNvbnNvbGVDbGllbnQoKSBjb25zdDsK IAotICAgIHZpcnR1YWwgYm9vbCBkZXZlbG9wZXJFeHRyYXNFbmFibGVkKCkgY29uc3Qgb3ZlcnJp ZGUgeyByZXR1cm4gdHJ1ZTsgfQorICAgIHZpcnR1YWwgYm9vbCBkZXZlbG9wZXJFeHRyYXNFbmFi bGVkKCkgY29uc3Qgb3ZlcnJpZGU7CiAgICAgdmlydHVhbCBib29sIGNhbkFjY2Vzc0luc3BlY3Rl ZFNjcmlwdFN0YXRlKEpTQzo6RXhlY1N0YXRlKikgY29uc3Qgb3ZlcnJpZGUgeyByZXR1cm4gdHJ1 ZTsgfQogICAgIHZpcnR1YWwgSW5zcGVjdG9yRnVuY3Rpb25DYWxsSGFuZGxlciBmdW5jdGlvbkNh bGxIYW5kbGVyKCkgY29uc3Qgb3ZlcnJpZGU7CiAgICAgdmlydHVhbCBJbnNwZWN0b3JFdmFsdWF0 ZUhhbmRsZXIgZXZhbHVhdGVIYW5kbGVyKCkgY29uc3Qgb3ZlcnJpZGU7Cg==