141584 2015-02-13 17:38:30 -0800 REGRESSION: Page opens with enlarged font after visiting PDF, navigating back, then doing a process swap 2015-02-14 14:57:01 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin simon.fraser thorton oldest_to_newest 1069073 0 bdakin 2015-02-13 17:38:30 -0800 REGRESSION: Page opens with enlarged font after visiting PDF, navigating back, then doing a process swap 1069075 1 246562 bdakin 2015-02-13 17:42:07 -0800 Created attachment 246562 Patch 1069079 2 246562 thorton 2015-02-13 17:47:22 -0800 Comment on attachment 246562 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246562&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:2830 > // WebPageProxy's cache of the value can get out of sync (e.g. in the case where a > // plugin is handling page scaling itself) so we should reset it to the default > // for standard main frame loads. I wonder if this comment means that this code is only needed in the plugin case and that therefore you don't need to reset m_pageScaleFactor. But I don't really remember. 1069244 3 bdakin 2015-02-14 14:57:01 -0800 Thanks Tim! http://trac.webkit.org/changeset/180115 246562 2015-02-13 17:42:07 -0800 2015-02-13 17:47:22 -0800 Patch for-review.txt text/plain 7505 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MDA5NCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMzIEBACisyMDE1LTAyLTEzICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OOiBQYWdlIG9wZW5z IHdpdGggZW5sYXJnZWQgZm9udCBhZnRlciB2aXNpdGluZyBQREYsIG5hdmlnYXRpbmcgYmFjaywg CisgICAgICAgIHRoZW4gZG9pbmcgYSBwcm9jZXNzIHN3YXAKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MTU4NAorICAgICAgICAtYW5kIGNvcnJlc3Bv bmRpbmctCisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzE4MTY3NzI5CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBrZWVwcyB0aGUgcGx1 Z2luIHpvb20vc2NhbGUgZmFjdG9ycyBzZXBhcmF0ZSBmcm9tIHBhZ2Ugem9vbS9zY2FsZSAKKyAg ICAgICAgZmFjdG9ycyBpbiB0aGUgVUkgcHJvY2VzcyBzaW5jZSB0aGV5IGFyZSB1c2VkIGZvciBz bGlnaHRseSBkaWZmZXJlbnQgcHVycG9zZXMgZm9yIAorICAgICAgICBwbHVnaW5zIChpLmUuLCBQ REZzKSB0aGFuIHRoZXkgYXJlIGZvciBub3JtYWwgcGFnZXMuIEtlZXBpbmcgdHJhY2sgb2YgdGhl IHJpZ2h0IAorICAgICAgICBmYWN0b3IgZm9yIHRoZSByaWdodCB0eXBlIG9mIGRvY3VtZW50IHdp bGwgZW5zdXJlIHRoYXQgd2UgZG9u4oCZdCB1c2UgdGhlIHdyb25nIG9uZS4KKworICAgICAgICAq IFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJv eHk6OldlYlBhZ2VQcm94eSk6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6cGFnZVpv b21GYWN0b3IpOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OnBhZ2VTY2FsZUZhY3Rv cik6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6cGx1Z2luU2NhbGVGYWN0b3JEaWRD aGFuZ2UpOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OnBsdWdpblpvb21GYWN0b3JE aWRDaGFuZ2UpOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OmRpZENvbW1pdExvYWRG b3JGcmFtZSk6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6cGFnZVpvb21GYWN0b3JE aWRDaGFuZ2UpOiBEZWxldGVkLgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaDoK KyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjpwYWdlWm9vbUZhY3Rvcik6IERlbGV0ZWQu CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6cGFnZVNjYWxlRmFjdG9yKTogRGVsZXRl ZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5Lm1lc3NhZ2VzLmluOgorICAgICAg ICAqIFdlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5WaWV3LmNwcDoKKyAgICAgICAgKFdlYktpdDo6 UGx1Z2luVmlldzo6c2V0UGFnZVNjYWxlRmFjdG9yKToKKwogMjAxNS0wMi0xMyAgU2ltb24gRnJh c2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBDcmFzaCBjbG9zaW5nIGEg dGFiIHdoZW4gYSBjb250ZXh0IG9yIHBvcHVwIG1lbnUgaXMgb3BlbgpJbmRleDogU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAJKHJldmlzaW9uIDE4MDA4MykKKysrIFNv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0zMDcsNiArMzA3LDggQEAgV2ViUGFnZVByb3h5OjpXZWJQYWdlUHJveHkoUGFnZUNsaWVudCYg cAogICAgICwgbV90ZXh0Wm9vbUZhY3RvcigxKQogICAgICwgbV9wYWdlWm9vbUZhY3RvcigxKQog ICAgICwgbV9wYWdlU2NhbGVGYWN0b3IoMSkKKyAgICAsIG1fcGx1Z2luWm9vbUZhY3RvcigxKQor ICAgICwgbV9wbHVnaW5TY2FsZUZhY3RvcigxKQogICAgICwgbV9pbnRyaW5zaWNEZXZpY2VTY2Fs ZUZhY3RvcigxKQogICAgICwgbV9jdXN0b21EZXZpY2VTY2FsZUZhY3RvcigwKQogICAgICwgbV90 b3BDb250ZW50SW5zZXQoMCkKQEAgLTIxMjEsNiArMjEyMywyNCBAQCB2b2lkIFdlYlBhZ2VQcm94 eTo6c2V0UGFnZUFuZFRleHRab29tRmFjCiAgICAgbV9wcm9jZXNzLT5zZW5kKE1lc3NhZ2VzOjpX ZWJQYWdlOjpTZXRQYWdlQW5kVGV4dFpvb21GYWN0b3JzKG1fcGFnZVpvb21GYWN0b3IsIG1fdGV4 dFpvb21GYWN0b3IpLCBtX3BhZ2VJRCk7IAogfQogCitkb3VibGUgV2ViUGFnZVByb3h5OjpwYWdl Wm9vbUZhY3RvcigpIGNvbnN0Cit7CisgICAgLy8gWm9vbSBmYWN0b3IgZm9yIG5vbi1QREYgcGFn ZXMgcGVyc2lzdHMgYWNyb3NzIHBhZ2UgbG9hZHMuIFdlIG1haW50YWluIGEgc2VwYXJhdGUgbWVt YmVyIHZhcmlhYmxlIGZvciBQREYKKyAgICAvLyB6b29tIHdoaWNoIGVuc3VyZXMgdGhhdCB3ZSBk b24ndCB1c2UgdGhlIFBERiB6b29tIGZvciBhIG5vcm1hbCBwYWdlLgorICAgIGlmIChtX21haW5G cmFtZSAmJiBtX21haW5GcmFtZS0+aXNEaXNwbGF5aW5nUERGRG9jdW1lbnQoKSkKKyAgICAgICAg cmV0dXJuIG1fcGx1Z2luWm9vbUZhY3RvcjsKKyAgICByZXR1cm4gbV9wYWdlWm9vbUZhY3RvcjsK K30KKworZG91YmxlIFdlYlBhZ2VQcm94eTo6cGFnZVNjYWxlRmFjdG9yKCkgY29uc3QKK3sKKyAg ICAvLyBQREYgZG9jdW1lbnRzIHVzZSB6b29tIGFuZCBzY2FsZSBmYWN0b3JzIHRvIHNpemUgdGhl bXNlbHZlcyBhcHByb3ByaWF0ZWx5IGluIHRoZSB3aW5kb3cuIFdlIHN0b3JlIHRoZW0KKyAgICAv LyBzZXBhcmF0ZWx5IGJ1dCBkZWNpZGUgd2hpY2ggdG8gcmV0dXJuIGJhc2VkIG9uIHRoZSBtYWlu IGZyYW1lLiAKKyAgICBpZiAobV9tYWluRnJhbWUgJiYgbV9tYWluRnJhbWUtPmlzRGlzcGxheWlu Z1BERkRvY3VtZW50KCkpCisgICAgICAgIHJldHVybiBtX3BsdWdpblNjYWxlRmFjdG9yOworICAg IHJldHVybiBtX3BhZ2VTY2FsZUZhY3RvcjsKK30KKwogdm9pZCBXZWJQYWdlUHJveHk6OnNjYWxl UGFnZShkb3VibGUgc2NhbGUsIGNvbnN0IEludFBvaW50JiBvcmlnaW4pCiB7CiAgICAgaWYgKCFp c1ZhbGlkKCkpCkBAIC0yMzgxLDkgKzI0MDEsMTQgQEAgdm9pZCBXZWJQYWdlUHJveHk6OnBhZ2VT Y2FsZUZhY3RvckRpZENoYQogICAgIG1fcGFnZVNjYWxlRmFjdG9yID0gc2NhbGVGYWN0b3I7CiB9 CiAKLXZvaWQgV2ViUGFnZVByb3h5OjpwYWdlWm9vbUZhY3RvckRpZENoYW5nZShkb3VibGUgem9v bUZhY3RvcikKK3ZvaWQgV2ViUGFnZVByb3h5OjpwbHVnaW5TY2FsZUZhY3RvckRpZENoYW5nZShk b3VibGUgcGx1Z2luU2NhbGVGYWN0b3IpCiB7Ci0gICAgbV9wYWdlWm9vbUZhY3RvciA9IHpvb21G YWN0b3I7CisgICAgbV9wbHVnaW5TY2FsZUZhY3RvciA9IHBsdWdpblNjYWxlRmFjdG9yOworfQor Cit2b2lkIFdlYlBhZ2VQcm94eTo6cGx1Z2luWm9vbUZhY3RvckRpZENoYW5nZShkb3VibGUgcGx1 Z2luWm9vbUZhY3RvcikKK3sKKyAgICBtX3BsdWdpblpvb21GYWN0b3IgPSBwbHVnaW5ab29tRmFj dG9yOwogfQogCiB2b2lkIFdlYlBhZ2VQcm94eTo6ZmluZFN0cmluZ01hdGNoZXMoY29uc3QgU3Ry aW5nJiBzdHJpbmcsIEZpbmRPcHRpb25zIG9wdGlvbnMsIHVuc2lnbmVkIG1heE1hdGNoQ291bnQp CkBAIC0yODAzLDggKzI4MjgsMTAgQEAgdm9pZCBXZWJQYWdlUHJveHk6OmRpZENvbW1pdExvYWRG b3JGcmFtZQogICAgIC8vIFdlYlBhZ2VQcm94eSdzIGNhY2hlIG9mIHRoZSB2YWx1ZSBjYW4gZ2V0 IG91dCBvZiBzeW5jIChlLmcuIGluIHRoZSBjYXNlIHdoZXJlIGEKICAgICAvLyBwbHVnaW4gaXMg aGFuZGxpbmcgcGFnZSBzY2FsaW5nIGl0c2VsZikgc28gd2Ugc2hvdWxkIHJlc2V0IGl0IHRvIHRo ZSBkZWZhdWx0CiAgICAgLy8gZm9yIHN0YW5kYXJkIG1haW4gZnJhbWUgbG9hZHMuCi0gICAgaWYg KGZyYW1lLT5pc01haW5GcmFtZSgpICYmIHN0YXRpY19jYXN0PEZyYW1lTG9hZFR5cGU+KG9wYXF1 ZUZyYW1lTG9hZFR5cGUpID09IEZyYW1lTG9hZFR5cGU6OlN0YW5kYXJkKQorICAgIGlmIChmcmFt ZS0+aXNNYWluRnJhbWUoKSAmJiBzdGF0aWNfY2FzdDxGcmFtZUxvYWRUeXBlPihvcGFxdWVGcmFt ZUxvYWRUeXBlKSA9PSBGcmFtZUxvYWRUeXBlOjpTdGFuZGFyZCkgewogICAgICAgICBtX3BhZ2VT Y2FsZUZhY3RvciA9IDE7CisgICAgICAgIG1fcGx1Z2luU2NhbGVGYWN0b3IgPSAxOworICAgIH0K IAogICAgIG1fcGFnZUxvYWRTdGF0ZS5jb21taXRDaGFuZ2VzKCk7CiAgICAgaWYgKG1fbmF2aWdh dGlvbkNsaWVudCkgewpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94 eS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHku aAkocmV2aXNpb24gMTgwMDgzKQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQ cm94eS5oCSh3b3JraW5nIGNvcHkpCkBAIC02MTcsMTMgKzYxNywxMyBAQCBwdWJsaWM6CiAgICAg Ym9vbCBzdXBwb3J0c1RleHRab29tKCkgY29uc3Q7CiAgICAgZG91YmxlIHRleHRab29tRmFjdG9y KCkgY29uc3QgeyByZXR1cm4gbV90ZXh0Wm9vbUZhY3RvcjsgfQogICAgIHZvaWQgc2V0VGV4dFpv b21GYWN0b3IoZG91YmxlKTsKLSAgICBkb3VibGUgcGFnZVpvb21GYWN0b3IoKSBjb25zdCB7IHJl dHVybiBtX3BhZ2Vab29tRmFjdG9yOyB9CisgICAgZG91YmxlIHBhZ2Vab29tRmFjdG9yKCkgY29u c3Q7CiAgICAgdm9pZCBzZXRQYWdlWm9vbUZhY3Rvcihkb3VibGUpOwogICAgIHZvaWQgc2V0UGFn ZUFuZFRleHRab29tRmFjdG9ycyhkb3VibGUgcGFnZVpvb21GYWN0b3IsIGRvdWJsZSB0ZXh0Wm9v bUZhY3Rvcik7CiAKICAgICB2b2lkIHNjYWxlUGFnZShkb3VibGUgc2NhbGUsIGNvbnN0IFdlYkNv cmU6OkludFBvaW50JiBvcmlnaW4pOwogICAgIHZvaWQgc2NhbGVQYWdlSW5WaWV3Q29vcmRpbmF0 ZXMoZG91YmxlIHNjYWxlLCBjb25zdCBXZWJDb3JlOjpJbnRQb2ludCYgY2VudGVySW5WaWV3Q29v cmRpbmF0ZXMpOwotICAgIGRvdWJsZSBwYWdlU2NhbGVGYWN0b3IoKSBjb25zdCB7IHJldHVybiBt X3BhZ2VTY2FsZUZhY3RvcjsgfQorICAgIGRvdWJsZSBwYWdlU2NhbGVGYWN0b3IoKSBjb25zdDsK IAogICAgIGZsb2F0IGRldmljZVNjYWxlRmFjdG9yKCkgY29uc3Q7CiAgICAgdm9pZCBzZXRJbnRy aW5zaWNEZXZpY2VTY2FsZUZhY3RvcihmbG9hdCk7CkBAIC02OTYsNyArNjk2LDggQEAgcHVibGlj OgogI2VuZGlmCiAKICAgICB2b2lkIHBhZ2VTY2FsZUZhY3RvckRpZENoYW5nZShkb3VibGUpOwot ICAgIHZvaWQgcGFnZVpvb21GYWN0b3JEaWRDaGFuZ2UoZG91YmxlKTsKKyAgICB2b2lkIHBsdWdp blNjYWxlRmFjdG9yRGlkQ2hhbmdlKGRvdWJsZSk7CisgICAgdm9pZCBwbHVnaW5ab29tRmFjdG9y RGlkQ2hhbmdlKGRvdWJsZSk7CiAKICAgICAvLyBGaW5kLgogICAgIHZvaWQgZmluZFN0cmluZyhj b25zdCBTdHJpbmcmLCBGaW5kT3B0aW9ucywgdW5zaWduZWQgbWF4TWF0Y2hDb3VudCk7CkBAIC0x NDgyLDYgKzE0ODMsOCBAQCBwcml2YXRlOgogICAgIGRvdWJsZSBtX3RleHRab29tRmFjdG9yOwog ICAgIGRvdWJsZSBtX3BhZ2Vab29tRmFjdG9yOwogICAgIGRvdWJsZSBtX3BhZ2VTY2FsZUZhY3Rv cjsKKyAgICBkb3VibGUgbV9wbHVnaW5ab29tRmFjdG9yOworICAgIGRvdWJsZSBtX3BsdWdpblNj YWxlRmFjdG9yOwogICAgIGZsb2F0IG1faW50cmluc2ljRGV2aWNlU2NhbGVGYWN0b3I7CiAgICAg ZmxvYXQgbV9jdXN0b21EZXZpY2VTY2FsZUZhY3RvcjsKICAgICBmbG9hdCBtX3RvcENvbnRlbnRJ bnNldDsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkubWVzc2Fn ZXMuaW4KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94 eS5tZXNzYWdlcy5pbgkocmV2aXNpb24gMTgwMDgzKQorKysgU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL1dlYlBhZ2VQcm94eS5tZXNzYWdlcy5pbgkod29ya2luZyBjb3B5KQpAQCAtMTk0LDcgKzE5 NCw4IEBAIG1lc3NhZ2VzIC0+IFdlYlBhZ2VQcm94eSB7CiAjZW5kaWYKIAogICAgIFBhZ2VTY2Fs ZUZhY3RvckRpZENoYW5nZShkb3VibGUgc2NhbGVGYWN0b3IpCi0gICAgUGFnZVpvb21GYWN0b3JE aWRDaGFuZ2UoZG91YmxlIHpvb21GYWN0b3IpCisgICAgUGx1Z2luU2NhbGVGYWN0b3JEaWRDaGFu Z2UoZG91YmxlIHpvb21GYWN0b3IpCisgICAgUGx1Z2luWm9vbUZhY3RvckRpZENoYW5nZShkb3Vi bGUgem9vbUZhY3RvcikKIAogI2lmIFBMQVRGT1JNKEdUSykKICAgICAjIFN1cHBvcnQgZm9yIEdU SysgcGxhdGZvcm0ga2V5YmluZGluZ3MKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv UGx1Z2lucy9QbHVnaW5WaWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5jcHAJKHJldmlzaW9uIDE4MDA4MykKKysrIFNvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5WaWV3LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNDgzLDggKzQ4Myw4IEBAIHZvaWQgUGx1Z2luVmlldzo6dG9wQ29udGVudEluc2V0RGlk Q2hhbmcKIHZvaWQgUGx1Z2luVmlldzo6c2V0UGFnZVNjYWxlRmFjdG9yKGRvdWJsZSBzY2FsZUZh Y3RvciwgSW50UG9pbnQpCiB7CiAgICAgbV9wYWdlU2NhbGVGYWN0b3IgPSBzY2FsZUZhY3RvcjsK LSAgICBtX3dlYlBhZ2UtPnNlbmQoTWVzc2FnZXM6OldlYlBhZ2VQcm94eTo6UGFnZVNjYWxlRmFj dG9yRGlkQ2hhbmdlKHNjYWxlRmFjdG9yKSk7Ci0gICAgbV93ZWJQYWdlLT5zZW5kKE1lc3NhZ2Vz OjpXZWJQYWdlUHJveHk6OlBhZ2Vab29tRmFjdG9yRGlkQ2hhbmdlKHNjYWxlRmFjdG9yKSk7Cisg ICAgbV93ZWJQYWdlLT5zZW5kKE1lc3NhZ2VzOjpXZWJQYWdlUHJveHk6OlBsdWdpblNjYWxlRmFj dG9yRGlkQ2hhbmdlKHNjYWxlRmFjdG9yKSk7CisgICAgbV93ZWJQYWdlLT5zZW5kKE1lc3NhZ2Vz OjpXZWJQYWdlUHJveHk6OlBsdWdpblpvb21GYWN0b3JEaWRDaGFuZ2Uoc2NhbGVGYWN0b3IpKTsK ICAgICBwYWdlU2NhbGVGYWN0b3JEaWRDaGFuZ2UoKTsKIH0KIAo=