141574 2015-02-13 14:03:29 -0800 Simplify ASSERT in lastRubyRun() 2015-02-13 14:26:59 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zalan zalan commit-queue dbates esprehn+autocc glenn kondapallykalyan oldest_to_newest 1069023 0 zalan 2015-02-13 14:03:29 -0800 ASSERT(!child || is<RenderRubyRun>(*child) || child->isBeforeContent() || child == rubyBeforeBlock(ruby)); is complex and redundant after r180064 1069024 1 246547 zalan 2015-02-13 14:09:55 -0800 Created attachment 246547 Patch 1069027 2 246547 dbates 2015-02-13 14:13:50 -0800 Comment on attachment 246547 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246547&action=review > Source/WebCore/rendering/RenderRuby.cpp:111 > + Nit: I don't feel that this empty line improves the readability of this code. 1069033 3 zalan 2015-02-13 14:26:59 -0800 http://trac.webkit.org/changeset/180081 246547 2015-02-13 14:09:55 -0800 2015-02-13 14:13:50 -0800 Patch bug-141574-20150213140952.patch text/plain 1640 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwMDY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWJlNDQyYmQ0NzJiNzYz MWE0NzliYzRhYzViODU3Y2RmNGJjMmFhOC4uNTEyNWNmZmYwNTZkNjc0YjYxNDBiMGM4MTFmNzBj MGU1YzIwZmJmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTAyLTEzICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgU2ltcGxpZnkgQVNTRVJUIGlu IGxhc3RSdWJ5UnVuKCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDE1NzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICByMTgwMDY0IG1hZGUgc29tZSBvZiB0aGUgY29uZGl0aW9ucyBpbiB0aGUgQVNTRVJU IHJlZHVuZGFudC4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAg ICAgICogcmVuZGVyaW5nL1JlbmRlclJ1YnkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6bGFzdFJ1 YnlSdW4pOgorCiAyMDE1LTAyLTEzICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgog CiAgICAgICAgIFtNU0VdW01hY10gQ3Jhc2ggYXQgV2ViQ29yZTo6U291cmNlQnVmZmVyUHJpdmF0 ZUFWRk9iakM6OmRpZFBhcnNlU3RyZWFtRGF0YUFzQXNzZXQgKyAyMzU3CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyUnVieS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyUnVieS5jcHAKaW5kZXggZjJlZDllOWY2YmZlZjQ0NTJjMWI4YzJiMTk0 Mzk3ZjEwZTRhNjE2Yy4uNjY1MDI0YjliNzY2ZDkxY2NkZTAwMzFkMGQyYzA3MzNmMmQzODMzYyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclJ1YnkuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJSdWJ5LmNwcApAQCAtMTA4LDkgKzEwOCwx MSBAQCBzdGF0aWMgUmVuZGVyUnVieVJ1biogbGFzdFJ1YnlSdW4oY29uc3QgUmVuZGVyRWxlbWVu dCogcnVieSkKICAgICBSZW5kZXJPYmplY3QqIGNoaWxkID0gcnVieS0+bGFzdENoaWxkKCk7CiAg ICAgaWYgKGNoaWxkICYmICFpczxSZW5kZXJSdWJ5UnVuPigqY2hpbGQpKQogICAgICAgICBjaGls ZCA9IGNoaWxkLT5wcmV2aW91c1NpYmxpbmcoKTsKLSAgICBBU1NFUlQoIWNoaWxkIHx8IGlzPFJl bmRlclJ1YnlSdW4+KCpjaGlsZCkgfHwgY2hpbGQtPmlzQmVmb3JlQ29udGVudCgpIHx8IGNoaWxk ID09IHJ1YnlCZWZvcmVCbG9jayhydWJ5KSk7Ci0gICAgaWYgKCFpczxSZW5kZXJSdWJ5UnVuPihj aGlsZCkpCisKKyAgICBpZiAoIWlzPFJlbmRlclJ1YnlSdW4+KGNoaWxkKSkgeworICAgICAgICBB U1NFUlQoIWNoaWxkIHx8IGNoaWxkLT5pc0JlZm9yZUNvbnRlbnQoKSB8fCBjaGlsZCA9PSBydWJ5 QmVmb3JlQmxvY2socnVieSkpOwogICAgICAgICByZXR1cm4gbnVsbHB0cjsKKyAgICB9CiAgICAg cmV0dXJuIGRvd25jYXN0PFJlbmRlclJ1YnlSdW4+KGNoaWxkKTsKIH0KIAo=