141561 2015-02-13 07:10:50 -0800 Add some RELEASE_ASSERTs to try to catch crashes in StyleResolver::loadPendingImages 2015-02-24 04:51:44 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned cdumez simon.fraser oldest_to_newest 1068907 0 koivisto 2015-02-13 07:10:50 -0800 One possibility is that loads triggered by loadPendingImages end up synchronously destroying or re-entering style resolver. Add some asserts. 1068909 1 246522 koivisto 2015-02-13 07:17:42 -0800 Created attachment 246522 patch 1068929 2 koivisto 2015-02-13 09:33:04 -0800 https://trac.webkit.org/r180051 1068933 3 cdumez 2015-02-13 09:47:04 -0800 Which radar / crash is that? 1068978 4 koivisto 2015-02-13 11:18:28 -0800 <rdar://problem/9392441&10021139&10138224&10180886&10265259&10738223&10932657&11327125&13281374&13286169&13294656&13294658&13612542&14343895&14492424&14807124&15164315> 1071626 5 koivisto 2015-02-24 04:51:44 -0800 Made this actually work in https://trac.webkit.org/r180554 246522 2015-02-13 07:17:42 -0800 2015-02-13 08:41:44 -0800 patch loadPendingImages-assert.patch text/plain 3914 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MDAzOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE1LTAyLTEzICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgc29tZSBSRUxFQVNFX0FT U0VSVHMgdG8gdHJ5IHRvIGNhdGNoIGNyYXNoZXMgaW4gbG9hZFBlbmRpbmdJbWFnZXMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MTU2MQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9uZSBwb3NzaWJpbGl0 eSBpcyB0aGF0IGxvYWRzIHRyaWdnZXJlZCBieSBsb2FkUGVuZGluZ0ltYWdlcyBlbmQgdXAgc3lu Y2hyb25vdXNseSBkZXN0cm95aW5nIG9yIHJlLWVudGVyaW5nCisgICAgICAgIHN0eWxlIHJlc29s dmVyLiBUcnkgdG8gY2F0Y2ggdGhlc2UgaW4gcmVsZWFzZSBidWlsZC4KKworICAgICAgICAqIGNz cy9TdHlsZVJlc29sdmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlN0eWxlUmVzb2x2ZXI6On5T dHlsZVJlc29sdmVyKToKKyAgICAgICAgKFdlYkNvcmU6OlN0eWxlUmVzb2x2ZXI6OnN0eWxlRm9y RWxlbWVudCk6CisgICAgICAgIChXZWJDb3JlOjpTdHlsZVJlc29sdmVyOjpzdHlsZUZvcktleWZy YW1lKToKKyAgICAgICAgKFdlYkNvcmU6OlN0eWxlUmVzb2x2ZXI6OnN0eWxlRm9yUGFnZSk6Cisg ICAgICAgIChXZWJDb3JlOjpTdHlsZVJlc29sdmVyOjpsb2FkUGVuZGluZ0ltYWdlcyk6CisgICAg ICAgICogY3NzL1N0eWxlUmVzb2x2ZXIuaDoKKwogMjAxNS0wMi0xMiAgWmFsYW4gQnVqdGFzICA8 emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIxNzYyNjIpOiBJbnZhbGlk IGNhc3QgaW4gV2ViQ29yZWBXZWJDb3JlOjpSb290SW5saW5lQm94OjpzZWxlY3Rpb25Ub3AKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAJKHJldmlzaW9uIDE4MDAzOSkKKysr IFNvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MTQwLDYgKzE0MCw3IEBACiAjaW5jbHVkZSAiWE1MTmFtZXMuaCIKICNpbmNsdWRlIDxiaXRzZXQ+ CiAjaW5jbHVkZSA8d3RmL1N0ZExpYkV4dHJhcy5oPgorI2luY2x1ZGUgPHd0Zi9UZW1wb3JhcnlD aGFuZ2UuaD4KICNpbmNsdWRlIDx3dGYvVmVjdG9yLmg+CiAKICNpZiBFTkFCTEUoQ1NTX0dSSURf TEFZT1VUKQpAQCAtMzQ0LDYgKzM0NSw4IEBAIHZvaWQgU3R5bGVSZXNvbHZlcjo6YWRkS2V5ZnJh bWVTdHlsZShQYXMKIAogU3R5bGVSZXNvbHZlcjo6flN0eWxlUmVzb2x2ZXIoKQogeworICAgIFJF TEVBU0VfQVNTRVJUKCFtX2luTG9hZFBlbmRpbmdJbWFnZXMpOworCiAjaWYgRU5BQkxFKENTU19E RVZJQ0VfQURBUFRBVElPTikKICAgICBtX3ZpZXdwb3J0U3R5bGVSZXNvbHZlci0+Y2xlYXJEb2N1 bWVudCgpOwogI2VuZGlmCkBAIC03NDAsNiArNzQzLDggQEAgc3RhdGljIGlubGluZSBib29sIGlz QXRTaGFkb3dCb3VuZGFyeShjbwogUmVmPFJlbmRlclN0eWxlPiBTdHlsZVJlc29sdmVyOjpzdHls ZUZvckVsZW1lbnQoRWxlbWVudCogZWxlbWVudCwgUmVuZGVyU3R5bGUqIGRlZmF1bHRQYXJlbnQs CiAgICAgU3R5bGVTaGFyaW5nQmVoYXZpb3Igc2hhcmluZ0JlaGF2aW9yLCBSdWxlTWF0Y2hpbmdC ZWhhdmlvciBtYXRjaGluZ0JlaGF2aW9yLCBjb25zdCBSZW5kZXJSZWdpb24qIHJlZ2lvbkZvclN0 eWxpbmcpCiB7CisgICAgUkVMRUFTRV9BU1NFUlQoIW1faW5Mb2FkUGVuZGluZ0ltYWdlcyk7CisK ICAgICAvLyBPbmNlIGFuIGVsZW1lbnQgaGFzIGEgcmVuZGVyZXIsIHdlIGRvbid0IHRyeSB0byBk ZXN0cm95IGl0LCBzaW5jZSBvdGhlcndpc2UgdGhlIHJlbmRlcmVyCiAgICAgLy8gd2lsbCB2YW5p c2ggaWYgYSBzdHlsZSByZWNhbGMgaGFwcGVucyBkdXJpbmcgbG9hZGluZy4KICAgICBpZiAoc2hh cmluZ0JlaGF2aW9yID09IEFsbG93U3R5bGVTaGFyaW5nICYmICFlbGVtZW50LT5kb2N1bWVudCgp LmhhdmVTdHlsZXNoZWV0c0xvYWRlZCgpICYmICFlbGVtZW50LT5yZW5kZXJlcigpKSB7CkBAIC04 MTEsNiArODE2LDggQEAgUmVmPFJlbmRlclN0eWxlPiBTdHlsZVJlc29sdmVyOjpzdHlsZUZvcgog CiBSZWY8UmVuZGVyU3R5bGU+IFN0eWxlUmVzb2x2ZXI6OnN0eWxlRm9yS2V5ZnJhbWUoY29uc3Qg UmVuZGVyU3R5bGUqIGVsZW1lbnRTdHlsZSwgY29uc3QgU3R5bGVLZXlmcmFtZSoga2V5ZnJhbWUs IEtleWZyYW1lVmFsdWUmIGtleWZyYW1lVmFsdWUpCiB7CisgICAgUkVMRUFTRV9BU1NFUlQoIW1f aW5Mb2FkUGVuZGluZ0ltYWdlcyk7CisKICAgICBNYXRjaFJlc3VsdCByZXN1bHQ7CiAgICAgcmVz dWx0LmFkZE1hdGNoZWRQcm9wZXJ0aWVzKGtleWZyYW1lLT5wcm9wZXJ0aWVzKCkpOwogCkBAIC05 NzgsNiArOTg1LDggQEAgUGFzc1JlZlB0cjxSZW5kZXJTdHlsZT4gU3R5bGVSZXNvbHZlcjo6cAog CiBSZWY8UmVuZGVyU3R5bGU+IFN0eWxlUmVzb2x2ZXI6OnN0eWxlRm9yUGFnZShpbnQgcGFnZUlu ZGV4KQogeworICAgIFJFTEVBU0VfQVNTRVJUKCFtX2luTG9hZFBlbmRpbmdJbWFnZXMpOworCiAg ICAgbV9zdGF0ZS5pbml0Rm9yU3R5bGVSZXNvbHZlKG1fZG9jdW1lbnQsIG1fZG9jdW1lbnQuZG9j dW1lbnRFbGVtZW50KCksIG1fZG9jdW1lbnQucmVuZGVyU3R5bGUoKSk7CiAKICAgICBtX3N0YXRl LnNldFN0eWxlKFJlbmRlclN0eWxlOjpjcmVhdGUoKSk7CkBAIC0yNDI4LDYgKzI0MzcsOSBAQCB2 b2lkIFN0eWxlUmVzb2x2ZXI6OmxvYWRQZW5kaW5nU2hhcGVJbWFnCiAKIHZvaWQgU3R5bGVSZXNv bHZlcjo6bG9hZFBlbmRpbmdJbWFnZXMoKQogeworICAgIFJFTEVBU0VfQVNTRVJUKCFtX2luTG9h ZFBlbmRpbmdJbWFnZXMpOworICAgIFRlbXBvcmFyeUNoYW5nZTxib29sPiB7IG1faW5Mb2FkUGVu ZGluZ0ltYWdlcywgdHJ1ZSB9OworCiAgICAgaWYgKG1fc3RhdGUucGVuZGluZ0ltYWdlUHJvcGVy dGllcygpLmlzRW1wdHkoKSkKICAgICAgICAgcmV0dXJuOwogCkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9jc3MvU3R5bGVSZXNvbHZlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Nzcy9T dHlsZVJlc29sdmVyLmgJKHJldmlzaW9uIDE4MDAzOSkKKysrIFNvdXJjZS9XZWJDb3JlL2Nzcy9T dHlsZVJlc29sdmVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTUyNSw2ICs1MjUsOSBAQCBwcml2YXRl OgogCiAgICAgU3RhdGUgbV9zdGF0ZTsKIAorICAgIC8vIFRyeSB0byBjYXRjaCBhIGNyYXNoLiBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxNTYxLgorICAgIGJvb2wg bV9pbkxvYWRQZW5kaW5nSW1hZ2VzIHsgZmFsc2UgfTsKKwogICAgIGZyaWVuZCBib29sIG9wZXJh dG9yPT0oY29uc3QgTWF0Y2hlZFByb3BlcnRpZXMmLCBjb25zdCBNYXRjaGVkUHJvcGVydGllcyYp OwogICAgIGZyaWVuZCBib29sIG9wZXJhdG9yIT0oY29uc3QgTWF0Y2hlZFByb3BlcnRpZXMmLCBj b25zdCBNYXRjaGVkUHJvcGVydGllcyYpOwogICAgIGZyaWVuZCBib29sIG9wZXJhdG9yPT0oY29u c3QgTWF0Y2hSYW5nZXMmLCBjb25zdCBNYXRjaFJhbmdlcyYpOwo=