141553 2015-02-12 22:17:47 -0800 Call updateMargins() from RenderListMarker::layout() 2015-02-13 12:53:49 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 cdumez cdumez commit-queue esprehn+autocc glenn kondapallykalyan oldest_to_newest 1068847 0 cdumez 2015-02-12 22:17:47 -0800 Call updateMargins() from RenderListMarker::layout() instead of computePreferredLogicalWidths(). 1068848 1 246509 cdumez 2015-02-12 22:18:31 -0800 Created attachment 246509 WIP Patch 1068850 2 commit-queue 2015-02-12 22:19:40 -0800 Attachment 246509 did not pass style-queue: ERROR: Source/WebCore/rendering/RenderListMarker.cpp:1529: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WebCore/rendering/RenderListMarker.cpp:1643: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 2 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style. 246509 2015-02-12 22:18:31 -0800 2015-02-12 22:18:31 -0800 WIP Patch updateMargins_wip.patch text/plain 1272 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMaXN0TWFya2VyLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMaXN0TWFya2VyLmNwcAppbmRleCBm NzQ2ZjQ1Li45Y2IwNjkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyTGlzdE1hcmtlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxp c3RNYXJrZXIuY3BwCkBAIC0xMzczLDYgKzEzNzMsNyBAQCB2b2lkIFJlbmRlckxpc3RNYXJrZXI6 OmxheW91dCgpCiAgICAgICAgIHNldFdpZHRoKG1faW1hZ2UtPmltYWdlU2l6ZSh0aGlzLCBzdHls ZSgpLmVmZmVjdGl2ZVpvb20oKSkud2lkdGgoKSk7CiAgICAgICAgIHNldEhlaWdodChtX2ltYWdl LT5pbWFnZVNpemUodGhpcywgc3R5bGUoKS5lZmZlY3RpdmVab29tKCkpLmhlaWdodCgpKTsKICAg ICB9IGVsc2UgeworICAgICAgICB1cGRhdGVNYXJnaW5zKCk7CiAgICAgICAgIHNldExvZ2ljYWxX aWR0aChtaW5QcmVmZXJyZWRMb2dpY2FsV2lkdGgoKSk7CiAgICAgICAgIHNldExvZ2ljYWxIZWln aHQoc3R5bGUoKS5mb250TWV0cmljcygpLmhlaWdodCgpKTsKICAgICB9CkBAIC0xNTI1LDcgKzE1 MjYsNyBAQCB2b2lkIFJlbmRlckxpc3RNYXJrZXI6OmNvbXB1dGVQcmVmZXJyZWRMb2dpY2FsV2lk dGhzKCkKICAgICAgICAgTGF5b3V0U2l6ZSBpbWFnZVNpemUgPSBMYXlvdXRTaXplKG1faW1hZ2Ut PmltYWdlU2l6ZSh0aGlzLCBzdHlsZSgpLmVmZmVjdGl2ZVpvb20oKSkpOwogICAgICAgICBtX21p blByZWZlcnJlZExvZ2ljYWxXaWR0aCA9IG1fbWF4UHJlZmVycmVkTG9naWNhbFdpZHRoID0gc3R5 bGUoKS5pc0hvcml6b250YWxXcml0aW5nTW9kZSgpID8gaW1hZ2VTaXplLndpZHRoKCkgOiBpbWFn ZVNpemUuaGVpZ2h0KCk7CiAgICAgICAgIHNldFByZWZlcnJlZExvZ2ljYWxXaWR0aHNEaXJ0eShm YWxzZSk7Ci0gICAgICAgIHVwZGF0ZU1hcmdpbnMoKTsKKyAgICAgICAgLy91cGRhdGVNYXJnaW5z KCk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKQEAgLTE2MzksNyArMTY0MCw3IEBAIHZvaWQg UmVuZGVyTGlzdE1hcmtlcjo6Y29tcHV0ZVByZWZlcnJlZExvZ2ljYWxXaWR0aHMoKQogCiAgICAg c2V0UHJlZmVycmVkTG9naWNhbFdpZHRoc0RpcnR5KGZhbHNlKTsKIAotICAgIHVwZGF0ZU1hcmdp bnMoKTsKKyAgICAvL3VwZGF0ZU1hcmdpbnMoKTsKIH0KIAogdm9pZCBSZW5kZXJMaXN0TWFya2Vy Ojp1cGRhdGVNYXJnaW5zKCkK