141551 2015-02-12 21:06:23 -0800 Crashes under RenderLayer::hitTestLayer under determinePrimarySnapshottedPlugIn() 2015-02-13 11:05:19 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser commit-queue esprehn+autocc glenn hyatt kondapallykalyan simon.fraser thorton zalan oldest_to_newest 1068838 0 simon.fraser 2015-02-12 21:06:23 -0800 Crashes under RenderLayer::hitTestLayer under determinePrimarySnapshottedPlugIn() 1068839 1 246504 simon.fraser 2015-02-12 21:16:46 -0800 Created attachment 246504 Patch 1068840 2 246504 zalan 2015-02-12 21:30:27 -0800 Comment on attachment 246504 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246504&action=review > Source/WebCore/page/FrameView.cpp:2577 > + for (auto& widget : children()) { const auto&? > Source/WebCore/page/FrameView.cpp:4008 > + // A child frame may have dirtied us during its layout. This is what frame flattening does and by judging the assertion above, it manages to resolve it without the extra layout. How is it different from that setup? > Source/WebCore/page/FrameView.h:125 > + bool needsStyleRecalcOrLayout(bool includeSubframes = true) const; We never call this function with includeSubframes = false; Could we drop this parameter? 1068971 3 simon.fraser 2015-02-13 11:05:19 -0800 https://trac.webkit.org/r180063 246504 2015-02-12 21:16:46 -0800 2015-02-12 21:30:27 -0800 Patch bug-141551-20150212211644.patch text/plain 5412 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5OTQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTkwOTQ3MjJkMDgzMzFl Y2RkZTdhMzgxYTYxOTFlNjA5MDlkMGUwNi4uMGQxY2M1MmEzNTk3MWYzNWFkMjBlOWFkMzk1NzU3 MzM0YmVjNTZlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM5IEBACisyMDE1LTAyLTEyICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIENyYXNoZXMgdW5k ZXIgUmVuZGVyTGF5ZXI6OmhpdFRlc3RMYXllciB1bmRlciBkZXRlcm1pbmVQcmltYXJ5U25hcHNo b3R0ZWRQbHVnSW4oKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTQxNTUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAg ICAgIAorICAgICAgICBJdCdzIHBvc3NpYmxlIGZvciBhIGxheW91dCB0byBkaXJ0eSB0aGUgcGFy ZW50IGZyYW1lJ3Mgc3RhdGUsIHZpYSB0aGUgY2FsbHMgdG8KKyAgICAgICAgb3duZXJFbGVtZW50 KCktPnNjaGVkdWxlU2V0TmVlZHNTdHlsZVJlY2FsYygpIHRoYXQgUmVuZGVyTGF5ZXJDb21wb3Np dG9yIGRvZXMgd2hlbgorICAgICAgICBpZnJhbWVzIHRvZ2dsZSB0aGVpciBjb21wb3NpdGluZyBt b2RlLgorICAgICAgICAKKyAgICAgICAgVGhhdCBjb3VsZCBjYXVzZSBGcmFtZVZpZXc6OnVwZGF0 ZUxheW91dEFuZFN0eWxlSWZOZWVkZWRSZWN1cnNpdmUoKSB0byBmYWlsIHRvIAorICAgICAgICBs ZWF2ZSBhbGwgdGhlIGZyYW1lcyBpbiBhIGNsZWFuIHN0YXRlLiBMYXRlciBvbiwgd2UgY291bGQg ZW50ZXIgaGl0IHRlc3RpbmcsCisgICAgICAgIHdoaWNoIGNhbGxzIGRvY3VtZW50KCkudXBkYXRl TGF5b3V0KCkgb24gZWFjaCBmcmFtZSdzIGRvY3VtZW50LiBEb2N1bWVudDo6dXBkYXRlTGF5b3V0 KCkKKyAgICAgICAgZG9lcyBsYXlvdXQgb24gYWxsIGFuY2VzdG9yIGRvY3VtZW50cywgc28gaW4g dGhlIG1pZGRsZSBvZiBoaXQgdGVzdGluZywgd2UgY291bGQKKyAgICAgICAgbGF5b3V0IGEgc3Vi ZnJhbWUgKGRpcnR5aW5nIGFuIGFuY2VzdG9yIGZyYW1lKSwgdGhlbiBsYXlvdXQgYW5vdGhlciBm cmFtZSwgd2hpY2gKKyAgICAgICAgd291bGQgZm9yY2luZyB0aGF0IGFuY2VzdG9yIHRvIGJlIGxh aWQgb3V0IHdoaWxlIHdlJ3JlIGhpdCB0ZXN0aW5nIGl0LCB0aHVzCisgICAgICAgIGNvcnJ1cHRp bmcgdGhlIFJlbmRlckxheWVyIHRyZWUgd2hpbGUgaXQncyBiZWluZyBpdGVyYXRlZCBvdmVyLgor ICAgICAgICAKKyAgICAgICAgRml4IGJ5IGhhdmluZyBGcmFtZVZpZXc6OnVwZGF0ZUxheW91dEFu ZFN0eWxlSWZOZWVkZWRSZWN1cnNpdmUoKSBkbyBhIHNlY29uZAorICAgICAgICBsYXlvdXQgYWZ0 ZXIgbGF5aW5nIG91dCBzdWJmcmFtZXMsIHdoaWNoIG1vc3Qgb2YgdGhlIHRpbWUgd2lsbCBiZSBh IG5vLW9wLgorICAgICAgICAKKyAgICAgICAgQWxzbyBhZGQgYSBzdHJvbmdlciBhc3NlcnRpb24s IHRoYXQgdGhpcyBmcmFtZSBhbmQgYWxsIHN1YmZyYW1lcyBhcmUgY2xlYW4KKyAgICAgICAgYXQg dGhlIGVuZCBvZiBGcmFtZVZpZXc6OnVwZGF0ZUxheW91dEFuZFN0eWxlSWZOZWVkZWRSZWN1cnNp dmUoKSBmb3IgdGhlCisgICAgICAgIG1haW4gZnJhbWUuCisKKyAgICAgICAgVmFyaW91cyBleGlz dGluZyBmcmFtZXMgdGVzdHMgaGl0IHRoZSBuZXcgYXNzZXJ0aW9uIGlmIHRoZSBjb2RlIGNoYW5n ZSBpcyByZW1vdmVkLAorICAgICAgICBzbyB0aGlzIGlzIGNvdmVyZWQgYnkgZXhpc3RpbmcgdGVz dHMuCisKKyAgICAgICAgKiBwYWdlL0ZyYW1lVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpG cmFtZVZpZXc6Om5lZWRzU3R5bGVSZWNhbGNPckxheW91dCk6CisgICAgICAgIChXZWJDb3JlOjpG cmFtZVZpZXc6OnVwZGF0ZUxheW91dEFuZFN0eWxlSWZOZWVkZWRSZWN1cnNpdmUpOgorICAgICAg ICAqIHBhZ2UvRnJhbWVWaWV3Lmg6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlcldpZGdldC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJXaWRnZXQ6OndpbGxCZURlc3Ryb3llZCk6CisK IDIwMTUtMDItMTEgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAg ICAgICAgSW1wcm92ZSB0aGUgc2hvd0ZyYW1lVHJlZSgpIG91dHB1dCBzbGlnaHRseQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUv cGFnZS9GcmFtZVZpZXcuY3BwCmluZGV4IDlmOTRjZWYwOWViYzM2NDkyMTBkMWEyNTFlOWVkOTU4 MTY1MmMxYWIuLmViMTgwZjU3MjU5Njg3MDA4MWU4NmQwNmYxYmRiYzY5MDRiOWM3NDMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKQEAgLTI1NjAsNiArMjU2MCwzMyBAQCBib29sIEZyYW1l Vmlldzo6bGF5b3V0UGVuZGluZygpIGNvbnN0CiAgICAgcmV0dXJuIG1fbGF5b3V0VGltZXIuaXNB Y3RpdmUoKTsKIH0KIAorYm9vbCBGcmFtZVZpZXc6Om5lZWRzU3R5bGVSZWNhbGNPckxheW91dChi b29sIGluY2x1ZGVTdWJmcmFtZXMpIGNvbnN0Cit7CisgICAgaWYgKGZyYW1lKCkuZG9jdW1lbnQo KSAmJiBmcmFtZSgpLmRvY3VtZW50KCktPmNoaWxkTmVlZHNTdHlsZVJlY2FsYygpKQorICAgICAg ICByZXR1cm4gdHJ1ZTsKKyAgICAKKyAgICBpZiAobmVlZHNMYXlvdXQoKSkKKyAgICAgICAgcmV0 dXJuIHRydWU7CisKKyAgICBpZiAoIWluY2x1ZGVTdWJmcmFtZXMpCisgICAgICAgIHJldHVybiBm YWxzZTsKKworICAgIC8vIEZpbmQgY2hpbGQgZnJhbWVzIHZpYSB0aGUgV2lkZ2V0IHRyZWUsIGFz IHVwZGF0ZUxheW91dEFuZFN0eWxlSWZOZWVkZWRSZWN1cnNpdmUoKSBkb2VzLgorICAgIFZlY3Rv cjxSZWY8RnJhbWVWaWV3PiwgMTY+IGNoaWxkVmlld3M7CisgICAgY2hpbGRWaWV3cy5yZXNlcnZl SW5pdGlhbENhcGFjaXR5KGNoaWxkcmVuKCkuc2l6ZSgpKTsKKyAgICBmb3IgKGF1dG8mIHdpZGdl dCA6IGNoaWxkcmVuKCkpIHsKKyAgICAgICAgaWYgKGlzPEZyYW1lVmlldz4oKndpZGdldCkpCisg ICAgICAgICAgICBjaGlsZFZpZXdzLnVuY2hlY2tlZEFwcGVuZChkb3duY2FzdDxGcmFtZVZpZXc+ KCp3aWRnZXQpKTsKKyAgICB9CisKKyAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgY2hpbGRW aWV3cy5zaXplKCk7ICsraSkgeworICAgICAgICBpZiAoY2hpbGRWaWV3c1tpXS0+bmVlZHNTdHls ZVJlY2FsY09yTGF5b3V0KCkpCisgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9CisKKyAg ICByZXR1cm4gZmFsc2U7Cit9CisKIGJvb2wgRnJhbWVWaWV3OjpuZWVkc0xheW91dCgpIGNvbnN0 CiB7CiAgICAgLy8gVGhpcyBjYW4gcmV0dXJuIHRydWUgaW4gY2FzZXMgd2hlcmUgdGhlIGRvY3Vt ZW50IGRvZXMgbm90IGhhdmUgYSBib2R5IHlldC4KQEAgLTM5NzgsMTAgKzQwMDUsMTIgQEAgdm9p ZCBGcmFtZVZpZXc6OnVwZGF0ZUxheW91dEFuZFN0eWxlSWZOZWVkZWRSZWN1cnNpdmUoKQogICAg IGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBjaGlsZFZpZXdzLnNpemUoKTsgKytpKQogICAgICAg ICBjaGlsZFZpZXdzW2ldLT51cGRhdGVMYXlvdXRBbmRTdHlsZUlmTmVlZGVkUmVjdXJzaXZlKCk7 CiAKLSAgICAvLyBXaGVuIGZyYW1lIGZsYXR0ZW5pbmcgaXMgb24sIGNoaWxkIGZyYW1lIGNhbiBt YXJrIHBhcmVudCBmcmFtZSBkaXJ0eS4gSW4gc3VjaCBjYXNlLCBjaGlsZCBmcmFtZQotICAgIC8v IG5lZWRzIHRvIGNhbGwgbGF5b3V0IG9uIHBhcmVudCBmcmFtZSByZWN1cnNpdmVseS4KLSAgICAv LyBUaGlzIGFzc2VydCBlbnN1cmVzIHRoYXQgcGFyZW50IGZyYW1lcyBhcmUgY2xlYW4sIHdoZW4g Y2hpbGQgZnJhbWVzIGZpbmlzaGVkIHVwZGF0aW5nIGxheW91dCBhbmQgc3R5bGUuCi0gICAgQVNT RVJUKCFuZWVkc0xheW91dCgpKTsKKyAgICAvLyBBIGNoaWxkIGZyYW1lIG1heSBoYXZlIGRpcnRp ZWQgdXMgZHVyaW5nIGl0cyBsYXlvdXQuCisgICAgZnJhbWUoKS5kb2N1bWVudCgpLT51cGRhdGVT dHlsZUlmTmVlZGVkKCk7CisgICAgaWYgKG5lZWRzTGF5b3V0KCkpCisgICAgICAgIGxheW91dCgp OworCisgICAgQVNTRVJUKCFmcmFtZSgpLmlzTWFpbkZyYW1lKCkgfHwgIW5lZWRzU3R5bGVSZWNh bGNPckxheW91dCgpKTsKIH0KIAogYm9vbCBGcmFtZVZpZXc6OnF1YWxpZmllc0FzVmlzdWFsbHlO b25FbXB0eSgpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmll dy5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaAppbmRleCAyN2JmNDBjMjFhZjll YTJmNGU0YzZlNzg0ODY4OWQ1ODE1NjFlZTFhLi4wYTI5YzM4YTJkYTA4MTYyMDM4MGY3YzVjNTIw ZDUyODBlNDg5NDc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmgKQEAgLTEyMiw2ICsxMjIsOCBA QCBwdWJsaWM6CiAgICAgV0VCQ09SRV9FWFBPUlQgdm9pZCBzZXROZWVkc0xheW91dCgpOwogICAg IHZvaWQgc2V0Vmlld3BvcnRDb25zdHJhaW5lZE9iamVjdHNOZWVkTGF5b3V0KCk7CiAKKyAgICBi b29sIG5lZWRzU3R5bGVSZWNhbGNPckxheW91dChib29sIGluY2x1ZGVTdWJmcmFtZXMgPSB0cnVl KSBjb25zdDsKKwogICAgIGJvb2wgbmVlZHNGdWxsUmVwYWludCgpIGNvbnN0IHsgcmV0dXJuIG1f bmVlZHNGdWxsUmVwYWludDsgfQogCiAgICAgV0VCQ09SRV9FWFBPUlQgYm9vbCByZW5kZXJlZENo YXJhY3RlcnNFeGNlZWQodW5zaWduZWQgdGhyZXNob2xkKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJXaWRnZXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlcldpZGdldC5jcHAKaW5kZXggMmU2Mjg3N2MxODY3YTU4MzM2YWVlNDhmZDAwZGQy MzU5MTdjY2ZlNi4uYzQ3NjUxMjdmNzkzMmQ4YjI3MmE2YTJkOWZkYmExYmVjYjI1ODIwZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlcldpZGdldC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlcldpZGdldC5jcHAKQEAgLTk5LDcgKzk5LDcg QEAgdm9pZCBSZW5kZXJXaWRnZXQ6OndpbGxCZURlc3Ryb3llZCgpCiAgICAgICAgIGNhY2hlLT5y ZW1vdmUodGhpcyk7CiAgICAgfQogCi0gICAgc2V0V2lkZ2V0KDApOworICAgIHNldFdpZGdldChu dWxscHRyKTsKIAogICAgIFJlbmRlclJlcGxhY2VkOjp3aWxsQmVEZXN0cm95ZWQoKTsKIH0K