141545 2015-02-12 17:21:11 -0800 Crash removing RemoteLayerTreeDisplayRefreshMonitor from the drawing area's map 2015-02-12 22:48:32 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca mitz sam simon.fraser oldest_to_newest 1068808 0 thorton 2015-02-12 17:21:11 -0800 Crash removing RemoteLayerTreeDisplayRefreshMonitor from the drawing area's map 1068809 1 246494 thorton 2015-02-12 17:21:26 -0800 Created attachment 246494 Patch 1068811 2 246494 simon.fraser 2015-02-12 17:31:32 -0800 Comment on attachment 246494 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246494&action=review r- for a test. > Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:87 > + // UnsignedWithZeroKeyHashTraits, which uses uint32_t::max and max - 1 as special values in that case. > + webPage.windowScreenDidChange(std::numeric_limits<uint32_t>::max() - 2 - webPage.pageID()); Please remove the -2 and simplify the comment. 1068824 3 thorton 2015-02-12 19:47:25 -0800 I'm not sure it's possible to write a test right now, because rAF doesn't seem to work in the hacked up WKViewIOS-based WKTR. I'll try to write one on Mac, but nobody runs the tests with --remote-layer-tree yet. 1068832 4 246494 simon.fraser 2015-02-12 20:45:55 -0800 Comment on attachment 246494 Patch OK 1068854 5 thorton 2015-02-12 22:48:32 -0800 http://trac.webkit.org/changeset/180031 246494 2015-02-12 17:21:26 -0800 2015-02-12 20:45:55 -0800 Patch bug-141545-20150212172124.patch text/plain 5272 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5OTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjI1OTYxZWNhNTU1ODM4 MjdkYWI0NmEwY2E3YzcxNjJkNzFmNmJlMS4uZGI3YjI1NzI4MDg1MDhkZmUzYjNlMjFjY2IyNTBl MzUwNjNlNTA0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE1LTAyLTEyICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIENyYXNoIHJlbW92 aW5nIFJlbW90ZUxheWVyVHJlZURpc3BsYXlSZWZyZXNoTW9uaXRvciBmcm9tIHRoZSBkcmF3aW5n IGFyZWEncyBtYXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE0MTU0NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTc3MTIyMDA+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBh Z2UvV2ViUGFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OndpbmRvd1NjcmVlbkRp ZENoYW5nZSk6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaDoKKyAgICAg ICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5tZXNzYWdlcy5pbjoKKyAgICAgICAgd2lu ZG93U2NyZWVuRGlkQ2hhbmdlIHNob3VsZCB0YWtlIHVpbnQzMl90LCBzaW5jZSB0aGF0J3Mgd2hh dCBQbGF0Zm9ybURpc3BsYXlJRCBpcy4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9t YWMvUmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWEubW06CisgICAgICAgIChXZWJLaXQ6OlJlbW90 ZUxheWVyVHJlZURyYXdpbmdBcmVhOjpSZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYSk6CisgICAg ICAgIFJlbW90ZUxheWVyVHJlZURpc3BsYXlSZWZyZXNoTW9uaXRvciBpcyBkcml2ZW4gYnkgdGhl IHBhZ2UncworICAgICAgICBSZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYS4gQmVjYXVzZSBvZiB0 aGlzLCB3ZSBjYW5ub3QgaGF2ZSB0aGUgc2FtZQorICAgICAgICBzaGFyaW5nIG9mIERpc3BsYXlS ZWZyZXNoTW9uaXRvcnMgdGhhdCBvdGhlciBwbGF0Zm9ybXMgdXNlLgorICAgICAgICBJbiBvcmRl ciB0byBlbnN1cmUgdGhhdCB3ZSBnZXQgYSB1bmlxdWUgRGlzcGxheVJlZnJlc2hNb25pdG9yCisg ICAgICAgIHBlci1EcmF3aW5nQXJlYSwgZ2l2ZSBlYWNoIHBhZ2UgYSB1bmlxdWUgRGlzcGxheUlE IGRlcml2ZWQKKyAgICAgICAgZnJvbSBXZWJQYWdlJ3MgdW5pcXVlIElELgorCiAyMDE1LTAyLTEx ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JF U1NJT04gKGlPUyA4KTogUERGcyBlbWJlZGRlZCBpbiA8b2JqZWN0Pi88ZW1iZWQ+IHRhZyBkb24n dCBsb2FkIGF0IGFsbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL1dlYlBhZ2UuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBh Z2UuY3BwCmluZGV4IDYwYTEwYjk4MTNmM2Y0NmVlZWNiNTc5NWZiYmYyOGU1YjEyYWUzNDQuLjMx YzkyOWRmMGY2NDkyMDg0N2RmYzVjYmQ0MWMzNDZlYmY2NjBiMTIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKQEAgLTE0MjgsNyArMTQyOCw3IEBA IHZvaWQgV2ViUGFnZTo6c2V0UGFnZUFuZFRleHRab29tRmFjdG9ycyhkb3VibGUgcGFnZVpvb21G YWN0b3IsIGRvdWJsZSB0ZXh0Wm9vbUZhCiAgICAgcmV0dXJuIGZyYW1lLT5zZXRQYWdlQW5kVGV4 dFpvb21GYWN0b3JzKHN0YXRpY19jYXN0PGZsb2F0PihwYWdlWm9vbUZhY3RvciksIHN0YXRpY19j YXN0PGZsb2F0Pih0ZXh0Wm9vbUZhY3RvcikpOwogfQogCi12b2lkIFdlYlBhZ2U6OndpbmRvd1Nj cmVlbkRpZENoYW5nZSh1aW50NjRfdCBkaXNwbGF5SUQpCit2b2lkIFdlYlBhZ2U6OndpbmRvd1Nj cmVlbkRpZENoYW5nZSh1aW50MzJfdCBkaXNwbGF5SUQpCiB7CiAgICAgbV9wYWdlLT5jaHJvbWUo KS53aW5kb3dTY3JlZW5EaWRDaGFuZ2Uoc3RhdGljX2Nhc3Q8UGxhdGZvcm1EaXNwbGF5SUQ+KGRp c3BsYXlJRCkpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL1dlYlBhZ2UuaCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdl LmgKaW5kZXggMGJkNzFjNjMyN2VlOGQ0ZDVlOGUzMmZjNmI5M2MzZTcxNDViNzExZS4uODE5N2Zm NGQyN2RlNDUyZGI1MjI5YmQzNDFmMjFhOTY1Y2JjYmQzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oCkBAIC0zNTAsNyArMzUwLDcgQEAgcHVibGljOgog ICAgIGRvdWJsZSBwYWdlWm9vbUZhY3RvcigpIGNvbnN0OwogICAgIHZvaWQgc2V0UGFnZVpvb21G YWN0b3IoZG91YmxlKTsKICAgICB2b2lkIHNldFBhZ2VBbmRUZXh0Wm9vbUZhY3RvcnMoZG91Ymxl IHBhZ2Vab29tRmFjdG9yLCBkb3VibGUgdGV4dFpvb21GYWN0b3IpOwotICAgIHZvaWQgd2luZG93 U2NyZWVuRGlkQ2hhbmdlKHVpbnQ2NF90KTsKKyAgICB2b2lkIHdpbmRvd1NjcmVlbkRpZENoYW5n ZSh1aW50MzJfdCk7CiAKICAgICB2b2lkIHNjYWxlUGFnZShkb3VibGUgc2NhbGUsIGNvbnN0IFdl YkNvcmU6OkludFBvaW50JiBvcmlnaW4pOwogICAgIHZvaWQgc2NhbGVQYWdlSW5WaWV3Q29vcmRp bmF0ZXMoZG91YmxlIHNjYWxlLCBXZWJDb3JlOjpJbnRQb2ludCBjZW50ZXJJblZpZXdDb29yZGlu YXRlcyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi UGFnZS5tZXNzYWdlcy5pbiBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQ YWdlLm1lc3NhZ2VzLmluCmluZGV4IDJjNzcxZjZlOWNhZjgyZGMzZDk2NTQ2MzdjNmNlZTY0ZTAw ZGFhMDguLjhlMTEzMGU1Nzc1MjE2ZDJkZTljOGYyNmRlZGU5NzllYzVhMDEwYTMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLm1lc3NhZ2VzLmlu CisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLm1lc3NhZ2Vz LmluCkBAIC0xOTAsNyArMTkwLDcgQEAgbWVzc2FnZXMgLT4gV2ViUGFnZSBMZWdhY3lSZWNlaXZl ciB7CiAgICAgU2V0UGFnZUFuZFRleHRab29tRmFjdG9ycyhkb3VibGUgcGFnZVpvb21GYWN0b3Is IGRvdWJsZSB0ZXh0Wm9vbUZhY3RvcikKICAgICBTZXRQYWdlWm9vbUZhY3Rvcihkb3VibGUgem9v bUZhY3RvcikKICAgICBTZXRUZXh0Wm9vbUZhY3Rvcihkb3VibGUgem9vbUZhY3RvcikKLSAgICBX aW5kb3dTY3JlZW5EaWRDaGFuZ2UodWludDY0X3QgZGlzcGxheUlEKQorICAgIFdpbmRvd1NjcmVl bkRpZENoYW5nZSh1aW50MzJfdCBkaXNwbGF5SUQpCiAKICAgICBTY2FsZVBhZ2UoZG91YmxlIHNj YWxlLCBXZWJDb3JlOjpJbnRQb2ludCBvcmlnaW4pCiAgICAgU2NhbGVQYWdlSW5WaWV3Q29vcmRp bmF0ZXMoZG91YmxlIHNjYWxlLCBXZWJDb3JlOjpJbnRQb2ludCBjZW50ZXJJblZpZXdDb29yZGlu YXRlcykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMv UmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWEubW0gYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYlBhZ2UvbWFjL1JlbW90ZUxheWVyVHJlZURyYXdpbmdBcmVhLm1tCmluZGV4IGE3NTQ5MDdm YTk0MDdmZTJhNGUyYTJmYWIwZDE0ZTE4YzQ5ZTVkMTEuLjNmNDMyYTdmNTZhNmQ1ZWI5Mzc2NTg3 MGNlYTAyNmI0Nzg1NDViODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9tYWMvUmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWEubW0KKysrIGIvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9SZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYS5t bQpAQCAtNzcsNiArNzcsMTQgQEAgUmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWE6OlJlbW90ZUxh eWVyVHJlZURyYXdpbmdBcmVhKFdlYlBhZ2UmIHdlYlBhZ2UsIGNvbnN0IFcKICNlbmRpZgogCiAg ICAgbV9jb21taXRRdWV1ZSA9IGRpc3BhdGNoX3F1ZXVlX2NyZWF0ZSgiY29tLmFwcGxlLldlYktp dC5XZWJDb250ZW50LlJlbW90ZUxheWVyVHJlZURyYXdpbmdBcmVhLkNvbW1pdFF1ZXVlIiwgbnVs bHB0cik7CisKKyAgICAvLyBJbiBvcmRlciB0byBlbnN1cmUgdGhhdCB3ZSBnZXQgYSB1bmlxdWUg RGlzcGxheVJlZnJlc2hNb25pdG9yIHBlci1EcmF3aW5nQXJlYSAobmVjZXNzYXJ5IGJlY2F1c2Ug RGlzcGxheVJlZnJlc2hNb25pdG9yCisgICAgLy8gaXMgZHJpdmVuIGJ5IHRoaXMgY2xhc3MpLCBn aXZlIGVhY2ggcGFnZSBhIHVuaXF1ZSBEaXNwbGF5SUQgZGVyaXZlZCBmcm9tIFdlYlBhZ2UncyB1 bmlxdWUgSUQuCisgICAgLy8gRklYTUU6IFdoaWxlIHVzaW5nIHRoZSBoaWdoIGVuZCBvZiB0aGUg cmFuZ2Ugb2YgRGlzcGxheUlEcyBtYWtlcyBhIGNvbGxpc2lvbiB3aXRoIHJlYWwsIG5vbi1SZW1v dGVMYXllclRyZWVEcmF3aW5nQXJlYQorICAgIC8vIERpc3BsYXlJRHMgbGVzcyBsaWtlbHksIGl0 IGlzIG5vdCBlbnRpcmVseSBzYWZlIHRvIGhhdmUgYSBSZW1vdGVMYXllclRyZWVEcmF3aW5nQXJl YSBhbmQgVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEKKyAgICAvLyBjb2VleGlzdCBpbiB0 aGUgc2FtZSBwcm9jZXNzLiBXZSBzdWJ0cmFjdCB0d28gYmVjYXVzZSBEaXNwbGF5SUQgd2FzIGhp c3RvcmljYWxseSB1c2VkIGFzIHRoZSBrZXkgaW4gSGFzaE1hcHMgd2l0aAorICAgIC8vIFVuc2ln bmVkV2l0aFplcm9LZXlIYXNoVHJhaXRzLCB3aGljaCB1c2VzIHVpbnQzMl90OjptYXggYW5kIG1h eCAtIDEgYXMgc3BlY2lhbCB2YWx1ZXMgaW4gdGhhdCBjYXNlLgorICAgIHdlYlBhZ2Uud2luZG93 U2NyZWVuRGlkQ2hhbmdlKHN0ZDo6bnVtZXJpY19saW1pdHM8dWludDMyX3Q+OjptYXgoKSAtIDIg LSB3ZWJQYWdlLnBhZ2VJRCgpKTsKIH0KIAogUmVtb3RlTGF5ZXJUcmVlRHJhd2luZ0FyZWE6On5S ZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYSgpCg==