141537 2015-02-12 14:36:58 -0800 REGRESSION: Should not send wheel events with a delta of 0 2015-02-19 18:13:52 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Regression P2 Normal --- 141821 1 bdakin webkit-unassigned bdakin bfulgham cmarcelo commit-queue esprehn+autocc kangil.han simon.fraser thorton oldest_to_newest 1068752 0 bdakin 2015-02-12 14:36:58 -0800 This is a regression from http://trac.webkit.org/changeset/172832/trunk/Source/WebCore/dom/Element.cpp We should not be sending wheel events to the DOM with a delta of 0. This affects webmail.apple.com rdar://problem/18903118 1068759 1 246478 bdakin 2015-02-12 14:58:01 -0800 Created attachment 246478 Patch 1068761 2 246478 simon.fraser 2015-02-12 15:05:38 -0800 Comment on attachment 246478 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246478&action=review > Source/WebCore/dom/Element.cpp:282 > + if (!(event.deltaX() || event.deltaY())) This would be clearer as if (!deltaX && !deltaY()) I think. 1068764 3 bdakin 2015-02-12 15:09:38 -0800 http://trac.webkit.org/changeset/180018 1068784 4 bdakin 2015-02-12 16:14:08 -0800 Re-baselined tests in: http://trac.webkit.org/changeset/180021 1069952 5 bfulgham 2015-02-17 14:38:46 -0800 This change breaks snap scroll points, but you couldn't have known that since I have not gotten around to making suitable tests! 1069956 6 bdakin 2015-02-17 14:42:50 -0800 (In reply to comment #5) > This change breaks snap scroll points, but you couldn't have known that > since I have not gotten around to making suitable tests! I wonder why snap scroll points rely on getting a delta of 0? 1069958 7 bfulgham 2015-02-17 14:47:40 -0800 (In reply to comment #6) > (In reply to comment #5) > > This change breaks snap scroll points, but you couldn't have known that > > since I have not gotten around to making suitable tests! > > I wonder why snap scroll points rely on getting a delta of 0? I'm not sure. I'm debugging the code now to see why it matters. I think we have some kind of edge case where the user has ended the wheel motion and the snap animation is about to start. If we return 'false' in this case, the event is treated as unhandled and the animation never starts. I'll know more once I finish debugging. 246478 2015-02-12 14:58:01 -0800 2015-02-12 15:05:38 -0800 Patch for-review.txt text/plain 4973 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MDAxNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE1LTAyLTEyICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OOiBTaG91bGQgbm90 IHNlbmQgd2hlZWwgZXZlbnRzIHdpdGggYSBkZWx0YSBvZiAwCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDE1MzcKKyAgICAgICAgLWFuZCBjb3JyZXNw b25kaW5nLQorICAgICAgICByZGFyOi8vcHJvYmxlbS8xODkwMzExOAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgY29kZSBzaG91bGQgbm90IGhh dmUgYmVlbiByZW1vdmVkIGVudGlyZWx5IHRvIGFjY29tbW9kYXRlIHJ1YmJlci1iYW5kaW5nLCBp dCAKKyAgICAgICAganVzdCBuZWVkcyB0byByZXR1cm4gZmFsc2UgaW5zdGVhZCBvZiB0cnVlIGlu IG9yZGVyIHRvIGFsbG93IHRoZSBNYXlCZWdpbiBhbmQgCisgICAgICAgIEVuZGVkIHBoYXNlcyB0 byBiZSBoYW5kbGVkIGJ5IHRoZSBFbGFzdGljaXR5Q29udHJvbGxlci4KKyAgICAgICAgKiBkb20v RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFbGVtZW50OjpkaXNwYXRjaFdoZWVsRXZl bnQpOgorCiAyMDE1LTAyLTEyICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAogICAg ICAgICBbaU9TIE1lZGlhXSBJbXBsZW1lbnQgMy1zdHlsZSBtZWRpYSB0aW1lbGluZSAoYnVmZmVy ZWQsIHBsYXllZCwgdW5hdmFpbGFibGUpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVu dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCShyZXZp c2lvbiAxNzk5OTcpCisrKyBTb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTI3OSw2ICsyNzksOSBAQCBib29sIEVsZW1lbnQ6OmRpc3BhdGNoTW91c2VFdmVu dChjb25zdCBQCiAKIGJvb2wgRWxlbWVudDo6ZGlzcGF0Y2hXaGVlbEV2ZW50KGNvbnN0IFBsYXRm b3JtV2hlZWxFdmVudCYgZXZlbnQpCiB7CisgICAgaWYgKCEoZXZlbnQuZGVsdGFYKCkgfHwgZXZl bnQuZGVsdGFZKCkpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKICAgICBSZWZQdHI8V2hlZWxF dmVudD4gd2hlZWxFdmVudCA9IFdoZWVsRXZlbnQ6OmNyZWF0ZShldmVudCwgZG9jdW1lbnQoKS5k ZWZhdWx0VmlldygpKTsKICAgICByZXR1cm4gRXZlbnREaXNwYXRjaGVyOjpkaXNwYXRjaEV2ZW50 KHRoaXMsIHdoZWVsRXZlbnQpICYmICF3aGVlbEV2ZW50LT5kZWZhdWx0SGFuZGxlZCgpOwogfQpJ bmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0No YW5nZUxvZwkocmV2aXNpb24gMTgwMDE0KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTUtMDItMTIgIEJldGggRGFraW4gIDxiZGFr aW5AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT046IFNob3VsZCBub3Qgc2VuZCB3aGVl bCBldmVudHMgd2l0aCBhIGRlbHRhIG9mIDAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0MTUzNworICAgICAgICAtYW5kIGNvcnJlc3BvbmRpbmctCisg ICAgICAgIHJkYXI6Ly9wcm9ibGVtLzE4OTAzMTE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMtd2syL3RpbGVkLWRyYXdpbmcv c2Nyb2xsaW5nL3doZWVsLWV2ZW50cy13aXRoLW5vLWRlbHRhLWV4cGVjdGVkLnR4dDogQWRkZWQu CisgICAgICAgICogcGxhdGZvcm0vbWFjLXdrMi90aWxlZC1kcmF3aW5nL3Njcm9sbGluZy93aGVl bC1ldmVudHMtd2l0aC1uby1kZWx0YS5odG1sOiBBZGRlZC4KKwogMjAxNS0wMi0xMiAgSm9zZXBo IFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6 IENyYXNoIGluc3BlY3Rpbmcgc3R5bGVzIG9mIGVsZW1lbnQgd2l0aCBtdXRhdGVkIHN0eWxlc2hl ZXQKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvdGlsZWQtZHJhd2luZy9zY3Jv bGxpbmcvd2hlZWwtZXZlbnRzLXdpdGgtbm8tZGVsdGEtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvdGlsZWQtZHJhd2luZy9zY3JvbGxpbmcv d2hlZWwtZXZlbnRzLXdpdGgtbm8tZGVsdGEtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysg TGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi90aWxlZC1kcmF3aW5nL3Njcm9sbGluZy93aGVl bC1ldmVudHMtd2l0aC1uby1kZWx0YS1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTAs MCArMSBAQAorU3VjY2VzcyEgV2UgZGlkbid0IGdldCBhIHdoZWVsIGV2ZW50IHdpdGggYSBkZWx0 YSBvZiAwLgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi90aWxlZC1kcmF3aW5n L3Njcm9sbGluZy93aGVlbC1ldmVudHMtd2l0aC1uby1kZWx0YS5odG1sCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvdGlsZWQtZHJhd2luZy9zY3JvbGxpbmcvd2hl ZWwtZXZlbnRzLXdpdGgtbm8tZGVsdGEuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3Rz L3BsYXRmb3JtL21hYy13azIvdGlsZWQtZHJhd2luZy9zY3JvbGxpbmcvd2hlZWwtZXZlbnRzLXdp dGgtbm8tZGVsdGEuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDU2IEBACis8aHRtbD4K KzxoZWFkPgorPHN0eWxlPgorYm9keSB7CisgICAgaGVpZ2h0OiAyMDAwcHg7Cit9Cis8L3N0eWxl PgorCis8c2NyaXB0PgorCitmdW5jdGlvbiBtb3VzZVdoZWVsRmlyZWQoZSkgeworICAgIGlmIChl LndoZWVsRGVsdGEgPT0gMCkKKyAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2xvZycp LnRleHRDb250ZW50ID0gIkZBSUwuIFdlIGdvdCBhIHdoZWVsIGV2ZW50IHdpdGggYSBkZWx0YSBv ZiAwLiI7CisKKyAgICBpZiAod2luZG93LmV2ZW50U2VuZGVyKQorICAgICAgICB0ZXN0UnVubmVy Lm5vdGlmeURvbmUoKTsKK30KKworZnVuY3Rpb24gc2Nyb2xsVGVzdCgpCit7CisgICAgZXZlbnRT ZW5kZXIubW91c2VNb3ZlVG8oMjAsIDIwKTsKKyAgICBldmVudFNlbmRlci5tb3VzZVNjcm9sbEJ5 V2l0aFdoZWVsQW5kTW9tZW50dW1QaGFzZXMoMCwgMCwgJ2JlZ2FuJywgJ25vbmUnKTsKKyAgICBl dmVudFNlbmRlci5tb3VzZVNjcm9sbEJ5V2l0aFdoZWVsQW5kTW9tZW50dW1QaGFzZXMoMCwgLTEs ICdjaGFuZ2VkJywgJ25vbmUnKTsKKyAgICBldmVudFNlbmRlci5tb3VzZVNjcm9sbEJ5V2l0aFdo ZWVsQW5kTW9tZW50dW1QaGFzZXMoMCwgLTEsICdjaGFuZ2VkJywgJ25vbmUnKTsKKyAgICBldmVu dFNlbmRlci5tb3VzZVNjcm9sbEJ5V2l0aFdoZWVsQW5kTW9tZW50dW1QaGFzZXMoMCwgMCwgJ2Vu ZGVkJywgJ25vbmUnKTsKKyAgICBldmVudFNlbmRlci5tb3VzZVNjcm9sbEJ5V2l0aFdoZWVsQW5k TW9tZW50dW1QaGFzZXMoMCwgMCwgJ25vbmUnLCAnYmVnaW4nKTsKKyAgICBldmVudFNlbmRlci5t b3VzZVNjcm9sbEJ5V2l0aFdoZWVsQW5kTW9tZW50dW1QaGFzZXMoMCwgLTEsICdub25lJywgJ2Nv bnRpbnVlJyk7CisgICAgZXZlbnRTZW5kZXIubW91c2VTY3JvbGxCeVdpdGhXaGVlbEFuZE1vbWVu dHVtUGhhc2VzKDAsIC0xLCAnbm9uZScsICdjb250aW51ZScpOworICAgIGV2ZW50U2VuZGVyLm1v dXNlU2Nyb2xsQnlXaXRoV2hlZWxBbmRNb21lbnR1bVBoYXNlcygwLCAtMSwgJ25vbmUnLCAnY29u dGludWUnKTsKKyAgICBldmVudFNlbmRlci5tb3VzZVNjcm9sbEJ5V2l0aFdoZWVsQW5kTW9tZW50 dW1QaGFzZXMoMCwgLTEsICdub25lJywgJ2NvbnRpbnVlJyk7CisgICAgZXZlbnRTZW5kZXIubW91 c2VTY3JvbGxCeVdpdGhXaGVlbEFuZE1vbWVudHVtUGhhc2VzKDAsIDAsICdub25lJywgJ2VuZCcp OworfQorCitmdW5jdGlvbiBsb2FkZWQoKQoreworICAgIGRvY3VtZW50LmJvZHkuYWRkRXZlbnRM aXN0ZW5lcignbW91c2V3aGVlbCcsIG1vdXNlV2hlZWxGaXJlZCwgZmFsc2UpOworCisgICAgaWYg KHdpbmRvdy5ldmVudFNlbmRlcikgeworICAgICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsK KyAgICAgICAgdGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7CisgICAgICAgIHNldFRpbWVvdXQo c2Nyb2xsVGVzdCwgMCk7CisgICAgfQorfQorCit3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcignbG9h ZCcsIGxvYWRlZCwgZmFsc2UpOworPC9zY3JpcHQ+Cis8L2hlYWQ+CisKKzxib2R5PgorCis8IS0t VG8gcnVuIHRoaXMgdGVzdCBvdXRzaWRlIG9mIHRoZSB0ZXN0IGhhcm5lc3MsIGp1c3QgbWFudWFs bHkgc2Nyb2xsIGFuZCBlbnN1cmUgdGhhdCB0aGUgc3VjY2VzcyBtZXNzYWdlCitkb2VzIG5vdCBj aGFuZ2UgdG8gYSBmYWlsdXJlIG1lc3NhZ2UuLS0+Cis8cHJlIGlkPSJsb2ciPlN1Y2Nlc3MhIFdl IGRpZG4ndCBnZXQgYSB3aGVlbCBldmVudCB3aXRoIGEgZGVsdGEgb2YgMC48L3ByZT4KKworPC9i b2R5PgorPC9odG1sPgo=