141518 2015-02-12 09:55:50 -0800 [buildbot] Enable run-api-tests on release Mac bots 2015-02-14 00:56:41 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy ossy ap barraclough commit-queue ggaren lforschler ossy rniwa simon.fraser slewis oldest_to_newest 1068649 0 ossy 2015-02-12 09:55:50 -0800 http://trac.webkit.org/changeset/112734 disabled it long long time ago due to bug82652. I tested locally, it works fine on my Mavericks machine. I think it works everywhere, but you might simply forgot to reenable this test on the release bots. Please double check. 1068650 1 246449 ossy 2015-02-12 09:59:10 -0800 Created attachment 246449 Patch Enable run-api-tests and minor cleanups: pass --no-build unconditionally and remove RunUnitTests() step from the TestFactory which isn't used by Mac and Win. 1068684 2 ap 2015-02-12 11:38:32 -0800 I am not aware of any intentional fix that would have addressed the problem. Looking at related bugs, I see a comment that this may have been fixed by making gtest build with libc++. Stephanie, can you confirm, and clean up the state of bug 82652 and rdar://problem/11149812? 1068687 3 246458 ossy 2015-02-12 11:45:41 -0800 Created attachment 246458 Patch typo fixed in the changelog (bug title( 1069171 4 246458 commit-queue 2015-02-14 00:56:36 -0800 Comment on attachment 246458 Patch Clearing flags on attachment: 246458 Committed r180106: <http://trac.webkit.org/changeset/180106> 1069172 5 commit-queue 2015-02-14 00:56:41 -0800 All reviewed patches have been landed. Closing bug. 246449 2015-02-12 09:59:10 -0800 2015-02-12 11:45:33 -0800 Patch bug-141518-20150212095906.patch text/plain 3445 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5OTk2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjc4Y2Y2ZmM4MGQ2Zjg3YTUwYjQxMTc1MjU2YzFkM2Y0 MzYxYmRiNC4uYzk1MGU2MjVkNmQwNTRlNGQyODMzYmNhNDFhMWEwM2I2OWE5NTMyMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE1LTAyLTEyICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgW2J1aWxkYm90XSBFbmFibGUgcnVuLWFwaS10ZXN0cyBvbiByZWxhc2UgTWFjIGJv dHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MTUx OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVp bGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZzoKKyAgICAg ICAgKFJ1blVuaXRUZXN0cyk6CisgICAgICAgIChCdWlsZEZhY3RvcnkuX19pbml0X18pOgorICAg ICAgICAoVGVzdEZhY3RvcnkuX19pbml0X18pOgorICAgICAgICAoQnVpbGRBbmRUZXN0RmFjdG9y eS5fX2luaXRfXyk6CisgICAgICAgIChSdW5Vbml0VGVzdHMuc3RhcnQpOiBEZWxldGVkLgorICAg ICAgICAodW5pdFRlc3RzU3VwcG9ydGVkKTogRGVsZXRlZC4KKwogMjAxNS0wMi0xMiAgQnJlbnQg RnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2luXSBUZXN0IGJvdCBp bmZyYXN0cnVjdHVyZSBzaG91bGQgbm90IHRyeSB0byBmaW5kL3VzZSBvbGQgU2FmYXJpIERMTHMK ZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL21hc3Rlci5jZmcgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9tYXN0ZXIuY2ZnCmluZGV4IDhkMDI4YWJkNDIxNjIwMGY5NWVhMjkzZmNhNjI5ZmU2 YWQxNDQyZGIuLmVlNGRmZWYwY2UzZWVlNzI5Njg4NDNjMzlhYjA3NTRkN2E0OTZkOGYgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21h c3Rlci5jZmcKKysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1j b25maWcvbWFzdGVyLmNmZwpAQCAtNDI4LDE3ICs0MjgsOSBAQCBjbGFzcyBSdW5Vbml0VGVzdHMo VGVzdFdpdGhGYWlsdXJlQ291bnQpOgogICAgIG5hbWUgPSAicnVuLWFwaS10ZXN0cyIKICAgICBk ZXNjcmlwdGlvbiA9IFsidW5pdCB0ZXN0cyBydW5uaW5nIl0KICAgICBkZXNjcmlwdGlvbkRvbmUg PSBbInVuaXQtdGVzdHMiXQotICAgIGNvbW1hbmQgPSBbInBlcmwiLCAiLi9Ub29scy9TY3JpcHRz L3J1bi1hcGktdGVzdHMiLCBXaXRoUHJvcGVydGllcygiLS0lKGNvbmZpZ3VyYXRpb24pcyIpLCAi LS12ZXJib3NlIl0KKyAgICBjb21tYW5kID0gWyJwZXJsIiwgIi4vVG9vbHMvU2NyaXB0cy9ydW4t YXBpLXRlc3RzIiwgIi0tbm8tYnVpbGQiLCBXaXRoUHJvcGVydGllcygiLS0lKGNvbmZpZ3VyYXRp b24pcyIpLCAiLS12ZXJib3NlIl0KICAgICBmYWlsZWRUZXN0c0Zvcm1hdFN0cmluZyA9ICIlZCB1 bml0IHRlc3QlcyBmYWlsZWQgb3IgdGltZWQgb3V0IgogCi0gICAgZGVmIHN0YXJ0KHNlbGYpOgot ICAgICAgICBwbGF0Zm9ybSA9IHNlbGYuZ2V0UHJvcGVydHkoJ2Z1bGxQbGF0Zm9ybScpCi0gICAg ICAgIGlmIHBsYXRmb3JtLnN0YXJ0c3dpdGgoJ3dpbicpOgotICAgICAgICAgICAgc2VsZi5zZXRD b21tYW5kKHNlbGYuY29tbWFuZCArIFsnLS1uby1idWlsZCddKQotICAgICAgICBpZiBwbGF0Zm9y bS5zdGFydHN3aXRoKCdtYWMnKToKLSAgICAgICAgICAgIHNlbGYuc2V0Q29tbWFuZChzZWxmLmNv bW1hbmQgKyBbJy0tbm8tYnVpbGQnXSkKLSAgICAgICAgcmV0dXJuIHNoZWxsLlRlc3Quc3RhcnQo c2VsZikKLQogICAgIGRlZiBjb3VudEZhaWx1cmVzKHNlbGYsIGNtZCk6CiAgICAgICAgIGxvZ190 ZXh0ID0gY21kLmxvZ3NbJ3N0ZGlvJ10uZ2V0VGV4dCgpCiAgICAgICAgIGNvdW50ID0gMApAQCAt NzkyLDExICs3ODQsNiBAQCBjbGFzcyBCdWlsZEZhY3RvcnkoRmFjdG9yeSk6CiAgICAgICAgICAg ICBzZWxmLmFkZFN0ZXAoVXBsb2FkQnVpbHRQcm9kdWN0KCkpCiAgICAgICAgICAgICBzZWxmLmFk ZFN0ZXAodHJpZ2dlci5UcmlnZ2VyKHNjaGVkdWxlck5hbWVzPXRyaWdnZXJzKSkKIAotZGVmIHVu aXRUZXN0c1N1cHBvcnRlZChjb25maWd1cmF0aW9uLCBwbGF0Zm9ybSk6Ci0gICAgaWYgcGxhdGZv cm0uc3RhcnRzd2l0aCgnbWFjJykgYW5kIGNvbmZpZ3VyYXRpb24gPT0gInJlbGVhc2UiOgotICAg ICAgICByZXR1cm4gRmFsc2U7ICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTgyNjUyCi0gICAgcmV0dXJuIHBsYXRmb3JtID09ICd3aW4nIG9yIHBsYXRmb3JtLnN0YXJ0 c3dpdGgoJ21hYycpCi0KIGRlZiBwaWNrTGF0ZXN0QnVpbGQoYnVpbGRlciwgcmVxdWVzdHMpOgog ICAgIHJldHVybiBtYXgocmVxdWVzdHMsIGtleT1vcGVyYXRvci5hdHRyZ2V0dGVyKCJzdWJtaXR0 ZWRBdCIpKQogCkBAIC04MTEsNyArNzk4LDcgQEAgY2xhc3MgVGVzdEZhY3RvcnkoRmFjdG9yeSk6 CiAgICAgICAgIGlmIHNlbGYuTGF5b3V0VGVzdENsYXNzOgogICAgICAgICAgICAgc2VsZi5hZGRT dGVwKHNlbGYuTGF5b3V0VGVzdENsYXNzKGJ1aWxkSlNDVG9vbD0ocGxhdGZvcm0gIT0gJ3dpbicp KSkKIAotICAgICAgICBpZiB1bml0VGVzdHNTdXBwb3J0ZWQoY29uZmlndXJhdGlvbiwgcGxhdGZv cm0pOiAKKyAgICAgICAgaWYgcGxhdGZvcm0gPT0gJ3dpbicgb3IgcGxhdGZvcm0uc3RhcnRzd2l0 aCgnbWFjJyk6CiAgICAgICAgICAgICBzZWxmLmFkZFN0ZXAoUnVuVW5pdFRlc3RzKCkpCiAgICAg ICAgIHNlbGYuYWRkU3RlcChSdW5QeXRob25UZXN0cygpKQogICAgICAgICBzZWxmLmFkZFN0ZXAo UnVuUGVybFRlc3RzKCkpCkBAIC04MzYsOCArODIzLDYgQEAgY2xhc3MgQnVpbGRBbmRUZXN0RmFj dG9yeShGYWN0b3J5KToKICAgICAgICAgc2VsZi5hZGRTdGVwKFJ1bkphdmFTY3JpcHRDb3JlVGVz dHMoKSkKICAgICAgICAgaWYgc2VsZi5MYXlvdXRUZXN0Q2xhc3M6CiAgICAgICAgICAgICBzZWxm LmFkZFN0ZXAoc2VsZi5MYXlvdXRUZXN0Q2xhc3MoKSkKLSAgICAgICAgaWYgdW5pdFRlc3RzU3Vw cG9ydGVkKGNvbmZpZ3VyYXRpb24sIHBsYXRmb3JtKTogCi0gICAgICAgICAgICBzZWxmLmFkZFN0 ZXAoUnVuVW5pdFRlc3RzKCkpCiAgICAgICAgIHNlbGYuYWRkU3RlcChSdW5QeXRob25UZXN0cygp KQogICAgICAgICBzZWxmLmFkZFN0ZXAoUnVuUGVybFRlc3RzKCkpCiAgICAgICAgIHNlbGYuYWRk U3RlcChSdW5CaW5kaW5nc1Rlc3RzKCkpCg== 246458 2015-02-12 11:45:41 -0800 2015-02-14 00:56:36 -0800 Patch bug-141518-20150212114536.patch text/plain 3529 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwMDAxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDljZjU2OTZkYmNhOGIyZmFiMmJjYzUwNGQ2NDZhNWQx Nzk3ODJlMS4uMDFiNTdiM2JmMmE3MTU5ZDc0ZmEyMjYzOWE0ZGRlMmYyNzUxNzZjZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIw IEBACiAyMDE1LTAyLTEyICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAK KyAgICAgICAgW2J1aWxkYm90XSBFbmFibGUgcnVuLWFwaS10ZXN0cyBvbiByZWxlYXNlIE1hYyBi b3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDE1 MTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1 aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmc6CisgICAg ICAgIChSdW5Vbml0VGVzdHMpOgorICAgICAgICAoQnVpbGRGYWN0b3J5Ll9faW5pdF9fKToKKyAg ICAgICAgKFRlc3RGYWN0b3J5Ll9faW5pdF9fKToKKyAgICAgICAgKEJ1aWxkQW5kVGVzdEZhY3Rv cnkuX19pbml0X18pOgorICAgICAgICAoUnVuVW5pdFRlc3RzLnN0YXJ0KTogRGVsZXRlZC4KKyAg ICAgICAgKHVuaXRUZXN0c1N1cHBvcnRlZCk6IERlbGV0ZWQuCisKKzIwMTUtMDItMTIgIENzYWJh IE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKwogICAgICAgICBydW4tanNjLXN0cmVz cy10ZXN0cyAtLXJlbW90ZSBzaG91bGQgYmUgYWJsZSBhZGQgdGhlIG5lY2Vzc2FyeSBsaWJyYXJp ZXMgdG8gdGhlIGJ1bmRsZSBvbiBMaW51eAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQxMjAyCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcgYi9Ub29scy9CdWlsZFNs YXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnCmluZGV4IDhkMDI4 YWJkNDIxNjIwMGY5NWVhMjkzZmNhNjI5ZmU2YWQxNDQyZGIuLmVlNGRmZWYwY2UzZWVlNzI5Njg4 NDNjMzlhYjA3NTRkN2E0OTZkOGYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcKKysrIGIvVG9vbHMvQnVpbGRTbGF2 ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZwpAQCAtNDI4LDE3ICs0 MjgsOSBAQCBjbGFzcyBSdW5Vbml0VGVzdHMoVGVzdFdpdGhGYWlsdXJlQ291bnQpOgogICAgIG5h bWUgPSAicnVuLWFwaS10ZXN0cyIKICAgICBkZXNjcmlwdGlvbiA9IFsidW5pdCB0ZXN0cyBydW5u aW5nIl0KICAgICBkZXNjcmlwdGlvbkRvbmUgPSBbInVuaXQtdGVzdHMiXQotICAgIGNvbW1hbmQg PSBbInBlcmwiLCAiLi9Ub29scy9TY3JpcHRzL3J1bi1hcGktdGVzdHMiLCBXaXRoUHJvcGVydGll cygiLS0lKGNvbmZpZ3VyYXRpb24pcyIpLCAiLS12ZXJib3NlIl0KKyAgICBjb21tYW5kID0gWyJw ZXJsIiwgIi4vVG9vbHMvU2NyaXB0cy9ydW4tYXBpLXRlc3RzIiwgIi0tbm8tYnVpbGQiLCBXaXRo UHJvcGVydGllcygiLS0lKGNvbmZpZ3VyYXRpb24pcyIpLCAiLS12ZXJib3NlIl0KICAgICBmYWls ZWRUZXN0c0Zvcm1hdFN0cmluZyA9ICIlZCB1bml0IHRlc3QlcyBmYWlsZWQgb3IgdGltZWQgb3V0 IgogCi0gICAgZGVmIHN0YXJ0KHNlbGYpOgotICAgICAgICBwbGF0Zm9ybSA9IHNlbGYuZ2V0UHJv cGVydHkoJ2Z1bGxQbGF0Zm9ybScpCi0gICAgICAgIGlmIHBsYXRmb3JtLnN0YXJ0c3dpdGgoJ3dp bicpOgotICAgICAgICAgICAgc2VsZi5zZXRDb21tYW5kKHNlbGYuY29tbWFuZCArIFsnLS1uby1i dWlsZCddKQotICAgICAgICBpZiBwbGF0Zm9ybS5zdGFydHN3aXRoKCdtYWMnKToKLSAgICAgICAg ICAgIHNlbGYuc2V0Q29tbWFuZChzZWxmLmNvbW1hbmQgKyBbJy0tbm8tYnVpbGQnXSkKLSAgICAg ICAgcmV0dXJuIHNoZWxsLlRlc3Quc3RhcnQoc2VsZikKLQogICAgIGRlZiBjb3VudEZhaWx1cmVz KHNlbGYsIGNtZCk6CiAgICAgICAgIGxvZ190ZXh0ID0gY21kLmxvZ3NbJ3N0ZGlvJ10uZ2V0VGV4 dCgpCiAgICAgICAgIGNvdW50ID0gMApAQCAtNzkyLDExICs3ODQsNiBAQCBjbGFzcyBCdWlsZEZh Y3RvcnkoRmFjdG9yeSk6CiAgICAgICAgICAgICBzZWxmLmFkZFN0ZXAoVXBsb2FkQnVpbHRQcm9k dWN0KCkpCiAgICAgICAgICAgICBzZWxmLmFkZFN0ZXAodHJpZ2dlci5UcmlnZ2VyKHNjaGVkdWxl ck5hbWVzPXRyaWdnZXJzKSkKIAotZGVmIHVuaXRUZXN0c1N1cHBvcnRlZChjb25maWd1cmF0aW9u LCBwbGF0Zm9ybSk6Ci0gICAgaWYgcGxhdGZvcm0uc3RhcnRzd2l0aCgnbWFjJykgYW5kIGNvbmZp Z3VyYXRpb24gPT0gInJlbGVhc2UiOgotICAgICAgICByZXR1cm4gRmFsc2U7ICMgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyNjUyCi0gICAgcmV0dXJuIHBsYXRmb3Jt ID09ICd3aW4nIG9yIHBsYXRmb3JtLnN0YXJ0c3dpdGgoJ21hYycpCi0KIGRlZiBwaWNrTGF0ZXN0 QnVpbGQoYnVpbGRlciwgcmVxdWVzdHMpOgogICAgIHJldHVybiBtYXgocmVxdWVzdHMsIGtleT1v cGVyYXRvci5hdHRyZ2V0dGVyKCJzdWJtaXR0ZWRBdCIpKQogCkBAIC04MTEsNyArNzk4LDcgQEAg Y2xhc3MgVGVzdEZhY3RvcnkoRmFjdG9yeSk6CiAgICAgICAgIGlmIHNlbGYuTGF5b3V0VGVzdENs YXNzOgogICAgICAgICAgICAgc2VsZi5hZGRTdGVwKHNlbGYuTGF5b3V0VGVzdENsYXNzKGJ1aWxk SlNDVG9vbD0ocGxhdGZvcm0gIT0gJ3dpbicpKSkKIAotICAgICAgICBpZiB1bml0VGVzdHNTdXBw b3J0ZWQoY29uZmlndXJhdGlvbiwgcGxhdGZvcm0pOiAKKyAgICAgICAgaWYgcGxhdGZvcm0gPT0g J3dpbicgb3IgcGxhdGZvcm0uc3RhcnRzd2l0aCgnbWFjJyk6CiAgICAgICAgICAgICBzZWxmLmFk ZFN0ZXAoUnVuVW5pdFRlc3RzKCkpCiAgICAgICAgIHNlbGYuYWRkU3RlcChSdW5QeXRob25UZXN0 cygpKQogICAgICAgICBzZWxmLmFkZFN0ZXAoUnVuUGVybFRlc3RzKCkpCkBAIC04MzYsOCArODIz LDYgQEAgY2xhc3MgQnVpbGRBbmRUZXN0RmFjdG9yeShGYWN0b3J5KToKICAgICAgICAgc2VsZi5h ZGRTdGVwKFJ1bkphdmFTY3JpcHRDb3JlVGVzdHMoKSkKICAgICAgICAgaWYgc2VsZi5MYXlvdXRU ZXN0Q2xhc3M6CiAgICAgICAgICAgICBzZWxmLmFkZFN0ZXAoc2VsZi5MYXlvdXRUZXN0Q2xhc3Mo KSkKLSAgICAgICAgaWYgdW5pdFRlc3RzU3VwcG9ydGVkKGNvbmZpZ3VyYXRpb24sIHBsYXRmb3Jt KTogCi0gICAgICAgICAgICBzZWxmLmFkZFN0ZXAoUnVuVW5pdFRlc3RzKCkpCiAgICAgICAgIHNl bGYuYWRkU3RlcChSdW5QeXRob25UZXN0cygpKQogICAgICAgICBzZWxmLmFkZFN0ZXAoUnVuUGVy bFRlc3RzKCkpCiAgICAgICAgIHNlbGYuYWRkU3RlcChSdW5CaW5kaW5nc1Rlc3RzKCkpCg==