141517 2015-02-12 09:38:34 -0800 [Win] Test bot infrastructure should not try to find/use old Safari DLLs 2015-02-12 09:48:03 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 bfulgham bfulgham andersca bfulgham ossy roger_fong oldest_to_newest 1068642 0 bfulgham 2015-02-12 09:38:34 -0800 The test bot infrastructure does not need to retrieve any DLL's or resource folders from the Safari install. We should remove these steps from our build and test infrastructure so that the lack of a Safari install on a Windows test bot does not cause any test failures. 1068645 1 246448 bfulgham 2015-02-12 09:43:21 -0800 Created attachment 246448 Patch 1068646 2 246448 ossy 2015-02-12 09:45:50 -0800 Comment on attachment 246448 Patch ++ 1068647 3 bfulgham 2015-02-12 09:48:03 -0800 Committed r179996: <http://trac.webkit.org/changeset/179996> 246448 2015-02-12 09:43:21 -0800 2015-02-12 09:44:51 -0800 Patch bug-141517-20150212094320.patch text/plain 3393 bfulgham SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3OTk5NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE1LTAyLTEyICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29t PgorCisgICAgICAgIFtXaW5dIFRlc3QgYm90IGluZnJhc3RydWN0dXJlIHNob3VsZCBub3QgdHJ5 IHRvIGZpbmQvdXNlIG9sZCBTYWZhcmkgRExMcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxNTE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2UgZG8gbm90IG5lZWQgdG8gbG9jYXRlIG9yIHVzZSB0aGUg RExMJ3MgdGhhdCBjYW1lIHdpdGggU2FmYXJpLCBzbyBzdG9wCisgICAgICAgIGZhaWxpbmcgd2hl biB3ZSBjYW5ub3QgZmluZCB0aGVtLiBBbHNvIHJlbW92ZSBzb21lIG9sZCBRdCBjcnVmdCBmcm9t IHRoaXMKKyAgICAgICAgc2NyaXB0LgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVp bHQtcHJvZHVjdC1hcmNoaXZlOgorICAgICAgICAoYXJjaGl2ZUJ1aWx0UHJvZHVjdCk6IAorICAg ICAgICAoZXh0cmFjdEJ1aWx0UHJvZHVjdCk6CisKIDIwMTUtMDItMTEgIEJyZW50IEZ1bGdoYW0g IDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgW1dpbl0gWzY0LWJpdF0gV29yayBhcm91 bmQgTVNWQzIwMTMgUnVudGltZSBCdWcKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1 aWx0LXByb2R1Y3QtYXJjaGl2ZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9y dC9idWlsdC1wcm9kdWN0LWFyY2hpdmUJKHJldmlzaW9uIDE3OTgyOCkKKysrIFRvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2J1aWx0LXByb2R1Y3QtYXJjaGl2ZQkod29ya2luZyBjb3B5KQpAQCAtMSw2 ICsxLDYgQEAKICMhL3Vzci9iaW4vcHl0aG9uCiAKLSMgQ29weXJpZ2h0IChDKSAyMDA5IEFwcGxl IEluYy4gIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisjIENvcHlyaWdodCAoQykgMjAwOSwgMjAxNSBB cHBsZSBJbmMuICBBbGwgcmlnaHRzIHJlc2VydmVkLgogIyBDb3B5cmlnaHQgKEMpIDIwMTIgR29v Z2xlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICMKICMgUmVkaXN0cmlidXRpb24gYW5kIHVz ZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CkBAIC0xMTMsNyAr MTEzLDcgQEAgZGVmIGNyZWF0ZVppcChkaXJlY3RvcnlUb1ppcCwgY29uZmlndXJhdAogCiAKIGRl ZiBhcmNoaXZlQnVpbHRQcm9kdWN0KGNvbmZpZ3VyYXRpb24sIHBsYXRmb3JtLCBmdWxsUGxhdGZv cm0pOgotICAgIGFzc2VydCBwbGF0Zm9ybSBpbiAoJ21hYycsICd3aW4nLCAncXQnLCAnZ3RrJywg J2VmbCcpCisgICAgYXNzZXJ0IHBsYXRmb3JtIGluICgnbWFjJywgJ3dpbicsICdndGsnLCAnZWZs JykKIAogICAgIGNvbmZpZ3VyYXRpb25CdWlsZERpcmVjdG9yeSA9IG9zLnBhdGguam9pbihfYnVp bGREaXJlY3RvcnksIGNvbmZpZ3VyYXRpb24udGl0bGUoKSkKIApAQCAtMTMxLDcgKzEzMSw3IEBA IGRlZiBhcmNoaXZlQnVpbHRQcm9kdWN0KGNvbmZpZ3VyYXRpb24sIHAKIAogICAgICAgICBzaHV0 aWwucm10cmVlKHRoaW5EaXJlY3RvcnkpCiAKLSAgICBlbGlmIHBsYXRmb3JtID09ICdxdCcgb3Ig cGxhdGZvcm0gPT0gJ2d0aycgb3IgcGxhdGZvcm0gPT0gJ2VmbCc6CisgICAgZWxpZiBwbGF0Zm9y bSA9PSAnZ3RrJyBvciBwbGF0Zm9ybSA9PSAnZWZsJzoKICAgICAgICAgdGhpbkRpcmVjdG9yeSA9 IG9zLnBhdGguam9pbihjb25maWd1cmF0aW9uQnVpbGREaXJlY3RvcnksICJ0aGluIikKIAogICAg ICAgICByZW1vdmVEaXJlY3RvcnlJZkV4aXN0cyh0aGluRGlyZWN0b3J5KQpAQCAtMTgxLDcgKzE4 MSw3IEBAIGRlZiB1bnppcEFyY2hpdmUoZGlyZWN0b3J5VG9FeHRyYWN0VG8sIGMKIAogCiBkZWYg ZXh0cmFjdEJ1aWx0UHJvZHVjdChjb25maWd1cmF0aW9uLCBwbGF0Zm9ybSk6Ci0gICAgYXNzZXJ0 IHBsYXRmb3JtIGluICgnbWFjJywgJ3dpbicsICdxdCcsICdndGsnLCAnZWZsJykKKyAgICBhc3Nl cnQgcGxhdGZvcm0gaW4gKCdtYWMnLCAnd2luJywgJ2d0aycsICdlZmwnKQogCiAgICAgYXJjaGl2 ZUZpbGUgPSBvcy5wYXRoLmpvaW4oX2J1aWxkRGlyZWN0b3J5LCBjb25maWd1cmF0aW9uICsgIi56 aXAiKQogICAgIGNvbmZpZ3VyYXRpb25CdWlsZERpcmVjdG9yeSA9IG9zLnBhdGguam9pbihfYnVp bGREaXJlY3RvcnksIGNvbmZpZ3VyYXRpb24udGl0bGUoKSkKQEAgLTE5MSwxOCArMTkxLDcgQEAg ZGVmIGV4dHJhY3RCdWlsdFByb2R1Y3QoY29uZmlndXJhdGlvbiwgcAogCiAgICAgaWYgcGxhdGZv cm0gPT0gJ21hYyc6CiAgICAgICAgIHJldHVybiB1bnppcEFyY2hpdmUoX2J1aWxkRGlyZWN0b3J5 LCBjb25maWd1cmF0aW9uKQotICAgIGVsaWYgcGxhdGZvcm0gPT0gJ3dpbic6Ci0gICAgICAgIGJp bkRpcmVjdG9yeSA9IG9zLnBhdGguam9pbihjb25maWd1cmF0aW9uQnVpbGREaXJlY3RvcnksICJi aW4zMiIpCi0gICAgICAgIG9zLm1ha2VkaXJzKGJpbkRpcmVjdG9yeSkKLQotICAgICAgICBzYWZh cmlQYXRoID0gc3VicHJvY2Vzcy5Qb3BlbignY3lncGF0aCAtdyAiJFBST0dSQU1GSUxFUyIvU2Fm YXJpJywKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc2hlbGw9VHJ1ZSwg c3Rkb3V0PXN1YnByb2Nlc3MuUElQRSkuY29tbXVuaWNhdGUoKVswXS5zdHJpcCgpCi0KLSAgICAg ICAgaWYgc3VicHJvY2Vzcy5jYWxsKCdjcCAtUiAiJXMiLyouZGxsICIlcyIvKi5yZXNvdXJjZXMg JXMnICUgKHNhZmFyaVBhdGgsIHNhZmFyaVBhdGgsIGJpbkRpcmVjdG9yeSksIHNoZWxsPVRydWUp OgotICAgICAgICAgICAgcmV0dXJuIDEKLQotICAgICAgICByZXR1cm4gdW56aXBBcmNoaXZlKGNv bmZpZ3VyYXRpb25CdWlsZERpcmVjdG9yeSwgY29uZmlndXJhdGlvbikKLSAgICBlbGlmIHBsYXRm b3JtID09ICdxdCcgb3IgcGxhdGZvcm0gPT0gJ2d0aycgb3IgcGxhdGZvcm0gPT0gJ2VmbCc6Cisg ICAgZWxpZiBwbGF0Zm9ybSA9PSAnd2luJyBvciBwbGF0Zm9ybSA9PSAnZ3RrJyBvciBwbGF0Zm9y bSA9PSAnZWZsJzoKICAgICAgICAgcHJpbnQgIkV4dHJhY3RpbmciLCBjb25maWd1cmF0aW9uQnVp bGREaXJlY3RvcnkKICAgICAgICAgcmV0dXJuIHVuemlwQXJjaGl2ZShjb25maWd1cmF0aW9uQnVp bGREaXJlY3RvcnksIGNvbmZpZ3VyYXRpb24pCiAK