141513 2015-02-12 09:02:13 -0800 [buildbot] Remove buildJSCTool cruft from master.cfg 2015-02-13 10:02:08 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy ossy ap lforschler ossy rniwa oldest_to_newest 1068630 0 ossy 2015-02-12 09:02:13 -0800 buildJSCTool was to determine if the run-javascriptcore-tests and run-webkit-tests should build JSC/DRT/WTR or not. These scripts call build-jsc / build-dumprendertree if --no-build isn't passed. Let's see run-javascriptore-tests first. Now master.cfg passes --no-build for all bots, except EFL/GTK "build and tester" bots, where calling build-jsc is unnecessary, because JSC is already built by build-webkit previously. Let's see run-webkit-tests. buildJSCTool is true on non Windows bots and --no-build is explicitly passed to Mac and Win bots unconditionally, but not for EFL/GTK bots when build-dumprendertree/build-webkittestrunner don't do anything useful on EFL and GTK, just simple return 0. So let's remove this huge and misleading cruft and pass --no-build everywhere unconditionally. 1068631 1 246445 ossy 2015-02-12 09:03:47 -0800 Created attachment 246445 Patch 1068901 2 246445 ossy 2015-02-13 06:37:17 -0800 Comment on attachment 246445 Patch Clearing flags on attachment: 246445 Committed r180039: <http://trac.webkit.org/changeset/180039> 1068902 3 ossy 2015-02-13 06:37:25 -0800 All reviewed patches have been landed. Closing bug. 1068934 4 ossy 2015-02-13 09:50:28 -0800 Ryosuke or Lucas, could you apply this change on the master if you have a little bit of free time? Thanks. 1068936 5 lforschler 2015-02-13 09:55:06 -0800 done 1068937 6 ossy 2015-02-13 10:02:08 -0800 (In reply to comment #5) > done yay, the bots already picked it up and they are a little bit faster now. :) 246445 2015-02-12 09:03:47 -0800 2015-02-13 06:37:17 -0800 Patch bug-141513-20150212090343.patch text/plain 5532 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5OTg1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2Y2OWFmNDgxN2JhOGYxMjRjOTM5MzA4MzdjYjhhNTYw ZmM4ZWZjNS4uZTIzY2YwZThjNTNiNDY0MjJiYmM2OGQ0ODY3OTg5YWE3YmZhYjQ1YiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDE1LTAyLTEyICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgW2J1aWxkYm90XSBSZW1vdmUgYnVpbGRKU0NUb29sIGNydWZ0IGZyb20gbWFzdGVy LmNmZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQx NTEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBC dWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnOgorICAg ICAgICAoUnVuSmF2YVNjcmlwdENvcmVUZXN0cyk6CisgICAgICAgIChSdW5KYXZhU2NyaXB0Q29y ZVRlc3RzLnN0YXJ0KToKKyAgICAgICAgKFJ1bldlYktpdFRlc3RzKToKKyAgICAgICAgKFJ1bldl YktpdFRlc3RzLnN0YXJ0KToKKyAgICAgICAgKFRlc3RGYWN0b3J5Ll9faW5pdF9fKToKKyAgICAg ICAgKFRlc3RMZWFrc0ZhY3RvcnkuX19pbml0X18pOgorICAgICAgICAoUnVuSmF2YVNjcmlwdENv cmVUZXN0cy5fX2luaXRfXyk6IERlbGV0ZWQuCisgICAgICAgIChSdW5XZWJLaXRUZXN0cy5fX2lu aXRfXyk6IERlbGV0ZWQuCisKIDIwMTUtMDItMTIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dh cmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIEFkZCBBUEkgdG8gYWxsb3cgb3ZlcnJp ZGluZyB0aGUgZGVmYXVsdCBjb2xvciBjaG9vc2VyIGltcGxlbWVudGF0aW9uCmRpZmYgLS1naXQg YS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIu Y2ZnIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFz dGVyLmNmZwppbmRleCA4ZDAyOGFiZDQyMTYyMDBmOTVlYTI5M2ZjYTYyOWZlNmFkMTQ0MmRiLi4x MGQ4YzBhYmQyMTZmNzAyNmMxNDc4OTFmZDM0YjQ0ODNhM2Y5MmFlIDEwMDY0NAotLS0gYS9Ub29s cy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnCisr KyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rl ci5jZmcKQEAgLTI4MywxOCArMjgzLDExIEBAIGNsYXNzIFJ1bkphdmFTY3JpcHRDb3JlVGVzdHMo VGVzdFdpdGhGYWlsdXJlQ291bnQpOgogICAgIG5hbWUgPSAianNjb3JlLXRlc3QiCiAgICAgZGVz Y3JpcHRpb24gPSBbImpzY29yZS10ZXN0cyBydW5uaW5nIl0KICAgICBkZXNjcmlwdGlvbkRvbmUg PSBbImpzY29yZS10ZXN0cyJdCi0gICAgY29tbWFuZCA9IFsicGVybCIsICIuL1Rvb2xzL1Njcmlw dHMvcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzIiwgV2l0aFByb3BlcnRpZXMoIi0tJShjb25maWd1 cmF0aW9uKXMiKV0KKyAgICBjb21tYW5kID0gWyJwZXJsIiwgIi4vVG9vbHMvU2NyaXB0cy9ydW4t amF2YXNjcmlwdGNvcmUtdGVzdHMiLCAiLS1uby1idWlsZCIsIFdpdGhQcm9wZXJ0aWVzKCItLSUo Y29uZmlndXJhdGlvbilzIildCiAgICAgZmFpbGVkVGVzdHNGb3JtYXRTdHJpbmcgPSAiJWQgSlND IHRlc3QlcyBmYWlsZWQiCiAKLSAgICBkZWYgX19pbml0X18oc2VsZiwgYnVpbGRKU0NUb29sPVRy dWUsICphcmdzLCAqKmt3YXJncyk6Ci0gICAgICAgIHNlbGYuYnVpbGRKU0NUb29sID0gYnVpbGRK U0NUb29sCi0gICAgICAgIHNoZWxsLlRlc3QuX19pbml0X18oc2VsZiwgKmFyZ3MsICoqa3dhcmdz KQotICAgICAgICBzZWxmLmFkZEZhY3RvcnlBcmd1bWVudHMoYnVpbGRKU0NUb29sPWJ1aWxkSlND VG9vbCkKLQogICAgIGRlZiBzdGFydChzZWxmKToKICAgICAgICAgYXBwZW5kQ3VzdG9tQnVpbGRG bGFncyhzZWxmLCBzZWxmLmdldFByb3BlcnR5KCdwbGF0Zm9ybScpKQotICAgICAgICBpZiBub3Qg c2VsZi5idWlsZEpTQ1Rvb2w6Ci0gICAgICAgICAgICBzZWxmLnNldENvbW1hbmQoc2VsZi5jb21t YW5kICsgWyctLW5vLWJ1aWxkJ10pCiAgICAgICAgIHJldHVybiBzaGVsbC5UZXN0LnN0YXJ0KHNl bGYpCiAKICAgICBkZWYgY291bnRGYWlsdXJlcyhzZWxmLCBjbWQpOgpAQCAtMzE1LDYgKzMwOCw3 IEBAIGNsYXNzIFJ1bldlYktpdFRlc3RzKHNoZWxsLlRlc3QpOgogICAgIGRlc2NyaXB0aW9uID0g WyJsYXlvdXQtdGVzdHMgcnVubmluZyJdCiAgICAgZGVzY3JpcHRpb25Eb25lID0gWyJsYXlvdXQt dGVzdHMiXQogICAgIGNvbW1hbmQgPSBbInB5dGhvbiIsICIuL1Rvb2xzL1NjcmlwdHMvcnVuLXdl YmtpdC10ZXN0cyIsCisgICAgICAgICAgICAgICAiLS1uby1idWlsZCIsCiAgICAgICAgICAgICAg ICAiLS1uby1zaG93LXJlc3VsdHMiLAogICAgICAgICAgICAgICAgIi0tbm8tbmV3LXRlc3QtcmVz dWx0cyIsCiAgICAgICAgICAgICAgICAiLS1uby1zYW1wbGUtb24tdGltZW91dCIsCkBAIC0zMjQs MjkgKzMxOCwxOCBAQCBjbGFzcyBSdW5XZWJLaXRUZXN0cyhzaGVsbC5UZXN0KToKICAgICAgICAg ICAgICAgICItLW1hc3Rlci1uYW1lIiwgIndlYmtpdC5vcmciLAogICAgICAgICAgICAgICAgIi0t dGVzdC1yZXN1bHRzLXNlcnZlciIsICJ3ZWJraXQtdGVzdC1yZXN1bHRzLmFwcHNwb3QuY29tIiwK ICAgICAgICAgICAgICAgICItLWRlYnVnLXJ3dC1sb2dnaW5nIiwKKyAgICAgICAgICAgICAgICIt LWV4aXQtYWZ0ZXItbi1jcmFzaGVzLW9yLXRpbWVvdXRzIiwgIjUwIiwKKyAgICAgICAgICAgICAg ICItLWV4aXQtYWZ0ZXItbi1mYWlsdXJlcyIsICI1MDAiLAogICAgICAgICAgICAgICAgV2l0aFBy b3BlcnRpZXMoIi0tJShjb25maWd1cmF0aW9uKXMiKV0KIAotICAgIGRlZiBfX2luaXRfXyhzZWxm LCBidWlsZEpTQ1Rvb2w9VHJ1ZSwgKmFyZ3MsICoqa3dhcmdzKToKLSAgICAgICAgc2VsZi5idWls ZEpTQ1Rvb2wgPSBidWlsZEpTQ1Rvb2wKLSAgICAgICAgc2hlbGwuVGVzdC5fX2luaXRfXyhzZWxm LCAqYXJncywgKiprd2FyZ3MpCi0gICAgICAgIHNlbGYuYWRkRmFjdG9yeUFyZ3VtZW50cyhidWls ZEpTQ1Rvb2w9YnVpbGRKU0NUb29sKQotCiAgICAgZGVmIHN0YXJ0KHNlbGYpOgogICAgICAgICBw bGF0Zm9ybSA9IHNlbGYuZ2V0UHJvcGVydHkoJ3BsYXRmb3JtJykKICAgICAgICAgYXBwZW5kQ3Vz dG9tQnVpbGRGbGFncyhzZWxmLCBwbGF0Zm9ybSwgc2VsZi5nZXRQcm9wZXJ0eSgnZnVsbFBsYXRm b3JtJykpCiAgICAgICAgIGFkZGl0aW9uYWxBcmd1bWVudHMgPSBzZWxmLmdldFByb3BlcnR5KCdh ZGRpdGlvbmFsQXJndW1lbnRzJykKIAotICAgICAgICBzZWxmLnNldENvbW1hbmQoc2VsZi5jb21t YW5kICsgWyItLWV4aXQtYWZ0ZXItbi1jcmFzaGVzLW9yLXRpbWVvdXRzIiwgIjUwIiwgIi0tZXhp dC1hZnRlci1uLWZhaWx1cmVzIiwgIjUwMCJdKQotCi0gICAgICAgIGlmIHBsYXRmb3JtLnN0YXJ0 c3dpdGgoJ21hYycpOgotICAgICAgICAgICAgc2VsZi5zZXRDb21tYW5kKHNlbGYuY29tbWFuZCAr IFsnLS1uby1idWlsZCddKQogICAgICAgICBpZiBwbGF0Zm9ybSA9PSAid2luIjoKLSAgICAgICAg ICAgIHJvb3RBcmd1bWVudCA9IFsnLS1yb290PScgKyBvcy5wYXRoLmpvaW4oIldlYktpdEJ1aWxk Iiwgc2VsZi5nZXRQcm9wZXJ0eSgnY29uZmlndXJhdGlvbicpLCAiYmluMzIiKV0KLSAgICAgICAg ICAgIHNlbGYuc2V0Q29tbWFuZChzZWxmLmNvbW1hbmQgKyBbJy0tbm8tYnVpbGQnLCAnLS1iYXRj aC1zaXplJywgJzEwMCddKQotICAgICAgICBlbHNlOgotICAgICAgICAgICAgcm9vdEFyZ3VtZW50 ID0gWyctLXJvb3Q9V2ViS2l0QnVpbGQvYmluJ10KLSAgICAgICAgaWYgbm90IHNlbGYuYnVpbGRK U0NUb29sOgotICAgICAgICAgICAgc2VsZi5zZXRDb21tYW5kKHNlbGYuY29tbWFuZCArIHJvb3RB cmd1bWVudCkKKyAgICAgICAgICAgIHNlbGYuc2V0Q29tbWFuZChzZWxmLmNvbW1hbmQgKyBbJy0t YmF0Y2gtc2l6ZScsICcxMDAnLCAnLS1yb290PScgKyBvcy5wYXRoLmpvaW4oIldlYktpdEJ1aWxk Iiwgc2VsZi5nZXRQcm9wZXJ0eSgnY29uZmlndXJhdGlvbicpLCAiYmluMzIiKV0pCisKICAgICAg ICAgaWYgYWRkaXRpb25hbEFyZ3VtZW50czoKICAgICAgICAgICAgIHNlbGYuc2V0Q29tbWFuZChz ZWxmLmNvbW1hbmQgKyBhZGRpdGlvbmFsQXJndW1lbnRzKQogICAgICAgICByZXR1cm4gc2hlbGwu VGVzdC5zdGFydChzZWxmKQpAQCAtODA3LDkgKzc5MCw5IEBAIGNsYXNzIFRlc3RGYWN0b3J5KEZh Y3RvcnkpOgogICAgICAgICBGYWN0b3J5Ll9faW5pdF9fKHNlbGYsIHBsYXRmb3JtLCBjb25maWd1 cmF0aW9uLCBhcmNoaXRlY3R1cmVzLCBGYWxzZSwgYWRkaXRpb25hbEFyZ3VtZW50cywgU1ZOTWly cm9yKQogICAgICAgICBzZWxmLmFkZFN0ZXAoRG93bmxvYWRCdWlsdFByb2R1Y3QoKSkKICAgICAg ICAgc2VsZi5hZGRTdGVwKEV4dHJhY3RCdWlsdFByb2R1Y3QoKSkKLSAgICAgICAgc2VsZi5hZGRT dGVwKFJ1bkphdmFTY3JpcHRDb3JlVGVzdHMoYnVpbGRKU0NUb29sPUZhbHNlKSkKKyAgICAgICAg c2VsZi5hZGRTdGVwKFJ1bkphdmFTY3JpcHRDb3JlVGVzdHMoKSkKICAgICAgICAgaWYgc2VsZi5M YXlvdXRUZXN0Q2xhc3M6Ci0gICAgICAgICAgICBzZWxmLmFkZFN0ZXAoc2VsZi5MYXlvdXRUZXN0 Q2xhc3MoYnVpbGRKU0NUb29sPShwbGF0Zm9ybSAhPSAnd2luJykpKQorICAgICAgICAgICAgc2Vs Zi5hZGRTdGVwKHNlbGYuTGF5b3V0VGVzdENsYXNzKCkpCiAKICAgICAgICAgaWYgdW5pdFRlc3Rz U3VwcG9ydGVkKGNvbmZpZ3VyYXRpb24sIHBsYXRmb3JtKTogCiAgICAgICAgICAgICBzZWxmLmFk ZFN0ZXAoUnVuVW5pdFRlc3RzKCkpCkBAIC04NzksNyArODYyLDcgQEAgY2xhc3MgVGVzdExlYWtz RmFjdG9yeShGYWN0b3J5KToKICAgICAgICAgRmFjdG9yeS5fX2luaXRfXyhzZWxmLCBwbGF0Zm9y bSwgY29uZmlndXJhdGlvbiwgYXJjaGl0ZWN0dXJlcywgRmFsc2UsIGFkZGl0aW9uYWxBcmd1bWVu dHMsIFNWTk1pcnJvcikKICAgICAgICAgc2VsZi5hZGRTdGVwKERvd25sb2FkQnVpbHRQcm9kdWN0 KCkpCiAgICAgICAgIHNlbGYuYWRkU3RlcChFeHRyYWN0QnVpbHRQcm9kdWN0KCkpCi0gICAgICAg IHNlbGYuYWRkU3RlcChSdW5XZWJLaXRMZWFrVGVzdHMoYnVpbGRKU0NUb29sPShwbGF0Zm9ybSAh PSAnd2luJykpKSAjIEZJWE1FOiBXaHkgaXMgYnVpbGRKU0NUb29sIG5lZWRlZD8KKyAgICAgICAg c2VsZi5hZGRTdGVwKFJ1bldlYktpdExlYWtUZXN0cygpKQogICAgICAgICBzZWxmLmFkZFN0ZXAo QXJjaGl2ZVRlc3RSZXN1bHRzKCkpCiAgICAgICAgIHNlbGYuYWRkU3RlcChVcGxvYWRUZXN0UmVz dWx0cygpKQogICAgICAgICBzZWxmLmFkZFN0ZXAoRXh0cmFjdFRlc3RSZXN1bHRzQW5kTGVha3Mo KSkK