141492 2015-02-11 14:16:57 -0800 extract-localizable-strings.pl shouldn't update the target file if the contents haven't changed 2015-02-11 15:14:39 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrowe mrowe commit-queue mitz oldest_to_newest 1068483 0 mrowe 2015-02-11 14:16:57 -0800 extract-localizable-strings.pl is typically run unconditionally during the build since it's difficult to get the dependencies right. The current behavior results in the output file always being updated, which results in Xcode always needing to copy the file into the framework. This has a flow-on effect of causing any dependent targets to be relinked against the framework. There are two ways to address this: 1) Only run extract-localizable-strings.pl if any of the files it considers have changed. This is difficult to arrange for with Xcode's build system, and would be cumbersome even with make. 2) Only update the target file if the new localizable strings are different from the existing localizable strings. This patch will take option 2. 1068484 1 246415 mrowe 2015-02-11 14:21:48 -0800 Created attachment 246415 Patch 1068501 2 246415 commit-queue 2015-02-11 15:14:36 -0800 Comment on attachment 246415 Patch Clearing flags on attachment: 246415 Committed r179970: <http://trac.webkit.org/changeset/179970> 1068502 3 commit-queue 2015-02-11 15:14:39 -0800 All reviewed patches have been landed. Closing bug. 246415 2015-02-11 14:21:48 -0800 2015-02-11 15:14:36 -0800 Patch bug-141492-20150211142148.patch text/plain 2344 mrowe U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5ODgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTczNWM5ZjEwOGY0NDc5 NzI1ZDVkYmI2MGNjYjAxYTUyMmYyMDQ0My4uNjlkMGQxMTkxMTZlMDRkNzhmNjJlNmEyNjA5YjE3 N2QxNjI1M2RlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTAyLTExICBNYXJr IFJvd2UgIDxtcm93ZUBhcHBsZS5jb20+CisKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9i LzE0MTQ5Mj4gZXh0cmFjdC1sb2NhbGl6YWJsZS1zdHJpbmdzLnBsIHNob3VsZG4ndCB1cGRhdGUg dGhlIHRhcmdldCBmaWxlIGlmIHRoZSBjb250ZW50cyBoYXZlbid0IGNoYW5nZWQKKworICAgICAg ICBBdm9pZCB1cGRhdGluZyB0aGUgdGFyZ2V0IGZpbGUgaWYgdGhlIGNvbnRlbnRzIGhhdmVuJ3Qg Y2hhbmdlZC4gVGhpcyBwcmV2ZW50cyBYY29kZSBmcm9tIGNvcHlpbmcgdGhlIGlkZW50aWNhbAor ICAgICAgICBmaWxlIGludG8gdGhlIGZyYW1ld29yayBhbmQgcmVzaWduaW5nIGl0LCB3aGljaCBh dm9pZHMgdGhlIHJlc3VsdGluZyByZWxpbmtpbmcgb2YgYWxsIHRhcmdldHMgdGhhdCBkZXBlbmQg b24KKyAgICAgICAgdGhlIGZyYW1ld29yay4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIGV4dHJhY3QtbG9jYWxpemFibGUtc3RyaW5ncy5wbDogV3Jp dGUgb3VyIG91dHB1dCB0byBhIHRlbXBvcmFyeSBmaWxlLiBJZiB0aGUgb3V0cHV0IGRpZmZlcnMg ZnJvbSB0aGUKKyAgICAgICAgZXhpc3RpbmcgY29udGVudHMgb2YgdGhlIHRhcmdldCBmaWxlLCBt b3ZlIHRoZSB0ZW1wb3JhcnkgZmlsZSBvdmVyIHRoZSB0YXJnZXQgZmlsZS4gT3RoZXJ3aXNlLCBk ZWxldGUKKyAgICAgICAgdGhlIHRlbXBvcmFyeSBmaWxlLgorCiAyMDE1LTAyLTA5ICBEYXZpZCBI eWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICB0ZXh0LXVuZGVybGluZS1wb3NpdGlv bjogdW5kZXIgaXMgYnJva2VuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9leHRyYWN0LWxv Y2FsaXphYmxlLXN0cmluZ3MucGwgYi9Tb3VyY2UvV2ViQ29yZS9leHRyYWN0LWxvY2FsaXphYmxl LXN0cmluZ3MucGwKaW5kZXggYzE3OTFiNmY2MDRkMzNlYzhjZDkzMzZhMjRhMmUxMDM5YzlkY2Rk OS4uYmRlY2QwNmM5N2RmNmE4YTY4ZjJkMzVlOGQwODA4ODNmMjY3MjU2ZiAxMDA3NTUKLS0tIGEv U291cmNlL1dlYkNvcmUvZXh0cmFjdC1sb2NhbGl6YWJsZS1zdHJpbmdzLnBsCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2V4dHJhY3QtbG9jYWxpemFibGUtc3RyaW5ncy5wbApAQCAtNDMsNiArNDMsOCBA QAogIyBUaGUgZXhjZXB0aW9ucyBmaWxlIGhhcyBhIGxpc3Qgb2Ygc3RyaW5ncyBpbiBxdW90ZXMs IGZpbGVuYW1lcywgYW5kIGZpbGVuYW1lL3N0cmluZyBwYWlycyBzZXBhcmF0ZWQgYnkgOi4KIAog dXNlIHN0cmljdDsKK3VzZSBGaWxlOjpDb21wYXJlOwordXNlIEZpbGU6OkNvcHk7CiB1c2UgR2V0 b3B0OjpMb25nOwogbm8gd2FybmluZ3MgJ2RlcHJlY2F0ZWQnOwogCkBAIC00MDEsOSArNDAzLDE3 IEBAIGZvciBteSAka2V5IChzb3J0IGtleXMgJWNvbW1lbnRCeUtleSkgewogaWYgKC1lICIkZmls ZVRvVXBkYXRlIikgewogICAgIGlmICghJHZlcmlmeSkgewogICAgICAgICAjIFdyaXRlIG91dCB0 aGUgc3RyaW5ncyBmaWxlIGFzIFVURi04Ci0gICAgICAgIG9wZW4gU1RSSU5HUywgIj4iLCAiJGZp bGVUb1VwZGF0ZSIgb3IgZGllOworICAgICAgICBteSAkdGVtcG9yYXJ5RmlsZSA9ICIkZmlsZVRv VXBkYXRlLnVwZGF0ZWQiOworICAgICAgICBvcGVuIFNUUklOR1MsICI+IiwgJHRlbXBvcmFyeUZp bGUgb3IgZGllOwogICAgICAgICBwcmludCBTVFJJTkdTICRsb2NhbGl6ZWRTdHJpbmdzOwogICAg ICAgICBjbG9zZSBTVFJJTkdTOworCisgICAgICAgICMgQXZvaWQgdXBkYXRpbmcgdGhlIHRhcmdl dCBmaWxlJ3MgbW9kaWZpY2F0aW9uIHRpbWUgaWYgdGhlIGNvbnRlbnRzIGhhdmUgbm90IGNoYW5n ZWQuCisgICAgICAgIGlmIChjb21wYXJlKCR0ZW1wb3JhcnlGaWxlLCAkZmlsZVRvVXBkYXRlKSkg eworICAgICAgICAgICAgbW92ZSgkdGVtcG9yYXJ5RmlsZSwgJGZpbGVUb1VwZGF0ZSk7CisgICAg ICAgIH0gZWxzZSB7CisgICAgICAgICAgICB1bmxpbmsgJHRlbXBvcmFyeUZpbGU7CisgICAgICAg IH0KICAgICB9IGVsc2UgewogICAgICAgICBvcGVuIFNUUklOR1MsICRmaWxlVG9VcGRhdGUgb3Ig ZGllOwogCg==