141482 2015-02-11 12:27:56 -0800 Improve the showFrameTree() output slightly 2015-02-11 12:34:46 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser simon.fraser oldest_to_newest 1068437 0 simon.fraser 2015-02-11 12:27:56 -0800 Improve the showFrameTree() output slightly 1068438 1 246404 simon.fraser 2015-02-11 12:29:05 -0800 Created attachment 246404 Patch 1068442 2 246404 zalan 2015-02-11 12:31:58 -0800 Comment on attachment 246404 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246404&action=review > Source/WebCore/page/FrameTree.cpp:429 > + printf(" renderView=%p\n", view->renderView()); NULL check the view please. 1068443 3 simon.fraser 2015-02-11 12:34:46 -0800 https://trac.webkit.org/r179947 246404 2015-02-11 12:29:05 -0800 2015-02-11 12:31:58 -0800 Patch bug-141482-20150211122904.patch text/plain 3075 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5NzcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmMyMTI5NzNjYTk3MTVl NDNhOTY4MjAxYzYzYzA4ZjlhMTkzNWRlMy4uNDIyNDZiZGYyNTZjMTVjYTgyNzAyNGEyZTUwY2Y0 NWNmN2RhMWY5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTAyLTExICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEltcHJvdmUgdGhl IHNob3dGcmFtZVRyZWUoKSBvdXRwdXQgc2xpZ2h0bHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MTQ4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEhhdmUgc2hvd0ZyYW1lVHJlZSgpIHNob3cgdGhlIEZy YW1lJ3MgUmVuZGVyVmlldyBzbyBpdCBjYW4gYmUgY29ycmVsYXRlZCB3aXRoCisgICAgICAgIGxh eWVyIGR1bXBzLCBhbmQgc2hvdyBzdHlsZVJlY2FsYyBhbmQgbmVlZHNMYXlvdXQgc3RhdGUuCisK KyAgICAgICAgKiBwYWdlL0ZyYW1lVHJlZS5jcHA6CisgICAgICAgIChwcmludEZyYW1lcyk6Cisg ICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3 Ojp1cGRhdGVMYXlvdXRBbmRTdHlsZUlmTmVlZGVkUmVjdXJzaXZlKTogQWRkIGFuIGV4cGxhbmF0 b3J5CisgICAgICAgIGNvbW1lbnQgYWJvdXQgd2h5IHdlIGRvbid0IHdhbGsgdGhlIEZyYW1lIHRy ZWUuCisKIDIwMTUtMDItMDYgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+ CiAKICAgICAgICAgQ29udmVydCB0aGUgY29tcG9zaXRpbmcgb3ZlcmxhcCBtYXAgdG8gdXNlIExh eW91dFJlY3RzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVHJlZS5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVHJlZS5jcHAKaW5kZXggMmVmMjNiMzM1OGE5ZDIy ZTIwYmJlYWU0NjA4ZjdjMGJjNzNiYTdmYy4uYWMwOTAwNDU3MDY4MWFhNzA4MTQwMTdlOGQ0ZTU2 NTdiMjJkNDBhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVRyZWUuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVUcmVlLmNwcApAQCAtNDI0LDExICs0MjQs MTMgQEAgc3RhdGljIHZvaWQgcHJpbnRGcmFtZXMoY29uc3QgV2ViQ29yZTo6RnJhbWUmIGZyYW1l LCBjb25zdCBXZWJDb3JlOjpGcmFtZSogdGFyZ2UKICAgICBwcmludEluZGVudChpbmRlbnQpOwog ICAgIHByaW50ZigiICBvd25lckVsZW1lbnQ9JXBcbiIsIGZyYW1lLm93bmVyRWxlbWVudCgpKTsK ICAgICBwcmludEluZGVudChpbmRlbnQpOwotICAgIHByaW50ZigiICBmcmFtZVZpZXc9JXBcbiIs IHZpZXcpOworICAgIHByaW50ZigiICBmcmFtZVZpZXc9JXAgKG5lZWRzIGxheW91dCAlZClcbiIs IHZpZXcsIHZpZXcgPyB2aWV3LT5uZWVkc0xheW91dCgpIDogZmFsc2UpOwogICAgIHByaW50SW5k ZW50KGluZGVudCk7Ci0gICAgcHJpbnRmKCIgIGRvY3VtZW50PSVwXG4iLCBmcmFtZS5kb2N1bWVu dCgpKTsKKyAgICBwcmludGYoIiAgcmVuZGVyVmlldz0lcFxuIiwgdmlldy0+cmVuZGVyVmlldygp KTsKICAgICBwcmludEluZGVudChpbmRlbnQpOwotICAgIHByaW50ZigiICB1cmk9JXNcblxuIiwg ZnJhbWUuZG9jdW1lbnQoKS0+ZG9jdW1lbnRVUkkoKS51dGY4KCkuZGF0YSgpKTsKKyAgICBwcmlu dGYoIiAgZG9jdW1lbnQ9JXAgKG5lZWRzIHN0eWxlIHJlY2FsYyAlZClcbiIsIGZyYW1lLmRvY3Vt ZW50KCksIGZyYW1lLmRvY3VtZW50KCkgPyBmcmFtZS5kb2N1bWVudCgpLT5uZWVkc1N0eWxlUmVj YWxjKCkgOiBmYWxzZSk7CisgICAgcHJpbnRJbmRlbnQoaW5kZW50KTsKKyAgICBwcmludGYoIiAg dXJpPSVzXG4iLCBmcmFtZS5kb2N1bWVudCgpLT5kb2N1bWVudFVSSSgpLnV0ZjgoKS5kYXRhKCkp OwogCiAgICAgZm9yIChXZWJDb3JlOjpGcmFtZSogY2hpbGQgPSBmcmFtZS50cmVlKCkuZmlyc3RD aGlsZCgpOyBjaGlsZDsgY2hpbGQgPSBjaGlsZC0+dHJlZSgpLm5leHRTaWJsaW5nKCkpCiAgICAg ICAgIHByaW50RnJhbWVzKCpjaGlsZCwgdGFyZ2V0RnJhbWUsIGluZGVudCArIDEpOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUv cGFnZS9GcmFtZVZpZXcuY3BwCmluZGV4IDY5ZmRhNmE5OGUwNDQ4YjBiM2EyYjFhOGU4MDcyMDRl NzE0OGVlOWYuLjlmOTRjZWYwOWViYzM2NDkyMTBkMWEyNTFlOWVkOTU4MTY1MmMxYWIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKQEAgLTM5NjcsNiArMzk2Nyw3IEBAIHZvaWQgRnJhbWVW aWV3Ojp1cGRhdGVMYXlvdXRBbmRTdHlsZUlmTmVlZGVkUmVjdXJzaXZlKCkKICAgICAvLyBHcmFi IGEgY29weSBvZiB0aGUgY2hpbGRyZW4oKSBzZXQsIGFzIGl0IG1heSBiZSBtdXRhdGVkIGJ5IHRo ZSBmb2xsb3dpbmcgdXBkYXRlTGF5b3V0QW5kU3R5bGVJZk5lZWRlZFJlY3Vyc2l2ZQogICAgIC8v IGNhbGxzLCBhcyB0aGV5IGNhbiBwb3RlbnRpYWxseSByZS1lbnRlciBhIGxheW91dCBvZiB0aGUg cGFyZW50IGZyYW1lIHZpZXcsIHdoaWNoIG1heSBhZGQvcmVtb3ZlIHNjcm9sbGJhcnMKICAgICAv LyBhbmQgdGh1cyBtdXRhdGVzIHRoZSBjaGlsZHJlbigpIHNldC4KKyAgICAvLyBXZSB1c2UgdGhl IFdpZGdldCBjaGlsZHJlbiBiZWNhdXNlIHdhbGtpbmcgdGhlIEZyYW1lIHRyZWUgd291bGQgaW5j bHVkZSBkaXNwbGF5Om5vbmUgZnJhbWVzLgogICAgIFZlY3RvcjxSZWY8RnJhbWVWaWV3PiwgMTY+ IGNoaWxkVmlld3M7CiAgICAgY2hpbGRWaWV3cy5yZXNlcnZlSW5pdGlhbENhcGFjaXR5KGNoaWxk cmVuKCkuc2l6ZSgpKTsKICAgICBmb3IgKGF1dG8mIHdpZGdldCA6IGNoaWxkcmVuKCkpIHsK