141480 2015-02-11 10:42:26 -0800 Regression(r179166): Crash when accessing document.dir on a document with no elements 2015-02-11 15:40:15 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 140922 1 sam sam cdumez commit-queue esprehn+autocc gyuyoung.kim webkit-bug-importer oldest_to_newest 1068397 0 sam 2015-02-11 10:42:26 -0800 Crash when accessing document.dir on a document with no elements 1068402 1 246397 sam 2015-02-11 10:50:10 -0800 Created attachment 246397 Test case 1068424 2 cdumez 2015-02-11 11:49:56 -0800 Are you going to work on this? Otherwise, I am happy to take it since I caused the regression it seems. 1068427 3 cdumez 2015-02-11 11:53:54 -0800 https://bugs.webkit.org/show_bug.cgi?id=140922#c5 1068473 4 246412 sam 2015-02-11 13:54:57 -0800 Created attachment 246412 Patch 1068474 5 246412 cdumez 2015-02-11 13:57:25 -0800 Comment on attachment 246412 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246412&action=review r=me % nit, thanks for fixing. > LayoutTests/fast/dom/document-dir-empty-document-crash.html:16 > +shouldBe('doc.dir', '""'); nit: shouldBeEmptyString() 1068477 6 246412 cdumez 2015-02-11 14:00:25 -0800 Comment on attachment 246412 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246412&action=review > Source/WebCore/ChangeLog:3 > + Crash when accessing document.dir on a document with no elements Outdated bug title. 1068506 7 webkit-bug-importer 2015-02-11 15:34:16 -0800 <rdar://problem/19804351> 1068507 8 sam 2015-02-11 15:40:15 -0800 Committed r179971: <http://trac.webkit.org/changeset/179971> 246397 2015-02-11 10:50:10 -0800 2015-02-11 10:50:10 -0800 Test case testDir.html text/html 162 sam PHNjcmlwdD4KICAgIHZhciBkb2MgPSBkb2N1bWVudC5pbXBsZW1lbnRhdGlvbi5jcmVhdGVIVE1M RG9jdW1lbnQoKTsKICAgIHdoaWxlIChkb2MuZmlyc3RDaGlsZCkKICAgICAgZG9jLnJlbW92ZUNo aWxkKGRvYy5maXJzdENoaWxkKTsKICAgIAogICAgZG9jLmRpcjsKPC9zY3JpcHQ+ 246412 2015-02-11 13:54:57 -0800 2015-02-11 13:57:25 -0800 Patch bug-141480-20150211135454.patch text/plain 3558 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3OTk1NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTAyLTExICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQ3Jhc2ggd2hlbiBhY2Nlc3NpbmcgZG9j dW1lbnQuZGlyIG9uIGEgZG9jdW1lbnQgd2l0aCBubyBlbGVtZW50cworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxNDgwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogZmFzdC9kb20vZG9jdW1lbnQt ZGlyLWVtcHR5LWRvY3VtZW50LWNyYXNoLmh0bWwKKworICAgICAgICAqIGh0bWwvSFRNTERvY3Vt ZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxEb2N1bWVudDo6ZGlyKToKKyAgICAgICAg RG9uJ3QgdW5uZWNlc3NhcmlseSBkZXJlZmVyZW5jZSB0aGUgZG9jdW1lbnRFbGVtZW50LiBpczxI VE1MSHRtbEVsZW1lbnQ+KCkgd2lsbCBoYW5kbGUgbnVsbCBqdXN0IGZpbmUuCisKIDIwMTUtMDIt MTEgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgW01TRV0gU2Ft cGxlTWFwOjphZGRSYW5nZSgpIHJldHVybnMgYW4gaW52ZXJ0ZWQgaXRlcmF0b3JfcmFuZ2UsIHBv c3NpYmx5IGNhdXNpbmcgYSBjcmFzaCB3aGVuIHRoYXQgaXRlcmF0b3JfcmFuZ2UgaXMgdHJhdmVy c2VkLgpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRG9jdW1lbnQuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTERvY3VtZW50LmNwcAkocmV2aXNpb24gMTc5 OTM1KQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRG9jdW1lbnQuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0xMTAsNyArMTEwLDcgQEAgaW50IEhUTUxEb2N1bWVudDo6aGVpZ2h0KCkKIGNvbnN0 IEF0b21pY1N0cmluZyYgSFRNTERvY3VtZW50OjpkaXIoKSBjb25zdAogewogICAgIGF1dG8qIGRv Y3VtZW50RWxlbWVudCA9IHRoaXMtPmRvY3VtZW50RWxlbWVudCgpOwotICAgIGlmICghaXM8SFRN TEh0bWxFbGVtZW50PigqZG9jdW1lbnRFbGVtZW50KSkKKyAgICBpZiAoIWlzPEhUTUxIdG1sRWxl bWVudD4oZG9jdW1lbnRFbGVtZW50KSkKICAgICAgICAgcmV0dXJuIG51bGxBdG9tOwogICAgIHJl dHVybiBkb3duY2FzdDxIVE1MSHRtbEVsZW1lbnQ+KCpkb2N1bWVudEVsZW1lbnQpLmRpcigpOwog fQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L0NoYW5nZUxvZwkocmV2aXNpb24gMTc5OTU3KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTUtMDItMTEgIFNhbSBXZWluaWcgIDxz YW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZWdyZXNzaW9uKHIxNzkxNjYpOiBDcmFzaCB3aGVu IGFjY2Vzc2luZyBkb2N1bWVudC5kaXIgb24gYSBkb2N1bWVudCB3aXRoIG5vIGVsZW1lbnRzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDE0ODAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvZG9t L2RvY3VtZW50LWRpci1lbXB0eS1kb2N1bWVudC1jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgor ICAgICAgICAqIGZhc3QvZG9tL2RvY3VtZW50LWRpci1lbXB0eS1kb2N1bWVudC1jcmFzaC5odG1s OiBBZGRlZC4KKwogMjAxNS0wMi0xMSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxl LmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChpT1MgOCk6IFBERnMgZW1iZWRkZWQgaW4gPG9i amVjdD4vPGVtYmVkPiB0YWcgZG9uJ3QgbG9hZCBhdCBhbGwKSW5kZXg6IExheW91dFRlc3RzL2Zh c3QvZG9tL2RvY3VtZW50LWRpci1lbXB0eS1kb2N1bWVudC1jcmFzaC1leHBlY3RlZC50eHQKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vZG9jdW1lbnQtZGlyLWVtcHR5LWRvY3Vt ZW50LWNyYXNoLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3Qv ZG9tL2RvY3VtZW50LWRpci1lbXB0eS1kb2N1bWVudC1jcmFzaC1leHBlY3RlZC50eHQJKHdvcmtp bmcgY29weSkKQEAgLTAsMCArMSwxMCBAQAorVGVzdCB0aGF0IGFjY2Vzc2luZyBkb2N1bWVudC5k aXIgZG9lcyBub3QgY3Jhc2ggZm9yIGEgZG9jdW1lbnQgd2l0aCBubyBlbGVtZW50cyAoYW5kIGlz IHRoZSBlbXB0eSBzdHJpbmcpLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMg b2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFT UyBkb2MuZGlyIGlzICIiCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1Qg Q09NUExFVEUKKwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vZG9jdW1lbnQtZGlyLWVtcHR5 LWRvY3VtZW50LWNyYXNoLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20v ZG9jdW1lbnQtZGlyLWVtcHR5LWRvY3VtZW50LWNyYXNoLmh0bWwJKHJldmlzaW9uIDApCisrKyBM YXlvdXRUZXN0cy9mYXN0L2RvbS9kb2N1bWVudC1kaXItZW1wdHktZG9jdW1lbnQtY3Jhc2guaHRt bAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDIxIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1s PgorPGhlYWQ+Cis8bWV0YSBjaGFyc2V0PSJ1dGYtOCI+Cis8c2NyaXB0IHNyYz0iLi4vLi4vcmVz b3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHNjcmlw dD4KKworZGVzY3JpcHRpb24oIlRlc3QgdGhhdCBhY2Nlc3NpbmcgZG9jdW1lbnQuZGlyIGRvZXMg bm90IGNyYXNoIGZvciBhIGRvY3VtZW50IHdpdGggbm8gZWxlbWVudHMgKGFuZCBpcyB0aGUgZW1w dHkgc3RyaW5nKS4iKTsKKwordmFyIGRvYyA9IGRvY3VtZW50LmltcGxlbWVudGF0aW9uLmNyZWF0 ZUhUTUxEb2N1bWVudCgpOword2hpbGUgKGRvYy5maXJzdENoaWxkKQorICBkb2MucmVtb3ZlQ2hp bGQoZG9jLmZpcnN0Q2hpbGQpOworCitzaG91bGRCZSgnZG9jLmRpcicsICciIicpOworCis8L3Nj cmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3Nj cmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K