141478 2015-02-11 10:03:20 -0800 performance.now can crash if accessed from a window that has navigated 2015-02-11 14:30:32 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sam sam ap oldest_to_newest 1068387 0 sam 2015-02-11 10:03:20 -0800 performance.now can crash if accessed from a window that has navigated 1068389 1 246395 sam 2015-02-11 10:10:01 -0800 Created attachment 246395 Patch 1068392 2 sam 2015-02-11 10:20:25 -0800 <rdar://problem/16892506> 1068393 3 246395 ap 2015-02-11 10:26:47 -0800 Comment on attachment 246395 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246395&action=review > LayoutTests/fast/performance/performance-now-crash-on-navigated-window.html:26 > + // Should not crash. > + value = perfFromInitialFrame.now(); > + shouldBe('value', '0'); Please test Firefox, and possibly update the comment for other reasonable outcomes. This way, if someone changes our behavior to match Firefox and accidentally breaks this test, they will have an easier time figuring out if that's OK. 1068394 4 sam 2015-02-11 10:33:12 -0800 Committed r179936: <http://trac.webkit.org/changeset/179936> 1068395 5 sam 2015-02-11 10:36:36 -0800 Committed r179937: <http://trac.webkit.org/changeset/179937> 1068486 6 ap 2015-02-11 14:29:25 -0800 The new regression test just crashed on a GuardMalloc bot: Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.WebCore 0x000000010824024a WebCore::Performance::now() const + 10 1 com.apple.WebCore 0x000000010802b58e WebCore::jsPerformancePrototypeFunctionNow(JSC::ExecState*) + 126 2 ??? 0x0000000112f73028 0 + 4613156904 3 com.apple.JavaScriptCore 0x0000000106e8e248 llint_entry + 22290 4 com.apple.JavaScriptCore 0x0000000106e8e248 llint_entry + 22290 1068487 7 ap 2015-02-11 14:30:32 -0800 False alarm, that's because the test was landed before the fix :) 246395 2015-02-11 10:10:01 -0800 2015-02-11 10:26:47 -0800 Patch bug-141478-20150211101004.patch text/plain 4970 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3OTkzNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTAyLTExICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgcGVyZm9ybWFuY2Uubm93IGNhbiBjcmFz aCBpZiBhY2Nlc3NlZCBmcm9tIGEgd2luZG93IHRoYXQgaGFzIG5hdmlnYXRlZAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxNDc4CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogZmFzdC9wZXJmb3Jt YW5jZS9wZXJmb3JtYW5jZS1ub3ctY3Jhc2gtb24tbmF2aWdhdGVkLXdpbmRvdy5odG1sCisKKyAg ICAgICAgKiBwYWdlL1BlcmZvcm1hbmNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBlcmZvcm1h bmNlOjpub3cpOgorICAgICAgICBDaGVjayBmb3IgYSBudWxsIGZyYW1lLCB3aGljaCBjYW4gaGFw cGVuIHdoZW4gdGhlIHdpbmRvdyBoYXMgYmVlbiBuYXZpZ2F0ZWQuCisKIDIwMTUtMDItMTAgIEFs ZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgVVJMOjpzZXRVc2Vy IGFuZCBVUkw6OnNldFBhc3MgZG9uJ3QgcGVyY2VudCBlbmNvZGUKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3BhZ2UvUGVyZm9ybWFuY2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Bh Z2UvUGVyZm9ybWFuY2UuY3BwCShyZXZpc2lvbiAxNzk5MjcpCisrKyBTb3VyY2UvV2ViQ29yZS9w YWdlL1BlcmZvcm1hbmNlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjI4LDYgKzIyOCw5IEBAIHZv aWQgUGVyZm9ybWFuY2U6OndlYmtpdENsZWFyTWVhc3VyZXMoY28KIAogZG91YmxlIFBlcmZvcm1h bmNlOjpub3coKSBjb25zdAogeworICAgIGlmICghZnJhbWUoKSkKKyAgICAgICAgcmV0dXJuIDA7 CisKICAgICByZXR1cm4gMTAwMC4wICogbV9mcmFtZS0+ZG9jdW1lbnQoKS0+bG9hZGVyKCktPnRp bWluZygpLm1vbm90b25pY1RpbWVUb1plcm9CYXNlZERvY3VtZW50VGltZShtb25vdG9uaWNhbGx5 SW5jcmVhc2luZ1RpbWUoKSk7CiB9CiAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3OTkzNCkKKysrIExh eW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1 LTAyLTExICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgcGVyZm9ybWFu Y2Uubm93IGNhbiBjcmFzaCBpZiBhY2Nlc3NlZCBmcm9tIGEgd2luZG93IHRoYXQgaGFzIG5hdmln YXRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQx NDc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBm YXN0L3BlcmZvcm1hbmNlL3BlcmZvcm1hbmNlLW5vdy1jcmFzaC1vbi1uYXZpZ2F0ZWQtd2luZG93 LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9wZXJmb3JtYW5jZS9wZXJmb3Jt YW5jZS1ub3ctY3Jhc2gtb24tbmF2aWdhdGVkLXdpbmRvdy5odG1sOiBBZGRlZC4KKyAgICAgICAg KiBmYXN0L3BlcmZvcm1hbmNlL3Jlc291cmNlczogQWRkZWQuCisgICAgICAgICogZmFzdC9wZXJm b3JtYW5jZS9yZXNvdXJjZXMvaW5pdGlhbEZyYW1lLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZh c3QvcGVyZm9ybWFuY2UvcmVzb3VyY2VzL3NlY29uZEZyYW1lLmh0bWw6IEFkZGVkLgorICAgICAg ICBBZGQgdGVzdCBmb3IgY2FsbGluZyBwZXJmb3JtYW5jZS5ub3coKSBvbiBmcm9tIGEgbmF2aWdh dGVkIHdpbmRvdy4KKwogMjAxNS0wMi0xMCAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxl LmNvbT4KIAogICAgICAgICBVUkw6OnNldFVzZXIgYW5kIFVSTDo6c2V0UGFzcyBkb24ndCBwZXJj ZW50IGVuY29kZQpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9wZXJmb3JtYW5jZS9wZXJmb3JtYW5j ZS1ub3ctY3Jhc2gtb24tbmF2aWdhdGVkLXdpbmRvdy1leHBlY3RlZC50eHQKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvZmFzdC9wZXJmb3JtYW5jZS9wZXJmb3JtYW5jZS1ub3ctY3Jhc2gtb24t bmF2aWdhdGVkLXdpbmRvdy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0 cy9mYXN0L3BlcmZvcm1hbmNlL3BlcmZvcm1hbmNlLW5vdy1jcmFzaC1vbi1uYXZpZ2F0ZWQtd2lu ZG93LWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDEwIEBACitUZXN0cyBo b3cgdGhlIHBlcmZvcm1hbmNlIG9iamVjdCB3b3JrcyB3aGVuIGl0J3Mgb3duaW5nIHdpbmRvdyBp cyBub3QgZnVsbHkgYWN0aXZlIGR1ZSB0byBuYXZpZ2F0aW9uLgorCitPbiBzdWNjZXNzLCB5b3Ug d2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBD T01QTEVURSIuCisKKworUEFTUyB2YWx1ZSBpcyAwCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBp cyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9wZXJmb3Jt YW5jZS9wZXJmb3JtYW5jZS1ub3ctY3Jhc2gtb24tbmF2aWdhdGVkLXdpbmRvdy5odG1sCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvcGVyZm9ybWFuY2UvcGVyZm9ybWFuY2Utbm93LWNy YXNoLW9uLW5hdmlnYXRlZC13aW5kb3cuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3Rz L2Zhc3QvcGVyZm9ybWFuY2UvcGVyZm9ybWFuY2Utbm93LWNyYXNoLW9uLW5hdmlnYXRlZC13aW5k b3cuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDMzIEBACis8IURPQ1RZUEUgaHRtbD4K KzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcHJl LmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHNjcmlwdD4KKyAgICBqc1Rlc3RJc0Fz eW5jID0gdHJ1ZTsKKyAgICBkZXNjcmlwdGlvbigiVGVzdHMgaG93IHRoZSBwZXJmb3JtYW5jZSBv YmplY3Qgd29ya3Mgd2hlbiBpdCdzIG93bmluZyB3aW5kb3cgaXMgbm90IGZ1bGx5IGFjdGl2ZSBk dWUgdG8gbmF2aWdhdGlvbi4iKTsKKworICAgIHZhciBwZXJmRnJvbUluaXRpYWxGcmFtZTsKKwor ICAgIC8vIENhbGxlZCBieSBpbml0aWFsRnJhbWUuaHRtbAorICAgIGZ1bmN0aW9uIGluaXRpYWxG cmFtZUxvYWRlZCgpCisgICAgeworICAgICAgICB2YXIgb3RoZXJXaW5kb3cgPSBkb2N1bWVudC5n ZXRFbGVtZW50QnlJZCgiZnJhbWUiKS5jb250ZW50V2luZG93OworICAgICAgICBwZXJmRnJvbUlu aXRpYWxGcmFtZSA9IG90aGVyV2luZG93LnBlcmZvcm1hbmNlOworICAgICAgICBvdGhlcldpbmRv dy5sb2NhdGlvbi5ocmVmID0gInNlY29uZEZyYW1lLmh0bWwiOworICAgIH0KKworICAgIC8vIENh bGxlZCBieSBzZWNvbmRGcmFtZS5odG1sCisgICAgZnVuY3Rpb24gc2Vjb25kRnJhbWVMb2FkZWQo KQorICAgIHsKKyAgICAgICAgLy8gU2hvdWxkIG5vdCBjcmFzaC4KKyAgICAgICAgdmFsdWUgPSBw ZXJmRnJvbUluaXRpYWxGcmFtZS5ub3coKTsKKyAgICAgICAgc2hvdWxkQmUoJ3ZhbHVlJywgJzAn KTsKKyAgICAgICAgZmluaXNoSlNUZXN0KCk7CisgICAgfQorPC9zY3JpcHQ+Cis8c2NyaXB0IHNy Yz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8aWZyYW1lIGlk PSJmcmFtZSIgc3JjPSJyZXNvdXJjZXMvaW5pdGlhbEZyYW1lLmh0bWwiPjwvaWZyYW1lPgorPC9i b2R5PgorPC9odG1sPgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9wZXJmb3JtYW5jZS9yZXNvdXJj ZXMvaW5pdGlhbEZyYW1lLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9wZXJm b3JtYW5jZS9yZXNvdXJjZXMvaW5pdGlhbEZyYW1lLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlv dXRUZXN0cy9mYXN0L3BlcmZvcm1hbmNlL3Jlc291cmNlcy9pbml0aWFsRnJhbWUuaHRtbAkod29y a2luZyBjb3B5KQpAQCAtMCwwICsxLDQgQEAKKzxwPkluaXRpYWwgRnJhbWU8L3A+Cis8c2NyaXB0 PgorICAgIHRvcC5pbml0aWFsRnJhbWVMb2FkZWQoKTsKKzwvc2NyaXB0PgpcIE5vIG5ld2xpbmUg YXQgZW5kIG9mIGZpbGUKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvcGVyZm9ybWFuY2UvcmVzb3Vy Y2VzL3NlY29uZEZyYW1lLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9wZXJm b3JtYW5jZS9yZXNvdXJjZXMvc2Vjb25kRnJhbWUuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91 dFRlc3RzL2Zhc3QvcGVyZm9ybWFuY2UvcmVzb3VyY2VzL3NlY29uZEZyYW1lLmh0bWwJKHdvcmtp bmcgY29weSkKQEAgLTAsMCArMSw0IEBACis8cD5TZWNvbmQgRnJhbWU8L3A+Cis8c2NyaXB0Pgor ICAgIHRvcC5zZWNvbmRGcmFtZUxvYWRlZCgpOworPC9zY3JpcHQ+ClwgTm8gbmV3bGluZSBhdCBl bmQgb2YgZmlsZQo=