141470 2015-02-11 03:49:38 -0800 run-jsc-stress-tests --remote should skip profiler tests 2015-02-13 11:02:07 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 141165 1 ossy ossy commit-queue darin fpizlo ggaren mark.lam mhahnenb msaboff oliver ossy oldest_to_newest 1068320 0 ossy 2015-02-11 03:49:38 -0800 addRunCommand("profiler", ["ruby", (pathToHelpers + "profiler-test-helper").to_s, (SCRIPTS_PATH + "display-profiler-output").to_s, profilerOutput.to_s, pathToVM.to_s, "-p", profilerOutput.to_s, $benchmark.to_s], silentOutputHandler, simpleErrorHandler) profiler tests now depends on many local paths: - SCRIPTS_PATH - profilerOutput - generated by uniqueFilename which does everything locally I think we should simply disable profiler tests for remote testing until proper fix. 1068321 1 246383 ossy 2015-02-11 03:54:18 -0800 Created attachment 246383 Patch 1068904 2 ossy 2015-02-13 06:51:07 -0800 It's safe to land it, because these tests are are already skipped on non-X86 Darwin and Windows platforms. (Enabled on X86-Darwin and all Linux platforms) 1068905 3 ossy 2015-02-13 06:53:07 -0800 https://bugs.webkit.org/show_bug.cgi?id=133149#c7 says the original goal was to skip these tests for remote testing. So here is the proper skipping. Filip, could you possibly review it? 1068967 4 246383 commit-queue 2015-02-13 11:02:02 -0800 Comment on attachment 246383 Patch Clearing flags on attachment: 246383 Committed r180061: <http://trac.webkit.org/changeset/180061> 1068969 5 commit-queue 2015-02-13 11:02:07 -0800 All reviewed patches have been landed. Closing bug. 246383 2015-02-11 03:54:18 -0800 2015-02-13 11:02:02 -0800 Patch bug-141470-20150211035418.patch text/plain 1365 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5OTIyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTUxZjllODRmNjBmMDVlNTc4YjE5ODRjOTIwYmE0YTg5 ZjRhZWJmOS4uYWU4ZDM0MzY3MzU1ZGVkNGI2MGUxNTgxNmE4NTM5ZDYxMmZiZmU0NiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDE1LTAyLTExICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgcnVuLWpzYy1zdHJlc3MtdGVzdHMgLS1yZW1vdGUgc2hvdWxkIHNraXAgcHJvZmls ZXIgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE0MTQ3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0czoKKwogMjAxNS0wMi0xMSAgQ2FybG9zIEdh cmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gQWRkIGRl ZmF1bHQgY29sb3IgY2hvb3NlciBpbXBsZW1lbnRhdGlvbiB1c2luZyBHdGtDb2xvckNob29zZXJE aWFsb2cKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHMgYi9U b29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzCmluZGV4IGJiZjk0NDQzZWNlNGZlYTE4 ZmRjNzhiNjY3NTE0MTgwMmQ2YjkxZmQuLjA0ZjZlYjE3ODA3NzgyODE0OWI0MTViODMwNjdkYTEz ODUxMDFkN2IgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHMK KysrIGIvVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwpAQCAtNzE2LDYgKzcxNiwx MSBAQCBkZWYgZGVmYXVsdE5vRWFnZXJSdW4KIGVuZAogCiBkZWYgcnVuUHJvZmlsZXIKKyAgICBp ZiAkcmVtb3RlCisgICAgICAgIHNraXAKKyAgICAgICAgcmV0dXJuCisgICAgZW5kCisKICAgICBw cm9maWxlck91dHB1dCA9IHVuaXF1ZUZpbGVuYW1lKCIuanNvbiIpCiAgICAgaWYgJGNhblJ1bkRp c3BsYXlQcm9maWxlck91dHB1dAogICAgICAgICBhZGRSdW5Db21tYW5kKCJwcm9maWxlciIsIFsi cnVieSIsIChwYXRoVG9IZWxwZXJzICsgInByb2ZpbGVyLXRlc3QtaGVscGVyIikudG9fcywgKFND UklQVFNfUEFUSCArICJkaXNwbGF5LXByb2ZpbGVyLW91dHB1dCIpLnRvX3MsIHByb2ZpbGVyT3V0 cHV0LnRvX3MsIHBhdGhUb1ZNLnRvX3MsICItcCIsIHByb2ZpbGVyT3V0cHV0LnRvX3MsICRiZW5j aG1hcmsudG9fc10sIHNpbGVudE91dHB1dEhhbmRsZXIsIHNpbXBsZUVycm9ySGFuZGxlcikK