141465 2015-02-11 00:15:52 -0800 Div having contentEditable and display:grid cannot be edited if it is empty. 2021-07-03 02:17:12 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=226926 P2 Normal --- 141647 1 changseok changseok commit-queue esprehn+autocc glenn hyatt jfernandez kangil.han kondapallykalyan ossy rego rniwa simon.fraser svillar oldest_to_newest 1068286 0 changseok 2015-02-11 00:15:52 -0800 This will fix a similar issue with Bug 141218, the only difference from 141218 is that a div has display:grid. 1068290 1 changseok 2015-02-11 00:23:21 -0800 Manuel Rego Casasnovas said : >> Source/WebCore/dom/Position.cpp:939 >> + if (is<RenderBlockFlow>(*renderer) || is<RenderFlexibleBox>(*renderer)) { >I think this is going to be failing for grid too. Maybe you could use here !renderer->isRenderBlockFlow() to cover both cases. >Also adding a test case for grid would be nice. :-) >Mmmm, I've just realized that this won't make any sense. I'm wondering if we should just add is<RenderGrid> or if this "if" is actually needed for something else. >Anyway, this is failing in grid too. 1068305 2 rego 2015-02-11 01:20:04 -0800 Just to give you more information. There're some of these bugs that are both in flex and grid, mostly because of they're not RenderBlockFlow. In some cases, we need some special methods to check that they're not RenderBlockFlow but they're not buttons either (as RenderButton, like RenderFullScreen) inherit from RenderFlexibleBox. For example take a look to this method: http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderBlock.cpp#L2927 1068690 3 changseok 2015-02-12 11:56:19 -0800 (In reply to comment #2) > Just to give you more information. There're some of these bugs that are both > in flex and grid, mostly because of they're not RenderBlockFlow. > > In some cases, we need some special methods to check that they're not > RenderBlockFlow but they're not buttons either (as RenderButton, like > RenderFullScreen) inherit from RenderFlexibleBox. > > For example take a look to this method: > http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderBlock. > cpp#L2927 Thanks for the comment. But I'm not sure if I understand your intention correctly. Why do we need to check that? As my understanding any element can be editable with the contenteditable attribute. https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/Content_Editable Actually I checked RenderFullScreen is allowed to edit in firefox. Could you provide me a sample which should not be allowed to edit even though it has a contenteditable attribute? I think just adding is<RenderGrid>(*renderer) is enough there? (Of course more touches are required to make grid work properly for this case.) 1068715 4 246469 changseok 2015-02-12 12:50:33 -0800 Created attachment 246469 Patch 1068871 5 rego 2015-02-13 00:56:54 -0800 (In reply to comment #3) > (In reply to comment #2) > > Just to give you more information. There're some of these bugs that are both > > in flex and grid, mostly because of they're not RenderBlockFlow. > > > > In some cases, we need some special methods to check that they're not > > RenderBlockFlow but they're not buttons either (as RenderButton, like > > RenderFullScreen) inherit from RenderFlexibleBox. > > > > For example take a look to this method: > > http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderBlock. > > cpp#L2927 > > Thanks for the comment. But I'm not sure if I understand your intention > correctly. Why do we need to check that? As my understanding any element can > be editable with the contenteditable attribute. > https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/Content_Editable > Actually I checked RenderFullScreen is allowed to edit in firefox. > Could you provide me a sample which should not be allowed to edit even > though it has a contenteditable attribute? > I think just adding is<RenderGrid>(*renderer) is enough there? (Of course > more touches are required to make grid work properly for this case.) Sorry for the misleading comment. I was not thinking about editable or not, just about how we usually detect in other parts of the code that a renderer is a flex or a grid. We usually use that kind of methods, as flex and grid don't inherit from RenderBlockFlow. However, sometimes we need that buttons, full-screen and other that inherit from RenderFlexibleBox behave like a RenderBlockFlow and we've this kind of special method. Anyway you can forget about my comment, sorry for the noise. 1068872 6 246469 svillar 2015-02-13 00:58:33 -0800 Comment on attachment 246469 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246469&action=review > Source/WebCore/ChangeLog:8 > + This bug is qutie similar with webkit.org/b/141218. RenderGrid should be also treated as a candidate qutie -> quite similar with -> similar to > Source/WebCore/ChangeLog:11 > + a minimum height of a single line if it is editable as well as RenderFlexibleBox does. Where is this specified? > LayoutTests/fast/events/key-events-in-editable-gridbox.html:7 > + display: grid; No need for the unprefixed version. 1068877 7 246469 svillar 2015-02-13 01:23:46 -0800 Comment on attachment 246469 Patch Setting cq- while we wait for clarifications. 1068913 8 246469 changseok 2015-02-13 07:29:32 -0800 Comment on attachment 246469 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246469&action=review Thanks for the review guys! Let me update the patch soon. =) >> Source/WebCore/ChangeLog:8 >> + This bug is qutie similar with webkit.org/b/141218. RenderGrid should be also treated as a candidate > > qutie -> quite > > similar with -> similar to Oops thanks. >> Source/WebCore/ChangeLog:11 >> + a minimum height of a single line if it is editable as well as RenderFlexibleBox does. > > Where is this specified? http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp#L707 >> LayoutTests/fast/events/key-events-in-editable-gridbox.html:7 >> + display: grid; > > No need for the unprefixed version. O.K Removed. BTW doesn't webkit have a plan to remove the --webkit- prefix in the future? 1068919 9 246525 changseok 2015-02-13 07:44:52 -0800 Created attachment 246525 Patch 1068925 10 246525 commit-queue 2015-02-13 09:15:57 -0800 Comment on attachment 246525 Patch Clearing flags on attachment: 246525 Committed r180050: <http://trac.webkit.org/changeset/180050> 1069435 11 ossy 2015-02-16 08:09:56 -0800 (In reply to comment #10) > Comment on attachment 246525 [details] > Patch > > Clearing flags on attachment: 246525 > > Committed r180050: <http://trac.webkit.org/changeset/180050> It broke the !ENABLE(CSS_GRID_LAYOUT) build - new bug report: bug141647 1129920 12 svillar 2015-10-01 08:20:08 -0700 Closing this as it landed some time ago. 246469 2015-02-12 12:50:33 -0800 2015-02-13 01:23:46 -0800 Patch bug-141465-20150213055030.patch text/plain 6564 changseok U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5OTgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDI1MWRmOTg4MDhkNWRj MDQ4NmEyMmZhOWQ1Mjg4OWNhYWU5NTAxZS4uZjU3M2I2ZmU4YzAwMTY2MjRhYWRmZDIzMzVlNDc0 ZjY2ZjY4MDI1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE1LTAyLTEyICBDaGFu Z1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNvbT4KKworICAgICAgICBEaXYgaGF2 aW5nIGNvbnRlbnRFZGl0YWJsZSBhbmQgZGlzcGxheTpncmlkIGNhbm5vdCBiZSBlZGl0ZWQgaWYg aXQgaXMgZW1wdHkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNDE0NjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGlzIGJ1ZyBpcyBxdXRpZSBzaW1pbGFyIHdpdGggd2Via2l0Lm9yZy9iLzE0MTIxOC4g UmVuZGVyR3JpZCBzaG91bGQgYmUgYWxzbyB0cmVhdGVkIGFzIGEgY2FuZGlkYXRlCisgICAgICAg IGZvciB2aXNpYmxlIHBvc2l0aW9uIGFzIGxpa2UgUmVuZGVyRmxleGlibGVCb3guIFRoZSBvbmx5 IGRpZmZlcmVudCBzaXR1YXRpb24gYmV0d2VlbiB0aGVtIGlzCisgICAgICAgIHRoYXQgUmVuZGVy R3JpZCBoYXMgYSBidWcgc2V0dGluZyAiMHB4IiBmb3IgbG9naWNhbEhlaWdodCB3aGVuIGl0IGlz IGVtcHR5LiBSZW5kZXJHcmlkIHNob3VsZCBhbHNvIGhhdmUKKyAgICAgICAgYSBtaW5pbXVtIGhl aWdodCBvZiBhIHNpbmdsZSBsaW5lIGlmIGl0IGlzIGVkaXRhYmxlIGFzIHdlbGwgYXMgUmVuZGVy RmxleGlibGVCb3ggZG9lcy4KKworICAgICAgICBUZXN0OiBmYXN0L2V2ZW50cy9rZXktZXZlbnRz LWluLWVkaXRhYmxlLWdyaWRib3guaHRtbAorCisgICAgICAgICogZG9tL1Bvc2l0aW9uLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlBvc2l0aW9uOjppc0NhbmRpZGF0ZSk6CisgICAgICAgIChXZWJD b3JlOjpQb3NpdGlvbjo6aXNSZW5kZXJlZENoYXJhY3Rlcik6CisgICAgICAgICogcmVuZGVyaW5n L1JlbmRlckdyaWQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyR3JpZDo6bGF5b3V0R3Jp ZEl0ZW1zKToKKwogMjAxNS0wMi0xMSAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAK ICAgICAgICAgU3RyZWFtbGluZSBhbmQgc2ltcGxpZnkgU1ZHU1ZHRWxlbWVudCBhbmQgcmVsYXRl ZCBjbGFzc2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vUG9zaXRpb24uY3BwIGIv U291cmNlL1dlYkNvcmUvZG9tL1Bvc2l0aW9uLmNwcAppbmRleCA5MzRlMmUzZDI4ZmZmODQ4ZmVl MWI0ZGU1NzY4NDFiNGE4YzMzMzNlLi44NjRmMDMxYzQyNjVhOGRlOWFhN2ExOWJiYTI1NjlhNWJi NDdmZjU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vUG9zaXRpb24uY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2RvbS9Qb3NpdGlvbi5jcHAKQEAgLTM2LDYgKzM2LDcgQEAKICNpbmNs dWRlICJQb3NpdGlvbkl0ZXJhdG9yLmgiCiAjaW5jbHVkZSAiUmVuZGVyQmxvY2suaCIKICNpbmNs dWRlICJSZW5kZXJGbGV4aWJsZUJveC5oIgorI2luY2x1ZGUgIlJlbmRlckdyaWQuaCIKICNpbmNs dWRlICJSZW5kZXJJbmxpbmUuaCIKICNpbmNsdWRlICJSZW5kZXJJdGVyYXRvci5oIgogI2luY2x1 ZGUgIlJlbmRlckxpbmVCcmVhay5oIgpAQCAtOTE1LDExICs5MTYsMTEgQEAgYm9vbCBQb3NpdGlv bjo6aXNDYW5kaWRhdGUoKSBjb25zdAogewogICAgIGlmIChpc051bGwoKSkKICAgICAgICAgcmV0 dXJuIGZhbHNlOwotICAgICAgICAKKwogICAgIFJlbmRlck9iamVjdCogcmVuZGVyZXIgPSBkZXBy ZWNhdGVkTm9kZSgpLT5yZW5kZXJlcigpOwogICAgIGlmICghcmVuZGVyZXIpCiAgICAgICAgIHJl dHVybiBmYWxzZTsKLSAgICAKKwogICAgIGlmIChyZW5kZXJlci0+c3R5bGUoKS52aXNpYmlsaXR5 KCkgIT0gVklTSUJMRSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCkBAIC05MzYsNyArOTM3LDcg QEAgYm9vbCBQb3NpdGlvbjo6aXNDYW5kaWRhdGUoKSBjb25zdAogICAgIGlmIChtX2FuY2hvck5v ZGUtPmhhc1RhZ05hbWUoaHRtbFRhZykpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAotICAgIGlm IChpczxSZW5kZXJCbG9ja0Zsb3c+KCpyZW5kZXJlcikgfHwgaXM8UmVuZGVyRmxleGlibGVCb3g+ KCpyZW5kZXJlcikpIHsKKyAgICBpZiAoaXM8UmVuZGVyQmxvY2tGbG93PigqcmVuZGVyZXIpIHx8 IGlzPFJlbmRlckZsZXhpYmxlQm94PigqcmVuZGVyZXIpIHx8IGlzPFJlbmRlckdyaWQ+KCpyZW5k ZXJlcikpIHsKICAgICAgICAgUmVuZGVyQmxvY2smIGJsb2NrID0gZG93bmNhc3Q8UmVuZGVyQmxv Y2s+KCpyZW5kZXJlcik7CiAgICAgICAgIGlmIChibG9jay5sb2dpY2FsSGVpZ2h0KCkgfHwgbV9h bmNob3JOb2RlLT5oYXNUYWdOYW1lKGJvZHlUYWcpKSB7CiAgICAgICAgICAgICBpZiAoIVBvc2l0 aW9uOjpoYXNSZW5kZXJlZE5vbkFub255bW91c0Rlc2NlbmRhbnRzV2l0aEhlaWdodChibG9jaykp CkBAIC05NTMsMTEgKzk1NCwxMSBAQCBib29sIFBvc2l0aW9uOjppc1JlbmRlcmVkQ2hhcmFjdGVy KCkgY29uc3QKIHsKICAgICBpZiAoIWlzPFRleHQ+KGRlcHJlY2F0ZWROb2RlKCkpKQogICAgICAg ICByZXR1cm4gZmFsc2U7Ci0gICAgICAgIAorCiAgICAgUmVuZGVyVGV4dCogcmVuZGVyZXIgPSBk b3duY2FzdDxUZXh0PigqZGVwcmVjYXRlZE5vZGUoKSkucmVuZGVyZXIoKTsKICAgICBpZiAoIXJl bmRlcmVyKQogICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgCisKICAgICByZXR1cm4gcmVuZGVy ZXItPmNvbnRhaW5zUmVuZGVyZWRDaGFyYWN0ZXJPZmZzZXQobV9vZmZzZXQpOwogfQogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyR3JpZC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyR3JpZC5jcHAKaW5kZXggNWI5M2YzMzYyMDY3MmQzMDZh MmFlMzg5YmFlMjFlZjgxMDE1NzgxOS4uNTlkYzYyOTBiZTY0YjY0ZmEzNjc4MjU3NTAxOTNlODgw ZjYyZjI4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckdyaWQu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJHcmlkLmNwcApAQCAtOTk5 LDYgKzk5OSwxNCBAQCB2b2lkIFJlbmRlckdyaWQ6OmxheW91dEdyaWRJdGVtcygpCiAKICAgICAv LyBtaW4gLyBtYXggbG9naWNhbCBoZWlnaHQgaXMgaGFuZGxlZCBpbiB1cGRhdGVMb2dpY2FsSGVp Z2h0KCkuCiAgICAgc2V0TG9naWNhbEhlaWdodChsb2dpY2FsSGVpZ2h0KCkgKyBib3JkZXJBbmRQ YWRkaW5nTG9naWNhbEhlaWdodCgpKTsKKyAgICBpZiAoaGFzTGluZUlmRW1wdHkoKSkgeworICAg ICAgICBMYXlvdXRVbml0IG1pbkhlaWdodCA9IGJvcmRlckFuZFBhZGRpbmdMb2dpY2FsSGVpZ2h0 KCkKKyAgICAgICAgICAgICsgbGluZUhlaWdodCh0cnVlLCBpc0hvcml6b250YWxXcml0aW5nTW9k ZSgpID8gSG9yaXpvbnRhbExpbmUgOiBWZXJ0aWNhbExpbmUsIFBvc2l0aW9uT2ZJbnRlcmlvckxp bmVCb3hlcykKKyAgICAgICAgICAgICsgc2Nyb2xsYmFyTG9naWNhbEhlaWdodCgpOworICAgICAg ICBpZiAoaGVpZ2h0KCkgPCBtaW5IZWlnaHQpCisgICAgICAgICAgICBzZXRMb2dpY2FsSGVpZ2h0 KG1pbkhlaWdodCk7CisgICAgfQorCiAgICAgY2xlYXJHcmlkKCk7CiB9CiAKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA2MWY3 NzRhOGMzMzJkYzJjNmM3ODA4ZTJjMDIzMmE3MGMxODFlZTQ0Li40OWE2YjgzODU4YWI5MzE5NjEw YjNjYTk1MWZhNmRjY2ZjNzU2Yzc4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK KysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTUtMDItMTIg IENoYW5nU2VvayBPaCAgPGNoYW5nc2Vvay5vaEBjb2xsYWJvcmEuY29tPgorCisgICAgICAgIERp diBoYXZpbmcgY29udGVudEVkaXRhYmxlIGFuZCBkaXNwbGF5OmdyaWQgY2Fubm90IGJlIGVkaXRl ZCBpZiBpdCBpcyBlbXB0eS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE0MTQ2NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoaXMgdGVzdHMgaWYgYW4gZWRpdGFibGUgZ3JpZCBib3ggY2FuIGJlIHJlZWRp dGVkIGFmdGVyIGVyYXNpbmcgYWxsIHRleHRzIGluIGl0LgorCisgICAgICAgICogZmFzdC9ldmVu dHMva2V5LWV2ZW50cy1pbi1lZGl0YWJsZS1ncmlkYm94LWV4cGVjdGVkLnR4dDogQWRkZWQuCisg ICAgICAgICogZmFzdC9ldmVudHMva2V5LWV2ZW50cy1pbi1lZGl0YWJsZS1ncmlkYm94Lmh0bWw6 IEFkZGVkLgorCiAyMDE1LTAyLTExICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5j b20+CiAKICAgICAgICAgQVg6IFVuZGVwcmVjYXRlIGlvcy1zaW11bGF0b3IgYWNjZXNzaWJpbGl0 eSB0ZXN0cwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMva2V5LWV2ZW50cy1p bi1lZGl0YWJsZS1ncmlkYm94LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRz L2tleS1ldmVudHMtaW4tZWRpdGFibGUtZ3JpZGJveC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4u MDViODVjOGNkNjM5MmEzYWU4MDAxZDNhYmZlMjhmMDdmNTM4NjlhNgotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2tleS1ldmVudHMtaW4tZWRpdGFibGUtZ3JpZGJv eC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw3IEBACitQQVNTIHRhcmdldERpdi5pbm5lclRleHQg aXMgIlRFU1QiCitQQVNTIHRhcmdldERpdi5pbm5lclRleHQgaXMgIiIKK1BBU1MgdGFyZ2V0RGl2 LmlubmVyVGV4dCBpcyAiVEVTVCIKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKwor VEVTVCBDT01QTEVURQorVEVTVApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMv a2V5LWV2ZW50cy1pbi1lZGl0YWJsZS1ncmlkYm94Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2V2 ZW50cy9rZXktZXZlbnRzLWluLWVkaXRhYmxlLWdyaWRib3guaHRtbApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4yN2Ri M2E1NjE3YzBkZThlMWU2YzJkNWMzYzBlMDJjN2NjYmY2ZWM2Ci0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9ldmVudHMva2V5LWV2ZW50cy1pbi1lZGl0YWJsZS1ncmlkYm94Lmh0 bWwKQEAgLTAsMCArMSwzOSBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHNj cmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LmpzIj48L3NjcmlwdD4KKzxzdHlsZT4K KyAgICAjdGFyZ2V0IHsKKyAgICAgICAgZGlzcGxheTogZ3JpZDsKKyAgICAgICAgZGlzcGxheTog LXdlYmtpdC1ncmlkOworICAgIH0KKzwvc3R5bGU+Cis8c2NyaXB0PgorICAgIHZhciB0YXJnZXRE aXY7CisgICAgZnVuY3Rpb24gdGVzdCgpCisgICAgeworICAgICAgICB0YXJnZXREaXYgPSBkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgndGFyZ2V0Jyk7CisgICAgICAgIHRhcmdldERpdi5mb2N1cygp OworCisgICAgICAgIC8vIE1vdmUgY3Vyc29yIHRvIHRoZSBlbmQgb2YgbGluZS4KKyAgICAgICAg Z2V0U2VsZWN0aW9uKCkubW9kaWZ5KCdtb3ZlJywgJ2ZvcndhcmQnLCAnbGluZWJvdW5kYXJ5Jyk7 CisKKyAgICAgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQoImluc2VydFRleHQiLCBmYWxzZSwgIkVT VCIpOworICAgICAgICBzaG91bGRCZUVxdWFsVG9TdHJpbmcoInRhcmdldERpdi5pbm5lclRleHQi LCAiVEVTVCIpOworCisgICAgICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJkZWxldGUiKTsKKyAg ICAgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQoImRlbGV0ZSIpOworICAgICAgICBkb2N1bWVudC5l eGVjQ29tbWFuZCgiZGVsZXRlIik7CisgICAgICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJkZWxl dGUiKTsKKyAgICAgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQoImRlbGV0ZSIpOyAvLyBSZW1vdmUg J1xuJworICAgICAgICBzaG91bGRCZUVtcHR5U3RyaW5nKCJ0YXJnZXREaXYuaW5uZXJUZXh0Iik7 CisKKyAgICAgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQoImluc2VydFRleHQiLCBmYWxzZSwgIlRF U1QiKTsKKyAgICAgICAgc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJ0YXJnZXREaXYuaW5uZXJUZXh0 IiwgIlRFU1QiKTsKKyAgICB9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0idGVz dCgpIj4KKzxkaXYgaWQ9InRhcmdldCIgY29udGVudEVkaXRhYmxlPlQ8L2Rpdj4KKzwvYm9keT4K KzwvaHRtbD4K 246525 2015-02-13 07:44:52 -0800 2015-02-13 09:15:57 -0800 Patch bug-141465-20150214004450.patch text/plain 6587 changseok U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwMDM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTU2NTIzZTQxYTY3YmYw ZGI0N2NhMTQzYTA0NzY2ZDMwYmEwNGY0Ni4uNDE0ZTZlZTNlNmIyZDNlMTNkNzI5NWExZDA0MTAw MjE1MGY0MDkxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE1LTAyLTEzICBDaGFu Z1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNvbT4KKworICAgICAgICBEaXYgaGF2 aW5nIGNvbnRlbnRFZGl0YWJsZSBhbmQgZGlzcGxheTpncmlkIGNhbm5vdCBiZSBlZGl0ZWQgaWYg aXQgaXMgZW1wdHkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNDE0NjUKKworICAgICAgICBSZXZpZXdlZCBieSBSeW9zdWtlIE5pd2EuCisKKyAgICAg ICAgVGhpcyBidWcgaXMgcXVpdGUgc2ltaWxhciB0byB3ZWJraXQub3JnL2IvMTQxMjE4LiBSZW5k ZXJHcmlkIHNob3VsZCBiZSBhbHNvIHRyZWF0ZWQgYXMgYSBjYW5kaWRhdGUKKyAgICAgICAgZm9y IHZpc2libGUgcG9zaXRpb24gYXMgbGlrZSBSZW5kZXJGbGV4aWJsZUJveC4gVGhlIG9ubHkgZGlm ZmVyZW50IHNpdHVhdGlvbiBiZXR3ZWVuIHRoZW0gaXMKKyAgICAgICAgdGhhdCBSZW5kZXJHcmlk IGhhcyBhIGJ1ZyBzZXR0aW5nICIwcHgiIGZvciBsb2dpY2FsSGVpZ2h0IHdoZW4gaXQgaXMgZW1w dHkuIFJlbmRlckdyaWQgc2hvdWxkIGFsc28gaGF2ZQorICAgICAgICBhIG1pbmltdW0gaGVpZ2h0 IG9mIGEgc2luZ2xlIGxpbmUgaWYgaXQgaXMgZWRpdGFibGUgYXMgd2VsbCBhcyBSZW5kZXJGbGV4 aWJsZUJveCBkb2VzLgorCisgICAgICAgIFRlc3Q6IGZhc3QvZXZlbnRzL2tleS1ldmVudHMtaW4t ZWRpdGFibGUtZ3JpZGJveC5odG1sCisKKyAgICAgICAgKiBkb20vUG9zaXRpb24uY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UG9zaXRpb246OmlzQ2FuZGlkYXRlKToKKyAgICAgICAgKFdlYkNvcmU6 OlBvc2l0aW9uOjppc1JlbmRlcmVkQ2hhcmFjdGVyKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVu ZGVyR3JpZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJHcmlkOjpsYXlvdXRHcmlkSXRl bXMpOgorCiAyMDE1LTAyLTEyICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAg ICAgICAgUkVHUkVTU0lPTiAocjE3NjI2Mik6IEludmFsaWQgY2FzdCBpbiBXZWJDb3JlYFdlYkNv cmU6OlJvb3RJbmxpbmVCb3g6OnNlbGVjdGlvblRvcApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvZG9tL1Bvc2l0aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Qb3NpdGlvbi5jcHAKaW5k ZXggOTM0ZTJlM2QyOGZmZjg0OGZlZTFiNGRlNTc2ODQxYjRhOGMzMzMzZS4uODY0ZjAzMWM0MjY1 YThkZTlhYTdhMTliYmEyNTY5YTViYjQ3ZmY1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv ZG9tL1Bvc2l0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vUG9zaXRpb24uY3BwCkBA IC0zNiw2ICszNiw3IEBACiAjaW5jbHVkZSAiUG9zaXRpb25JdGVyYXRvci5oIgogI2luY2x1ZGUg IlJlbmRlckJsb2NrLmgiCiAjaW5jbHVkZSAiUmVuZGVyRmxleGlibGVCb3guaCIKKyNpbmNsdWRl ICJSZW5kZXJHcmlkLmgiCiAjaW5jbHVkZSAiUmVuZGVySW5saW5lLmgiCiAjaW5jbHVkZSAiUmVu ZGVySXRlcmF0b3IuaCIKICNpbmNsdWRlICJSZW5kZXJMaW5lQnJlYWsuaCIKQEAgLTkxNSwxMSAr OTE2LDExIEBAIGJvb2wgUG9zaXRpb246OmlzQ2FuZGlkYXRlKCkgY29uc3QKIHsKICAgICBpZiAo aXNOdWxsKCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICAgICAgCisKICAgICBSZW5kZXJP YmplY3QqIHJlbmRlcmVyID0gZGVwcmVjYXRlZE5vZGUoKS0+cmVuZGVyZXIoKTsKICAgICBpZiAo IXJlbmRlcmVyKQogICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgCisKICAgICBpZiAocmVuZGVy ZXItPnN0eWxlKCkudmlzaWJpbGl0eSgpICE9IFZJU0lCTEUpCiAgICAgICAgIHJldHVybiBmYWxz ZTsKIApAQCAtOTM2LDcgKzkzNyw3IEBAIGJvb2wgUG9zaXRpb246OmlzQ2FuZGlkYXRlKCkgY29u c3QKICAgICBpZiAobV9hbmNob3JOb2RlLT5oYXNUYWdOYW1lKGh0bWxUYWcpKQogICAgICAgICBy ZXR1cm4gZmFsc2U7CiAKLSAgICBpZiAoaXM8UmVuZGVyQmxvY2tGbG93PigqcmVuZGVyZXIpIHx8 IGlzPFJlbmRlckZsZXhpYmxlQm94PigqcmVuZGVyZXIpKSB7CisgICAgaWYgKGlzPFJlbmRlckJs b2NrRmxvdz4oKnJlbmRlcmVyKSB8fCBpczxSZW5kZXJGbGV4aWJsZUJveD4oKnJlbmRlcmVyKSB8 fCBpczxSZW5kZXJHcmlkPigqcmVuZGVyZXIpKSB7CiAgICAgICAgIFJlbmRlckJsb2NrJiBibG9j ayA9IGRvd25jYXN0PFJlbmRlckJsb2NrPigqcmVuZGVyZXIpOwogICAgICAgICBpZiAoYmxvY2su bG9naWNhbEhlaWdodCgpIHx8IG1fYW5jaG9yTm9kZS0+aGFzVGFnTmFtZShib2R5VGFnKSkgewog ICAgICAgICAgICAgaWYgKCFQb3NpdGlvbjo6aGFzUmVuZGVyZWROb25Bbm9ueW1vdXNEZXNjZW5k YW50c1dpdGhIZWlnaHQoYmxvY2spKQpAQCAtOTUzLDExICs5NTQsMTEgQEAgYm9vbCBQb3NpdGlv bjo6aXNSZW5kZXJlZENoYXJhY3RlcigpIGNvbnN0CiB7CiAgICAgaWYgKCFpczxUZXh0PihkZXBy ZWNhdGVkTm9kZSgpKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgICAgICAKKwogICAgIFJl bmRlclRleHQqIHJlbmRlcmVyID0gZG93bmNhc3Q8VGV4dD4oKmRlcHJlY2F0ZWROb2RlKCkpLnJl bmRlcmVyKCk7CiAgICAgaWYgKCFyZW5kZXJlcikKICAgICAgICAgcmV0dXJuIGZhbHNlOwotICAg IAorCiAgICAgcmV0dXJuIHJlbmRlcmVyLT5jb250YWluc1JlbmRlcmVkQ2hhcmFjdGVyT2Zmc2V0 KG1fb2Zmc2V0KTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckdyaWQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckdyaWQuY3BwCmlu ZGV4IDViOTNmMzM2MjA2NzJkMzA2YTJhZTM4OWJhZTIxZWY4MTAxNTc4MTkuLjU5ZGM2MjkwYmU2 NGI2NGZhMzY3ODI1NzUwMTkzZTg4MGY2MmYyOGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJHcmlkLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyR3JpZC5jcHAKQEAgLTk5OSw2ICs5OTksMTQgQEAgdm9pZCBSZW5kZXJHcmlkOjpsYXlv dXRHcmlkSXRlbXMoKQogCiAgICAgLy8gbWluIC8gbWF4IGxvZ2ljYWwgaGVpZ2h0IGlzIGhhbmRs ZWQgaW4gdXBkYXRlTG9naWNhbEhlaWdodCgpLgogICAgIHNldExvZ2ljYWxIZWlnaHQobG9naWNh bEhlaWdodCgpICsgYm9yZGVyQW5kUGFkZGluZ0xvZ2ljYWxIZWlnaHQoKSk7CisgICAgaWYgKGhh c0xpbmVJZkVtcHR5KCkpIHsKKyAgICAgICAgTGF5b3V0VW5pdCBtaW5IZWlnaHQgPSBib3JkZXJB bmRQYWRkaW5nTG9naWNhbEhlaWdodCgpCisgICAgICAgICAgICArIGxpbmVIZWlnaHQodHJ1ZSwg aXNIb3Jpem9udGFsV3JpdGluZ01vZGUoKSA/IEhvcml6b250YWxMaW5lIDogVmVydGljYWxMaW5l LCBQb3NpdGlvbk9mSW50ZXJpb3JMaW5lQm94ZXMpCisgICAgICAgICAgICArIHNjcm9sbGJhckxv Z2ljYWxIZWlnaHQoKTsKKyAgICAgICAgaWYgKGhlaWdodCgpIDwgbWluSGVpZ2h0KQorICAgICAg ICAgICAgc2V0TG9naWNhbEhlaWdodChtaW5IZWlnaHQpOworICAgIH0KKwogICAgIGNsZWFyR3Jp ZCgpOwogfQogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKaW5kZXggNGU5MTkzMzljNGNhZjI5OGRlNWM3YTc1MjZlYjdmZDNmYTBhMzEw MS4uMjg4YzgwN2M5ZGM2NWUyYWNlNGQ5YzU2MDUzMGY5ZGE0MzE0ZTViYSAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE1IEBACisyMDE1LTAyLTEzICBDaGFuZ1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFi b3JhLmNvbT4KKworICAgICAgICBEaXYgaGF2aW5nIGNvbnRlbnRFZGl0YWJsZSBhbmQgZGlzcGxh eTpncmlkIGNhbm5vdCBiZSBlZGl0ZWQgaWYgaXQgaXMgZW1wdHkuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDE0NjUKKworICAgICAgICBSZXZpZXdl ZCBieSBSeW9zdWtlIE5pd2EuCisKKyAgICAgICAgVGhpcyB0ZXN0cyBpZiBhbiBlZGl0YWJsZSBn cmlkIGJveCBjYW4gYmUgcmVlZGl0ZWQgYWZ0ZXIgZXJhc2luZyBhbGwgdGV4dHMgaW4gaXQuCisK KyAgICAgICAgKiBmYXN0L2V2ZW50cy9rZXktZXZlbnRzLWluLWVkaXRhYmxlLWdyaWRib3gtZXhw ZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2V2ZW50cy9rZXktZXZlbnRzLWluLWVk aXRhYmxlLWdyaWRib3guaHRtbDogQWRkZWQuCisKIDIwMTUtMDItMTIgIFphbGFuIEJ1anRhcyAg PHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMTc2MjYyKTogSW52YWxp ZCBjYXN0IGluIFdlYkNvcmVgV2ViQ29yZTo6Um9vdElubGluZUJveDo6c2VsZWN0aW9uVG9wCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9rZXktZXZlbnRzLWluLWVkaXRhYmxl LWdyaWRib3gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMva2V5LWV2ZW50 cy1pbi1lZGl0YWJsZS1ncmlkYm94LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4wNWI4NWM4Y2Q2 MzkyYTNhZTgwMDFkM2FiZmUyOGYwN2Y1Mzg2OWE2Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvZmFzdC9ldmVudHMva2V5LWV2ZW50cy1pbi1lZGl0YWJsZS1ncmlkYm94LWV4cGVjdGVk LnR4dApAQCAtMCwwICsxLDcgQEAKK1BBU1MgdGFyZ2V0RGl2LmlubmVyVGV4dCBpcyAiVEVTVCIK K1BBU1MgdGFyZ2V0RGl2LmlubmVyVGV4dCBpcyAiIgorUEFTUyB0YXJnZXREaXYuaW5uZXJUZXh0 IGlzICJURVNUIgorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBM RVRFCitURVNUCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9rZXktZXZlbnRz LWluLWVkaXRhYmxlLWdyaWRib3guaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2tleS1l dmVudHMtaW4tZWRpdGFibGUtZ3JpZGJveC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmJhN2I4ZGJjODJiMzFh N2NmZjJkNjk1NTQxYTc1ZmRmMGU0MGUyNjcKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2V2ZW50cy9rZXktZXZlbnRzLWluLWVkaXRhYmxlLWdyaWRib3guaHRtbApAQCAtMCww ICsxLDM4IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0i Li4vLi4vcmVzb3VyY2VzL2pzLXRlc3QuanMiPjwvc2NyaXB0PgorPHN0eWxlPgorICAgICN0YXJn ZXQgeworICAgICAgICBkaXNwbGF5OiAtd2Via2l0LWdyaWQ7CisgICAgfQorPC9zdHlsZT4KKzxz Y3JpcHQ+CisgICAgdmFyIHRhcmdldERpdjsKKyAgICBmdW5jdGlvbiB0ZXN0KCkKKyAgICB7Cisg ICAgICAgIHRhcmdldERpdiA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd0YXJnZXQnKTsKKyAg ICAgICAgdGFyZ2V0RGl2LmZvY3VzKCk7CisKKyAgICAgICAgLy8gTW92ZSBjdXJzb3IgdG8gdGhl IGVuZCBvZiBsaW5lLgorICAgICAgICBnZXRTZWxlY3Rpb24oKS5tb2RpZnkoJ21vdmUnLCAnZm9y d2FyZCcsICdsaW5lYm91bmRhcnknKTsKKworICAgICAgICBkb2N1bWVudC5leGVjQ29tbWFuZCgi aW5zZXJ0VGV4dCIsIGZhbHNlLCAiRVNUIik7CisgICAgICAgIHNob3VsZEJlRXF1YWxUb1N0cmlu ZygidGFyZ2V0RGl2LmlubmVyVGV4dCIsICJURVNUIik7CisKKyAgICAgICAgZG9jdW1lbnQuZXhl Y0NvbW1hbmQoImRlbGV0ZSIpOworICAgICAgICBkb2N1bWVudC5leGVjQ29tbWFuZCgiZGVsZXRl Iik7CisgICAgICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJkZWxldGUiKTsKKyAgICAgICAgZG9j dW1lbnQuZXhlY0NvbW1hbmQoImRlbGV0ZSIpOworICAgICAgICBkb2N1bWVudC5leGVjQ29tbWFu ZCgiZGVsZXRlIik7IC8vIFJlbW92ZSAnXG4nCisgICAgICAgIHNob3VsZEJlRW1wdHlTdHJpbmco InRhcmdldERpdi5pbm5lclRleHQiKTsKKworICAgICAgICBkb2N1bWVudC5leGVjQ29tbWFuZCgi aW5zZXJ0VGV4dCIsIGZhbHNlLCAiVEVTVCIpOworICAgICAgICBzaG91bGRCZUVxdWFsVG9TdHJp bmcoInRhcmdldERpdi5pbm5lclRleHQiLCAiVEVTVCIpOworICAgIH0KKzwvc2NyaXB0PgorPC9o ZWFkPgorPGJvZHkgb25sb2FkPSJ0ZXN0KCkiPgorPGRpdiBpZD0idGFyZ2V0IiBjb250ZW50RWRp dGFibGU+VDwvZGl2PgorPC9ib2R5PgorPC9odG1sPgo=