141461 2015-02-10 21:29:32 -0800 fix windows debug build 2015-02-10 21:57:53 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen bfulgham commit-queue darin esprehn+autocc kangil.han oldest_to_newest 1068256 0 achristensen 2015-02-10 21:29:32 -0800 Fixing Visual Studio crashes will never cease to be an adventure. https://bugs.webkit.org/show_bug.cgi?id=141374 caused debug builds on Windows to fail because iterating descendantsOfType was too complicated for Visual Studio. Explicitly calling the iterator constructor fixes this problem. 1068257 1 246373 achristensen 2015-02-10 21:34:47 -0800 Created attachment 246373 Patch 1068259 2 246373 commit-queue 2015-02-10 21:51:43 -0800 Comment on attachment 246373 Patch Rejecting attachment 246373 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 246373, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: e: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/dom/TypedElementDescendantIterator.h Hunk #1 FAILED at 263. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/dom/TypedElementDescendantIterator.h.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Benjamin Poulain']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/6357838435713024 1068261 3 achristensen 2015-02-10 21:57:39 -0800 http://trac.webkit.org/changeset/179916 246373 2015-02-10 21:34:47 -0800 2015-02-10 21:51:43 -0800 Patch bug-141461-20150210213448.patch text/plain 1568 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3OTkxNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE1LTAyLTEwICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1dpbl0gRml4 IGRlYnVnIGJ1aWxkIGFmdGVyIHIxNzk4MDcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNDE0NjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIGRvbS9UeXBlZEVsZW1lbnREZXNjZW5kYW50SXRlcmF0b3Iu aDoKKyAgICAgICAgRXhwbGljaXRseSBjYWxsIEl0ZXJhdG9yIGNvbnN0cnVjdG9yIHRvIHJlZHVj ZSBjb21wbGV4aXR5IHdoZW4gaXRlcmF0aW5nIGRlc2NlbmRhbnRzT2ZUeXBlLgorCiAyMDE1LTAy LTEwICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgW1dLMl0gQWRk IGxvZ2dpbmcgdG8gdmFsaWRhdGUgdGhlIG5ldHdvcmsgY2FjaGUgZWZmaWNhY3kgKFBhcnQgMikK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9UeXBlZEVsZW1lbnREZXNjZW5kYW50SXRlcmF0b3Iu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vVHlwZWRFbGVtZW50RGVzY2VuZGFu dEl0ZXJhdG9yLmgJKHJldmlzaW9uIDE3OTkxNSkKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9UeXBl ZEVsZW1lbnREZXNjZW5kYW50SXRlcmF0b3IuaAkod29ya2luZyBjb3B5KQpAQCAtMjYzLDEyICsy NjMsMTIgQEAgdGVtcGxhdGU8dHlwZW5hbWUgRWxlbWVudFR5cGU+IGlubGluZSBEbwogCiB0ZW1w bGF0ZTx0eXBlbmFtZSBFbGVtZW50VHlwZT4gaW5saW5lIGF1dG8gRG91YmxlVHlwZWRFbGVtZW50 RGVzY2VuZGFudEl0ZXJhdG9yQWRhcHRlcjxFbGVtZW50VHlwZT46OmJlZ2luKCkgLT4gSXRlcmF0 b3IKIHsKLSAgICByZXR1cm4geyBtX3BhaXIuZmlyc3QuYmVnaW4oKSwgbV9wYWlyLnNlY29uZC5i ZWdpbigpIH07CisgICAgcmV0dXJuIEl0ZXJhdG9yKG1fcGFpci5maXJzdC5iZWdpbigpLCBtX3Bh aXIuc2Vjb25kLmJlZ2luKCkpOwogfQogCiB0ZW1wbGF0ZTx0eXBlbmFtZSBFbGVtZW50VHlwZT4g aW5saW5lIGF1dG8gRG91YmxlVHlwZWRFbGVtZW50RGVzY2VuZGFudEl0ZXJhdG9yQWRhcHRlcjxF bGVtZW50VHlwZT46OmVuZCgpIC0+IEl0ZXJhdG9yCiB7Ci0gICAgcmV0dXJuIHsgbV9wYWlyLmZp cnN0LmVuZCgpLCBtX3BhaXIuc2Vjb25kLmVuZCgpIH07CisgICAgcmV0dXJuIEl0ZXJhdG9yKG1f cGFpci5maXJzdC5lbmQoKSwgbV9wYWlyLnNlY29uZC5lbmQoKSk7CiB9CiAKIC8vIERvdWJsZVR5 cGVkRWxlbWVudERlc2NlbmRhbnRJdGVyYXRvcgo=