<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>141460</bug_id>
          
          <creation_ts>2015-02-10 20:39:30 -0800</creation_ts>
          <short_desc>Optimize MutableStyleProperties::removePropertiesInSet()</short_desc>
          <delta_ts>2015-02-10 22:02:49 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>141321</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">cdumez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>benjamin</cc>
    
    <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>kling</cc>
    
    <cc>koivisto</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1068246</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2015-02-10 20:39:30 -0800</bug_when>
    <thetext>Optimize MutableStyleProperties::removePropertiesInSet() by doing an in-place removal of the vector properties, using the new and efficient Vector::removalAllMatching().</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1068247</commentid>
    <comment_count>1</comment_count>
      <attachid>246370</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2015-02-10 20:44:15 -0800</bug_when>
    <thetext>Created attachment 246370
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1068254</commentid>
    <comment_count>2</comment_count>
      <attachid>246370</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2015-02-10 21:17:52 -0800</bug_when>
    <thetext>Comment on attachment 246370
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1068263</commentid>
    <comment_count>3</comment_count>
      <attachid>246370</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-02-10 22:02:43 -0800</bug_when>
    <thetext>Comment on attachment 246370
Patch

Clearing flags on attachment: 246370

Committed r179917: &lt;http://trac.webkit.org/changeset/179917&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1068264</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-02-10 22:02:49 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>246370</attachid>
            <date>2015-02-10 20:44:15 -0800</date>
            <delta_ts>2015-02-10 22:02:43 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-141460-20150210204418.patch</filename>
            <type>text/plain</type>
            <size>2662</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5OTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzEwNzZlNmIyMGVlNThl
YTQzNTQzOWMyY2M4MDRiMmNhNDZiOWUzOC4uYzk4MjBkNGYwNGRlZTNhZDI1ODI3MDhkNTMzYmFi
MTc2M2U0YThjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI3IEBACiAyMDE1LTAyLTEwICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgT3B0aW1pemUgTXV0YWJsZVN0
eWxlUHJvcGVydGllczo6cmVtb3ZlUHJvcGVydGllc0luU2V0KCkKKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MTQ2MAorCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9wdGltaXplIE11dGFibGVTdHlsZVByb3Bl
cnRpZXM6OnJlbW92ZVByb3BlcnRpZXNJblNldCgpIGJ5IGRvaW5nIGFuCisgICAgICAgIGluLXBs
YWNlIHJlbW92YWwgb2YgdGhlIHZlY3RvciBwcm9wZXJ0aWVzLCB1c2luZyB0aGUgbmV3IGFuZCBl
ZmZpY2llbnQKKyAgICAgICAgVmVjdG9yOjpyZW1vdmFsQWxsTWF0Y2hpbmcoKS4KKworICAgICAg
ICBJIHNlZSBhIH4xMSUgc3BlZWQtdXAgb24gQ1NTL0NTU1Byb3BlcnR5U2V0dGVyR2V0dGVyLmh0
bWwgcGVyZm9ybWFuY2UKKyAgICAgICAgdGVzdC4KKworICAgICAgICBUaGlzIGNoYW5nZSB3YXMg
aW5zcGlyZWQgYnkgdGhlIGZvbGxvd2luZyBCbGluayByZXZpc2lvbjoKKyAgICAgICAgaHR0cHM6
Ly9zcmMuY2hyb21pdW0ub3JnL3ZpZXd2Yy9ibGluaz92aWV3PXJldiZyZXZpc2lvbj0xODkzODcK
KworICAgICAgICBUZXN0OiBQZXJmb3JtYW5jZVRlc3RzL0NTUy9DU1NQcm9wZXJ0eVNldHRlckdl
dHRlci5odG1sCisKKyAgICAgICAgKiBjc3MvU3R5bGVQcm9wZXJ0aWVzLmNwcDoKKyAgICAgICAg
KFdlYkNvcmU6Ok11dGFibGVTdHlsZVByb3BlcnRpZXM6OnJlbW92ZVByb3BlcnRpZXNJblNldCk6
CisKKzIwMTUtMDItMTAgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKwogICAgICAg
ICBbV0syXSBBZGQgbG9nZ2luZyB0byB2YWxpZGF0ZSB0aGUgbmV0d29yayBjYWNoZSBlZmZpY2Fj
eSAoUGFydCAyKQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9MTQxMzQ1CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVByb3BlcnRp
ZXMuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUHJvcGVydGllcy5jcHAKaW5kZXggNWUy
OWQ3YjVjM2M1ZTZhMTc1NmQzYzIzZWE1ZjE0MzRkYTc0MzRlMy4uNjYxZDNmNTkyOGMzZTg4ZWU3
ZGNlMWMzYTg2N2Y4ZjEzNWFjNDk4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL1N0
eWxlUHJvcGVydGllcy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUHJvcGVydGll
cy5jcHAKQEAgLTExMzMsMjMgKzExMzMsMTAgQEAgYm9vbCBNdXRhYmxlU3R5bGVQcm9wZXJ0aWVz
OjpyZW1vdmVQcm9wZXJ0aWVzSW5TZXQoY29uc3QgQ1NTUHJvcGVydHlJRCogc2V0LCB1bnMKICAg
ICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgbGVuZ3RoOyArK2kpCiAgICAgICAgIHRvUmVtb3Zl
LmFkZChzZXRbaV0pOwogCi0gICAgVmVjdG9yPENTU1Byb3BlcnR5PiBuZXdQcm9wZXJ0aWVzOwot
ICAgIG5ld1Byb3BlcnRpZXMucmVzZXJ2ZUluaXRpYWxDYXBhY2l0eShtX3Byb3BlcnR5VmVjdG9y
LnNpemUoKSk7Ci0KLSAgICB1bnNpZ25lZCBzaXplID0gbV9wcm9wZXJ0eVZlY3Rvci5zaXplKCk7
Ci0gICAgZm9yICh1bnNpZ25lZCBuID0gMDsgbiA8IHNpemU7ICsrbikgewotICAgICAgICBjb25z
dCBDU1NQcm9wZXJ0eSYgcHJvcGVydHkgPSBtX3Byb3BlcnR5VmVjdG9yLmF0KG4pOworICAgIHJl
dHVybiBtX3Byb3BlcnR5VmVjdG9yLnJlbW92ZUFsbE1hdGNoaW5nKFsmdG9SZW1vdmVdIChjb25z
dCBDU1NQcm9wZXJ0eSYgcHJvcGVydHkpIHsKICAgICAgICAgLy8gTm90IHF1aXRlIHN1cmUgaWYg
dGhlIGlzSW1wb3J0YW50IHRlc3QgaXMgbmVlZGVkIGJ1dCBpdCBtYXRjaGVzIHRoZSBleGlzdGlu
ZyBiZWhhdmlvci4KLSAgICAgICAgaWYgKCFwcm9wZXJ0eS5pc0ltcG9ydGFudCgpKSB7Ci0gICAg
ICAgICAgICBpZiAodG9SZW1vdmUuY29udGFpbnMocHJvcGVydHkuaWQoKSkpCi0gICAgICAgICAg
ICAgICAgY29udGludWU7Ci0gICAgICAgIH0KLSAgICAgICAgbmV3UHJvcGVydGllcy5hcHBlbmQo
cHJvcGVydHkpOwotICAgIH0KLQotICAgIGJvb2wgY2hhbmdlZCA9IG5ld1Byb3BlcnRpZXMuc2l6
ZSgpICE9IG1fcHJvcGVydHlWZWN0b3Iuc2l6ZSgpOwotICAgIG1fcHJvcGVydHlWZWN0b3IgPSBu
ZXdQcm9wZXJ0aWVzOwotICAgIHJldHVybiBjaGFuZ2VkOworICAgICAgICByZXR1cm4gIXByb3Bl
cnR5LmlzSW1wb3J0YW50KCkgJiYgdG9SZW1vdmUuY29udGFpbnMocHJvcGVydHkuaWQoKSk7Cisg
ICAgfSkgPiAwOwogfQogCiBpbnQgSW1tdXRhYmxlU3R5bGVQcm9wZXJ0aWVzOjpmaW5kUHJvcGVy
dHlJbmRleChDU1NQcm9wZXJ0eUlEIHByb3BlcnR5SUQpIGNvbnN0Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>