141447 2015-02-10 15:15:28 -0800 Add another assertion to help track down crash in DocumentLoader::stopLoadingForPolicyChange() 2015-02-10 15:59:10 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez ap commit-queue japhet oldest_to_newest 1068161 0 cdumez 2015-02-10 15:15:28 -0800 Add another assertion to help track down crash in DocumentLoader::stopLoadingForPolicyChange(). The trace seems to hint that frameLoader() returns null when stopLoadingForPolicyChange() is called. frameLoader() can only return null after DocumentLoader::detachFromFrame() has been called. Also, stopLoadingForPolicyChange() here is called from the DocumentLoader::continueAfterContentPolicy() policy callback which requires m_waitingForContentPolicy to be true. Therefore, we should assert that m_waitingForContentPolicy is false when m_frame is cleared in DocumentLoader::detachFromFrame(). Radar: <rdar://problem/13811738> 1068163 1 246347 cdumez 2015-02-10 15:19:26 -0800 Created attachment 246347 Patch 1068170 2 cdumez 2015-02-10 15:59:10 -0800 Committed r179895: <http://trac.webkit.org/changeset/179895> 246347 2015-02-10 15:19:26 -0800 2015-02-10 15:56:24 -0800 Patch bug-141447-20150210151928.patch text/plain 2476 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5ODgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzU1ZGI4MTVmNzIyMmYx MzYxOWQyZWEyN2I1NDUwZDNjZWI2YzY5ZC4uYjNkMjkwMTY4MTk2ODg0OTcyNzgyOWUxMDIzYTBj OWU3ZDNjNmUzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI3IEBACiAyMDE1LTAyLTEwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgQWRkIGFub3RoZXIgYXNzZXJ0 aW9uIHRvIGhlbHAgdHJhY2sgZG93biBjcmFzaCBpbiBEb2N1bWVudExvYWRlcjo6c3RvcExvYWRp bmdGb3JQb2xpY3lDaGFuZ2UoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQxNDQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkIGFub3RoZXIgYXNzZXJ0aW9uIHRvIGhlbHAgdHJhY2sgZG93biBjcmFz aCBpbgorICAgICAgICBEb2N1bWVudExvYWRlcjo6c3RvcExvYWRpbmdGb3JQb2xpY3lDaGFuZ2Uo KS4KKworICAgICAgICBUaGUgdHJhY2Ugc2VlbXMgdG8gaGludCB0aGF0IGZyYW1lTG9hZGVyKCkg cmV0dXJucyBudWxsIHdoZW4KKyAgICAgICAgc3RvcExvYWRpbmdGb3JQb2xpY3lDaGFuZ2UoKSBp cyBjYWxsZWQuIGZyYW1lTG9hZGVyKCkgY2FuIG9ubHkgcmV0dXJuCisgICAgICAgIG51bGwgYWZ0 ZXIgRG9jdW1lbnRMb2FkZXI6OmRldGFjaEZyb21GcmFtZSgpIGhhcyBiZWVuIGNhbGxlZC4KKyAg ICAgICAgQWxzbywgc3RvcExvYWRpbmdGb3JQb2xpY3lDaGFuZ2UoKSBoZXJlIGlzIGNhbGxlZCBm cm9tIHRoZQorICAgICAgICBEb2N1bWVudExvYWRlcjo6Y29udGludWVBZnRlckNvbnRlbnRQb2xp Y3koKSBwb2xpY3kgY2FsbGJhY2sgd2hpY2gKKyAgICAgICAgcmVxdWlyZXMgbV93YWl0aW5nRm9y Q29udGVudFBvbGljeSB0byBiZSB0cnVlLiBUaGVyZWZvcmUsIHdlIHNob3VsZAorICAgICAgICBh c3NlcnQgdGhhdCBtX3dhaXRpbmdGb3JDb250ZW50UG9saWN5IGlzIGZhbHNlIHdoZW4gbV9mcmFt ZSBpcyBjbGVhcmVkCisgICAgICAgIGluIERvY3VtZW50TG9hZGVyOjpkZXRhY2hGcm9tRnJhbWUo KS4KKworICAgICAgICAqIGxvYWRlci9Eb2N1bWVudExvYWRlci5jcHA6CisgICAgICAgIChXZWJD b3JlOjpEb2N1bWVudExvYWRlcjo6ZGV0YWNoRnJvbUZyYW1lKToKKworMjAxNS0wMi0xMCAgQ2hy aXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCiAgICAgICAgIEFkZCBhc3NlcnRpb24gdG8g aGVscCB0cmFjayBkb3duIFdlYkNvcmU6OkRvY3VtZW50TG9hZGVyOjpzdG9wTG9hZGluZ0ZvclBv bGljeUNoYW5nZSgpIGNyYXNoCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNDE0NDEKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEzODExNzM4PgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAKaW5kZXggMGIwOTY4YzM1ZDQ5Yjg0 MjdkOWUyYmEwMWFiYmM1ZTg0NDFmNGFlNi4uYjhhM2VhNWFlNTI0MjcyNGJmYjE3NDMyOGU4OGU3 MDhiNzg5Mzg1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9h ZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwCkBA IC05NDgsOSArOTQ4LDExIEBAIHZvaWQgRG9jdW1lbnRMb2FkZXI6OmRldGFjaEZyb21GcmFtZSgp CiAgICAgaWYgKG1fbWFpblJlc291cmNlICYmIG1fbWFpblJlc291cmNlLT5oYXNDbGllbnQodGhp cykpCiAgICAgICAgIG1fbWFpblJlc291cmNlLT5yZW1vdmVDbGllbnQodGhpcyk7CiAKLSAgICBt X2FwcGxpY2F0aW9uQ2FjaGVIb3N0LT5zZXRET01BcHBsaWNhdGlvbkNhY2hlKDApOworICAgIG1f YXBwbGljYXRpb25DYWNoZUhvc3QtPnNldERPTUFwcGxpY2F0aW9uQ2FjaGUobnVsbHB0cik7CiAg ICAgSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uOjpsb2FkZXJEZXRhY2hlZEZyb21GcmFtZSgqbV9m cmFtZSwgKnRoaXMpOwotICAgIG1fZnJhbWUgPSAwOworICAgIG1fZnJhbWUgPSBudWxscHRyOwor ICAgIC8vIFRoZSBjYWxsIHRvIHN0b3BMb2FkaW5nKCkgYWJvdmUgc2hvdWxkIGhhdmUgY2FuY2Vs ZWQgYW55IHBlbmRpbmcgY29udGVudCBwb2xpY3kgY2hlY2suCisgICAgQVNTRVJUX1dJVEhfTUVT U0FHRSghbV93YWl0aW5nRm9yQ29udGVudFBvbGljeSwgIlRoZSBjb250ZW50IHBvbGljeSBjYWxs YmFjayBuZWVkcyBhIHZhbGlkIGZyYW1lLiIpOwogfQogCiB2b2lkIERvY3VtZW50TG9hZGVyOjpj bGVhck1haW5SZXNvdXJjZUxvYWRlcigpCg==