141441 2015-02-10 12:59:32 -0800 Add assertion to help track down WebCore::DocumentLoader::stopLoadingForPolicyChange() crash 2015-02-10 13:44:02 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez ap commit-queue japhet oldest_to_newest 1068117 0 cdumez 2015-02-10 12:59:32 -0800 Add assertions to help track down WebCore::DocumentLoader::stopLoadingForPolicyChange() crash. Radar: <rdar://problem/13811738> 1068121 1 246338 cdumez 2015-02-10 13:04:54 -0800 Created attachment 246338 Patch 1068133 2 246338 ap 2015-02-10 13:40:46 -0800 Comment on attachment 246338 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246338&action=review > Source/WebCore/ChangeLog:24 > + (WebCore::DocumentLoader::interruptedForPolicyChangeError): > + Make sure frameLoader() is not null before using it. How does this help? If it's null, we crash right away anyway. 1068138 3 cdumez 2015-02-10 13:44:02 -0800 Committed r179880: <http://trac.webkit.org/changeset/179880> 246338 2015-02-10 13:04:54 -0800 2015-02-10 13:40:46 -0800 Patch bug-141441-20150210130457.patch text/plain 2467 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5ODcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWEyODkwMzI1OGIwOTc0 ODc4N2ZiZTNiNDcxNmJhNTFjZTk1OTRkZi4uMTM4MDkyMWE1Mjk3MWQ0NmNhMzg3YjM1YzdjMzU1 ZDJjNzg1YmEyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE1LTAyLTEwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGFzc2VydGlvbnMgdG8g aGVscCB0cmFjayBkb3duIFdlYkNvcmU6OkRvY3VtZW50TG9hZGVyOjpzdG9wTG9hZGluZ0ZvclBv bGljeUNoYW5nZSgpIGNyYXNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNDE0NDEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEzODExNzM4PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhc3NlcnRp b25zIHRvIGhlbHAgdHJhY2sgZG93biBhIGNyYXNoIGluCisgICAgICAgIFdlYkNvcmU6OkRvY3Vt ZW50TG9hZGVyOjpzdG9wTG9hZGluZ0ZvclBvbGljeUNoYW5nZSgpLgorCisgICAgICAgICogbG9h ZGVyL0RvY3VtZW50TG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50TG9hZGVy Ojp+RG9jdW1lbnRMb2FkZXIpOgorICAgICAgICBNYWtlIHN1cmUgdGhlIERvY3VtZW50TG9hZGVy IGlzIG5vdCB3YWl0aW5nIGZvciBhIGNvbnRlbnQgcG9saWN5CisgICAgICAgIHJlc3BvbnNlIHdo ZW4gaXQgaXMgZGVzdHJveWVkLiBJZiB0aGlzIHdlcmUgdG8gaGFwcGVuLCB0aGVuIHRoZQorICAg ICAgICBsYW1iZGEgZnVuY3Rpb24gcGFzc2VkIHRvIFBvbGljeUNoZWNrZXI6OmNoZWNrQ29udGVu dFBvbGljeSgpCisgICAgICAgIHdvdWxkIG91dGxpdmUgdGhlIERvY3VtZW50TG9hZGVyLiBUaGlz IGlzIGFuIGlzc3VlIGJlY2F1c2UKKyAgICAgICAgdGhhdCBsYW1iZGEgZnVuY3Rpb24gY2FwdHVy ZXMgW3RoaXNdLCB3aGljaCBpcyB0aGUgRG9jdW1lbnRMb2FkZXIuCisgICAgICAgIFRoaXMgd291 bGQgY2F1c2UgRG9jdW1lbnRMb2FkZXI6OmNvbnRpbnVlQWZ0ZXJDb250ZW50UG9saWN5KCkgdG8K KyAgICAgICAgYmUgY2FsbGVkIGFmdGVyIHRoZSBEb2N1bWVudExvYWRlciBoYXMgYmVlbiBkZXN0 cm95ZWQsIHdoaWNoIHdvdWxkCisgICAgICAgIGV4cGxhaW4gdGhlIGNyYXNoLgorCisgICAgICAg IChXZWJDb3JlOjpEb2N1bWVudExvYWRlcjo6aW50ZXJydXB0ZWRGb3JQb2xpY3lDaGFuZ2VFcnJv cik6CisgICAgICAgIE1ha2Ugc3VyZSBmcmFtZUxvYWRlcigpIGlzIG5vdCBudWxsIGJlZm9yZSB1 c2luZyBpdC4KKwogMjAxNS0wMi0xMCAgSnVsaWVuIElzb3JjZSAgPGouaXNvcmNlQHNhbXN1bmcu Y29tPgogCiAgICAgICAgIFJlbmRlcjogcHJvcGVybHkgdXBkYXRlIGJvZHkncyBiYWNrZ3JvdW5k IGltYWdlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIu Y3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcAppbmRleCA2M2Q1 ZTNhNjkwNDVmZTg4MjQ3MzgyMjFlYzIxNjA3MDQ1YzhhMDUyLi5iZDVkMzIzNDc0OGZmZjU0NWY0 MmQ0ZWUyMzI5ZmY5NTE4ZjIwZmQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIv RG9jdW1lbnRMb2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExv YWRlci5jcHAKQEAgLTE2MSw2ICsxNjEsNyBAQCBSZXNvdXJjZUxvYWRlciogRG9jdW1lbnRMb2Fk ZXI6Om1haW5SZXNvdXJjZUxvYWRlcigpIGNvbnN0CiBEb2N1bWVudExvYWRlcjo6fkRvY3VtZW50 TG9hZGVyKCkKIHsKICAgICBBU1NFUlQoIW1fZnJhbWUgfHwgZnJhbWVMb2FkZXIoKS0+YWN0aXZl RG9jdW1lbnRMb2FkZXIoKSAhPSB0aGlzIHx8ICFpc0xvYWRpbmcoKSk7CisgICAgQVNTRVJUKCFt X3dhaXRpbmdGb3JDb250ZW50UG9saWN5KTsKICAgICBpZiAobV9pY29uTG9hZERlY2lzaW9uQ2Fs bGJhY2spCiAgICAgICAgIG1faWNvbkxvYWREZWNpc2lvbkNhbGxiYWNrLT5pbnZhbGlkYXRlKCk7 CiAgICAgaWYgKG1faWNvbkRhdGFDYWxsYmFjaykKQEAgLTc3Myw2ICs3NzQsNyBAQCB2b2lkIERv Y3VtZW50TG9hZGVyOjpjb21taXRMb2FkKGNvbnN0IGNoYXIqIGRhdGEsIGludCBsZW5ndGgpCiAK IFJlc291cmNlRXJyb3IgRG9jdW1lbnRMb2FkZXI6OmludGVycnVwdGVkRm9yUG9saWN5Q2hhbmdl RXJyb3IoKSBjb25zdAogeworICAgIEFTU0VSVChmcmFtZUxvYWRlcigpKTsKICAgICByZXR1cm4g ZnJhbWVMb2FkZXIoKS0+Y2xpZW50KCkuaW50ZXJydXB0ZWRGb3JQb2xpY3lDaGFuZ2VFcnJvcihy ZXF1ZXN0KCkpOwogfQogCg==