141434 2015-02-10 08:55:20 -0800 Add the crash-on-failure behavior to bmalloc-based fastMalloc 2015-02-10 20:54:10 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 darin darin ap benjamin cmarcelo commit-queue ggaren kling oldest_to_newest 1068072 0 darin 2015-02-10 08:55:20 -0800 Add the crash-on-failure behavior to bmalloc-based fastMalloc 1068073 1 246328 darin 2015-02-10 09:00:08 -0800 Created attachment 246328 Patch 1068086 2 246328 ap 2015-02-10 09:41:25 -0800 Comment on attachment 246328 Patch r=me. It's very surprising that a behavior change like this sneaked in accidentally. 1068252 3 246328 commit-queue 2015-02-10 20:54:05 -0800 Comment on attachment 246328 Patch Clearing flags on attachment: 246328 Committed r179915: <http://trac.webkit.org/changeset/179915> 1068253 4 commit-queue 2015-02-10 20:54:10 -0800 All reviewed patches have been landed. Closing bug. 246328 2015-02-10 09:00:08 -0800 2015-02-10 20:54:05 -0800 Patch bug-141434-20150210090010.patch text/plain 5111 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5ODcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDE4OTUzMTNiMjNlYmQ5M2MzZjQwZTJi NTUzYmE4NTk5MTEwMzJhNTAuLjNiOGEyMTRmNWJiM2EyZWE5NDRjOThjZDFjNDNmN2I4YWM0ZGU4 Y2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTUtMDItMTAgIERhcmluIEFkbGVyICA8ZGFyaW5A YXBwbGUuY29tPgorCisgICAgICAgIEFkZCB0aGUgY3Jhc2gtb24tZmFpbHVyZSBiZWhhdmlvciB0 byBibWFsbG9jLWJhc2VkIGZhc3RNYWxsb2MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0MTQzNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogd3RmL0Zhc3RNYWxsb2MuY3BwOiBSZW1vdmVkIHVubmVlZGVk IGluY2x1ZGVzLgorICAgICAgICAoV1RGOjpmYXN0TWFsbG9jKTogQWRkZWQgbnVsbCBjaGVjayBh bmQgQ1JBU0guCisgICAgICAgIChXVEY6OmZhc3RDYWxsb2MpOiBBZGRlZCBvdmVyZmxvdyBjaGVj a2luZywgbnVsbCBjaGVjaywgYW5kIENSQVNILgorICAgICAgICAoV1RGOjpmYXN0UmVhbGxvYyk6 IEFkZGVkIG51bGwgY2hlY2sgYW5kIENSQVNILgorICAgICAgICAoV1RGOjpmYXN0TWFsbG9jU2l6 ZSk6IEFkZGVkIEZJWE1FIGNvbW1lbnQuCisgICAgICAgIChXVEY6OmZhc3RNYWxsb2NHb29kU2l6 ZSk6IEFkZGVkIEZJWE1FIGNvbW1lbnQuCisgICAgICAgIChXVEY6OmZhc3RBbGlnbmVkTWFsbG9j KTogQWRkZWQgbnVsbCBjaGVjayBhbmQgQ1JBU0guCisgICAgICAgIChXVEY6OnRyeUZhc3RNYWxs b2MpOiBDaGFuZ2VkIHRvIGNhbGwgYm1hbGxvYyBkaXJlY3RseSBpbnN0ZWFkIG9mCisgICAgICAg IGNhbGxpbmcgZmFzdE1hbGxvYywgc2luY2UgZmFzdE1hbGxvYyB3aWxsIG5vdyBjcmFzaCBvbiBm YWlsdXJlLgorICAgICAgICAoV1RGOjp0cnlGYXN0UmVhbGxvYyk6IENoYW5nZWQgdG8gY2FsbCBi bWFsbG9jIGRpcmVjdGx5IGluc3RlYWQgb2YKKyAgICAgICAgY2FsbGluZyBmYXN0UmVhbGxvYywg c2luY2UgZmFzdFJlYWxsb2Mgd2lsbCBub3cgY3Jhc2ggb24gZmFpbHVyZS4KKyAgICAgICAgKFdU Rjo6dHJ5RmFzdENhbGxvYyk6IEFkZGVkIG92ZXJmbG93IGNoZWNraW5nLgorICAgICAgICAoV1RG OjpmYXN0TWFsbG9jU3RhdGlzdGljcyk6IEFkZGVkIEZJWE1FIGNvbW1lbnQuCisKIDIwMTUtMDIt MTAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAg IFtHVEtdIEdNdXRleExvY2tlciBidWlsZCBpc3N1ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93 dGYvRmFzdE1hbGxvYy5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9GYXN0TWFsbG9jLmNwcAppbmRleCBh Y2M1YTcwNjJlZmFjN2NkYmIyZmI5MTMwZTVjZDVhYzc2MTMyODdhLi45YjE1YWMwNzBhMDU1YjJm NzQ2N2YwMWNhMDQyMTU0ZDFiNDk1ODNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9GYXN0 TWFsbG9jLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9GYXN0TWFsbG9jLmNwcApAQCAtMSw2ICsx LDYgQEAKIC8vIENvcHlyaWdodCAoYykgMjAwNSwgMjAwNywgR29vZ2xlIEluYy4KIC8vIEFsbCBy aWdodHMgcmVzZXJ2ZWQuCi0vLyBDb3B5cmlnaHQgKEMpIDIwMDUsIDIwMDYsIDIwMDcsIDIwMDgs IDIwMDksIDIwMTEsIDIwMTUgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorLy8gQ29w eXJpZ2h0IChDKSAyMDA1LTIwMDksIDIwMTEsIDIwMTUgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJl c2VydmVkLgogLy8gCiAvLyBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmlu YXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKIC8vIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRl ZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucyBhcmUKQEAgLTc3LDE4ICs3 NywxNyBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkZhc3RNYWxsb2MuaCIKIAot I2luY2x1ZGUgIkFzc2VydGlvbnMuaCIKKyNpbmNsdWRlICJDaGVja2VkQXJpdGhtZXRpYy5oIgog I2luY2x1ZGUgIkN1cnJlbnRUaW1lLmgiCi0KICNpbmNsdWRlIDxsaW1pdHM+CisjaW5jbHVkZSA8 c3RyaW5nLmg+CisjaW5jbHVkZSA8d3RmL0RhdGFMb2cuaD4KKwogI2lmIE9TKFdJTkRPV1MpCiAj aW5jbHVkZSA8d2luZG93cy5oPgogI2Vsc2UKICNpbmNsdWRlIDxwdGhyZWFkLmg+CiAjZW5kaWYK LSNpbmNsdWRlIDxzdHJpbmcuaD4KLSNpbmNsdWRlIDx3dGYvRGF0YUxvZy5oPgotI2luY2x1ZGUg PHd0Zi9TdGRMaWJFeHRyYXMuaD4KIAogI2lmIE9TKERBUldJTikKICNpbmNsdWRlIDxtYWNoL21h Y2hfaW5pdC5oPgpAQCAtMjczLDM3ICsyNzIsNTUgQEAgbmFtZXNwYWNlIFdURiB7CiAKIHZvaWQq IGZhc3RNYWxsb2Moc2l6ZV90IHNpemUpCiB7Ci0gICAgcmV0dXJuIGJtYWxsb2M6OmFwaTo6bWFs bG9jKHNpemUpOworICAgIHZvaWQqIHJlc3VsdCA9IGJtYWxsb2M6OmFwaTo6bWFsbG9jKHNpemUp OworICAgIGlmICghcmVzdWx0KQorICAgICAgICBDUkFTSCgpOworICAgIHJldHVybiByZXN1bHQ7 CiB9CiAKIHZvaWQqIGZhc3RDYWxsb2Moc2l6ZV90IG51bUVsZW1lbnRzLCBzaXplX3QgZWxlbWVu dFNpemUpCiB7Ci0gICAgcmV0dXJuIGZhc3RaZXJvZWRNYWxsb2MobnVtRWxlbWVudHMgKiBlbGVt ZW50U2l6ZSk7CisgICAgQ2hlY2tlZDxzaXplX3Q+IGNoZWNrZWRTaXplID0gZWxlbWVudFNpemU7 CisgICAgY2hlY2tlZFNpemUgKj0gbnVtRWxlbWVudHM7CisgICAgdm9pZCogcmVzdWx0ID0gZmFz dFplcm9lZE1hbGxvYyhjaGVja2VkU2l6ZS51bnNhZmVHZXQoKSk7CisgICAgaWYgKCFyZXN1bHQp CisgICAgICAgIENSQVNIKCk7CisgICAgcmV0dXJuIHJlc3VsdDsKIH0KLSAgICAKKwogdm9pZCog ZmFzdFJlYWxsb2Modm9pZCogb2JqZWN0LCBzaXplX3Qgc2l6ZSkKIHsKLSAgICByZXR1cm4gYm1h bGxvYzo6YXBpOjpyZWFsbG9jKG9iamVjdCwgc2l6ZSk7CisgICAgdm9pZCogcmVzdWx0ID0gYm1h bGxvYzo6YXBpOjpyZWFsbG9jKG9iamVjdCwgc2l6ZSk7CisgICAgaWYgKCFyZXN1bHQpCisgICAg ICAgIENSQVNIKCk7CisgICAgcmV0dXJuIHJlc3VsdDsKIH0KLSAgICAKKwogdm9pZCBmYXN0RnJl ZSh2b2lkKiBvYmplY3QpCiB7CiAgICAgYm1hbGxvYzo6YXBpOjpmcmVlKG9iamVjdCk7CiB9Ci0g ICAgCisKIHNpemVfdCBmYXN0TWFsbG9jU2l6ZShjb25zdCB2b2lkKikKIHsKKyAgICAvLyBGSVhN RTogVGhpcyBpcyBpbmNvcnJlY3Q7IGJlc3QgZml4IGlzIHByb2JhYmx5IHRvIHJlbW92ZSB0aGlz IGZ1bmN0aW9uLgorICAgIC8vIENhbGxlciBjdXJyZW50bHkgYXJlIGFsbCB1c2luZyB0aGlzIGZv ciBhc3NlcnRpb24sIG5vdCB0byBhY3R1YWxseSBjaGVjaworICAgIC8vIHRoZSBzaXplIG9mIHRo ZSBhbGxvY2F0aW9uLCBzbyBtYXliZSB3ZSBjYW4gY29tZSB1cCB3aXRoIHNvbWV0aGluZyBmb3Ig dGhhdC4KICAgICByZXR1cm4gMTsKIH0KLSAgICAKKwogc2l6ZV90IGZhc3RNYWxsb2NHb29kU2l6 ZShzaXplX3Qgc2l6ZSkKIHsKKyAgICAvLyBGSVhNRTogVGhpcyBpcyBub24taGVscGZ1bDsgZmFz dE1hbGxvY0dvb2RTaXplIHdpbGwgYmUgcmVtb3ZlZCBzb29uLgogICAgIHJldHVybiBzaXplOwog fQotICAgIAorCiB2b2lkKiBmYXN0QWxpZ25lZE1hbGxvYyhzaXplX3QgYWxpZ25tZW50LCBzaXpl X3Qgc2l6ZSkgCiB7Ci0gICAgcmV0dXJuIGJtYWxsb2M6OmFwaTo6bWVtYWxpZ24oYWxpZ25tZW50 LCBzaXplKTsKKyAgICB2b2lkKiByZXN1bHQgPSBibWFsbG9jOjphcGk6Om1lbWFsaWduKGFsaWdu bWVudCwgc2l6ZSk7CisgICAgaWYgKCFyZXN1bHQpCisgICAgICAgIENSQVNIKCk7CisgICAgcmV0 dXJuIHJlc3VsdDsKIH0KIAogdm9pZCBmYXN0QWxpZ25lZEZyZWUodm9pZCogcCkgCkBAIC0zMTMs MTcgKzMzMCwyMSBAQCB2b2lkIGZhc3RBbGlnbmVkRnJlZSh2b2lkKiBwKQogCiBUcnlNYWxsb2NS ZXR1cm5WYWx1ZSB0cnlGYXN0TWFsbG9jKHNpemVfdCBzaXplKQogewotICAgIHJldHVybiBmYXN0 TWFsbG9jKHNpemUpOworICAgIHJldHVybiBibWFsbG9jOjphcGk6Om1hbGxvYyhzaXplKTsKIH0K ICAgICAKLVRyeU1hbGxvY1JldHVyblZhbHVlIHRyeUZhc3RSZWFsbG9jKHZvaWQqIHAsIHNpemVf dCBuKQorVHJ5TWFsbG9jUmV0dXJuVmFsdWUgdHJ5RmFzdFJlYWxsb2Modm9pZCogb2JqZWN0LCBz aXplX3Qgc2l6ZSkKIHsKLSAgICByZXR1cm4gZmFzdFJlYWxsb2MocCwgbik7CisgICAgcmV0dXJu IGJtYWxsb2M6OmFwaTo6cmVhbGxvYyhvYmplY3QsIHNpemUpOwogfQogICAgIAogVHJ5TWFsbG9j UmV0dXJuVmFsdWUgdHJ5RmFzdENhbGxvYyhzaXplX3QgbnVtRWxlbWVudHMsIHNpemVfdCBlbGVt ZW50U2l6ZSkKIHsKLSAgICByZXR1cm4gdHJ5RmFzdFplcm9lZE1hbGxvYyhudW1FbGVtZW50cyAq IGVsZW1lbnRTaXplKTsKKyAgICBDaGVja2VkPHNpemVfdCwgUmVjb3JkT3ZlcmZsb3c+IGNoZWNr ZWRTaXplID0gZWxlbWVudFNpemU7CisgICAgY2hlY2tlZFNpemUgKj0gbnVtRWxlbWVudHM7Cisg ICAgaWYgKGNoZWNrZWRTaXplLmhhc092ZXJmbG93ZWQoKSkKKyAgICAgICAgcmV0dXJuIG51bGxw dHI7CisgICAgcmV0dXJuIHRyeUZhc3RaZXJvZWRNYWxsb2MoY2hlY2tlZFNpemUudW5zYWZlR2V0 KCkpOwogfQogICAgIAogdm9pZCByZWxlYXNlRmFzdE1hbGxvY0ZyZWVNZW1vcnlGb3JUaGlzVGhy ZWFkKCkKQEAgLTMzOCw2ICszNTksNyBAQCB2b2lkIHJlbGVhc2VGYXN0TWFsbG9jRnJlZU1lbW9y eSgpCiAKIEZhc3RNYWxsb2NTdGF0aXN0aWNzIGZhc3RNYWxsb2NTdGF0aXN0aWNzKCkKIHsKKyAg ICAvLyBGSVhNRTogVGhpcyBpcyBpbmNvcnJlY3Q7IG5lZWRzIGFuIGltcGxlbWVudGF0aW9uIG9y IHRvIGJlIHJlbW92ZWQuCiAgICAgRmFzdE1hbGxvY1N0YXRpc3RpY3Mgc3RhdGlzdGljcyA9IHsg MCwgMCwgMCB9OwogICAgIHJldHVybiBzdGF0aXN0aWNzOwogfQo=