141423 2015-02-10 03:54:38 -0800 [GTK] Layout Tests are failing since the change of the computed value of line-height:normal 2017-03-11 10:54:25 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 chavarria1991 webkit-unassigned bugs-noreply chavarria1991 clopez dino galineau ltilve oldest_to_newest 1068021 0 chavarria1991 2015-02-10 03:54:38 -0800 The fast/css/font-shorthand-from-longhands.html layout test is failing since r179168 (http://trac.webkit.org/r179168). The test replaces "normal" value by a numeric value. GTK+ port results have different numeric values. The diff can be found here https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r179867%20%286096%29/fast/css/font-shorthand-from-longhands-pretty-diff.html 1068023 1 chavarria1991 2015-02-10 04:39:42 -0800 More tests are failing due to the same revision the error is the different numeric values from the expected and the test result. * css3/calc/line-height.html --- /home/ch01/wk-tools/layout-test-results/css3/calc/line-height-expected.txt +++ /home/ch01/wk-tools/layout-test-results/css3/calc/line-height-actual.txt @@ -4,7 +4,7 @@ PASS getComputedStyle(document.getElementById("calc-percent"), null).lineHeight is getComputedStyle(document.getElementById("control"), null).lineHeight -FAIL getComputedStyle(document.getElementById("calc-percent-pixels"), null).lineHeight should be 32px. Was 18px. +FAIL getComputedStyle(document.getElementById("calc-percent-pixels"), null).lineHeight should be 32px. Was 17px. PASS successfullyParsed is true TEST COMPLETE * fast/css/font-shorthand-line-height.html --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/css/font-shorthand-line-height-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/css/font-shorthand-line-height-actual.txt @@ -4,9 +4,9 @@ PASS lineHeight(system_font_1) is '100px' -PASS lineHeight(system_font_2) is '16px' +FAIL lineHeight(system_font_2) should be 16px. Was 17px. PASS lineHeight(shorthand_normal_1) is '100px' -PASS lineHeight(shorthand_normal_2) is '12px' +FAIL lineHeight(shorthand_normal_2) should be 12px. Was 11px. PASS lineHeight(shorthand_line_height_1) is '100px' PASS lineHeight(shorthand_line_height_2) is '200px' PASS successfullyParsed is true https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r179867%20%286096%29/fast/css/font-shorthand-line-height-pretty-diff.html * fast/css/getComputedStyle/computed-style-font.html https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r179867%20%286096%29/fast/css/getComputedStyle/computed-style-font-pretty-diff.html * fast/css/getComputedStyle/computed-style-without-renderer.html --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/css/getComputedStyle/computed-style-without-renderer-actual.txt @@ -49,7 +49,7 @@ image-rendering: auto left: auto letter-spacing: normal -line-height: 18px +line-height: 17px list-style-image: none list-style-position: outside list-style-type: disc https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r179867%20%286096%29/fast/css/getComputedStyle/computed-style-without-renderer-pretty-diff.html * fast/css/line-height-text-autosizing.html --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/css/line-height-text-autosizing-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/css/line-height-text-autosizing-actual.txt @@ -4,7 +4,7 @@ Case without text size adjust. -PASS window.getComputedStyle(testDivNoAdjust).getPropertyValue('line-height') is "23px" +FAIL window.getComputedStyle(testDivNoAdjust).getPropertyValue('line-height') should be 23px. Was 22px. PASS window.getComputedStyle(testDivNoAdjust).getPropertyValue('font-size') is "20px" testDivNoAdjust.style['line-height'] = '1.6' PASS window.getComputedStyle(testDivNoAdjust).getPropertyValue('line-height') is "32px" https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r179867%20%286096%29/fast/css/line-height-text-autosizing-pretty-diff.html * fast/css/getComputedStyle/computed-style.html --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/css/getComputedStyle/computed-style-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/css/getComputedStyle/computed-style-actual.txt @@ -50,7 +50,7 @@ image-rendering: auto; left: auto; letter-spacing: normal; -line-height: 18px; +line-height: 17px; list-style-image: none; list-style-position: outside; list-style-type: disc; https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r179867%20%286096%29/fast/css/getComputedStyle/computed-style-pretty-diff.html * fast/css/font-shorthand-from-longhands.html https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r179867%20%286096%29/fast/css/font-shorthand-from-longhands-pretty-diff.html * editing/pasteboard/simplfiying-markup-should-not-strip-content.html https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r179867%20%286096%29/editing/pasteboard/simplfiying-markup-should-not-strip-content-pretty-diff.html 1068025 2 chavarria1991 2015-02-10 04:41:12 -0800 *** Bug 141418 has been marked as a duplicate of this bug. *** 1068027 3 chavarria1991 2015-02-10 04:41:41 -0800 *** Bug 141421 has been marked as a duplicate of this bug. *** 1068322 4 chavarria1991 2015-02-11 04:11:11 -0800 The svg/css/getComputedStyle-basic.xhtml layout test is also affected: --- /home/ch01/wk-tools/layout-test-results/svg/css/getComputedStyle-basic-expected.txt +++ /home/ch01/wk-tools/layout-test-results/svg/css/getComputedStyle-basic-actual.txt @@ -98,7 +98,7 @@ rect: style.getPropertyCSSValue(left) : [object CSSPrimitiveValue] rect: style.getPropertyValue(letter-spacing) : normal rect: style.getPropertyCSSValue(letter-spacing) : [object CSSPrimitiveValue] -rect: style.getPropertyValue(line-height) : 18px +rect: style.getPropertyValue(line-height) : 17px rect: style.getPropertyCSSValue(line-height) : [object CSSPrimitiveValue] rect: style.getPropertyValue(list-style-image) : none rect: style.getPropertyCSSValue(list-style-image) : [object CSSPrimitiveValue] @@ -610,7 +610,7 @@ g: style.getPropertyCSSValue(left) : [object CSSPrimitiveValue] g: style.getPropertyValue(letter-spacing) : normal g: style.getPropertyCSSValue(letter-spacing) : [object CSSPrimitiveValue] -g: style.getPropertyValue(line-height) : 18px +g: style.getPropertyValue(line-height) : 17px g: style.getPropertyCSSValue(line-height) : [object CSSPrimitiveValue] g: style.getPropertyValue(list-style-image) : none g: style.getPropertyCSSValue(list-style-image) : [object CSSPrimitiveValue] 1068812 5 galineau 2015-02-12 17:48:10 -0800 To be clear, r179168 only made line-height: normal compute to a length instead of 'normal'. What we see here are line-height length values changing, most of them by 1px. It seems we may have stumbled into a difference between ports that wasn't visible before. I will try to look into this though I'm not able to build on Linux at this time. 1149975 6 ltilve 2015-12-17 07:17:50 -0800 editing/pasteboard/simplfiying-markup-should-not-strip-content.html layout test was being skipped. Passing again after <http://trac.webkit.org/changeset/186191>. Unskipped in <http://trac.webkit.org/changeset/194218>. 1201281 7 clopez 2016-06-10 11:15:26 -0700 r200534 <http://trac.webkit.org/r200534> removed the test fast/css/line-height-text-autosizing.html and made it iOS specific fast/text-autosizing/ios/autosize-width-expected.html