141419 2015-02-10 02:07:30 -0800 [GTK] Layout Test editing/deleting/delete-emoji.html is failing 2015-03-30 05:41:53 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 chavarria1991 webkit-unassigned chavarria1991 clopez commit-queue darin enrica esprehn+autocc glenn kondapallykalyan mmaxfield oldest_to_newest 1068012 0 chavarria1991 2015-02-10 02:07:30 -0800 The following layout test is failing on GTK+ since it was added on r179567 (http://trac.webkit.org/r179567) The diff can be found here https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r179867%20%286096%29/editing/deleting/delete-emoji-pretty-diff.html The delete emoji operation doesn't seem to be working. 1075928 1 248322 chavarria1991 2015-03-10 02:54:49 -0700 Created attachment 248322 Patch 1075931 2 chavarria1991 2015-03-10 03:04:25 -0700 The code for deleting special characters like emoji was specific for EFL and COCOA plarforms, there was a #if preprocessor directive like the following: #if PLATFORM(COCOA) || PLATFORM(EFL) I added PLATFORM(GTK) to the previous directive and now the emoji deletion is working on GTK+ I don't know if it has some side effects but I have run the Layout tests and they seem to work properly. 1081140 3 248322 commit-queue 2015-03-30 05:41:48 -0700 Comment on attachment 248322 Patch Clearing flags on attachment: 248322 Committed r182137: <http://trac.webkit.org/changeset/182137> 1081141 4 commit-queue 2015-03-30 05:41:53 -0700 All reviewed patches have been landed. Closing bug. 248322 2015-03-10 02:54:49 -0700 2015-03-30 05:41:48 -0700 Patch bug-141419-20150310105425.patch text/plain 3212 chavarria1991 U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxMzIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzRiOGU5ZmVmZjU2MTE3 YjIwNjczYzkyZjk5Mjc0OTUxODlmZDljOC4uNWJkZmRhOTY1ZmNmMzQ4ZTE1NTZjY2Y2YmU5OGJm MmMzYmU3MGJlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTAzLTEwICBNYXJj b3MgQ2hhdmFycsOtYSBUZWlqZWlybyAgPGNoYXZhcnJpYTE5OTFAZ21haWwuY29tPgorCisgICAg ICAgIEFkZCBzdXBwb3J0IGZvciBkZWxldGluZyBlbW9qaSBvbiBHVEsKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MTQxOQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBjb2RlIGZvciBkZWxldGluZyBz cGVjaWFsIGdyb3VwIG9mIGNoYXJhY3RlcnMgd2FzIHNwZWNpZmljIGZvcgorICAgICAgICBDT0NP QSBhbmQgRUZMIHBsYXRmb3Jtcy4gVGhlIGZpeCBjb25zaXN0cyBvbiBhZGQgR1RLIHRvIHRoZSAj aWYKKyAgICAgICAgcHJlcHJvY2Vzc29yIGRpcmVjdGl2ZS4KKworICAgICAgICAqIHJlbmRlcmlu Zy9SZW5kZXJUZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRleHQ6OnByZXZpb3Vz T2Zmc2V0Rm9yQmFja3dhcmREZWxldGlvbik6CisKIDIwMTUtMDMtMTAgIFphbiBEb2JlcnNlayAg PHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFNocmluayB0aGUgQ1NTUHJvcGVydHlJ RCBlbnVtIHR5cGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJU ZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0LmNwcAppbmRleCAx NmZiYzA5MmRiY2U2ZjUzYzExYzRhYjg5ODZmOTkwZGI0MDc2ZWM2Li43NDkwZWQyZDFlZjU2Zjk1 MzQ5ZmUxNDhlMWZlOWY0MWU2ZDFjMWQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyVGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl clRleHQuY3BwCkBAIC0xNDAxLDcgKzE0MDEsNyBAQCBpbnQgUmVuZGVyVGV4dDo6cHJldmlvdXNP ZmZzZXQoaW50IGN1cnJlbnQpIGNvbnN0CiAgICAgcmV0dXJuIHJlc3VsdDsKIH0KIAotI2lmIFBM QVRGT1JNKENPQ09BKSB8fCBQTEFURk9STShFRkwpCisjaWYgUExBVEZPUk0oQ09DT0EpIHx8IFBM QVRGT1JNKEVGTCkgfHwgUExBVEZPUk0oR1RLKQogCiAjZGVmaW5lIEhBTkdVTF9DSE9TRU9OR19T VEFSVCAoMHgxMTAwKQogI2RlZmluZSBIQU5HVUxfQ0hPU0VPTkdfRU5EICgweDExNUYpCkBAIC0x NDQzLDcgKzE0NDMsNyBAQCBzdGF0aWMgaW5saW5lIGJvb2wgaXNSZWdpb25hbEluZGljYXRvcihV Q2hhcjMyIGNoYXJhY3RlcikKIAogaW50IFJlbmRlclRleHQ6OnByZXZpb3VzT2Zmc2V0Rm9yQmFj a3dhcmREZWxldGlvbihpbnQgY3VycmVudCkgY29uc3QKIHsKLSNpZiBQTEFURk9STShDT0NPQSkg fHwgUExBVEZPUk0oRUZMKQorI2lmIFBMQVRGT1JNKENPQ09BKSB8fCBQTEFURk9STShFRkwpIHx8 IFBMQVRGT1JNKEdUSykKICAgICBBU1NFUlQobV90ZXh0KTsKICAgICBTdHJpbmdJbXBsJiB0ZXh0 ID0gKm1fdGV4dC5pbXBsKCk7CiAgICAgVUNoYXIzMiBjaGFyYWN0ZXI7CmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggN2FlZjgy OGQ0NmQ4MGIzNjcyYTliMjY3ZGNiN2MyNjI0Y2FmY2Y1My4uNjMxYzMzZTUwMjA4NWJhYzI3YzM2 NzY5MDE1YTJmYTA4NjAyZDM0ZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisr KyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1LTAzLTEwICBN YXJjb3MgQ2hhdmFycsOtYSBUZWlqZWlybyAgPGNoYXZhcnJpYTE5OTFAZ21haWwuY29tPgorCisg ICAgICAgIFVwZGF0ZSBleHBlY3RhdGlvbnMgZm9yIGRlbGV0ZS1lbW9qaSB0ZXN0IHNpbmNlIHRo ZSBidWcgaXMgZml4ZWQgbm93LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQxNDE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxNS0wMy0w OSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBTa2lwIGNv bnRlbnRmaWx0ZXJpbmcvYmxvY2stYWZ0ZXItYWRkLWRhdGEuaHRtbCBmb3Igbm93LgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwppbmRleCAzM2VkOTM0NmViZWQ1YjBm OWViY2NiOGVhNDNkMDQ1ZWUzODQwOWYzLi5lYTE1ODAzZjVkMjUzMmVjN2NlMzcxYWE4YTVjOTZm MDRjNDg2MTA2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVj dGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwpA QCAtNTMwLDcgKzUzMCw2IEBAIEJ1ZyhHVEspIGNzczMvZmlsdGVycy9iYWNrZHJvcCBbIFNraXAg XQogd2Via2l0Lm9yZy9iLzE0MTA3MiBhY2Nlc3NpYmlsaXR5L2ZyYW1lLWRpc2Nvbm5lY3QtdGV4 dG1hcmtlci1jYWNoZS1jcmFzaC5odG1sIFsgRmFpbHVyZSBdCiAKIHdlYmtpdC5vcmcvYi8xNDE0 MjMgY3NzMy9jYWxjL2xpbmUtaGVpZ2h0Lmh0bWwgWyBGYWlsdXJlIF0KLXdlYmtpdC5vcmcvYi8x NDE0MTkgZWRpdGluZy9kZWxldGluZy9kZWxldGUtZW1vamkuaHRtbCBbIEZhaWx1cmUgXQogd2Vi a2l0Lm9yZy9iLzE0MTQyMyBlZGl0aW5nL3Bhc3RlYm9hcmQvc2ltcGxmaXlpbmctbWFya3VwLXNo b3VsZC1ub3Qtc3RyaXAtY29udGVudC5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTQx NDIzIGZhc3QvY3NzL2ZvbnQtc2hvcnRoYW5kLWZyb20tbG9uZ2hhbmRzLmh0bWwgWyBGYWlsdXJl IF0KIHdlYmtpdC5vcmcvYi8xNDE0MjMgZmFzdC9jc3MvZm9udC1zaG9ydGhhbmQtbGluZS1oZWln aHQuaHRtbCBbIEZhaWx1cmUgXQo=