141411 2015-02-09 15:51:38 -0800 Web Inspector: CSS Pretty Printing: still fails fails to put space between rgb(...) and numbers in minified gradients 2015-02-10 13:41:59 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1067952 0 joepeck 2015-02-09 15:51:38 -0800 * SUMMARY CSS Pretty Printing: still fails fails to put space between rgb(...) and numbers in minified gradients. PrettyPrinting tests work, but not the inspector frontend which modifies token strings. * TEST div{background:linear-gradient(top,rgb(126,198,234)0%,rgb(70,179,234)45%,rgb(3,135,201)100%);} * EXPECTED ..., rgb(126, 198, 234) 0%, ... * ACTUAL ..., rgb(126, 198, 234)0%, ... 1067953 1 246302 joepeck 2015-02-09 15:53:42 -0800 Created attachment 246302 [PATCH] Proposed Fix 1068136 2 246302 commit-queue 2015-02-10 13:41:56 -0800 Comment on attachment 246302 [PATCH] Proposed Fix Clearing flags on attachment: 246302 Committed r179879: <http://trac.webkit.org/changeset/179879> 1068137 3 commit-queue 2015-02-10 13:41:59 -0800 All reviewed patches have been landed. Closing bug. 246302 2015-02-09 15:53:42 -0800 2015-02-10 13:41:56 -0800 [PATCH] Proposed Fix better.patch text/plain 2871 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDczZmU5NTQuLmNmN2YwM2UgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAyLTA5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ1NTIFBy ZXR0eSBQcmludGluZzogc3RpbGwgZmFpbHMgZmFpbHMgdG8gcHV0IHNwYWNlIGJldHdlZW4gcmdi KC4uLikgYW5kIG51bWJlcnMgaW4gbWluaWZpZWQgZ3JhZGllbnRzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDE0MTEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFRvb2xzL1ByZXR0eVByaW50aW5nL0Nv ZGVNaXJyb3JGb3JtYXR0ZXJzLmpzOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvQ29k ZU1pcnJvckZvcm1hdHRlcnMuanM6CisgICAgICAgIFRva2VuIGFjdHVhbGx5IHdhcyAibnVtYmVy IG0tY3NzIiBzbyB3ZSBzaG91bGQgY2hlY2sgdG9rZW4gc3RyaW5ncworICAgICAgICBtb3JlIHJv YnVzdGx5LCBsaWtlIGVsc2V3aGVyZSBpbiB0aGUgZm9ybWF0dGVycy4KKwogMjAxNS0wMi0wNiAg Sm9ubyBXZWxscyAgPGpvbm93ZWxsc0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rv cjogUkVHUkVTU0lPTjogQ1NTIFJlc291cmNlIGFwcGVhcnMgYXMgZW1wdHkgYWZ0ZXIgZWRpdGlu ZyBpdCB2aWEgU3R5bGVzIHNpZGViYXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Ub29scy9QcmV0dHlQcmludGluZy9Db2RlTWlycm9yRm9ybWF0dGVycy5qcyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Ub29scy9QcmV0dHlQcmludGluZy9Db2RlTWlycm9yRm9ybWF0dGVycy5q cwppbmRleCA4MWQ3NGNiLi5mZWM4MzkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVG9vbHMvUHJldHR5UHJpbnRpbmcvQ29kZU1pcnJvckZvcm1hdHRlcnMuanMKKysrIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1Rvb2xzL1ByZXR0eVByaW50aW5nL0NvZGVNaXJyb3JGb3JtYXR0 ZXJzLmpzCkBAIC0zMjMsNyArMzIzLDcgQEAgQ29kZU1pcnJvci5leHRlbmRNb2RlKCJjc3MiLCB7 CiAgICAgICAgICAgICBpZiAobGFzdENvbnRlbnQgPT09ICI6IikgLy8gU3BhY2UgaW4gInByb3A6 IHZhbHVlIiBidXQgbm90IGluIGEgc2VsZWN0b3JzICJhOmxpbmsiIG9yICJkaXY6OmFmdGVyIiBv ciBtZWRpYSBxdWVyaWVzICIobWF4LWRldmljZS13aWR0aDo0ODBweCkiLgogICAgICAgICAgICAg ICAgIHJldHVybiBzdGF0ZS5zdGF0ZSA9PT0gInByb3AiOwogICAgICAgICAgICAgaWYgKGxhc3RD b250ZW50ID09PSAiKSIgJiYgKGNvbnRlbnQgIT09ICIpIiAmJiBjb250ZW50ICE9PSAiLCIpKSB7 Ci0gICAgICAgICAgICAgICAgaWYgKHRva2VuID09PSAibnVtYmVyIikgLy8gbGluZWFyLWdyYWRp ZW50KHJnYiguLi4pMCUscmdiKC4uLikxMDAlKQorICAgICAgICAgICAgICAgIGlmICgvXGJudW1i ZXJcYi8udGVzdCh0b2tlbikpIC8vIGxpbmVhci1ncmFkaWVudChyZ2IoLi4uKTAlLHJnYiguLi4p MTAwJSkKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgICAgICAgICAgICAg aWYgKHN0YXRlLnN0YXRlID09PSAicHJvcCIpIC8vIC13ZWJraXQtdHJhbnNmb3JtOnJvdGF0ZSgu Li4pdHJhbnNsYXRlKC4uLik7CiAgICAgICAgICAgICAgICAgICAgIHJldHVybiB0cnVlOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29kZU1p cnJvckZvcm1hdHRlcnMuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9Db2RlTWlycm9yRm9ybWF0dGVycy5qcwppbmRleCA4MWQ3NGNiLi5mZWM4MzkyIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db2RlTWly cm9yRm9ybWF0dGVycy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9Db2RlTWlycm9yRm9ybWF0dGVycy5qcwpAQCAtMzIzLDcgKzMyMyw3IEBAIENvZGVN aXJyb3IuZXh0ZW5kTW9kZSgiY3NzIiwgewogICAgICAgICAgICAgaWYgKGxhc3RDb250ZW50ID09 PSAiOiIpIC8vIFNwYWNlIGluICJwcm9wOiB2YWx1ZSIgYnV0IG5vdCBpbiBhIHNlbGVjdG9ycyAi YTpsaW5rIiBvciAiZGl2OjphZnRlciIgb3IgbWVkaWEgcXVlcmllcyAiKG1heC1kZXZpY2Utd2lk dGg6NDgwcHgpIi4KICAgICAgICAgICAgICAgICByZXR1cm4gc3RhdGUuc3RhdGUgPT09ICJwcm9w IjsKICAgICAgICAgICAgIGlmIChsYXN0Q29udGVudCA9PT0gIikiICYmIChjb250ZW50ICE9PSAi KSIgJiYgY29udGVudCAhPT0gIiwiKSkgewotICAgICAgICAgICAgICAgIGlmICh0b2tlbiA9PT0g Im51bWJlciIpIC8vIGxpbmVhci1ncmFkaWVudChyZ2IoLi4uKTAlLHJnYiguLi4pMTAwJSkKKyAg ICAgICAgICAgICAgICBpZiAoL1xibnVtYmVyXGIvLnRlc3QodG9rZW4pKSAvLyBsaW5lYXItZ3Jh ZGllbnQocmdiKC4uLikwJSxyZ2IoLi4uKTEwMCUpCiAgICAgICAgICAgICAgICAgICAgIHJldHVy biB0cnVlOwogICAgICAgICAgICAgICAgIGlmIChzdGF0ZS5zdGF0ZSA9PT0gInByb3AiKSAvLyAt d2Via2l0LXRyYW5zZm9ybTpyb3RhdGUoLi4uKXRyYW5zbGF0ZSguLi4pOwogICAgICAgICAgICAg ICAgICAgICByZXR1cm4gdHJ1ZTsK