141410 2015-02-09 15:42:34 -0800 Hit testing is misplaced when selecting on wikipedia page 2015-02-10 15:02:55 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified iOS 8.0 RESOLVED FIXED P2 Normal --- 1 enrica enrica oldest_to_newest 1067946 0 enrica 2015-02-09 15:42:34 -0800 Repro steps: 1. Navigate to wikipedia.org 2. Type a search term in the search field 3. Press enter 4. After the page loads try to select something using long press. Results: The selection is either not visible at all or in the incorrect place. rdar://problem/19768211 1067949 1 246301 enrica 2015-02-09 15:48:34 -0800 Created attachment 246301 Patch 1067951 2 246301 simon.fraser 2015-02-09 15:51:17 -0800 Comment on attachment 246301 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246301&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:4553 > + m_assistedNode = 0; nullptr. Higher up is a if (!frame->isMainFrame()) return; check so what if the assisted node is in a subframe? I still think we should do this on teardown/caching of the previous document, not the loading of the new one. 1068150 3 246343 enrica 2015-02-10 14:56:39 -0800 Created attachment 246343 Patch2 1068152 4 enrica 2015-02-10 15:02:55 -0800 https://trac.webkit.org/r179885 246301 2015-02-09 15:48:34 -0800 2015-02-10 14:56:39 -0800 Patch reset-assisted-node.txt text/plain 2574 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3OTg1MCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDE1LTAyLTA5ICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgSGl0IHRlc3RpbmcgaXMgbWlz cGxhY2VkIHdoZW4gc2VsZWN0aW5nIG9uIHdpa2lwZWRpYSBwYWdlLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxNDEwCisgICAgICAgIHJkYXI6Ly9w cm9ibGVtLzE5NzY4MjExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgV2hlbiBsb2FkaW5nIGEgbmV3IGRvY3VtZW50IGludG8gdGhlIHNhbWUgV2ViUGFn ZSBvYmplY3QsIHdlIG5lZWQKKyAgICAgICAgdG8gY2xlYXIgdGhlIGFzc2lzdGVkIG5vZGUsIHNp bmNlIHRoZXJlIGlzIG5vIGd1YXJhbnRlZSB0aGF0IHRoZQorICAgICAgICBub2RlIHdpbGwgYmUg Ymx1cnJlZC4gVGhlIGJ1ZyB3YXMgY2F1c2VkIGJ5IHRoZSB1c2Ugb2YgYSBzdGFsZQorICAgICAg ICBhc3Npc3RlZCBub2RlIHRvIGNvbnN0cmFpbiB0aGUgcG9pbnQgd2hlcmUgdGhlIGdlc3R1cmUg b2NjdXJzLgorICAgICAgICBUaGUgbm9kZSB3YXMgc3RpbGwgdmFsaWQsIHNpbmNlIHRoZSBwcmV2 aW91cyBwYWdlIHdhcyBpbiB0aGUgY2FjaGUuCisgICAgICAgIEkndmUgYWRkZWQgYSBBU1NFUlQg dG8gY2hlY2sgdGhhdCwgd2hlbiBjb25zdHJhaW5pbmcgdGhlIHBvaW50IHRvCisgICAgICAgIG5v ZGUgcmVjdGFuZ2xlLCB0aGUgbm9kZSBpcyBpbiB0aGUgc2FtZSBkb2N1bWVudCBhcyB0aGUgb25l IHdlCisgICAgICAgIGFyZSBwZXJmb3JtaW5nIGhpdCB0ZXN0IG9uLgorCisgICAgICAgICogV2Vi UHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpk aWRDb21taXRMb2FkKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJ T1MubW06CisgICAgICAgIChXZWJLaXQ6OmNvbnN0cmFpblBvaW50KToKKwogMjAxNS0wMi0wOSAg RW5yaWNhIENhc3VjY2kgIDxlbnJpY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFNlbGVjdGlvbiBm bGlja2VycyB3aGVuIHRyeWluZyB0byBjaGFuZ2Ugc2l6ZSBvZiBzZWxlY3Rpb24uCkluZGV4OiBT b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCShyZXZpc2lv biAxNzk4NDMpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTQ1NTAsNiArNDU1MCw3IEBAIHZvaWQgV2ViUGFnZTo6ZGlk Q29tbWl0TG9hZChXZWJGcmFtZSogZnIKICAgICBtX3VzZXJIYXNDaGFuZ2VkUGFnZVNjYWxlRmFj dG9yID0gZmFsc2U7CiAgICAgbV9lc3RpbWF0ZWRMYXRlbmN5ID0gc3RkOjpjaHJvbm86Om1pbGxp c2Vjb25kcygxMDAwIC8gNjApOwogICAgIGNhbmNlbFBvdGVudGlhbFRhcCgpOworICAgIG1fYXNz aXN0ZWROb2RlID0gMDsKIAogI2lmIEVOQUJMRShJT1NfVE9VQ0hfRVZFTlRTKQogICAgIFdlYlBy b2Nlc3M6OnNpbmdsZXRvbigpLmV2ZW50RGlzcGF0Y2hlcigpLmNsZWFyUXVldWVkVG91Y2hFdmVu dHNGb3JQYWdlKCp0aGlzKTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFn ZS9pb3MvV2ViUGFnZUlPUy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0JKHJldmlzaW9uIDE3OTg0NykKKysrIFNvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQkod29ya2luZyBj b3B5KQpAQCAtNjk1LDYgKzY5NSw3IEBAIHN0YXRpYyBGbG9hdFF1YWQgaW5uZXJGcmFtZVF1YWQo RnJhbWUqIGYKIAogc3RhdGljIEludFBvaW50IGNvbnN0cmFpblBvaW50KGNvbnN0IEludFBvaW50 JiBwb2ludCwgRnJhbWUqIGZyYW1lLCBOb2RlKiBhc3Npc3RlZE5vZGUpCiB7CisgICAgQVNTRVJU KCFhc3Npc3RlZE5vZGUgfHwgJmFzc2lzdGVkTm9kZS0+ZG9jdW1lbnQoKSA9PSBmcmFtZS0+ZG9j dW1lbnQoKSk7CiAgICAgY29uc3QgaW50IERFRkFVTFRfQ09OU1RSQUlOX0lOU0VUID0gMjsKICAg ICBJbnRSZWN0IGlubmVyRnJhbWUgPSBpbm5lckZyYW1lUXVhZChmcmFtZSwgYXNzaXN0ZWROb2Rl KS5lbmNsb3NpbmdCb3VuZGluZ0JveCgpOwogICAgIEludFBvaW50IGNvbnN0cmFpbmVkUG9pbnQg PSBwb2ludDsK 246343 2015-02-10 14:56:39 -0800 2015-02-10 15:00:26 -0800 Patch2 reset-assisted-node.txt text/plain 4030 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3OTg4NCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBACisyMDE1LTAyLTEwICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgSGl0IHRlc3RpbmcgaXMgbWlz cGxhY2VkIHdoZW4gc2VsZWN0aW5nIG9uIHdpa2lwZWRpYSBwYWdlLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxNDEwCisgICAgICAgIHJkYXI6Ly9w cm9ibGVtLzE5NzY4MjExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgV2hlbiBsb2FkaW5nIGEgbmV3IGRvY3VtZW50IGludG8gdGhlIHNhbWUgV2ViUGFn ZSBvYmplY3QsIHdlIG5lZWQKKyAgICAgICAgdG8gY2xlYXIgdGhlIGFzc2lzdGVkIG5vZGUsIHNp bmNlIHRoZXJlIGlzIG5vIGd1YXJhbnRlZSB0aGF0IHRoZQorICAgICAgICBub2RlIHdpbGwgYmUg Ymx1cnJlZC4gVGhlIGJ1ZyB3YXMgY2F1c2VkIGJ5IHRoZSB1c2Ugb2YgYSBzdGFsZQorICAgICAg ICBhc3Npc3RlZCBub2RlIHRvIGNvbnN0cmFpbiB0aGUgcG9pbnQgd2hlcmUgdGhlIGdlc3R1cmUg b2NjdXJzLgorICAgICAgICBUaGUgbm9kZSB3YXMgc3RpbGwgdmFsaWQsIHNpbmNlIHRoZSBwcmV2 aW91cyBwYWdlIHdhcyBpbiB0aGUgY2FjaGUuCisgICAgICAgIEkndmUgYWRkZWQgYSBBU1NFUlQg dG8gY2hlY2sgdGhhdCwgd2hlbiBjb25zdHJhaW5pbmcgdGhlIHBvaW50IHRvCisgICAgICAgIG5v ZGUgcmVjdGFuZ2xlLCB0aGUgbm9kZSBpcyBpbiB0aGUgc2FtZSBkb2N1bWVudCBhcyB0aGUgb25l IHdlCisgICAgICAgIGFyZSBwZXJmb3JtaW5nIGhpdCB0ZXN0IG9uLiBXaGVuIHRoZSBmcmFtZSBp cyBkZXRhY2hlZCwgd2UgY2xlYXIKKyAgICAgICAgdGhlIGFzc2lzdGVkIG5vZGUgaWYgdGhlIG5v ZGUgaXMgcGFydCBvZiB0aGUgZG9jdW1lbnQgaXMgdGhlIGZyYW1lCisgICAgICAgIGJlaW5nIGRl dGFjaGVkLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxv YWRlckNsaWVudC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkZyYW1lTG9hZGVyQ2xpZW50Ojpk ZXRhY2hlZEZyb21QYXJlbnQyKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFn ZS5oOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbToKKyAg ICAgICAgKFdlYktpdDo6Y29uc3RyYWluUG9pbnQpOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdl OjpyZXNldEFzc2lzdGVkTm9kZUZvckZyYW1lKToKKwogMjAxNS0wMi0xMCAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFtDb2NvYV0gTlNEYXRhIG92ZXIg cmV0YWluIGluIFdLQnJvd3NpbmdDb250ZXh0Q29udHJvbGxlciBsb2FkRGF0YQpJbmRleDogU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVu dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3Vw cG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5jcHAJKHJldmlzaW9uIDE3OTg0MykKKysrIFNvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDIsNiArMTQyLDkgQEAgdm9pZCBXZWJGcmFtZUxvYWRl ckNsaWVudDo6ZGV0YWNoZWRGcm9tUAogICAgIGlmICghd2ViUGFnZSkKICAgICAgICAgcmV0dXJu OwogCisjaWYgUExBVEZPUk0oSU9TKQorICAgIHdlYlBhZ2UtPnJlc2V0QXNzaXN0ZWROb2RlRm9y RnJhbWUobV9mcmFtZSk7CisjZW5kaWYKICAgICBSZWZQdHI8QVBJOjpPYmplY3Q+IHVzZXJEYXRh OwogCiAgICAgLy8gTm90aWZ5IHRoZSBidW5kbGUgY2xpZW50LgpJbmRleDogU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oCShyZXZpc2lvbiAxNzk4NDMpCisrKyBT b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oCSh3b3JraW5nIGNvcHkp CkBAIC01MTYsNiArNTE2LDcgQEAgcHVibGljOgogICAgIHZvaWQgc2V0QXNzaXN0ZWROb2RlVmFs dWUoY29uc3QgU3RyaW5nJik7CiAgICAgdm9pZCBzZXRBc3Npc3RlZE5vZGVWYWx1ZUFzTnVtYmVy KGRvdWJsZSk7CiAgICAgdm9pZCBzZXRBc3Npc3RlZE5vZGVTZWxlY3RlZEluZGV4KHVpbnQzMl90 IGluZGV4LCBib29sIGFsbG93TXVsdGlwbGVTZWxlY3Rpb24pOworICAgIHZvaWQgcmVzZXRBc3Np c3RlZE5vZGVGb3JGcmFtZShXZWJGcmFtZSopOwogICAgIFdlYkNvcmU6OkludFJlY3QgcmVjdEZv ckVsZW1lbnRBdEludGVyYWN0aW9uTG9jYXRpb24oKTsKICAgICB2b2lkIHVwZGF0ZVNlbGVjdGlv bkFwcGVhcmFuY2UoKTsKIApJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdl L2lvcy9XZWJQYWdlSU9TLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQkocmV2aXNpb24gMTc5ODQ3KQorKysgU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCSh3b3JraW5nIGNv cHkpCkBAIC02OTUsNiArNjk1LDcgQEAgc3RhdGljIEZsb2F0UXVhZCBpbm5lckZyYW1lUXVhZChG cmFtZSogZgogCiBzdGF0aWMgSW50UG9pbnQgY29uc3RyYWluUG9pbnQoY29uc3QgSW50UG9pbnQm IHBvaW50LCBGcmFtZSogZnJhbWUsIE5vZGUqIGFzc2lzdGVkTm9kZSkKIHsKKyAgICBBU1NFUlQo IWFzc2lzdGVkTm9kZSB8fCAmYXNzaXN0ZWROb2RlLT5kb2N1bWVudCgpID09IGZyYW1lLT5kb2N1 bWVudCgpKTsKICAgICBjb25zdCBpbnQgREVGQVVMVF9DT05TVFJBSU5fSU5TRVQgPSAyOwogICAg IEludFJlY3QgaW5uZXJGcmFtZSA9IGlubmVyRnJhbWVRdWFkKGZyYW1lLCBhc3Npc3RlZE5vZGUp LmVuY2xvc2luZ0JvdW5kaW5nQm94KCk7CiAgICAgSW50UG9pbnQgY29uc3RyYWluZWRQb2ludCA9 IHBvaW50OwpAQCAtMjI2NCw2ICsyMjY1LDE2IEBAIHZvaWQgV2ViUGFnZTo6Z2V0QXNzaXN0ZWRO b2RlSW5mb3JtYXRpb24KICAgICB9CiB9CiAKK3ZvaWQgV2ViUGFnZTo6cmVzZXRBc3Npc3RlZE5v ZGVGb3JGcmFtZShXZWJGcmFtZSogZnJhbWUpCit7CisgICAgaWYgKCFtX2Fzc2lzdGVkTm9kZSkK KyAgICAgICAgcmV0dXJuOworICAgIGlmIChtX2Fzc2lzdGVkTm9kZS0+ZG9jdW1lbnQoKS5mcmFt ZSgpID09IGZyYW1lLT5jb3JlRnJhbWUoKSkgeworICAgICAgICBzZW5kKE1lc3NhZ2VzOjpXZWJQ YWdlUHJveHk6OlN0b3BBc3Npc3RpbmdOb2RlKCkpOworICAgICAgICBtX2Fzc2lzdGVkTm9kZSA9 IG51bGxwdHI7CisgICAgfQorfQorCiB2b2lkIFdlYlBhZ2U6OmVsZW1lbnREaWRGb2N1cyhXZWJD b3JlOjpOb2RlKiBub2RlKQogewogICAgIGlmIChub2RlLT5oYXNUYWdOYW1lKFdlYkNvcmU6OkhU TUxOYW1lczo6c2VsZWN0VGFnKSB8fCBub2RlLT5oYXNUYWdOYW1lKFdlYkNvcmU6OkhUTUxOYW1l czo6aW5wdXRUYWcpIHx8IG5vZGUtPmhhc1RhZ05hbWUoV2ViQ29yZTo6SFRNTE5hbWVzOjp0ZXh0 YXJlYVRhZykgfHwgbm9kZS0+aGFzRWRpdGFibGVTdHlsZSgpKSB7Cg==