141402 2015-02-09 14:31:55 -0800 Check for self-assignment in Length::operator=(const Length&) 2015-02-10 09:49:00 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez andersca commit-queue ddkilzer kling koivisto simon.fraser oldest_to_newest 1067912 0 cdumez 2015-02-09 14:31:55 -0800 Check for self-assignment in Length::operator=(const Length&) as calling memset() with the same source and destination addresses has undefined behavior. 1067915 1 246292 cdumez 2015-02-09 14:34:17 -0800 Created attachment 246292 Patch 1067918 2 246293 cdumez 2015-02-09 14:40:37 -0800 Created attachment 246293 Patch 1067967 3 246293 commit-queue 2015-02-09 17:17:48 -0800 Comment on attachment 246293 Patch Clearing flags on attachment: 246293 Committed r179860: <http://trac.webkit.org/changeset/179860> 1067968 4 commit-queue 2015-02-09 17:17:52 -0800 All reviewed patches have been landed. Closing bug. 1068079 5 ddkilzer 2015-02-10 09:18:06 -0800 (In reply to comment #0) > Check for self-assignment in Length::operator=(const Length&) as calling > memset() with the same source and destination addresses has undefined > behavior. On Darwin platforms (iOS, OS X), the undefined behavior has been well-defined as being identical to memmove(). (However, that's not true on other platforms, so it's still a good idea to fix this.) 1068089 6 cdumez 2015-02-10 09:49:00 -0800 (In reply to comment #5) > (In reply to comment #0) > > Check for self-assignment in Length::operator=(const Length&) as calling > > memset() with the same source and destination addresses has undefined > > behavior. > > On Darwin platforms (iOS, OS X), the undefined behavior has been > well-defined as being identical to memmove(). (However, that's not true on > other platforms, so it's still a good idea to fix this.) Oh, I did not know that. If I do a "man memcpy" on my Mac, it says "If dst and src overlap, behavior is undefined". 246292 2015-02-09 14:34:17 -0800 2015-02-09 14:40:33 -0800 Patch bug-141402-20150209143419.patch text/plain 1364 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5ODQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjVjY2QzODk2N2VhYmY0 ODhlZjY2MDgxZTNiN2I2Zjk1OTQ2MzllMC4uMjM2MDkwYjJlNjI3ZmNjNWIzYzBhYWU3YmQyNjFk NWYwNTdlNjcwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTAyLTA5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQ2hlY2sgZm9yIHNlbGYtYXNz aWdubWVudCBpbiBMZW5ndGg6Om9wZXJhdG9yPShjb25zdCBMZW5ndGgmKQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxNDAyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hlY2sgZm9yIHNlbGYtYXNzaWdu bWVudCBpbiBMZW5ndGg6Om9wZXJhdG9yPShjb25zdCBMZW5ndGgmKSBhcworICAgICAgICBjYWxs aW5nIG1lbXNldCgpIHdpdGggdGhlIHNhbWUgc291cmNlIGFuZCBkZXN0aW5hdGlvbiBhZGRyZXNz ZXMgaGFzCisgICAgICAgIHVuZGVmaW5lZCBiZWhhdmlvci4KKworICAgICAgICAqIHBsYXRmb3Jt L0xlbmd0aC5oOgorICAgICAgICAoV2ViQ29yZTo6TGVuZ3RoOjpvcGVyYXRvcj0pOgorCiAyMDE1 LTAyLTA3ICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CiAKICAgICAgICAgV2Vi R0wgMjogVGV4dHVyZSBjYWxsIGZvcm1hdCwgaW50ZXJuYWwgZm9ybWF0LCBhbmQgdHlwZSB2YWxp ZGF0aW9uLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTGVuZ3RoLmggYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9MZW5ndGguaAppbmRleCAwYWU1ZGE4NjkxYmIyYWYyNTg3 YzE1MTRiMDkyN2JlNzQyZmU2ZTZhLi4zYTk0NmNiNjBhYTAzY2RkNDk2N2I4MzQ0Y2U4OTVkY2E1 MTg1NmIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9MZW5ndGguaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9MZW5ndGguaApAQCAtMTc5LDYgKzE3OSw5IEBAIGlu bGluZSBMZW5ndGg6Okxlbmd0aChMZW5ndGgmJiBvdGhlcikKIAogaW5saW5lIExlbmd0aCYgTGVu Z3RoOjpvcGVyYXRvcj0oY29uc3QgTGVuZ3RoJiBvdGhlcikKIHsKKyAgICBpZiAodGhpcyA9PSAm b3RoZXIpCisgICAgICAgIHJldHVybiAqdGhpczsKKwogICAgIGlmIChvdGhlci5pc0NhbGN1bGF0 ZWQoKSkKICAgICAgICAgb3RoZXIucmVmKCk7CiAgICAgaWYgKGlzQ2FsY3VsYXRlZCgpKQo= 246293 2015-02-09 14:40:37 -0800 2015-02-09 17:17:48 -0800 Patch bug-141402-20150209144038.patch text/plain 1364 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5ODQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjVjY2QzODk2N2VhYmY0 ODhlZjY2MDgxZTNiN2I2Zjk1OTQ2MzllMC4uY2NlZjYzNDE4MTk3N2E3N2FjMTIyYzFlYTI4YTM3 ZWQyZTlmNjUwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTAyLTA5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQ2hlY2sgZm9yIHNlbGYtYXNz aWdubWVudCBpbiBMZW5ndGg6Om9wZXJhdG9yPShjb25zdCBMZW5ndGgmKQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxNDAyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hlY2sgZm9yIHNlbGYtYXNzaWdu bWVudCBpbiBMZW5ndGg6Om9wZXJhdG9yPShjb25zdCBMZW5ndGgmKSBhcworICAgICAgICBjYWxs aW5nIG1lbWNweSgpIHdpdGggdGhlIHNhbWUgc291cmNlIGFuZCBkZXN0aW5hdGlvbiBhZGRyZXNz ZXMgaGFzCisgICAgICAgIHVuZGVmaW5lZCBiZWhhdmlvci4KKworICAgICAgICAqIHBsYXRmb3Jt L0xlbmd0aC5oOgorICAgICAgICAoV2ViQ29yZTo6TGVuZ3RoOjpvcGVyYXRvcj0pOgorCiAyMDE1 LTAyLTA3ICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CiAKICAgICAgICAgV2Vi R0wgMjogVGV4dHVyZSBjYWxsIGZvcm1hdCwgaW50ZXJuYWwgZm9ybWF0LCBhbmQgdHlwZSB2YWxp ZGF0aW9uLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTGVuZ3RoLmggYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9MZW5ndGguaAppbmRleCAwYWU1ZGE4NjkxYmIyYWYyNTg3 YzE1MTRiMDkyN2JlNzQyZmU2ZTZhLi4zYTk0NmNiNjBhYTAzY2RkNDk2N2I4MzQ0Y2U4OTVkY2E1 MTg1NmIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9MZW5ndGguaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9MZW5ndGguaApAQCAtMTc5LDYgKzE3OSw5IEBAIGlu bGluZSBMZW5ndGg6Okxlbmd0aChMZW5ndGgmJiBvdGhlcikKIAogaW5saW5lIExlbmd0aCYgTGVu Z3RoOjpvcGVyYXRvcj0oY29uc3QgTGVuZ3RoJiBvdGhlcikKIHsKKyAgICBpZiAodGhpcyA9PSAm b3RoZXIpCisgICAgICAgIHJldHVybiAqdGhpczsKKwogICAgIGlmIChvdGhlci5pc0NhbGN1bGF0 ZWQoKSkKICAgICAgICAgb3RoZXIucmVmKCk7CiAgICAgaWYgKGlzQ2FsY3VsYXRlZCgpKQo=