141391 2015-02-09 10:20:19 -0800 AX: [Win] OBJID_CLIENT comparisons broken in 64-bit Builds 2015-02-09 12:27:52 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham webkit-bug-importer oldest_to_newest 1067849 0 bfulgham 2015-02-09 10:20:19 -0800 In all builds (64-bit and 32-bit), OBJID_CLIENT is defined as (LONG) 0xFFFFFFFC. However, testing indicates that the lParam value passed to WebKit from the operating system is sometimes passed as 0x0FFFFFFFC, and sometimes as 0xFFFFFFFFFFFFFFFC (depending on client software). This is probably a bug at the client program level (or perhaps even Windows itself), but we can guard against as follows: Instead of checking: lParam != OBJID_CLIENT we can truncate the value: static_cast<LONG>(lParam) != OBJID_CLIENT This will have no effect on our 32-bit builds, and ensure that our 64-bit builds are insulated against this problem. 1067850 1 webkit-bug-importer 2015-02-09 10:20:46 -0800 <rdar://problem/19767342> 1067853 2 246275 bfulgham 2015-02-09 10:23:48 -0800 Created attachment 246275 Patch 1067883 3 bfulgham 2015-02-09 12:27:52 -0800 Committed r179841: <http://trac.webkit.org/changeset/179841> 246275 2015-02-09 10:23:48 -0800 2015-02-09 10:27:24 -0800 Patch bug-141391-20150209103142.patch text/plain 1209 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3OTgzMikKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAyLTA5 ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIEFYOiBbV2lu XSBPQkpJRF9DTElFTlQgY29tcGFyaXNvbnMgYnJva2VuIGluIDY0LWJpdCBidWlsZHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MTM5MQorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMTk3NjczNDI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBXZWJWaWV3LmNwcDoKKyAgICAgICAgKFdlYlZpZXc6Om9u R2V0T2JqZWN0KTogQ2FzdCBsUGFyYW0gYXMgTE9ORyB0byBlbnN1cmUgcHJvcGVyIHdvcmQgc2l6 ZSBmb3IKKyAgICAgICAgY29tcGFyaXNvbiBhZ2FpbnN0IE9CSklEX0NMSUVOVC4KKwogMjAxNS0w Mi0wNyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBWZWN0 b3I6OnJlbW92ZUZpcnN0TWF0Y2hpbmcoKSAvIHJlbW92ZUFsbE1hdGNoaW5nKCkgbWV0aG9kcyB0 YWtpbmcgbGFtYmRhIGZ1bmN0aW9ucwpJbmRleDogU291cmNlL1dlYktpdC93aW4vV2ViVmlldy5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC93aW4vV2ViVmlldy5jcHAJKHJldmlzaW9u IDE3OTc1MCkKKysrIFNvdXJjZS9XZWJLaXQvd2luL1dlYlZpZXcuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC02MjgyLDcgKzYyODIsNyBAQCBib29sIFdlYlZpZXc6Om9uR2V0T2JqZWN0KFdQQVJBTSB3 UGFyYW0sCiB7CiAgICAgbFJlc3VsdCA9IDA7CiAKLSAgICBpZiAobFBhcmFtICE9IE9CSklEX0NM SUVOVCkKKyAgICBpZiAoc3RhdGljX2Nhc3Q8TE9ORz4obFBhcmFtKSAhPSBPQkpJRF9DTElFTlQp CiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIEFYT2JqZWN0Q2FjaGU6OmVuYWJsZUFjY2Vz c2liaWxpdHkoKTsK