141377 2015-02-08 16:22:05 -0800 Null deref in _clearImmediateActionState when closing a view with a DataDetectors popover open 2015-02-08 16:31:08 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca bdakin commit-queue mitz sam simon.fraser oldest_to_newest 1067725 0 thorton 2015-02-08 16:22:05 -0800 WebKit2 only; WebKit1 is safe because it's all ObjC messaging, so nil is fine. 1067726 1 thorton 2015-02-08 16:22:16 -0800 <rdar://problem/19711203> 1067727 2 246252 thorton 2015-02-08 16:22:59 -0800 Created attachment 246252 patch 1067728 3 commit-queue 2015-02-08 16:24:52 -0800 Attachment 246252 did not pass style-queue: ERROR: Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1067729 4 thorton 2015-02-08 16:31:08 -0800 Thanks, Darin! http://trac.webkit.org/changeset/179809 246252 2015-02-08 16:22:59 -0800 2015-02-08 16:26:27 -0800 patch null.diff text/plain 1640 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAzNjQ4MTQ5Li42MWRlOWM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTUtMDItMDggIFRpbW90aHkgSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29t PgorCisgICAgICAgIE51bGwgZGVyZWYgaW4gX2NsZWFySW1tZWRpYXRlQWN0aW9uU3RhdGUgd2hl biBjbG9zaW5nIGEgdmlldyB3aXRoIGEgRGF0YURldGVjdG9ycyBwb3BvdmVyIG9wZW4KKyAgICAg ICAgTmVlZCB0aGUgYnVnIFVSTCAoT09QUyEpLgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTk3 MTEyMDM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBVSVByb2Nlc3MvbWFjL1dLSW1tZWRpYXRlQWN0aW9uQ29udHJvbGxlci5tbToKKyAgICAgICAg KC1bV0tJbW1lZGlhdGVBY3Rpb25Db250cm9sbGVyIF9jbGVhckltbWVkaWF0ZUFjdGlvblN0YXRl XSk6CisgICAgICAgIFdlIGNhbiBoYXZlIGFscmVhZHkgZGV0YWNoZWQgdGhlIHBhZ2Ugd2hlbiBE YXRhRGV0ZWN0b3JzIGNhbGxzIHVzIGJhY2sKKyAgICAgICAgaW4gaW50ZXJhY3Rpb25TdG9wcGVk SGFuZGxlci4gV2hpbGUgd2UgaGF2ZSBrZXB0IGEgc3Ryb25nIHJlZmVyZW5jZSB0byB0aGUKKyAg ICAgICAgcGFnZSBpbiB0aGUgaW50ZXJhY3Rpb25TdG9wcGVkSGFuZGxlciBibG9jaywgX3BhZ2Ug aXMgbnVsbGVkIG91dC4KKyAgICAgICAgSXQncyBPSyB0byBhdm9pZCBkb2luZyB0aGlzIHdvcmss IGluIGFueSBjYXNlLCBiZWNhdXNlIGNsb3NpbmcgYSBwYWdlCisgICAgICAgIHRlYXJzIGRvd24g dGhlIFRleHRJbmRpY2F0b3IgYW55d2F5LgorCiAyMDE1LTAyLTA4ICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgW1dLMl0gQWRkIGxvZ2dpbmcgdG8gdmFsaWRhdGUg dGhlIG5ldHdvcmsgY2FjaGUgZWZmaWNhY3kgKFBhcnQgMSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tJbW1lZGlhdGVBY3Rpb25Db250cm9sbGVyLm1tIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XS0ltbWVkaWF0ZUFjdGlvbkNvbnRyb2xsZXIubW0K aW5kZXggYzFiODc5Zi4uMmM3YzkyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL21hYy9XS0ltbWVkaWF0ZUFjdGlvbkNvbnRyb2xsZXIubW0KKysrIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL21hYy9XS0ltbWVkaWF0ZUFjdGlvbkNvbnRyb2xsZXIubW0KQEAgLTExNSw3 ICsxMTUsOCBAQCB1c2luZyBuYW1lc3BhY2UgV2ViS2l0OwogCiAtICh2b2lkKV9jbGVhckltbWVk aWF0ZUFjdGlvblN0YXRlCiB7Ci0gICAgX3BhZ2UtPmNsZWFyVGV4dEluZGljYXRvcigpOworICAg IGlmIChfcGFnZSkKKyAgICAgICAgX3BhZ2UtPmNsZWFyVGV4dEluZGljYXRvcigpOwogCiAgICAg aWYgKF9jdXJyZW50QWN0aW9uQ29udGV4dCAmJiBfaGFzQWN0aXZhdGVkQWN0aW9uQ29udGV4dCkg ewogICAgICAgICBfaGFzQWN0aXZhdGVkQWN0aW9uQ29udGV4dCA9IE5POwo=