141364 2015-02-07 15:49:39 -0800 fullscreen/full-screen-plugin.html is very flaky on Yosemite WK2 2015-04-01 18:53:47 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified REOPENED https://bugs.webkit.org/show_bug.cgi?id=134489 P2 Normal --- 1 ap webkit-unassigned commit-queue koivisto zalan oldest_to_newest 1067587 0 ap 2015-02-07 15:49:39 -0800 fullscreen/full-screen-plugin.html fails on Yosemite WK2 about 50% of the time: <http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&showExpectations=true&revision=179781&tests=fullscreen%2Ffull-screen-plugin.html>. This test was added in <http://trac.webkit.org/r170717>. @@ -1,3 +1,3 @@ Test that plugin doesn't restart when taking it to full screen and back. -SUCCESS +FAIL 1067635 1 246230 ap 2015-02-07 19:41:14 -0800 Created attachment 246230 speculative fix 1067644 2 246230 commit-queue 2015-02-07 21:24:31 -0800 Comment on attachment 246230 speculative fix Clearing flags on attachment: 246230 Committed r179794: <http://trac.webkit.org/changeset/179794> 1067645 3 commit-queue 2015-02-07 21:24:36 -0800 All reviewed patches have been landed. Closing bug. 1067686 4 ap 2015-02-08 11:22:44 -0800 This made the test fail differently, shedding more light on why it failed before: -Test that plugin doesn't restart when taking it to full screen and back. -SUCCESS +CONSOLE MESSAGE: line 26: TypeError: undefined is not an object (evaluating 'testObject.property = 'foo'') +FAIL: Timed out waiting for notifyDone to be called Apparently, testObject is not necessarily available even by the time the load event fires. 1067687 5 246244 ap 2015-02-08 11:28:49 -0800 Created attachment 246244 second try 1067701 6 246244 sam 2015-02-08 13:37:57 -0800 Comment on attachment 246244 second try View in context: https://bugs.webkit.org/attachment.cgi?id=246244&action=review > LayoutTests/fullscreen/full-screen-plugin.html:65 > +function checkForPlugin() > +{ > + var plugin = document.getElementById('plugin'); > + if (plugin.testObject) > + test(); > + else > + setTimeout(checkForPlugin, 100); > +} It seems like it might make sense for the test plugin to have a way to indicate it is ready without the need to poll. Maybe the plugin could look for a predefined function name (e.g. function pluginIsAvailable()) and call it when it has been instantiated. I can't imagine this is the only place where this mistake is made. 1067734 7 ap 2015-02-08 17:19:14 -0800 I thought that plug-ins were supposed to be available in onload, however maybe some of the async layout patches broke that. Or maybe it never worked correctly in WebKit. 1067735 8 246244 commit-queue 2015-02-08 17:20:42 -0800 Comment on attachment 246244 second try Rejecting attachment 246244 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 246244, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/5013007134359552 1067736 9 ap 2015-02-08 17:25:31 -0800 Committed <http://trac.webkit.org/r179811>. 1068213 10 ap 2015-02-10 18:12:43 -0800 Hmm, it still fails. @@ -1,3 +1,2 @@ -Test that plugin doesn't restart when taking it to full screen and back. -SUCCESS +FAIL: Timed out waiting for notifyDone to be called 1069562 11 ap 2015-02-16 13:47:48 -0800 Marked as flaky in <http://trac.webkit.org/changeset/180170>. Antti, this is a test for your fix, please make it work correctly if you can. 246230 2015-02-07 19:41:14 -0800 2015-02-07 21:24:31 -0800 speculative fix PluginFullScreen.txt text/plain 1783 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE3OTc5MykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTAyLTA3ICBBbGV4ZXkgUHJvc2t1cnlh a292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIGZ1bGxzY3JlZW4vZnVsbC1zY3JlZW4tcGx1 Z2luLmh0bWwgaXMgdmVyeSBmbGFreSBvbiBZb3NlbWl0ZSBXSzIKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MTM2NAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNwZWN1bGF0aXZlIGZpeC4gTWFrZSBzdXJl IHRoYXQgdGhlIHBsdWctaW4gaGFzIGxvYWRlZCBiZWZvcmUgdXNpbmcgaXQuCisKKyAgICAgICAg KiBmdWxsc2NyZWVuL2Z1bGwtc2NyZWVuLXBsdWdpbi5odG1sOgorCiAyMDE1LTAyLTA3ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBzb21lIGRp Y3Rpb25hcnkgbG9va3VwIHRlc3RzCkluZGV4OiBMYXlvdXRUZXN0cy9mdWxsc2NyZWVuL2Z1bGwt c2NyZWVuLXBsdWdpbi5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Z1bGxzY3JlZW4v ZnVsbC1zY3JlZW4tcGx1Z2luLmh0bWwJKHJldmlzaW9uIDE3OTc4MikKKysrIExheW91dFRlc3Rz L2Z1bGxzY3JlZW4vZnVsbC1zY3JlZW4tcGx1Z2luLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTYs MTIgKzYsMTIgQEAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7CiA8L3NjcmlwdD4KIDxkaXY+CiAg ICAgPGRpdj5UZXN0IHRoYXQgcGx1Z2luIGRvZXNuJ3QgcmVzdGFydCB3aGVuIHRha2luZyBpdCB0 byBmdWxsIHNjcmVlbiBhbmQgYmFjay48L2Rpdj4KLSAgICA8ZGl2IGlkPSJyZXN1bHQiPlRlc3Qg ZGlkbid0IHJ1bic8L2Rpdj4KKyAgICA8ZGl2IGlkPSJyZXN1bHQiPlRlc3QgZGlkbid0IHJ1bjwv ZGl2PgogICAgIDxlbWJlZCBpZD0icGx1Z2luIiB0eXBlPSJhcHBsaWNhdGlvbi94LXdlYmtpdC10 ZXN0LW5ldHNjYXBlIiB3aWR0aD0iMjAwIiBoZWlnaHQ9IjIwMCI+PC9lbWJlZD4KIDwvZGl2Pgog CiA8c2NyaXB0PgotaWYgKCJ3ZWJraXRSZXF1ZXN0RnVsbFNjcmVlbiIgaW4gRWxlbWVudC5wcm90 b3R5cGUpIHsKK29ubG9hZCA9IGZ1bmN0aW9uKCkgewogICAgIHZhciBjYWxsYmFjazsKICAgICB2 YXIgZnVsbHNjcmVlbkNoYW5nZWQgPSBmdW5jdGlvbihldmVudCkKICAgICB7CkBAIC0yMyw2ICsy Myw3IEBAIGlmICgid2Via2l0UmVxdWVzdEZ1bGxTY3JlZW4iIGluIEVsZW1lbnQKICAgICBkb2N1 bWVudC5ib2R5Lm9mZnNldFRvcDsKICAgICB2YXIgcGx1Z2luID0gZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoJ3BsdWdpbicpOwogICAgIHZhciB0ZXN0T2JqZWN0ID0gcGx1Z2luLnRlc3RPYmplY3Q7 CisgICAgdGVzdE9iamVjdC5wcm9wZXJ0eSA9ICdmb28nOyAvLyBWZXJpZnkgdGhhdCBzZXR0aW5n IGEgcHJvcGVydHkgd29ya3MgYmVmb3JlIGdvaW5nIGZ1bGxzY3JlZW4uCiAKICAgICB2YXIgc3Bh bkVudGVyZWRGdWxsU2NyZWVuID0gZnVuY3Rpb24oZXZlbnQpIHsKICAgICAgICAgc2V0VGltZW91 dChmdW5jdGlvbiAoKSB7Cg== 246244 2015-02-08 11:28:49 -0800 2015-02-08 17:20:42 -0800 second try FullScreen2.txt text/plain 1396 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE3OTc5OSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE1LTAyLTA4ICBBbGV4ZXkgUHJvc2t1cnlh a292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIGZ1bGxzY3JlZW4vZnVsbC1zY3JlZW4tcGx1 Z2luLmh0bWwgaXMgdmVyeSBmbGFreSBvbiBZb3NlbWl0ZSBXSzIKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MTM2NAorCisgICAgICAgIE1ha2UgdGhl IHRlc3Qgd2FpdCBmb3IgdGhlIHBsdWctaW4gdG8gYmVjb21lIGF2YWlsYWJsZS4KKworICAgICAg ICAqIGZ1bGxzY3JlZW4vZnVsbC1zY3JlZW4tcGx1Z2luLmh0bWw6CisKIDIwMTUtMDItMDggIEFs ZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgaHR0cC90ZXN0cy9z ZWN1cml0eS9hcHBjYWNoZS1pbi1wcml2YXRlLWJyb3dzaW5nLmh0bWwgaXMgZmxha3kKSW5kZXg6 IExheW91dFRlc3RzL2Z1bGxzY3JlZW4vZnVsbC1zY3JlZW4tcGx1Z2luLmh0bWwKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1wbHVnaW4uaHRtbAkocmV2 aXNpb24gMTc5Nzk5KQorKysgTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1wbHVn aW4uaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMTEsNyArMTEsOCBAQCBpZiAod2luZG93LnRlc3RS dW5uZXIpIHsKIDwvZGl2PgogCiA8c2NyaXB0Pgotb25sb2FkID0gZnVuY3Rpb24oKSB7CitmdW5j dGlvbiB0ZXN0KCkKK3sKICAgICB2YXIgY2FsbGJhY2s7CiAgICAgdmFyIGZ1bGxzY3JlZW5DaGFu Z2VkID0gZnVuY3Rpb24oZXZlbnQpCiAgICAgewpAQCAtNTMsNCArNTQsMTYgQEAgb25sb2FkID0g ZnVuY3Rpb24oKSB7CiAgICAgaWYgKHdpbmRvdy5ldmVudFNlbmRlcikKICAgICAgICAgZXZlbnRT ZW5kZXIua2V5RG93bignYScpOwogfQorCitmdW5jdGlvbiBjaGVja0ZvclBsdWdpbigpCit7Cisg ICAgdmFyIHBsdWdpbiA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdwbHVnaW4nKTsKKyAgICBp ZiAocGx1Z2luLnRlc3RPYmplY3QpCisgICAgICAgIHRlc3QoKTsKKyAgICBlbHNlCisgICAgICAg IHNldFRpbWVvdXQoY2hlY2tGb3JQbHVnaW4sIDEwMCk7Cit9CisKK3dpbmRvdy5vbmxvYWQgPSBj aGVja0ZvclBsdWdpbjsKKwogPC9zY3JpcHQ+Cg==