141362 2015-02-07 14:35:52 -0800 Use a PairHash for DFGByteCodeParser's ConstantBufferKey 2015-02-07 15:49:14 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 benjamin benjamin oldest_to_newest 1067569 0 benjamin 2015-02-07 14:35:52 -0800 Use a PairHash for DFGByteCodeParser's ConstantBufferKey 1067570 1 246218 benjamin 2015-02-07 14:37:22 -0800 Created attachment 246218 Patch 1067586 2 246218 darin 2015-02-07 15:49:14 -0800 Comment on attachment 246218 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246218&action=review > Source/JavaScriptCore/ChangeLog:10 > + Use nullptr for pointers when possible. Seems like we’d also want to use member initialization rather than initializing in each constructor. Makes it harder to accidentally leave m_codeBlock uninitialized. > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:84 > + return WTF::pairIntHash(PtrHash<CodeBlock*>::hash(m_codeBlock), IntHash<unsigned>::hash(m_index)); Doesn’t pairIntHash already do enough hashing that we don’t need the IntHash<unsigned>::hash here? Also, that could just be WTF::intHash(m_index). I’m also not sure why HashFunctions.h doesn’t do using WTF::intHash and WTF::pairIntHash. No reason for us to be inconsistent about things like that. 246218 2015-02-07 14:37:22 -0800 2015-02-07 15:49:14 -0800 Patch bug-141362-20150207143721.patch text/plain 2679 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5NzgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj ODFmOTZmMmFjYzQzZWViOGU4ZTlmNGNhYjVmN2IxMGQwZDhmYWM3Li43YzhlNGViNTM3YWRhYjY3 NTVkOGJjYzIzOTQ3YmQzM2U3NDQyMDhjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMyBAQAogMjAxNS0wMi0wNyAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtp dC5vcmc+CiAKKyAgICAgICAgVXNlIGEgUGFpckhhc2ggZm9yIERGR0J5dGVDb2RlUGFyc2VyJ3Mg Q29uc3RhbnRCdWZmZXJLZXkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE0MTM2MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcDoKKyAgICAgICAgKEpTQzo6REZH OjpDb25zdGFudEJ1ZmZlcktleTo6Q29uc3RhbnRCdWZmZXJLZXkpOgorICAgICAgICBVc2UgbnVs bHB0ciBmb3IgcG9pbnRlcnMgd2hlbiBwb3NzaWJsZS4KKworICAgICAgICAoSlNDOjpERkc6OkNv bnN0YW50QnVmZmVyS2V5OjpvcGVyYXRvcj09KToKKyAgICAgICAgV2ViS2l0IHN0eWxlLgorCisg ICAgICAgIChKU0M6OkRGRzo6Q29uc3RhbnRCdWZmZXJLZXk6Omhhc2gpOgorICAgICAgICBUaGlz IGtpbmQgb2YgaGFzaCB0dXJuZWQgb3V0IHByZXR0eSBiYWQgZm9yIFdlYkNvcmUuIFRyeSBhIHN0 YW5kYXJkCisgICAgICAgIGhhc2ggZm9yIHRoZSBwYWlyLgorCisyMDE1LTAyLTA3ICBCZW5qYW1p biBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KKwogICAgICAgICBSZW1vdmUgdXNlbGVz cyBkZWNsYXJhdGlvbnMgYW5kIGEgc3RhbGUgY29tbWVudCBmcm9tIERGR0J5dGVDb2RlUGFyc2Vy LmgKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MTM2 MQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0J5dGVDb2RlUGFy c2VyLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3Bw CmluZGV4IGExMDg4OWJjNjIyYmQwYmQwYzQxNmIxMTFkY2FjNjZjNGY2MzcxOWYuLmY3OGFkZGJk NTAzY2EwNjA2MDhiN2MyOGRkYTk3YWYxMTBjY2MxOTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwCkBAIC01Nyw0MiArNTcsNDEgQEAgc3Rh dGljIGNvbnN0IGJvb2wgdmVyYm9zZSA9IGZhbHNlOwogY2xhc3MgQ29uc3RhbnRCdWZmZXJLZXkg ewogcHVibGljOgogICAgIENvbnN0YW50QnVmZmVyS2V5KCkKLSAgICAgICAgOiBtX2NvZGVCbG9j aygwKQorICAgICAgICA6IG1fY29kZUJsb2NrKG51bGxwdHIpCiAgICAgICAgICwgbV9pbmRleCgw KQogICAgIHsKICAgICB9Ci0gICAgCisKICAgICBDb25zdGFudEJ1ZmZlcktleShXVEY6Okhhc2hU YWJsZURlbGV0ZWRWYWx1ZVR5cGUpCi0gICAgICAgIDogbV9jb2RlQmxvY2soMCkKKyAgICAgICAg OiBtX2NvZGVCbG9jayhudWxscHRyKQogICAgICAgICAsIG1faW5kZXgoMSkKICAgICB7CiAgICAg fQotICAgIAorCiAgICAgQ29uc3RhbnRCdWZmZXJLZXkoQ29kZUJsb2NrKiBjb2RlQmxvY2ssIHVu c2lnbmVkIGluZGV4KQogICAgICAgICA6IG1fY29kZUJsb2NrKGNvZGVCbG9jaykKICAgICAgICAg LCBtX2luZGV4KGluZGV4KQogICAgIHsKICAgICB9Ci0gICAgCisKICAgICBib29sIG9wZXJhdG9y PT0oY29uc3QgQ29uc3RhbnRCdWZmZXJLZXkmIG90aGVyKSBjb25zdAogICAgIHsKLSAgICAgICAg cmV0dXJuIG1fY29kZUJsb2NrID09IG90aGVyLm1fY29kZUJsb2NrCi0gICAgICAgICAgICAmJiBt X2luZGV4ID09IG90aGVyLm1faW5kZXg7CisgICAgICAgIHJldHVybiBtX2NvZGVCbG9jayA9PSBv dGhlci5tX2NvZGVCbG9jayAmJiBtX2luZGV4ID09IG90aGVyLm1faW5kZXg7CiAgICAgfQotICAg IAorCiAgICAgdW5zaWduZWQgaGFzaCgpIGNvbnN0CiAgICAgewotICAgICAgICByZXR1cm4gV1RG OjpQdHJIYXNoPENvZGVCbG9jayo+OjpoYXNoKG1fY29kZUJsb2NrKSBeIG1faW5kZXg7CisgICAg ICAgIHJldHVybiBXVEY6OnBhaXJJbnRIYXNoKFB0ckhhc2g8Q29kZUJsb2NrKj46Omhhc2gobV9j b2RlQmxvY2spLCBJbnRIYXNoPHVuc2lnbmVkPjo6aGFzaChtX2luZGV4KSk7CiAgICAgfQotICAg IAorCiAgICAgYm9vbCBpc0hhc2hUYWJsZURlbGV0ZWRWYWx1ZSgpIGNvbnN0CiAgICAgewogICAg ICAgICByZXR1cm4gIW1fY29kZUJsb2NrICYmIG1faW5kZXg7CiAgICAgfQotICAgIAorCiAgICAg Q29kZUJsb2NrKiBjb2RlQmxvY2soKSBjb25zdCB7IHJldHVybiBtX2NvZGVCbG9jazsgfQogICAg IHVuc2lnbmVkIGluZGV4KCkgY29uc3QgeyByZXR1cm4gbV9pbmRleDsgfQotICAgIAorCiBwcml2 YXRlOgogICAgIENvZGVCbG9jayogbV9jb2RlQmxvY2s7CiAgICAgdW5zaWduZWQgbV9pbmRleDsK