141352 2015-02-06 23:25:43 -0800 ASan complains about plugins/snapshotting/snapshot-plugin-not-quite-blocked-by-image.html 2015-02-07 12:56:02 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap benjamin bfulgham commit-queue esprehn+autocc kangil.han roger_fong oldest_to_newest 1067502 0 ap 2015-02-06 23:25:43 -0800 ASan complains about an out of bounds read on plugins/snapshotting/snapshot-plugin-not-quite-blocked-by-image.html rdar://problem/19717490 1067503 1 246200 ap 2015-02-06 23:31:57 -0800 Created attachment 246200 proposed fix 1067546 2 ap 2015-02-07 11:36:50 -0800 I'm going to assume that the Windows EWS failure is a random flake. The actual error is not visible in the truncated log. 1067553 3 246200 commit-queue 2015-02-07 12:21:29 -0800 Comment on attachment 246200 proposed fix Clearing flags on attachment: 246200 Committed r179783: <http://trac.webkit.org/changeset/179783> 1067554 4 commit-queue 2015-02-07 12:21:36 -0800 All reviewed patches have been landed. Closing bug. 1067555 5 246200 darin 2015-02-07 12:55:46 -0800 Comment on attachment 246200 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=246200&action=review > Source/WebCore/dom/Document.cpp:6274 > + jsString = String(plugInsJavaScript, sizeof(plugInsJavaScript)); It would be more efficient to call StringImpl::createWithoutCopying here instead of the String constructor. No need to copy the file. 1067556 6 246200 darin 2015-02-07 12:56:02 -0800 Comment on attachment 246200 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=246200&action=review >> Source/WebCore/dom/Document.cpp:6274 >> + jsString = String(plugInsJavaScript, sizeof(plugInsJavaScript)); > > It would be more efficient to call StringImpl::createWithoutCopying here instead of the String constructor. No need to copy the file. Copy the characters, I mean. 246200 2015-02-06 23:31:57 -0800 2015-02-07 12:21:29 -0800 proposed fix PluginsResourcesData.txt text/plain 1410 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3OTc3NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTAyLTA2ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIEFTYW4gY29tcGxhaW5zIGFi b3V0IHBsdWdpbnMvc25hcHNob3R0aW5nL3NuYXBzaG90LXBsdWdpbi1ub3QtcXVpdGUtYmxvY2tl ZC1ieS1pbWFnZS5odG1sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDEzNTIKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMTk3MTc0OTAKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGRvbS9Eb2N1bWVudC5j cHA6IChXZWJDb3JlOjpEb2N1bWVudDo6ZW5zdXJlUGx1Z0luc0luamVjdGVkU2NyaXB0KTogVGhp cyBzdHJpbmcKKyAgICAgICAgaXMgbm90IG51bGwgdGVybWluYXRlZC4KKwogMjAxNS0wMi0wNiAg WmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIEFTU0VSVCByZXBhaW50 Q29udGFpbmVyLT5oYXNMYXllcigpIGluIFdlYkNvcmU6OlJlbmRlck9iamVjdDo6cmVwYWludFVz aW5nQ29udGFpbmVyCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAJKHJldmlzaW9uIDE3OTc3 NikKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTYyNzEsNyArNjI3MSw3IEBAIHZvaWQgRG9jdW1lbnQ6OmVuc3VyZVBsdWdJbnNJbmplY3RlZFNj cmkKICAgICAvLyBVc2UgdGhlIEpTIGZpbGUgcHJvdmlkZWQgYnkgdGhlIENocm9tZSBjbGllbnQs IG9yIGZhbGxiYWNrIHRvIHRoZSBkZWZhdWx0IG9uZS4KICAgICBTdHJpbmcganNTdHJpbmcgPSBw YWdlKCktPmNocm9tZSgpLmNsaWVudCgpLnBsdWdJbkV4dHJhU2NyaXB0KCk7CiAgICAgaWYgKCFq c1N0cmluZykKLSAgICAgICAganNTdHJpbmcgPSBwbHVnSW5zSmF2YVNjcmlwdDsKKyAgICAgICAg anNTdHJpbmcgPSBTdHJpbmcocGx1Z0luc0phdmFTY3JpcHQsIHNpemVvZihwbHVnSW5zSmF2YVNj cmlwdCkpOwogCiAgICAgbV9mcmFtZS0+bWFpbkZyYW1lKCkuc2NyaXB0KCkuZXZhbHVhdGVJbldv cmxkKFNjcmlwdFNvdXJjZUNvZGUoanNTdHJpbmcpLCB3b3JsZCk7CiAK