141349 2015-02-06 17:23:27 -0800 dashboard: BuildbotTesterQueueView crashesOnly logic is wrong 2015-02-06 20:35:40 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dburkart dburkart ap commit-queue dburkart ddkilzer oldest_to_newest 1067474 0 dburkart 2015-02-06 17:23:27 -0800 We should be testing for layoutTestResults.crashCount, not iteration.crashCount, as that's an invalid property on the BuildbotIteration object. 1067476 1 246194 dburkart 2015-02-06 17:30:27 -0800 Created attachment 246194 Fix crashesOnly logic 1067490 2 246194 commit-queue 2015-02-06 20:35:37 -0800 Comment on attachment 246194 Fix crashesOnly logic Clearing flags on attachment: 246194 Committed r179775: <http://trac.webkit.org/changeset/179775> 1067491 3 commit-queue 2015-02-06 20:35:40 -0800 All reviewed patches have been landed. Closing bug. 246194 2015-02-06 17:30:27 -0800 2015-02-06 20:35:37 -0800 Fix crashesOnly logic bug_141349.patch text/plain 3044 dburkart SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3OTc3MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE1LTAyLTA2ICBEYW5hIEJ1cmthcnQgIDxkYnVya2FydEBhcHBsZS5jb20+ CisKKyAgICAgICAgZGFzaGJvYXJkOiBCdWlsZGJvdFRlc3RlclF1ZXVlVmlldyBjcmFzaGVzT25s eSBsb2dpYyBpcyB3cm9uZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTQxMzQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJs aWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdFRlc3RlclF1ZXVlVmlldy5qczoKKyAg ICAgICAgKEJ1aWxkYm90VGVzdGVyUXVldWVWaWV3LnByb3RvdHlwZS51cGRhdGUuYXBwZW5kQnVp bGRlclF1ZXVlU3RhdHVzKToKKyAgICAgICAgKEJ1aWxkYm90VGVzdGVyUXVldWVWaWV3LnByb3Rv dHlwZS51cGRhdGUpOgorCiAyMDE1LTAyLTA2ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBw bGUuY29tPgogCiAgICAgICAgIFJlcG9ydCBuZXR3b3JrIHByb2Nlc3MgY3Jhc2hlcyBkdXJpbmcg bGF5b3V0IHRlc3RzCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQu b3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdFRlc3RlclF1 ZXVlVmlldy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53 ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdFRl c3RlclF1ZXVlVmlldy5qcwkocmV2aXNpb24gMTc5NzcxKQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1 cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1Njcmlw dHMvQnVpbGRib3RUZXN0ZXJRdWV1ZVZpZXcuanMJKHdvcmtpbmcgY29weSkKQEAgLTc5LDEyICs3 OSwxMiBAQCBCdWlsZGJvdFRlc3RlclF1ZXVlVmlldy5wcm90b3R5cGUgPSB7CiAgICAgICAgICAg ICAgICAgfSBlbHNlIGlmICghaXRlcmF0aW9uLnByb2R1Y3RpdmUpIHsKICAgICAgICAgICAgICAg ICAgICAgdmFyIHVybCA9IGl0ZXJhdGlvbi5xdWV1ZS5idWlsZGJvdC5idWlsZFBhZ2VVUkxGb3JJ dGVyYXRpb24oaXRlcmF0aW9uKTsKICAgICAgICAgICAgICAgICAgICAgdmFyIHN0YXR1cyA9IG5l dyBTdGF0dXNMaW5lVmlldyhtZXNzYWdlRWxlbWVudCwgU3RhdHVzTGluZVZpZXcuU3RhdHVzLkRh bmdlciwgaXRlcmF0aW9uLnRleHQsIHVuZGVmaW5lZCwgdXJsKTsKLSAgICAgICAgICAgICAgICB9 IGVsc2UgaWYgKHF1ZXVlLmNyYXNoZXNPbmx5ICYmICFpdGVyYXRpb24uY3Jhc2hDb3VudCkgewor ICAgICAgICAgICAgICAgIH0gZWxzZSBpZiAocXVldWUuY3Jhc2hlc09ubHkgJiYgIWxheW91dFRl c3RSZXN1bHRzLmNyYXNoQ291bnQpIHsKICAgICAgICAgICAgICAgICAgICAgdmFyIHVybCA9IGl0 ZXJhdGlvbi5xdWV1ZS5idWlsZGJvdC5idWlsZFBhZ2VVUkxGb3JJdGVyYXRpb24oaXRlcmF0aW9u KTsKICAgICAgICAgICAgICAgICAgICAgdmFyIHN0YXR1cyA9IG5ldyBTdGF0dXNMaW5lVmlldyht ZXNzYWdlRWxlbWVudCwgU3RhdHVzTGluZVZpZXcuU3RhdHVzLkdvb2QsICJubyBjcmFzaGVzIGZv dW5kIiwgdW5kZWZpbmVkLCB1cmwpOwotICAgICAgICAgICAgICAgIH0gZWxzZSBpZiAocXVldWUu Y3Jhc2hlc09ubHkgJiYgaXRlcmF0aW9uLmNyYXNoQ291bnQpIHsKKyAgICAgICAgICAgICAgICB9 IGVsc2UgaWYgKHF1ZXVlLmNyYXNoZXNPbmx5ICYmIGxheW91dFRlc3RSZXN1bHRzLmNyYXNoQ291 bnQpIHsKICAgICAgICAgICAgICAgICAgICAgdmFyIHVybCA9IGl0ZXJhdGlvbi5xdWV1ZS5idWls ZGJvdC5sYXlvdXRUZXN0UmVzdWx0c1VSTEZvckl0ZXJhdGlvbihpdGVyYXRpb24pOwotICAgICAg ICAgICAgICAgICAgICB2YXIgc3RhdHVzID0gbmV3IFN0YXR1c0xpbmVWaWV3KG1lc3NhZ2VFbGVt ZW50LCBTdGF0dXNMaW5lVmlldy5TdGF0dXMuQmFkLCBsYXlvdXRUZXN0UmVzdWx0cy5mYWlsdXJl Q291bnQgPT09IDEgPyAiY3Jhc2ggZm91bmQiIDogImNyYXNoZXMgZm91bmQiLCB1bmRlZmluZWQs IHVybCk7CisgICAgICAgICAgICAgICAgICAgIHZhciBzdGF0dXMgPSBuZXcgU3RhdHVzTGluZVZp ZXcobWVzc2FnZUVsZW1lbnQsIFN0YXR1c0xpbmVWaWV3LlN0YXR1cy5CYWQsIGxheW91dFRlc3RS ZXN1bHRzLmNyYXNoQ291bnQgPT09IDEgPyAiY3Jhc2ggZm91bmQiIDogImNyYXNoZXMgZm91bmQi LCBsYXlvdXRUZXN0UmVzdWx0cy5jcmFzaENvdW50LCB1cmwpOwogICAgICAgICAgICAgICAgICAg ICBuZXcgUG9wb3ZlclRyYWNrZXIoc3RhdHVzLnN0YXR1c0J1YmJsZUVsZW1lbnQsIHRoaXMuX3By ZXNlbnRQb3BvdmVyRm9yTGF5b3V0VGVzdFJlZ3Jlc3Npb25zLmJpbmQodGhpcyksIGl0ZXJhdGlv bik7CiAgICAgICAgICAgICAgICAgfSBlbHNlIGlmICghbGF5b3V0VGVzdFJlc3VsdHMuZmFpbHVy ZUNvdW50ICYmICFqYXZhc2NyaXB0VGVzdFJlc3VsdHMuZmFpbHVyZUNvdW50ICYmICFhcGlUZXN0 UmVzdWx0cy5mYWlsdXJlQ291bnQgJiYgIXBsYXRmb3JtQVBJVGVzdFJlc3VsdHMuZmFpbHVyZUNv dW50ICYmICFweXRob25UZXN0UmVzdWx0cy5mYWlsdXJlQ291bnQgJiYgIXBlcmxUZXN0UmVzdWx0 cy5lcnJvck9jY3VycmVkICYmICFiaW5kaW5nVGVzdFJlc3VsdHMuZXJyb3JPY2N1cnJlZCkgewog ICAgICAgICAgICAgICAgICAgICAvLyBTb21ldGhpbmcgd3JvbmcgaGFwcGVuZWQsIGJ1dCBpdCB3 YXMgbm90IGEgdGVzdCBmYWlsdXJlLgo=