141348 2015-02-06 17:02:07 -0800 Have SQLiteStatement::database() return a reference 2015-02-06 19:07:04 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez commit-queue japhet kling oldest_to_newest 1067467 0 cdumez 2015-02-06 17:02:07 -0800 Have SQLiteStatement::database() return a reference 1067468 1 246193 cdumez 2015-02-06 17:03:27 -0800 Created attachment 246193 Patch 1067469 2 commit-queue 2015-02-06 17:05:32 -0800 Attachment 246193 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1067480 3 246193 kling 2015-02-06 17:45:23 -0800 Comment on attachment 246193 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246193&action=review okay! > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). OOPS! 1067486 4 cdumez 2015-02-06 19:07:04 -0800 Committed r179774: <http://trac.webkit.org/changeset/179774> 246193 2015-02-06 17:03:27 -0800 2015-02-06 17:45:23 -0800 Patch bug-141348-20150206170326.patch text/plain 5468 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5NzY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2EzMWNhZjc3ZjNjMjI0 NTFlMWIyYmEwZWFmYWExNDk2M2MwNThlNy4uNGVlZWY5ZjQ0MTBlMTRkY2VkYzAyMGU4NjQ5OWQx MTM5NjhjNmY5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTAyLTA2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgSGF2ZSBTUUxpdGVTdGF0ZW1l bnQ6OmRhdGFiYXNlKCkgcmV0dXJuIGEgcmVmZXJlbmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDEzNDgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE9PUFMhKS4KKworICAgICAg ICBIYXZlIFNRTGl0ZVN0YXRlbWVudDo6ZGF0YWJhc2UoKSByZXR1cm4gYSByZWZlcmVuY2UgYXMg aXQgY2FuIG5ldmVyCisgICAgICAgIHJldHVybiBudWxsLgorCisgICAgICAgICogbG9hZGVyL2lj b24vSWNvbkRhdGFiYXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnJlYWR5U1FMaXRlU3RhdGVt ZW50KToKKyAgICAgICAgKiBwbGF0Zm9ybS9zcWwvU1FMaXRlU3RhdGVtZW50Lmg6CisgICAgICAg IChXZWJDb3JlOjpTUUxpdGVTdGF0ZW1lbnQ6OmRhdGFiYXNlKToKKwogMjAxNS0wMi0wNiAgQnJl bnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBJbXBsZW1l bnQgYXVkaW8gdHJhY2sgc2VsZWN0aW9uIGluIGZ1bGxzY3JlZW4uCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMGJh OTZmNjgzZjliZDIxZDQ5NTZlMjVmNWQ5N2RiNTBiZjRkMzE5YS4uZDAwYzQ4NzdmMWQ5ZDI4MjFl YjU4MTMyNTg4N2JlZjgyZTU5YzEzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1 LTAyLTA2ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgSGF2ZSBT UUxpdGVTdGF0ZW1lbnQ6OmRhdGFiYXNlKCkgcmV0dXJuIGEgcmVmZXJlbmNlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDEzNDgKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBIYXZlIFNRTGl0ZVN0YXRlbWVu dDo6ZGF0YWJhc2UoKSByZXR1cm4gYSByZWZlcmVuY2UgYXMgaXQgY2FuIG5ldmVyCisgICAgICAg IHJldHVybiBudWxsLgorCisgICAgICAgICogRGF0YWJhc2VQcm9jZXNzL0luZGV4ZWREQi9zcWxp dGUvU1FMaXRlSURCQ3Vyc29yLmNwcDoKKyAgICAgICAgKFdlYktpdDo6U1FMaXRlSURCQ3Vyc29y OjppbnRlcm5hbEFkdmFuY2VPbmNlKToKKwogMjAxNS0wMi0wNiAgQWxleGV5IFByb3NrdXJ5YWtv diAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXBvcnQgbmV0d29yayBwcm9jZXNzIGNyYXNo ZXMgZHVyaW5nIGxheW91dCB0ZXN0cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVy L2ljb24vSWNvbkRhdGFiYXNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9pY29uL0ljb25E YXRhYmFzZS5jcHAKaW5kZXggOTgzOGVhNjU1NThiY2VhNmMyOWI0ZDQ3Y2YxNjU3NDQ0NmFkMzQ3 Yi4uYzI5NzRmMTNmZmUxMGUyMTgxMzU2ODYwZmU1ZjViZjJiMjMwOTM2YSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvbG9hZGVyL2ljb24vSWNvbkRhdGFiYXNlLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9sb2FkZXIvaWNvbi9JY29uRGF0YWJhc2UuY3BwCkBAIC0xODEyLDcgKzE4MTIsNyBA QCB2b2lkKiBJY29uRGF0YWJhc2U6OmNsZWFudXBTeW5jVGhyZWFkKCkKIC8vIDIgLSBMYXp5IGNv bnN0cnVjdGlvbiBvZiB0aGUgU3RhdGVtZW50IGluIHRoZSBmaXJzdCBwbGFjZSwgaW4gY2FzZSB3 ZSd2ZSBuZXZlciBtYWRlIHRoaXMgcXVlcnkgYmVmb3JlCiBpbmxpbmUgdm9pZCByZWFkeVNRTGl0 ZVN0YXRlbWVudChzdGQ6OnVuaXF1ZV9wdHI8U1FMaXRlU3RhdGVtZW50PiYgc3RhdGVtZW50LCBT UUxpdGVEYXRhYmFzZSYgZGIsIGNvbnN0IFN0cmluZyYgc3RyKQogewotICAgIGlmIChzdGF0ZW1l bnQgJiYgKHN0YXRlbWVudC0+ZGF0YWJhc2UoKSAhPSAmZGIgfHwgc3RhdGVtZW50LT5pc0V4cGly ZWQoKSkpIHsKKyAgICBpZiAoc3RhdGVtZW50ICYmICgmc3RhdGVtZW50LT5kYXRhYmFzZSgpICE9 ICZkYiB8fCBzdGF0ZW1lbnQtPmlzRXhwaXJlZCgpKSkgewogICAgICAgICBpZiAoc3RhdGVtZW50 LT5pc0V4cGlyZWQoKSkKICAgICAgICAgICAgIExPRyhJY29uRGF0YWJhc2UsICJTUUxpdGVTdGF0 ZW1lbnQgYXNzb2NpYXRlZCB3aXRoICVzIGlzIGV4cGlyZWQiLCBzdHIuYXNjaWkoKS5kYXRhKCkp OwogICAgICAgICBzdGF0ZW1lbnQgPSBudWxscHRyOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vc3FsL1NRTGl0ZVN0YXRlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vc3FsL1NRTGl0ZVN0YXRlbWVudC5oCmluZGV4IDg0NTM1ZjczMTliOWQ5MjFjMjg5MDljNDZj Mzg0ZmY5YWQyZTc5NGQuLjRjYmRkNzdlNDc0OWY4OGJhOWI2ODYyNzc2MjgzNmZjNDNlOWJiYjAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3NxbC9TUUxpdGVTdGF0ZW1lbnQu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zcWwvU1FMaXRlU3RhdGVtZW50LmgKQEAg LTkwLDcgKzkwLDcgQEAgcHVibGljOgogICAgIGJvb2wgcmV0dXJuSW50NjRSZXN1bHRzKGludCBj b2wsIFZlY3RvcjxpbnQ2NF90PiYpOwogICAgIGJvb2wgcmV0dXJuRG91YmxlUmVzdWx0cyhpbnQg Y29sLCBWZWN0b3I8ZG91YmxlPiYpOwogCi0gICAgU1FMaXRlRGF0YWJhc2UqIGRhdGFiYXNlKCkg eyByZXR1cm4gJm1fZGF0YWJhc2U7IH0KKyAgICBTUUxpdGVEYXRhYmFzZSYgZGF0YWJhc2UoKSB7 IHJldHVybiBtX2RhdGFiYXNlOyB9CiAgICAgCiAgICAgY29uc3QgU3RyaW5nJiBxdWVyeSgpIGNv bnN0IHsgcmV0dXJuIG1fcXVlcnk7IH0KICAgICAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L0RhdGFiYXNlUHJvY2Vzcy9JbmRleGVkREIvc3FsaXRlL1NRTGl0ZUlEQkN1cnNvci5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9EYXRhYmFzZVByb2Nlc3MvSW5kZXhlZERCL3NxbGl0ZS9TUUxpdGVJREJD dXJzb3IuY3BwCmluZGV4IDI1M2JkNWMxYzEzOTJhNTFhZjYwMWFmZTlmNTFmYTQxODRkNmRkM2Iu LjY2YTU2NGVjMTYxZTFhM2ZiMzhiNDkxOTBkNzkyYzU0ZjY0ZTNkN2MgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL0RhdGFiYXNlUHJvY2Vzcy9JbmRleGVkREIvc3FsaXRlL1NRTGl0ZUlEQkN1 cnNvci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvRGF0YWJhc2VQcm9jZXNzL0luZGV4ZWREQi9z cWxpdGUvU1FMaXRlSURCQ3Vyc29yLmNwcApAQCAtMzI5LDEyICszMjksMTIgQEAgU1FMaXRlSURC Q3Vyc29yOjpBZHZhbmNlUmVzdWx0IFNRTGl0ZUlEQkN1cnNvcjo6aW50ZXJuYWxBZHZhbmNlT25j ZSgpCiAgICAgICAgICAgICByZXR1cm4gQWR2YW5jZVJlc3VsdDo6RmFpbHVyZTsKICAgICAgICAg fQogCi0gICAgICAgIFNRTGl0ZVN0YXRlbWVudCBvYmplY3RTdG9yZVN0YXRlbWVudCgqbV9zdGF0 ZW1lbnQtPmRhdGFiYXNlKCksICJTRUxFQ1QgdmFsdWUgRlJPTSBSZWNvcmRzIFdIRVJFIGtleSA9 IENBU1QoPyBBUyBURVhUKSBhbmQgb2JqZWN0U3RvcmVJRCA9ID87Iik7CisgICAgICAgIFNRTGl0 ZVN0YXRlbWVudCBvYmplY3RTdG9yZVN0YXRlbWVudChtX3N0YXRlbWVudC0+ZGF0YWJhc2UoKSwg IlNFTEVDVCB2YWx1ZSBGUk9NIFJlY29yZHMgV0hFUkUga2V5ID0gQ0FTVCg/IEFTIFRFWFQpIGFu ZCBvYmplY3RTdG9yZUlEID0gPzsiKTsKIAogICAgICAgICBpZiAob2JqZWN0U3RvcmVTdGF0ZW1l bnQucHJlcGFyZSgpICE9IFNRTFJlc3VsdE9rCiAgICAgICAgICAgICB8fCBvYmplY3RTdG9yZVN0 YXRlbWVudC5iaW5kQmxvYigxLCBtX2N1cnJlbnRWYWx1ZUJ1ZmZlci5kYXRhKCksIG1fY3VycmVu dFZhbHVlQnVmZmVyLnNpemUoKSkgIT0gU1FMUmVzdWx0T2sKICAgICAgICAgICAgIHx8IG9iamVj dFN0b3JlU3RhdGVtZW50LmJpbmRJbnQ2NCgyLCBtX29iamVjdFN0b3JlSUQpICE9IFNRTFJlc3Vs dE9rKSB7Ci0gICAgICAgICAgICBMT0dfRVJST1IoIkNvdWxkIG5vdCBjcmVhdGUgaW5kZXggY3Vy c29yIHN0YXRlbWVudCBpbnRvIG9iamVjdCBzdG9yZSByZWNvcmRzICglaSkgJyVzJyIsIG1fc3Rh dGVtZW50LT5kYXRhYmFzZSgpLT5sYXN0RXJyb3IoKSwgbV9zdGF0ZW1lbnQtPmRhdGFiYXNlKCkt Pmxhc3RFcnJvck1zZygpKTsKKyAgICAgICAgICAgIExPR19FUlJPUigiQ291bGQgbm90IGNyZWF0 ZSBpbmRleCBjdXJzb3Igc3RhdGVtZW50IGludG8gb2JqZWN0IHN0b3JlIHJlY29yZHMgKCVpKSAn JXMnIiwgbV9zdGF0ZW1lbnQtPmRhdGFiYXNlKCkubGFzdEVycm9yKCksIG1fc3RhdGVtZW50LT5k YXRhYmFzZSgpLmxhc3RFcnJvck1zZygpKTsKICAgICAgICAgICAgIG1fY29tcGxldGVkID0gdHJ1 ZTsKICAgICAgICAgICAgIG1fZXJyb3JlZCA9IHRydWU7CiAgICAgICAgICAgICByZXR1cm4gQWR2 YW5jZVJlc3VsdDo6RmFpbHVyZTsKQEAgLTM0OSw3ICszNDksNyBAQCBTUUxpdGVJREJDdXJzb3I6 OkFkdmFuY2VSZXN1bHQgU1FMaXRlSURCQ3Vyc29yOjppbnRlcm5hbEFkdmFuY2VPbmNlKCkKICAg ICAgICAgICAgIC8vIFNraXAgb3ZlciBpdC4KICAgICAgICAgICAgIHJldHVybiBBZHZhbmNlUmVz dWx0OjpTaG91bGRBZHZhbmNlQWdhaW47CiAgICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICBM T0dfRVJST1IoIkNvdWxkIG5vdCBzdGVwIGluZGV4IGN1cnNvciBzdGF0ZW1lbnQgaW50byBvYmpl Y3Qgc3RvcmUgcmVjb3JkcyAoJWkpICclcyciLCBtX3N0YXRlbWVudC0+ZGF0YWJhc2UoKS0+bGFz dEVycm9yKCksIG1fc3RhdGVtZW50LT5kYXRhYmFzZSgpLT5sYXN0RXJyb3JNc2coKSk7CisgICAg ICAgICAgICBMT0dfRVJST1IoIkNvdWxkIG5vdCBzdGVwIGluZGV4IGN1cnNvciBzdGF0ZW1lbnQg aW50byBvYmplY3Qgc3RvcmUgcmVjb3JkcyAoJWkpICclcyciLCBtX3N0YXRlbWVudC0+ZGF0YWJh c2UoKS5sYXN0RXJyb3IoKSwgbV9zdGF0ZW1lbnQtPmRhdGFiYXNlKCkubGFzdEVycm9yTXNnKCkp OwogICAgICAgICAgICAgbV9jb21wbGV0ZWQgPSB0cnVlOwogICAgICAgICAgICAgbV9lcnJvcmVk ID0gdHJ1ZTsKICAgICAgICAgICAgIHJldHVybiBBZHZhbmNlUmVzdWx0OjpGYWlsdXJlOwo=