141343 2015-02-06 15:38:34 -0800 REGRESSION(r179705): 2nd-level inspector availability no longer controlled by DeveloperExtrasEnabled user default 2015-02-09 08:37:50 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All OS X 10.10 RESOLVED FIXED InRadar P2 Normal --- 1 burg burg commit-queue graouts joepeck jonowells kling mattbaker nvasilyev sam timothy webkit-bug-importer oldest_to_newest 1067441 0 burg 2015-02-06 15:38:34 -0800 There might be a mismatch in prefix keys between two WebPreferences instances. Instance (1) is made by lazy initialization of WKWebViewConfiguration's WebPreferences, using prefix of "WebKit" (WKPreferences:init) Instance (2) is made by the inspector WKWebView's WebPageGroup, using prefix of ".WebKit2" (WebPageGroup::WebPageGroup). Both instances appear to read from NSUserDefaults. We manually set DeveloperExtrasEnabled on instance (1) before calling WKWebView:initWithFrame and that has the intended effect, so this instance is probably the one to worry about. When stepping through WebPreferences::platformInitialize(), it seems that the if (!m_identifier) test fails, so only the debug preferences (enumerated by FOR_EACH_WEBKIT_DEBUG_PREFERENCE) are populated from user defaults. 1067442 1 webkit-bug-importer 2015-02-06 15:38:50 -0800 <rdar://problem/19751830> 1067643 2 246233 burg 2015-02-07 21:03:51 -0800 Created attachment 246233 Patch 1067820 3 burg 2015-02-09 07:57:13 -0800 Updated instructions at <https://trac.webkit.org/wiki/HackingWebInspector> to reflect new keys. However, we probably need to move the LogsPageMessagesToSystemConsoleEnabled key to the DEBUG group as well. 1067827 4 246233 commit-queue 2015-02-09 08:37:44 -0800 Comment on attachment 246233 Patch Clearing flags on attachment: 246233 Committed r179828: <http://trac.webkit.org/changeset/179828> 1067828 5 commit-queue 2015-02-09 08:37:50 -0800 All reviewed patches have been landed. Closing bug. 246233 2015-02-07 21:03:51 -0800 2015-02-09 08:37:44 -0800 Patch bug-141343-20150207210350.patch text/plain 3284 burg U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5NzUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzA1OGU0N2IwMWRjNDhm MzQ3MDhiZTc3NGU3NjgxNmJkNmY4OWYzZS4uMWZmYWRjZGRlZjhkYjkzZGZmMTlhMjczZmM5NmI4 NTE3OGJjNGUwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE1LTAyLTA3ICBCcmlh biBKLiBCdXJnICA8YnVyZ0Bjcy53YXNoaW5ndG9uLmVkdT4KKworICAgICAgICBSRUdSRVNTSU9O KHIxNzk3MDUpOiAybmQtbGV2ZWwgaW5zcGVjdG9yIGF2YWlsYWJpbGl0eSBubyBsb25nZXIgY29u dHJvbGxlZCBieSBEZXZlbG9wZXJFeHRyYXNFbmFibGVkIHVzZXIgZGVmYXVsdAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxMzQzCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHJlZ3Jlc3Npb24gd2Fz IGNhdXNlZCBieSB0aGUgc3dpdGNoIHRvIHVzaW5nIFdLV2ViVmlld0NvbmZpZ3VyYXRpb24gYW5k CisgICAgICAgIGl0cyBkZWZhdWx0IFdlYlByZWZlcmVuY2VzIG9iamVjdCwgd2hpY2ggaXMgdXNl ZCB0byBwb3B1bGF0ZSB0aGUgaW5zcGVjdG9yIHBhZ2UncworICAgICAgICBTZXR0aW5ncyBvYmpl Y3QuIFRoaXMgV2ViUHJlZmVyZW5jZXMgaXMgaW5pdGlhbGl6ZWQgd2l0aCBubyBpZGVudGlmaWVy LCBzbworICAgICAgICBvbmx5IHByZWZlcmVuY2VzIGluIHRoZSBGT1JfRUFDSF9XRUJLSVRfREVC VUdfKl9QUkVGRVJFTkNFIG1hY3JvcyBhcmUgcG9wdWxhdGVkCisgICAgICAgIGZyb20gTlNVc2Vy RGVmYXVsdHMuCisKKyAgICAgICAgVGhlIHNpbXBsZXN0IGZpeCBpcyB0byBtb3ZlIERldmVsb3Bl ckV4dHJhc0VuYWJsZWQgaW50byB0aGUgREVCVUcgZ3JvdXAuCisKKyAgICAgICAgUHJldmlvdXNs eSwgZWFjaCBpbnNwZWN0b3IgbGV2ZWwgaGFkIGEgdW5pcXVlIGlkZW50aWZpZXIgc3VjaCBhcwor ICAgICAgICBfX1dlYkluc3BlY3RvclBhZ2VHcm91cExldmVsTl9fLCBhbmQgdGhlIG4rMSBsZXZl bCBpbnNwZWN0b3Igd2FzIGVuYWJsZWQKKyAgICAgICAgYnkgdG9nZ2xpbmcgX19XZWJJbnNwZWN0 b3JQYWdlR3JvdXBMZXZlbE5fXy5XZWJLaXQyRGV2ZWxvcGVyRXhyYXNFbmFibGVkLgorICAgICAg ICBXaXRoIHRoZSBtb3ZlIHRvIHRoZSBERUJVRyBncm91cCwgdGhlIHByZWZlcmVuY2UgYmVjb21l cyBzaW1wbHkKKyAgICAgICAgV2ViS2l0RGV2ZWxvcGVyRXh0cmFzRW5hYmxlZCwgd2hpY2ggZW5h YmxlcyBhbnkgbGV2ZWwgb2YgaW5zcGVjdG9yLgorICAgICAgICAoVGhpcyBkb2VzIG5vdCBjbGFz aCB3aXRoIFNhZmFyaSdzICJTaG93IERldmVsb3AgTWVudSIgcHJlZmVyZW5jZSwgd2hpY2ggdXNl cworICAgICAgICB0aGUga2V5ICJXZWJLaXREZXZlbG9wZXJFeHRyYXNFbmFibGVkUHJlZmVyZW5j ZUtleSIpCisKKyAgICAgICAgKiBTaGFyZWQvV2ViUHJlZmVyZW5jZXNEZWZpbml0aW9ucy5oOgor CiAyMDE1LTAyLTA1ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KIAogICAg ICAgICBTdXBwb3J0IG92ZXJyaWRpbmcgdGhlIGRldmljZVNjYWxlRmFjdG9yIHBlciBXS1dlYlZp ZXcvV0tWaWV3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViUHJlZmVyZW5j ZXNEZWZpbml0aW9ucy5oIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVm aW5pdGlvbnMuaAppbmRleCAwZTNiNTY3ZTRmZDllMWZlNjU3Y2M5OGRlZGVmMzAwMjFhZTRkZThi Li43MTA5YTA0ZTYwMmIzNzk0YTA1MjY2MjQ1NGU2ZWUwNTJkYWRhODRlIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViUHJlZmVyZW5jZXNEZWZpbml0aW9ucy5oCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJQcmVmZXJlbmNlc0RlZmluaXRpb25zLmgKQEAgLTk1LDcg Kzk1LDYgQEAKICAgICBtYWNybyhEYXRhYmFzZXNFbmFibGVkLCBkYXRhYmFzZXNFbmFibGVkLCBC b29sLCBib29sLCB0cnVlKSBcCiAgICAgbWFjcm8oWFNTQXVkaXRvckVuYWJsZWQsIHhzc0F1ZGl0 b3JFbmFibGVkLCBCb29sLCBib29sLCB0cnVlKSBcCiAgICAgbWFjcm8oRnJhbWVGbGF0dGVuaW5n RW5hYmxlZCwgZnJhbWVGbGF0dGVuaW5nRW5hYmxlZCwgQm9vbCwgYm9vbCwgREVGQVVMVF9GUkFN RV9GTEFUVEVOSU5HX0VOQUJMRUQpIFwKLSAgICBtYWNybyhEZXZlbG9wZXJFeHRyYXNFbmFibGVk LCBkZXZlbG9wZXJFeHRyYXNFbmFibGVkLCBCb29sLCBib29sLCBmYWxzZSkgXAogICAgIG1hY3Jv KEphdmFTY3JpcHRFeHBlcmltZW50c0VuYWJsZWQsIGphdmFTY3JpcHRFeHBlcmltZW50c0VuYWJs ZWQsIEJvb2wsIGJvb2wsIGZhbHNlKSBcCiAgICAgbWFjcm8oUHJpdmF0ZUJyb3dzaW5nRW5hYmxl ZCwgcHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCwgQm9vbCwgYm9vbCwgZmFsc2UpIFwKICAgICBtYWNy byhUZXh0QXJlYXNBcmVSZXNpemFibGUsIHRleHRBcmVhc0FyZVJlc2l6YWJsZSwgQm9vbCwgYm9v bCwgREVGQVVMVF9URVhUX0FSRUFTX0FSRV9SRVNJWkFCTEUpIFwKQEAgLTIyNiw2ICsyMjUsNyBA QAogICAgIG1hY3JvKENvbXBvc2l0aW5nUmVwYWludENvdW50ZXJzVmlzaWJsZSwgY29tcG9zaXRp bmdSZXBhaW50Q291bnRlcnNWaXNpYmxlLCBCb29sLCBib29sLCBmYWxzZSkgXAogICAgIG1hY3Jv KFRpbGVkU2Nyb2xsaW5nSW5kaWNhdG9yVmlzaWJsZSwgdGlsZWRTY3JvbGxpbmdJbmRpY2F0b3JW aXNpYmxlLCBCb29sLCBib29sLCBmYWxzZSkgXAogICAgIG1hY3JvKFNpbXBsZUxpbmVMYXlvdXRE ZWJ1Z0JvcmRlcnNFbmFibGVkLCBzaW1wbGVMaW5lTGF5b3V0RGVidWdCb3JkZXJzRW5hYmxlZCwg Qm9vbCwgYm9vbCwgZmFsc2UpIFwKKyAgICBtYWNybyhEZXZlbG9wZXJFeHRyYXNFbmFibGVkLCBk ZXZlbG9wZXJFeHRyYXNFbmFibGVkLCBCb29sLCBib29sLCBmYWxzZSkgXAogICAgIG1hY3JvKExv Z3NQYWdlTWVzc2FnZXNUb1N5c3RlbUNvbnNvbGVFbmFibGVkLCBsb2dzUGFnZU1lc3NhZ2VzVG9T eXN0ZW1Db25zb2xlRW5hYmxlZCwgQm9vbCwgYm9vbCwgZmFsc2UpIFwKICAgICBtYWNybyhJZ25v cmVWaWV3cG9ydFNjYWxpbmdDb25zdHJhaW50cywgaWdub3JlVmlld3BvcnRTY2FsaW5nQ29uc3Ry YWludHMsIEJvb2wsIGJvb2wsIGZhbHNlKSBcCiAgICAgXAo=