141334 2015-02-06 11:11:16 -0800 Web Inspector: BasicBlockAnnotator ranges should be inclusive of both the start and end offset 2015-02-23 15:18:50 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 141095 1 saam saam commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1067380 0 saam 2015-02-06 11:11:16 -0800 This should land in concert with this JSC change: https://bugs.webkit.org/show_bug.cgi?id=141095 1067381 1 webkit-bug-importer 2015-02-06 11:11:41 -0800 <rdar://problem/19747067> 1067384 2 246168 saam 2015-02-06 11:47:30 -0800 Created attachment 246168 the patch 1067385 3 246168 joepeck 2015-02-06 11:50:14 -0800 Comment on attachment 246168 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=246168&action=review r=me > Source/WebInspectorUI/UserInterface/Views/TextEditor.js:464 > + var options = { Meh, could be inlined still =) 1068110 4 246334 saam 2015-02-10 12:05:39 -0800 Created attachment 246334 patch Patch slightly changed. I don't think CodeMirror Actually respects the inclusiveLeft/Right options. I tried all variations of the 2^2=4 assignments to inclusiveLeft/Right and I couldn't get the text marking to behave any differently. I couldn't figure out why this is, it may be worth filing a bug with CodeMirror if this is indeed the case. Anyways, I found that if you have a text range [start, end], then the range that CodeMirror actually marks is such: [start, end). This patch compensates for this by adding one to the end position's offset. 1068123 5 246334 timothy 2015-02-10 13:10:26 -0800 Comment on attachment 246334 patch You should file a CodeMirror bug with a simple test case. 1071362 6 246334 commit-queue 2015-02-23 15:18:45 -0800 Comment on attachment 246334 patch Clearing flags on attachment: 246334 Committed r180526: <http://trac.webkit.org/changeset/180526> 1071363 7 commit-queue 2015-02-23 15:18:50 -0800 All reviewed patches have been landed. Closing bug. 246168 2015-02-06 11:47:30 -0800 2015-02-10 12:05:39 -0800 the patch patch.diff text/plain 1616 saam SW5kZXg6IFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwkocmV2aXNpb24gMTc5NzUwKQorKysgU291cmNl L1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE1LTAyLTA2ICBTYWFtIEJhcmF0aSAgPHNhYW1iYXJhdGkxQGdtYWlsLmNvbT4KKworICAg ICAgICBXZWIgSW5zcGVjdG9yOiBCYXNpY0Jsb2NrQW5ub3RhdG9yIHJhbmdlcyBzaG91bGQgYmUg aW5jbHVzaXZlIG9mIGJvdGggdGhlIHN0YXJ0IGFuZCBlbmQgb2Zmc2V0CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDEzMzQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3Mv VGV4dEVkaXRvci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yLnByb3RvdHlw ZS5hZGRTdHlsZVRvVGV4dFJhbmdlKToKKwogMjAxNS0wMi0wNCAgSm9ubyBXZWxscyAgPGpvbm93 ZWxsc0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVTU0lPTjogSW5s aW5lIFNvdXJjZU1hcCByZXNvdXJjZXMgc2hvdyBlbXB0eSBjb250ZW50IHdoZW4gb3BlbmVkLgpJ bmRleDogU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGV4dEVkaXRv ci5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9UZXh0RWRpdG9yLmpzCShyZXZpc2lvbiAxNzk2NzkpCisrKyBTb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UZXh0RWRpdG9yLmpzCSh3b3JraW5nIGNvcHkpCkBA IC00NjEsNyArNDYxLDEzIEBAIFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yLnByb3RvdHlwZSA9IHsK IAogICAgIGFkZFN0eWxlVG9UZXh0UmFuZ2U6IGZ1bmN0aW9uKHN0YXJ0UG9zaXRpb24sIGVuZFBv c2l0aW9uLCBzdHlsZUNsYXNzTmFtZSkKICAgICB7Ci0gICAgICAgIHJldHVybiB0aGlzLl9jb2Rl TWlycm9yLmdldERvYygpLm1hcmtUZXh0KHN0YXJ0UG9zaXRpb24sIGVuZFBvc2l0aW9uLCB7Y2xh c3NOYW1lOiBzdHlsZUNsYXNzTmFtZX0pOworICAgICAgICB2YXIgb3B0aW9ucyA9IHsKKyAgICAg ICAgICAgIGNsYXNzTmFtZTogc3R5bGVDbGFzc05hbWUsCisgICAgICAgICAgICBpbmNsdXNpdmVM ZWZ0OiB0cnVlLAorICAgICAgICAgICAgaW5jbHVzaXZlUmlnaHQ6IHRydWUKKyAgICAgICAgfTsK KworICAgICAgICByZXR1cm4gdGhpcy5fY29kZU1pcnJvci5nZXREb2MoKS5tYXJrVGV4dChzdGFy dFBvc2l0aW9uLCBlbmRQb3NpdGlvbiwgb3B0aW9ucyk7CiAgICAgfSwKIAogICAgIHJldmVhbFBv c2l0aW9uOiBmdW5jdGlvbihwb3NpdGlvbiwgdGV4dFJhbmdlVG9TZWxlY3QsIGZvcmNlVW5mb3Jt YXR0ZWQsIG5vSGlnaGxpZ2h0KQo= 246334 2015-02-10 12:05:39 -0800 2015-02-23 15:18:45 -0800 patch patch.diff text/plain 1567 saam SW5kZXg6IFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwkocmV2aXNpb24gMTc5ODc1KQorKysgU291cmNl L1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE1LTAyLTEwICBTYWFtIEJhcmF0aSAgPHNhYW1iYXJhdGkxQGdtYWlsLmNvbT4KKworICAg ICAgICBXZWIgSW5zcGVjdG9yOiBCYXNpY0Jsb2NrQW5ub3RhdG9yIHJhbmdlcyBzaG91bGQgYmUg aW5jbHVzaXZlIG9mIGJvdGggdGhlIHN0YXJ0IGFuZCBlbmQgb2Zmc2V0CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDEzMzQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3Mv VGV4dEVkaXRvci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yLnByb3RvdHlw ZS5hZGRTdHlsZVRvVGV4dFJhbmdlKToKKwogMjAxNS0wMi0wOSAgQnJpYW4gSi4gQnVyZyAgPGJ1 cmdAY3Mud2FzaGluZ3Rvbi5lZHU+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogVW5jYXVnaHQg ZXhjZXB0aW9uIHdoZW4gcmVwb3J0aW5nIHdyb25nIGJhY2tlbmQgY29tbWFuZCBjYWxsIHNpZ25h dHVyZQpJbmRleDogU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGV4 dEVkaXRvci5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9UZXh0RWRpdG9yLmpzCShyZXZpc2lvbiAxNzk4NzIpCisrKyBTb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UZXh0RWRpdG9yLmpzCSh3b3JraW5nIGNv cHkpCkBAIC00NjEsNyArNDYxLDggQEAgV2ViSW5zcGVjdG9yLlRleHRFZGl0b3IucHJvdG90eXBl ID0gewogCiAgICAgYWRkU3R5bGVUb1RleHRSYW5nZTogZnVuY3Rpb24oc3RhcnRQb3NpdGlvbiwg ZW5kUG9zaXRpb24sIHN0eWxlQ2xhc3NOYW1lKQogICAgIHsKLSAgICAgICAgcmV0dXJuIHRoaXMu X2NvZGVNaXJyb3IuZ2V0RG9jKCkubWFya1RleHQoc3RhcnRQb3NpdGlvbiwgZW5kUG9zaXRpb24s IHtjbGFzc05hbWU6IHN0eWxlQ2xhc3NOYW1lfSk7CisgICAgICAgIGVuZFBvc2l0aW9uLmNoICs9 IDE7CisgICAgICAgIHJldHVybiB0aGlzLl9jb2RlTWlycm9yLmdldERvYygpLm1hcmtUZXh0KHN0 YXJ0UG9zaXRpb24sIGVuZFBvc2l0aW9uLCB7Y2xhc3NOYW1lOiBzdHlsZUNsYXNzTmFtZSwgaW5j bHVzaXZlTGVmdDogdHJ1ZSwgaW5jbHVzaXZlUmlnaHQ6IHRydWV9KTsKICAgICB9LAogCiAgICAg cmV2ZWFsUG9zaXRpb246IGZ1bmN0aW9uKHBvc2l0aW9uLCB0ZXh0UmFuZ2VUb1NlbGVjdCwgZm9y Y2VVbmZvcm1hdHRlZCwgbm9IaWdobGlnaHQpCg==