141333 2015-02-06 08:53:23 -0800 REGRESSION(r179705): [GTK] The Web Inspector doesn't work after r179705 2015-02-09 00:02:46 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned burg timothy oldest_to_newest 1067362 0 cgarcia 2015-02-06 08:53:23 -0800 The unit tests are timing out and the inspector doesn't show up in MiniBrowser either. It seems that after r179705 the initial attach message is never received in the UI process. 1067373 1 burg 2015-02-06 10:05:38 -0800 The following code was moved out of the static PageGroup management code. It was re-added in a platform-specific way for PLATFORM(MAC), so maybe it has to be re-added to GTK/EFL when the PageGroup is constructed. (On Mac, Inspector now uses WKWebView which only takes the group identifier. So we first construct the view, then adjust prefs, then do the initial load.) #ifndef NDEBUG // Allow developers to inspect the Web Inspector in debug builds without changing settings. pageGroup->preferences().setDeveloperExtrasEnabled(true); pageGroup->preferences().setLogsPageMessagesToSystemConsoleEnabled(true); #endif pageGroup->preferences().setAllowFileAccessFromFileURLs(true); 1067664 2 cgarcia 2015-02-08 04:23:02 -0800 Yes, that was it, thanks! 1067665 3 246240 cgarcia 2015-02-08 04:23:25 -0800 Created attachment 246240 Patch 1067766 4 cgarcia 2015-02-09 00:02:46 -0800 Committed r179821: <http://trac.webkit.org/changeset/179821> 246240 2015-02-08 04:23:25 -0800 2015-02-08 13:32:35 -0800 Patch wk2-inspector.diff text/plain 2291 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBhOTAzNjIzLi45NTU3OGVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTUtMDItMDggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04ocjE3OTcwNSk6IFtHVEtdIFRoZSBXZWIgSW5zcGVjdG9y IGRvZXNuJ3Qgd29yayBhZnRlciByMTc5NzA1CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNDEzMzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBDcmVhdGUgYW4gaW5pdGlhbGl6ZSBXZWJQcmVmZXJlbmNlcyBm b3IgdGhlIGluc3BlY3RvciBwYWdlLiBUaGlzCisgICAgICAgIHdhcyBtb3ZlZCBmcm9tIGNyb3Nz LXBsYXRmb3JtIGNvZGUgdG8gcGxhdGZvcm0gc3BlY2lmaWMgY29kZS4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9ndGsvV2ViSW5zcGVjdG9yUHJveHlHdGsuY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJJbnNwZWN0b3JQcm94eTo6cGxhdGZvcm1DcmVhdGVJbnNwZWN0b3JQYWdlKToKKwogMjAxNS0w Mi0wNiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAg ICAgW0dUS10gUmVtb3ZlIFdlYktpdFdlYlZpZXc6OmNsb3NlLW5vdGlmaWNhdGlvbiBzaWduYWwK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvV2ViSW5zcGVjdG9yUHJv eHlHdGsuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2d0ay9XZWJJbnNwZWN0b3JQcm94 eUd0ay5jcHAKaW5kZXggYzQ0NmY0MS4uZTRhMmI1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL2d0ay9XZWJJbnNwZWN0b3JQcm94eUd0ay5jcHAKKysrIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL2d0ay9XZWJJbnNwZWN0b3JQcm94eUd0ay5jcHAKQEAgLTYxLDkgKzYx LDE4IEBAIFdlYlBhZ2VQcm94eSogV2ViSW5zcGVjdG9yUHJveHk6OnBsYXRmb3JtQ3JlYXRlSW5z cGVjdG9yUGFnZSgpCiB7CiAgICAgQVNTRVJUKGluc3BlY3RlZFBhZ2UoKSk7CiAgICAgQVNTRVJU KCFtX2luc3BlY3RvclZpZXcpOwotICAgIFJlZlB0cjxXZWJQYWdlR3JvdXA+IHBhZ2VHcm91cCA9 IFdlYlBhZ2VHcm91cDo6Y3JlYXRlKGluc3BlY3RvclBhZ2VHcm91cElkZW50aWZpZXIoKSwgZmFs c2UsIGZhbHNlKS5sZWFrUmVmKCk7Ci0gICAgbV9pbnNwZWN0b3JWaWV3ID0gR1RLX1dJREdFVCh3 ZWJraXRXZWJWaWV3QmFzZUNyZWF0ZSgmaW5zcGVjdG9yUHJvY2Vzc1Bvb2woKSwgbnVsbHB0ciwg cGFnZUdyb3VwLmdldCgpLCBudWxscHRyLCBudWxscHRyKSk7CisKKyAgICBSZWZQdHI8V2ViUHJl ZmVyZW5jZXM+IHByZWZlcmVuY2VzID0gV2ViUHJlZmVyZW5jZXM6OmNyZWF0ZShTdHJpbmcoKSwg IldlYktpdDIuIiwgIldlYktpdDIuIik7CisjaWZuZGVmIE5ERUJVRworICAgIC8vIEFsbG93IGRl dmVsb3BlcnMgdG8gaW5zcGVjdCB0aGUgV2ViIEluc3BlY3RvciBpbiBkZWJ1ZyBidWlsZHMgd2l0 aG91dCBjaGFuZ2luZyBzZXR0aW5ncy4KKyAgICBwcmVmZXJlbmNlcy0+c2V0RGV2ZWxvcGVyRXh0 cmFzRW5hYmxlZCh0cnVlKTsKKyAgICBwcmVmZXJlbmNlcy0+c2V0TG9nc1BhZ2VNZXNzYWdlc1Rv U3lzdGVtQ29uc29sZUVuYWJsZWQodHJ1ZSk7CisjZW5kaWYKKyAgICBwcmVmZXJlbmNlcy0+c2V0 QWxsb3dGaWxlQWNjZXNzRnJvbUZpbGVVUkxzKHRydWUpOworICAgIFJlZlB0cjxXZWJQYWdlR3Jv dXA+IHBhZ2VHcm91cCA9IFdlYlBhZ2VHcm91cDo6Y3JlYXRlKGluc3BlY3RvclBhZ2VHcm91cElk ZW50aWZpZXIoKSwgZmFsc2UsIGZhbHNlKTsKKyAgICBtX2luc3BlY3RvclZpZXcgPSBHVEtfV0lE R0VUKHdlYmtpdFdlYlZpZXdCYXNlQ3JlYXRlKCZpbnNwZWN0b3JQcm9jZXNzUG9vbCgpLCBwcmVm ZXJlbmNlcy5nZXQoKSwgcGFnZUdyb3VwLmdldCgpLCBudWxscHRyLCBudWxscHRyKSk7CiAgICAg Z19vYmplY3RfYWRkX3dlYWtfcG9pbnRlcihHX09CSkVDVChtX2luc3BlY3RvclZpZXcpLCByZWlu dGVycHJldF9jYXN0PHZvaWQqKj4oJm1faW5zcGVjdG9yVmlldykpOworCiAgICAgcmV0dXJuIHdl YmtpdFdlYlZpZXdCYXNlR2V0UGFnZShXRUJLSVRfV0VCX1ZJRVdfQkFTRShtX2luc3BlY3RvclZp ZXcpKTsKIH0KIAo=