141327 2015-02-06 02:17:31 -0800 REGRESSION(r179476): It broke the !ENABLE(PICTURE_SIZES) build 2015-02-11 08:41:23 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 141026 1 ossy darin andersca commit-queue darin esprehn+autocc gyuyoung.kim ossy oldest_to_newest 1067331 0 ossy 2015-02-06 02:17:31 -0800 ../../Source/WebCore/html/parser/HTMLPreloadScanner.cpp: In member function 'void WebCore::TokenPreloadScanner::StartTagScanner::processAttributes(const AttributeList&, WebCore::Document&)': ../../Source/WebCore/html/parser/HTMLPreloadScanner.cpp:110:55: error: 'm_sizesAttribute' was not declared in this scope 1068357 1 ossy 2015-02-11 07:36:56 -0800 It seems nobody is interested in fixing this broken ENABLE(PICTURE_SIZES) guard. Can we remove this guard if nobody wants to build with disabled guard? 1068366 2 246393 darin 2015-02-11 08:30:25 -0800 Created attachment 246393 Patch 1068369 3 darin 2015-02-11 08:41:14 -0800 Committed r179928: <http://trac.webkit.org/changeset/179928> 246393 2015-02-11 08:30:25 -0800 2015-02-11 08:41:23 -0800 Patch bug-141327-20150211083028.patch text/plain 1729 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5OTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjhkYThlNjZmMTE3NTA3 NWFiYTQ4NmJmMDk1YTY4N2ZmMDU1ZWQ5Zi4uZTJlMzZjMzQ3ZTk0YWIxOTFiYjQ0NTZjMGNmYjJi Y2ZmNjJhNzU3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTAyLTExICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIxNzk0NzYp OiBJdCBicm9rZSB0aGUgIUVOQUJMRShQSUNUVVJFX1NJWkVTKSBidWlsZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQxMzI3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBodG1sL3BhcnNlci9IVE1MUHJl bG9hZFNjYW5uZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VG9rZW5QcmVsb2FkU2Nhbm5lcjo6 U3RhcnRUYWdTY2FubmVyOjpwcm9jZXNzQXR0cmlidXRlcyk6CisgICAgICAgIFB1dCAjaWYgYXJv dW5kIHVzZSBvZiBtX3NpemVzQXR0cmlidXRlLgorCiAyMDE1LTAyLTExICBDb21taXQgUXVldWUg IDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5n IG91dCByMTc5OTIxLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRN TFByZWxvYWRTY2FubmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxQcmVs b2FkU2Nhbm5lci5jcHAKaW5kZXggZjBlODhlN2RjYjNmOWVkOGM2NjI2ZGQ1MjE1ZWU3M2Y2NzRm Njc4ZS4uN2Q4MGNmN2FkYzk2NWM2MjFkOTcwZGY3ZDNhM2EyODY1NDY4MzFhMiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFByZWxvYWRTY2FubmVyLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MUHJlbG9hZFNjYW5uZXIuY3BwCkBAIC0x MDcsNyArMTA3LDEwIEBAIHB1YmxpYzoKIAogICAgICAgICAvLyBSZXNvbHZlIGJldHdlZW4gc3Jj IGFuZCBzcmNTZXQgaWYgd2UgaGF2ZSB0aGVtLgogICAgICAgICBpZiAoIW1fc3JjU2V0QXR0cmli dXRlLmlzRW1wdHkoKSkgewotICAgICAgICAgICAgdW5zaWduZWQgc291cmNlU2l6ZSA9IHBhcnNl U2l6ZXNBdHRyaWJ1dGUobV9zaXplc0F0dHJpYnV0ZSwgZG9jdW1lbnQucmVuZGVyVmlldygpLCBk b2N1bWVudC5mcmFtZSgpKTsKKyAgICAgICAgICAgIHVuc2lnbmVkIHNvdXJjZVNpemUgPSAwOwor I2lmIEVOQUJMRShQSUNUVVJFX1NJWkVTKQorICAgICAgICAgICAgc291cmNlU2l6ZSA9IHBhcnNl U2l6ZXNBdHRyaWJ1dGUobV9zaXplc0F0dHJpYnV0ZSwgZG9jdW1lbnQucmVuZGVyVmlldygpLCBk b2N1bWVudC5mcmFtZSgpKTsKKyNlbmRpZgogICAgICAgICAgICAgSW1hZ2VDYW5kaWRhdGUgaW1h Z2VDYW5kaWRhdGUgPSBiZXN0Rml0U291cmNlRm9ySW1hZ2VBdHRyaWJ1dGVzKG1fZGV2aWNlU2Nh bGVGYWN0b3IsIG1fdXJsVG9Mb2FkLCBtX3NyY1NldEF0dHJpYnV0ZSwgc291cmNlU2l6ZSk7CiAg ICAgICAgICAgICBzZXRVcmxUb0xvYWQoaW1hZ2VDYW5kaWRhdGUuc3RyaW5nLnRvU3RyaW5nKCks IHRydWUpOwogICAgICAgICB9Cg==