141326 2015-02-06 00:23:25 -0800 error: redefinition of 'tryGetFileBackedSharedBufferFromCFURLCachedResponse in OSX 10.8.5 2015-02-06 23:01:55 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Unspecified OS X 10.8 RESOLVED INVALID P2 Normal --- 1 hyungwook.lee webkit-unassigned ap commit-queue japhet oldest_to_newest 1067320 0 hyungwook.lee 2015-02-06 00:23:25 -0800 I've compilation errors on OSX 10.8.5 as follows. webkit/Source/WebCore/loader/cocoa/DiskCacheMonitorCocoa.mm:49:44: error: redefinition of 'tryGetFileBackedSharedBufferFromCFURLCachedResponse' PassRefPtr<SharedBuffer> DiskCacheMonitor::tryGetFileBackedSharedBufferFromCFURLCachedResponse(CFCachedURLResponseRef cachedResponse) ^ In file included from webkit/Source/WebCore/loader/cocoa/DiskCacheMonitorCocoa.mm:27: webkit/Source/WebCore/loader/cocoa/DiskCacheMonitorCocoa.h:64:51: note: previous definition is here inline PassRefPtr<SharedBuffer> DiskCacheMonitor::tryGetFileBackedSharedBufferFromCFURLCachedResponse(CFCachedURLResponseRef) ^ webkit/Source/WebCore/loader/cocoa/DiskCacheMonitorCocoa.mm:58:24: error: redefinition of 'monitorFileBackingStoreCreation' void DiskCacheMonitor::monitorFileBackingStoreCreation(const ResourceRequest& request, SessionID sessionID, CFCachedURLResponseRef cachedResponse) ^ In file included from webkit/Source/WebCore/loader/cocoa/DiskCacheMonitorCocoa.mm:27: webkit/Source/WebCore/loader/cocoa/DiskCacheMonitorCocoa.h:60:31: note: previous definition is here inline void DiskCacheMonitor::monitorFileBackingStoreCreation(const ResourceRequest&, SessionID, CFCachedURLResponseRef) 1067322 1 246153 hyungwook.lee 2015-02-06 00:32:55 -0800 Created attachment 246153 patch 1067501 2 246153 ap 2015-02-06 23:01:40 -0800 Comment on attachment 246153 patch Support for OS X 10.8 has been removed from WebKit trunk. I think that even with this fix, you will find out that a lot of things don't work correctly. 246153 2015-02-06 00:32:55 -0800 2015-02-06 23:01:40 -0800 patch patch text/plain 1944 hyungwook.lee SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3OTc0MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAyLTA2ICBIeXVuZ3dv b2sgTGVlICA8aHl1bmd3b29rLmxlZUBuYXZlcmNvcnAuY29tPgorCisgICAgICAgIEZpeCBjb21w aWxhdGlvbiBlcnJvcnMgaW4gRGlza0NhY2hlTW9uaXRvckNvY29hLm1tIG9uIE9TWCAxMC44LjUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MTMyNgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlZGVmaW5p dGlvbiBvZiB0cnlHZXRGaWxlQmFja2VkU2hhcmVkQnVmZmVyRnJvbUNGVVJMQ2FjaGVkUmVzcG9u c2UoKSwKKyAgICAgICAgbW9uaXRvckZpbGVCYWNraW5nU3RvcmVDcmVhdGlvbigpIGNhdXNlZCBi eSBtaXNzaW5nIFBsYXRmb3JtIGRlZmluZS4KKworICAgICAgICAqIGxvYWRlci9jb2NvYS9EaXNr Q2FjaGVNb25pdG9yQ29jb2EubW06CisKIDIwMTUtMDItMDUgIERoaSBBdXJyYWhtYW4gIDxkaW9y YWhtYW5Acm9ja3liYXJzLmNvbT4KIAogICAgICAgICBSZW1vdmUgZHVwbGljYXRlIGxvb3AgYWZ0 ZXIgcjE3OTUzMgpJbmRleDogU291cmNlL1dlYkNvcmUvbG9hZGVyL2NvY29hL0Rpc2tDYWNoZU1v bml0b3JDb2NvYS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvY29jb2Ev RGlza0NhY2hlTW9uaXRvckNvY29hLm1tCShyZXZpc2lvbiAxNzk3NDApCisrKyBTb3VyY2UvV2Vi Q29yZS9sb2FkZXIvY29jb2EvRGlza0NhY2hlTW9uaXRvckNvY29hLm1tCSh3b3JraW5nIGNvcHkp CkBAIC00Niw2ICs0Niw4IEBACiAvLyBUaGUgbWF4aW11bSBudW1iZXIgb2Ygc2Vjb25kcyB3ZSds bCB0cnkgdG8gd2FpdCBmb3IgYSByZXNvdXJjZSB0byBiZSBkaXNrIGNhY2hlZCBiZWZvcmUgd2Ug Zm9yZ2V0IHRoZSByZXF1ZXN0Lgogc3RhdGljIGNvbnN0IGRvdWJsZSBkaXNrQ2FjaGVNb25pdG9y VGltZW91dCA9IDIwOwogCisjaWYgKFBMQVRGT1JNKElPUykgJiYgX19JUEhPTkVfT1NfVkVSU0lP Tl9NSU5fUkVRVUlSRUQgPj0gODAwMDApIHx8IChQTEFURk9STShNQUMpICYmIF9fTUFDX09TX1hf VkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTA5MCkKKwogUGFzc1JlZlB0cjxTaGFyZWRCdWZmZXI+ IERpc2tDYWNoZU1vbml0b3I6OnRyeUdldEZpbGVCYWNrZWRTaGFyZWRCdWZmZXJGcm9tQ0ZVUkxD YWNoZWRSZXNwb25zZShDRkNhY2hlZFVSTFJlc3BvbnNlUmVmIGNhY2hlZFJlc3BvbnNlKQogewog ICAgIENGRGF0YVJlZiBkYXRhID0gX0NGQ2FjaGVkVVJMUmVzcG9uc2VHZXRNZW1NYXBwZWREYXRh KGNhY2hlZFJlc3BvbnNlKTsKQEAgLTYzLDYgKzY1LDggQEAKICAgICBuZXcgRGlza0NhY2hlTW9u aXRvcihyZXF1ZXN0LCBzZXNzaW9uSUQsIGNhY2hlZFJlc3BvbnNlKTsgLy8gQmFsYW5jZWQgYnkg YWRvcHRQdHIgaW4gdGhlIGJsb2NrcyBzZXR1cCBpbiB0aGUgY29uc3RydWN0b3IsIG9uZSBvZiB3 aGljaCBpcyBndWFyYW50ZWVkIHRvIHJ1bi4KIH0KIAorI2VuZGlmCisKIERpc2tDYWNoZU1vbml0 b3I6OkRpc2tDYWNoZU1vbml0b3IoY29uc3QgUmVzb3VyY2VSZXF1ZXN0JiByZXF1ZXN0LCBTZXNz aW9uSUQgc2Vzc2lvbklELCBDRkNhY2hlZFVSTFJlc3BvbnNlUmVmIGNhY2hlZFJlc3BvbnNlKQog ICAgIDogbV9yZXNvdXJjZVJlcXVlc3QocmVxdWVzdCkKICAgICAsIG1fc2Vzc2lvbklEKHNlc3Np b25JRCkK