141324 2015-02-05 22:24:01 -0800 REGRESSION(r179706): Caused memory corruption on some tests 2015-02-06 10:56:52 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 136544 1 commit-queue commit-queue esprehn+autocc glenn hyatt kondapallykalyan mjs zalan oldest_to_newest 1067311 0 commit-queue 2015-02-05 22:24:01 -0800 http://trac.webkit.org/changeset/179706 broke the build: Caused memory corruption on some tests (Requested by _ap_ on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 1067313 1 246150 commit-queue 2015-02-05 22:24:31 -0800 Created attachment 246150 ROLLOUT of r179706 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 1067317 2 246152 mjs 2015-02-06 00:21:22 -0800 Created attachment 246152 Patch 1067321 3 246152 ap 2015-02-06 00:29:13 -0800 Comment on attachment 246152 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246152&action=review > Source/WebCore/rendering/RenderLineBoxList.cpp:390 > + if (auto prevBox = box->prevRootBox()) There are different opinions on this, however I find it much preferable to see which classes I'm dealing with (i.e., I'd write this as RootInlineBox* previousBox = box->prevRootBox()). > Source/WebCore/rendering/RenderLineBoxList.cpp:392 > + // FIXME: Always dirty the next line. This is only strictly necessary some of the time, This sounds like a command (as if we needed always dirty the next line, but didn't). > Source/WebCore/rendering/RenderLineBoxList.cpp:394 > + // but it's hard to safely and completely compute the conditions under which it's safe > + // not to. I'd omit this, as it doesn't explain what is hard about this, and is thus unhelpful to the reader. 1067366 4 ap 2015-02-06 09:27:50 -0800 Ping? 1067374 5 zalan 2015-02-06 10:14:37 -0800 (In reply to comment #3) > Comment on attachment 246152 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=246152&action=review > > > Source/WebCore/rendering/RenderLineBoxList.cpp:390 > > + if (auto prevBox = box->prevRootBox()) > > There are different opinions on this, however I find it much preferable to > see which classes I'm dealing with (i.e., I'd write this as RootInlineBox* > previousBox = box->prevRootBox()). I am in favor of not over-using auto, but I think in this case auto is acceptable as the method (prev/nextRootBox()) hints that the return type is a root box. Hopefully the perf bots will catch if there's any inline layout performance impact of this change. 1067378 6 mjs 2015-02-06 10:56:52 -0800 Committed r179750: <http://trac.webkit.org/changeset/179750> 246150 2015-02-05 22:24:31 -0800 2015-02-06 00:21:12 -0800 ROLLOUT of r179706 bug-141324-20150205222430.patch text/plain 4166 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5NzQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2E3NTZlMGI1ZDJmYjMy NWQyZDk4YzQ1OWI5MDRkYzNlNTgxNGYxOC4uMzFiZWRmNDNiMGMxOTAwMjA3ZDJlN2NmY2NjZGEz ZWNkMGQyYjE0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTAyLTA1ICBDb21t aXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KKworICAgICAgICBVbnJldmlld2Vk LCByb2xsaW5nIG91dCByMTc5NzA2LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTQxMzI0CisKKyAgICAgICAgQ2F1c2VkIG1lbW9yeSBjb3JydXB0aW9u IG9uIHNvbWUgdGVzdHMgKFJlcXVlc3RlZCBieSBfYXBfIG9uCisgICAgICAgICN3ZWJraXQpLgor CisgICAgICAgIFJldmVydGVkIGNoYW5nZXNldDoKKworICAgICAgICAiQ3Jhc2ggZHVlIHRvIGZh aWxpbmcgdG8gZGlydHkgYSByZW1vdmVkIHRleHQgbm9kZSdzIGxpbmUgYm94IgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2NTQ0CisgICAgICAgIGh0 dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzE3OTcwNgorCiAyMDE1LTAyLTA1ICBEaGkg QXVycmFobWFuICA8ZGlvcmFobWFuQHJvY2t5YmFycy5jb20+CiAKICAgICAgICAgUmVtb3ZlIGR1 cGxpY2F0ZSBsb29wIGFmdGVyIHIxNzk1MzIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJMaW5lQm94TGlzdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyTGluZUJveExpc3QuY3BwCmluZGV4IDM5YTlkNGYxNDAzMDJhNDcxNzlhZjI2YjE5MGJm MGM3ZmM5MWM0NDIuLjg2ZWJjMTdjZTc4NThkYzAyNzIxMzVjYjJlMzY0OWExYTQyYjk3MjIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMaW5lQm94TGlzdC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxpbmVCb3hMaXN0LmNwcApAQCAt Mzk2LDcgKzM5Niw3IEBAIHZvaWQgUmVuZGVyTGluZUJveExpc3Q6OmRpcnR5TGluZXNGcm9tQ2hh bmdlZENoaWxkKFJlbmRlckJveE1vZGVsT2JqZWN0JiBjb250YWluCiAgICAgICAgIC8vIHNwYWNl LCB0aGUgc2VhcmNoIGZvciB8Y2hpbGR8J3MgbGluZWJveCB3aWxsIGdvIHBhc3QgdGhlIGxlYWRp bmcgc3BhY2UgdG8gdGhlIHByZXZpb3VzIGxpbmVib3ggYW5kIHNlbGVjdCB0aGF0CiAgICAgICAg IC8vIG9uZSBhcyB8Ym94fC4gSWYgd2UgaGl0IHRoYXQgc2l0dWF0aW9uIGhlcmUsIGRpcnR5IHRo ZSB8Ym94fCBhY3R1YWxseSBjb250YWluaW5nIHRoZSBjaGlsZCB0b28uIAogICAgICAgICBib29s IGluc2VydGVkQWZ0ZXJMZWFkaW5nU3BhY2UgPSBib3gtPmxpbmVCcmVha09iaigpID09IGNoaWxk LnByZXZpb3VzU2libGluZygpOwotICAgICAgICBpZiAoYWRqYWNlbnRCb3ggJiYgKGFkamFjZW50 Qm94LT5saW5lQnJlYWtPYmooKS0+aXNEZXNjZW5kYW50T2YoJmNoaWxkKSB8fCBjaGlsZC5pc0JS KCkgfHwgKGN1cnJlbnQgJiYgY3VycmVudC0+aXNCUigpKQorICAgICAgICBpZiAoYWRqYWNlbnRC b3ggJiYgKGFkamFjZW50Qm94LT5saW5lQnJlYWtPYmooKSA9PSAmY2hpbGQgfHwgY2hpbGQuaXNC UigpIHx8IChjdXJyZW50ICYmIGN1cnJlbnQtPmlzQlIoKSkKICAgICAgICAgICAgIHx8IGluc2Vy dGVkQWZ0ZXJMZWFkaW5nU3BhY2UgfHwgaXNJc29sYXRlZChjb250YWluZXIuc3R5bGUoKS51bmlj b2RlQmlkaSgpKSkpCiAgICAgICAgICAgICBhZGphY2VudEJveC0+bWFya0RpcnR5KCk7CiAgICAg fQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCmluZGV4IDMyY2QxZWM5YjgyYjZjNGRiNTMzMTZlNTVhOTAyMjc0OTA4NWNiOWUuLjEzOTRk MmZkNTNjZWVmNDRjY2EwMjgyZmM0MzI4ZDAwOTk1ZDJlOGEgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBA QAorMjAxNS0wMi0wNSAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CisK KyAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjE3OTcwNi4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MTMyNAorCisgICAgICAgIENhdXNl ZCBtZW1vcnkgY29ycnVwdGlvbiBvbiBzb21lIHRlc3RzIChSZXF1ZXN0ZWQgYnkgX2FwXyBvbgor ICAgICAgICAjd2Via2l0KS4KKworICAgICAgICBSZXZlcnRlZCBjaGFuZ2VzZXQ6CisKKyAgICAg ICAgIkNyYXNoIGR1ZSB0byBmYWlsaW5nIHRvIGRpcnR5IGEgcmVtb3ZlZCB0ZXh0IG5vZGUncyBs aW5lIGJveCIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEzNjU0NAorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8xNzk3MDYK KwogMjAxNS0wMi0wNSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAg ICAgICBUZXN0IGdhcmRlbmluZyBmb3IgaXNzdWVzIHVuY292ZXJlZCBieSBkaXNhYmxpbmcgcmV0 cmllcyBvbiBkZWJ1ZyBib3RzLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC90ZXh0L3Jl bW92ZS10ZXh0LW5vZGUtbGluZWJveC1ub3QtZGlydHktY3Jhc2gtZXhwZWN0ZWQudHh0IGIvTGF5 b3V0VGVzdHMvZmFzdC90ZXh0L3JlbW92ZS10ZXh0LW5vZGUtbGluZWJveC1ub3QtZGlydHktY3Jh c2gtZXhwZWN0ZWQudHh0CmRlbGV0ZWQgZmlsZSBtb2RlIDEwMDY0NAppbmRleCBkY2IxMDgxZDc4 OTQ5N2YzOWI3NzJhMjU3OGY1YThkMGFjYzNjODA2Li4wMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwCi0tLSBhL0xheW91dFRlc3RzL2Zhc3QvdGV4dC9yZW1vdmUtdGV4dC1u b2RlLWxpbmVib3gtbm90LWRpcnR5LWNyYXNoLWV4cGVjdGVkLnR4dAorKysgL2Rldi9udWxsCkBA IC0xLDMgKzAsMCBAQAotVGhpcyB0ZXN0IHBhc3NlcyBpZiBpdCBkb2VzIG5vdCBjcmFzaC4gIGJh cgotCi0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvdGV4dC9yZW1vdmUtdGV4dC1ub2Rl LWxpbmVib3gtbm90LWRpcnR5LWNyYXNoLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3RleHQvcmVt b3ZlLXRleHQtbm9kZS1saW5lYm94LW5vdC1kaXJ0eS1jcmFzaC5odG1sCmRlbGV0ZWQgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAxNTFjNTA0NTQ5MjhjZDMxNzVhYmQ5NGVlM2FjMzhmMjQxMGFjNmM0 Li4wMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwCi0tLSBhL0xheW91dFRl c3RzL2Zhc3QvdGV4dC9yZW1vdmUtdGV4dC1ub2RlLWxpbmVib3gtbm90LWRpcnR5LWNyYXNoLmh0 bWwKKysrIC9kZXYvbnVsbApAQCAtMSwyMyArMCwwIEBACi08c2NyaXB0PgotaWYgKHdpbmRvdy50 ZXN0UnVubmVyKSB7Ci0gICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7Ci0gICAgdGVzdFJ1bm5l ci53YWl0VW50aWxEb25lKCk7Ci19Ci0KLXdpbmRvdy5vbmxvYWQgPSBmdW5jdGlvbigpCi17Ci0g ICAgZG9jdW1lbnQuYm9keS5vZmZzZXRUb3A7Ci0gICAgYi5sYXN0Q2hpbGQucGFyZW50Tm9kZS5y ZW1vdmVDaGlsZChiLmxhc3RDaGlsZCk7Ci0gICAgZG9jdW1lbnQuYm9keS5vZmZzZXRUb3A7Ci0g ICAgYS5maXJzdENoaWxkLnBhcmVudE5vZGUucmVtb3ZlQ2hpbGQoYS5maXJzdENoaWxkKTsKLSAg ICBkb2N1bWVudC5ib2R5Lm9mZnNldFRvcDsKLSAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpCi0g ICAgICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOwotfQotPC9zY3JpcHQ+Ci08ZGl2IGlkPSJh Ij5mb288L2Rpdj4KLTxkaXY+PC9kaXY+Ci0gVGhpcyB0ZXN0IHBhc3NlcyBpZiBpdCBkb2VzIG5v dCBjcmFzaC4gPG91dHB1dD4KLTx1bmtub3duPmJhcjwvb3V0cHV0PgotPHNwYW4gaWQ9ImIiPgot PHNwYW4+PGRpdiBzdHlsZT0iZGlzcGxheTppbmxpbmUtYmxvY2siPjwvZGl2Pjxicj48YnI+PC9z cGFuPgo= 246152 2015-02-06 00:21:22 -0800 2015-02-06 00:29:13 -0800 Patch bug-141324-20150206002120.patch text/plain 3290 mjs SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3OTc0MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE1LTAyLTA2ICBNYWNpZWog U3RhY2hvd2lhayAgPG1qc0BhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMTc5NzA2 KTogQ2F1c2VkIG1lbW9yeSBjb3JydXB0aW9uIG9uIHNvbWUgdGVzdHMgKFJlcXVlc3RlZCBieSBf YXBfIG9uICN3ZWJraXQpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTQxMzI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGlzIGlzIGNhdWdodCBieSBleGlzdGluZyB0ZXN0cyB1 bmRlciBBU0FOLCBhbmQgSSBkb24ndCBrbm93IGhvdyB0byByZXByb2R1Y2UKKyAgICAgICAgaXQg d2l0aG91dCBBU0FOLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxpbmVCb3hMaXN0LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxpbmVCb3hMaXN0OjpkaXJ0eUxpbmVzRnJvbUNo YW5nZWRDaGlsZCk6IEdpdmUgdXAKKyAgICAgICAgYW5kIGp1c3QgYWx3YXlzIGludmFsaWRhdGUg dGhlIG5leHQgbGluZS4gSXQncyB0b28gaGFyZCB0byBjb21lIHVwCisgICAgICAgIHdpdGggdGhl IGNvbmRpdGlvbiB0aGF0IGNhdGNoZXMgYWxsIG5lZWRlZCBjYXNlcywgZG9lc24ndCBpdHNlbGYK KyAgICAgICAgY2F1c2UgYSBjcmFzaCwgYW5kIGlzbid0IG92ZXJ6ZWFsb3VzLiBBbmQgd2UgZG8g dGhpcyBmb3IgdGhlCisgICAgICAgIHByZXZpb3VzIGxpbmUgYW55d2F5LiAgQWxzbyBjbGVhbiB1 cCB0aGUgY29kZSBhIGJpdCBzaW5jZSBpdAorICAgICAgICBjb25mdXNpbmdseSByZXVzZXMgYSB2 YXJpYWJsZSwgYW5kIGRlY2xhcmVzIGl0IHVuaW5pdGlhbGl6ZWQsIGZvcgorICAgICAgICBubyBn b29kIHJlYXNvbi4KKwogMjAxNS0wMi0wNSAgRGhpIEF1cnJhaG1hbiAgPGRpb3JhaG1hbkByb2Nr eWJhcnMuY29tPgogCiAgICAgICAgIFJlbW92ZSBkdXBsaWNhdGUgbG9vcCBhZnRlciByMTc5NTMy CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGluZUJveExpc3QuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMaW5lQm94TGlzdC5j cHAJKHJldmlzaW9uIDE3OTczOSkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJM aW5lQm94TGlzdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM3OCw3ICszNzgsNiBAQCB2b2lkIFJl bmRlckxpbmVCb3hMaXN0OjpkaXJ0eUxpbmVzRnJvbUNoCiAKICAgICAvLyBJZiB3ZSBmb3VuZCBh IGxpbmUgYm94LCB0aGVuIGRpcnR5IGl0LgogICAgIGlmIChib3gpIHsKLSAgICAgICAgUm9vdElu bGluZUJveCogYWRqYWNlbnRCb3g7CiAgICAgICAgIGJveC0+bWFya0RpcnR5KCk7CiAKICAgICAg ICAgLy8gZGlydHkgdGhlIGFkamFjZW50IGxpbmVzIHRoYXQgbWlnaHQgYmUgYWZmZWN0ZWQKQEAg LTM4OCwxNyArMzg3LDEzIEBAIHZvaWQgUmVuZGVyTGluZUJveExpc3Q6OmRpcnR5TGluZXNGcm9t Q2gKICAgICAgICAgLy8gY2FsbHMgc2V0TGluZUJyZWFrSW5mbyB3aXRoIHRoZSByZXN1bHQgb2Yg ZmluZE5leHRMaW5lQnJlYWsuICBmaW5kTmV4dExpbmVCcmVhaywKICAgICAgICAgLy8gZGVzcGl0 ZSB0aGUgbmFtZSwgYWN0dWFsbHkgcmV0dXJucyB0aGUgZmlyc3QgUmVuZGVyT2JqZWN0IGFmdGVy IHRoZSBCUi4KICAgICAgICAgLy8gPHJkYXI6Ly9wcm9ibGVtLzM4NDk5NDc+ICJUeXBpbmcgYWZ0 ZXIgcGFzdGluZyBsaW5lIGRvZXMgbm90IGFwcGVhciB1bnRpbCBhZnRlciB3aW5kb3cgcmVzaXpl LiIKLSAgICAgICAgYWRqYWNlbnRCb3ggPSBib3gtPnByZXZSb290Qm94KCk7Ci0gICAgICAgIGlm IChhZGphY2VudEJveCkKLSAgICAgICAgICAgIGFkamFjZW50Qm94LT5tYXJrRGlydHkoKTsKLSAg ICAgICAgYWRqYWNlbnRCb3ggPSBib3gtPm5leHRSb290Qm94KCk7Ci0gICAgICAgIC8vIElmIHxj aGlsZHwgaGFzIGJlZW4gaW5zZXJ0ZWQgYmVmb3JlIHRoZSBmaXJzdCBlbGVtZW50IGluIHRoZSBs aW5lYm94LCBidXQgYWZ0ZXIgY29sbGFwc2VkIGxlYWRpbmcKLSAgICAgICAgLy8gc3BhY2UsIHRo ZSBzZWFyY2ggZm9yIHxjaGlsZHwncyBsaW5lYm94IHdpbGwgZ28gcGFzdCB0aGUgbGVhZGluZyBz cGFjZSB0byB0aGUgcHJldmlvdXMgbGluZWJveCBhbmQgc2VsZWN0IHRoYXQKLSAgICAgICAgLy8g b25lIGFzIHxib3h8LiBJZiB3ZSBoaXQgdGhhdCBzaXR1YXRpb24gaGVyZSwgZGlydHkgdGhlIHxi b3h8IGFjdHVhbGx5IGNvbnRhaW5pbmcgdGhlIGNoaWxkIHRvby4gCi0gICAgICAgIGJvb2wgaW5z ZXJ0ZWRBZnRlckxlYWRpbmdTcGFjZSA9IGJveC0+bGluZUJyZWFrT2JqKCkgPT0gY2hpbGQucHJl dmlvdXNTaWJsaW5nKCk7Ci0gICAgICAgIGlmIChhZGphY2VudEJveCAmJiAoYWRqYWNlbnRCb3gt PmxpbmVCcmVha09iaigpLT5pc0Rlc2NlbmRhbnRPZigmY2hpbGQpIHx8IGNoaWxkLmlzQlIoKSB8 fCAoY3VycmVudCAmJiBjdXJyZW50LT5pc0JSKCkpCi0gICAgICAgICAgICB8fCBpbnNlcnRlZEFm dGVyTGVhZGluZ1NwYWNlIHx8IGlzSXNvbGF0ZWQoY29udGFpbmVyLnN0eWxlKCkudW5pY29kZUJp ZGkoKSkpKQotICAgICAgICAgICAgYWRqYWNlbnRCb3gtPm1hcmtEaXJ0eSgpOworICAgICAgICBp ZiAoYXV0byBwcmV2Qm94ID0gYm94LT5wcmV2Um9vdEJveCgpKQorICAgICAgICAgICAgcHJldkJv eC0+bWFya0RpcnR5KCk7CisgICAgICAgIC8vIEZJWE1FOiBBbHdheXMgZGlydHkgdGhlIG5leHQg bGluZS4gVGhpcyBpcyBvbmx5IHN0cmljdGx5IG5lY2Vzc2FyeSBzb21lIG9mIHRoZSB0aW1lLCAK KyAgICAgICAgLy8gYnV0IGl0J3MgaGFyZCB0byBzYWZlbHkgYW5kIGNvbXBsZXRlbHkgY29tcHV0 ZSB0aGUgY29uZGl0aW9ucyB1bmRlciB3aGljaCBpdCdzIHNhZmUgCisgICAgICAgIC8vIG5vdCB0 by4KKyAgICAgICAgaWYgKGF1dG8gbmV4dEJveCA9IGJveC0+bmV4dFJvb3RCb3goKSkKKyAgICAg ICAgICAgIG5leHRCb3gtPm1hcmtEaXJ0eSgpOwogICAgIH0KIH0KIAo=