141313 2015-02-05 16:17:08 -0800 [iOS] Run a full garbage collection on memory warning. 2015-02-12 15:19:48 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Performance P2 Normal --- 1 kling kling barraclough commit-queue ggaren kling webkit-bug-importer oldest_to_newest 1067248 0 kling 2015-02-05 16:17:08 -0800 In the iOS/WebKit1 world, we would synchronously GC upon receiving a memory warning. We should have the same behavior in iOS/WebKit2. 1067249 1 webkit-bug-importer 2015-02-05 16:18:09 -0800 <rdar://problem/19738024> 1067272 2 246142 kling 2015-02-05 17:48:00 -0800 Created attachment 246142 Patch 1067275 3 246142 cdumez 2015-02-05 18:09:46 -0800 Comment on attachment 246142 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246142&action=review > Source/WebCore/platform/MemoryPressureHandler.cpp:139 > +#if PLATFORM(IOS) Since this is iOS-specific, it seems like this should be in MemoryPressureHandler::platformReleaseMemory(bool) in MemoryPressureHandlerCocoa.mm, right? 1067279 4 246143 kling 2015-02-05 18:40:23 -0800 Created attachment 246143 Patch Moved the logic per Chris's excellent suggestion. 1067281 5 246143 cdumez 2015-02-05 18:41:49 -0800 Comment on attachment 246143 Patch r=me 1067284 6 246143 kling 2015-02-05 19:14:25 -0800 Comment on attachment 246143 Patch Clearing flags on attachment: 246143 Committed r179737: <http://trac.webkit.org/changeset/179737> 1067285 7 kling 2015-02-05 19:14:30 -0800 All reviewed patches have been landed. Closing bug. 1068766 8 ggaren 2015-02-12 15:19:48 -0800 I'm worried about cost here in the edge case of pathological pressure. Let's do what you suggested in person -- GC now in response to background, GC soon in response to memory warning. 246142 2015-02-05 17:48:00 -0800 2015-02-05 18:40:23 -0800 Patch bug-141313.diff text/plain 1558 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjNDk0YTFhLi44OTM5NmRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTUtMDItMDUgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIFtpT1NdIFJ1biBhIGZ1bGwgZ2FyYmFnZSBjb2xsZWN0aW9uIG9uIG1lbW9yeSB3YXJuaW5n LgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTQxMzEzPgorICAgICAgICA8cmRhcjov L3Byb2JsZW0vMTk3MzgwMjQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTWFrZSBzdXJlIHRoYXQgd2UgcnVuIGEgZnVsbCBHQyB3aGVuIHRyeWluZyBm cmVlIHVwIG1lbW9yeSwgYXMgdGhpcyBtaWdodCBiZQorICAgICAgICBvdXIgbGFzdCBjaGFuY2Ug dG8gZXhlY3V0ZSBiZWZvcmUgdGhlIGtlcm5lbCBzdXNwZW5kcyB0aGlzIHByb2Nlc3MuCisKKyAg ICAgICAgVGhpcyBhbGlnbnMgV2ViS2l0MiB3aXRoIHRoZSBvbGQgV2ViS2l0MSBiZWhhdmlvci4K KworICAgICAgICAqIHBsYXRmb3JtL01lbW9yeVByZXNzdXJlSGFuZGxlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpNZW1vcnlQcmVzc3VyZUhhbmRsZXI6OnJlbGVhc2VNZW1vcnkpOgorCiAyMDE1 LTAyLTA1ICBNYWNpZWogU3RhY2hvd2lhayAgPG1qc0BhcHBsZS5jb20+CiAKICAgICAgICAgQ3Jh c2ggZHVlIHRvIGZhaWxpbmcgdG8gZGlydHkgYSByZW1vdmVkIHRleHQgbm9kZSdzIGxpbmUgYm94 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9NZW1vcnlQcmVzc3VyZUhhbmRs ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTWVtb3J5UHJlc3N1cmVIYW5kbGVyLmNw cAppbmRleCAwMzQxNDFkLi5lOGFmZjc2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9NZW1vcnlQcmVzc3VyZUhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL01lbW9yeVByZXNzdXJlSGFuZGxlci5jcHAKQEAgLTEzNiw2ICsxMzYsMTMgQEAgdm9pZCBN ZW1vcnlQcmVzc3VyZUhhbmRsZXI6OnJlbGVhc2VNZW1vcnkoYm9vbCBjcml0aWNhbCkKIAogICAg IHBsYXRmb3JtUmVsZWFzZU1lbW9yeShjcml0aWNhbCk7CiAKKyNpZiBQTEFURk9STShJT1MpCisg ICAgeworICAgICAgICBSZWxpZWZMb2dnZXIgbG9nKCJDb2xsZWN0aW5nIEphdmFTY3JpcHQgZ2Fy YmFnZSIpOworICAgICAgICBnY0NvbnRyb2xsZXIoKS5nYXJiYWdlQ29sbGVjdE5vdygpOworICAg IH0KKyNlbmRpZgorCiAgICAgewogICAgICAgICBSZWxpZWZMb2dnZXIgbG9nKCJSZWxlYXNlIGZy ZWUgRmFzdE1hbGxvYyBtZW1vcnkiKTsKICAgICAgICAgLy8gRmFzdE1hbGxvYyBoYXMgbG9jay1m cmVlIHRocmVhZCBzcGVjaWZpYyBjYWNoZXMgdGhhdCBjYW4gb25seSBiZSBjbGVhcmVkIGZyb20g dGhlIHRocmVhZCBpdHNlbGYuCg== 246143 2015-02-05 18:40:23 -0800 2015-02-05 19:14:25 -0800 Patch bug-141313-2.diff text/plain 1529 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjNDk0YTFhLi5lOWU0OTE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTUtMDItMDUgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIFtpT1NdIFJ1biBhIGZ1bGwgZ2FyYmFnZSBjb2xsZWN0aW9uIG9uIG1lbW9yeSB3YXJuaW5n LgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTQxMzEzPgorICAgICAgICA8cmRhcjov L3Byb2JsZW0vMTk3MzgwMjQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTWFrZSBzdXJlIHRoYXQgd2UgcnVuIGEgZnVsbCBHQyB3aGVuIHRyeWluZyB0 byBmcmVlIHVwIG1lbW9yeSwgYXMgdGhpcyBtaWdodAorICAgICAgICBiZSBvdXIgbGFzdCBjaGFu Y2UgdG8gZXhlY3V0ZSBiZWZvcmUgdGhlIGtlcm5lbCBzdXNwZW5kcyB0aGlzIHByb2Nlc3MuCisK KyAgICAgICAgVGhpcyBhbGlnbnMgV2ViS2l0MiB3aXRoIHRoZSBvbGQgV2ViS2l0MSBiZWhhdmlv ci4KKworICAgICAgICAqIHBsYXRmb3JtL2NvY29hL01lbW9yeVByZXNzdXJlSGFuZGxlckNvY29h Lm1tOgorICAgICAgICAoV2ViQ29yZTo6TWVtb3J5UHJlc3N1cmVIYW5kbGVyOjpwbGF0Zm9ybVJl bGVhc2VNZW1vcnkpOgorCisKIDIwMTUtMDItMDUgIE1hY2llaiBTdGFjaG93aWFrICA8bWpzQGFw cGxlLmNvbT4KIAogICAgICAgICBDcmFzaCBkdWUgdG8gZmFpbGluZyB0byBkaXJ0eSBhIHJlbW92 ZWQgdGV4dCBub2RlJ3MgbGluZSBib3gKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2NvY29hL01lbW9yeVByZXNzdXJlSGFuZGxlckNvY29hLm1tIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vY29jb2EvTWVtb3J5UHJlc3N1cmVIYW5kbGVyQ29jb2EubW0KaW5kZXggNTc3MjIw Yi4uYTM0NjFlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvTWVt b3J5UHJlc3N1cmVIYW5kbGVyQ29jb2EubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Y29jb2EvTWVtb3J5UHJlc3N1cmVIYW5kbGVyQ29jb2EubW0KQEAgLTU5LDYgKzU5LDEzIEBAIHZv aWQgTWVtb3J5UHJlc3N1cmVIYW5kbGVyOjpwbGF0Zm9ybVJlbGVhc2VNZW1vcnkoYm9vbCkKICAg ICAgICAgSU9TdXJmYWNlUG9vbDo6c2hhcmVkUG9vbCgpLmRpc2NhcmRBbGxTdXJmYWNlcygpOwog ICAgIH0KICNlbmRpZgorCisjaWYgUExBVEZPUk0oSU9TKQorICAgIHsKKyAgICAgICAgUmVsaWVm TG9nZ2VyIGxvZygiQ29sbGVjdGluZyBKYXZhU2NyaXB0IGdhcmJhZ2UiKTsKKyAgICAgICAgZ2ND b250cm9sbGVyKCkuZ2FyYmFnZUNvbGxlY3ROb3coKTsKKyAgICB9CisjZW5kaWYKIH0KIAogc3Rh dGljIGRpc3BhdGNoX3NvdXJjZV90IF9jYWNoZV9ldmVudF9zb3VyY2UgPSAwOwo=