141312 2015-02-05 16:08:05 -0800 Dashboard doesn't consider building ASan a productive step 2015-02-05 16:30:58 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap dburkart oldest_to_newest 1067242 0 ap 2015-02-05 16:08:05 -0800 This breaks displaying how far behind we are, possibly more. 1067246 1 246136 ap 2015-02-05 16:13:03 -0800 Created attachment 246136 proposed fix I started to wonder if we should consider "build" a productive step, or "upload". Is the builder behind if it successfully built, but failed to upload, and needs to build again? On one hand, it did tell us whether the build is broken, but on another hand, it didn't provide any binaries to testers. This patch just keeps with tradition. 1067250 2 246136 simon.fraser 2015-02-05 16:20:28 -0800 Comment on attachment 246136 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=246136&action=review > Tools/ChangeLog:15 > +2015-02-05 Alexey Proskuryakov <ap@apple.com> > + > + Need a short description (OOPS!). > + Need the bug URL (OOPS!). > + > + Reviewed by NOBODY (OOPS!). OOPS 1067251 3 ap 2015-02-05 16:30:58 -0800 Committed <http://trac.webkit.org/r179721>. 246136 2015-02-05 16:13:03 -0800 2015-02-05 16:20:28 -0800 proposed fix ProductiveStep.txt text/plain 1586 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3OTcyMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIxIEBACisyMDE1LTAyLTA1ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIERhc2hib2FyZCBkb2Vzbid0IGNvbnNpZGVyIGJ1aWxkaW5nIEFTYW4gYSBw cm9kdWN0aXZlIHN0ZXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0MTMxMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGlj X2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvQnVpbGRib3RJdGVyYXRpb24uanM6CisKKzIwMTUtMDIt MDUgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgTmVlZCBh IHNob3J0IGRlc2NyaXB0aW9uIChPT1BTISkuCisgICAgICAgIE5lZWQgdGhlIGJ1ZyBVUkwgKE9P UFMhKS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rh c2hib2FyZC9TY3JpcHRzL0J1aWxkYm90SXRlcmF0aW9uLmpzOgorCiAyMDE1LTAyLTA1ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSB3ZWJraXRweS54 Y29kZS5zaW11bGF0b3IuUnVudGltZS5mcm9tX2lkZW50aWZpZXIoKSByZXR1cm5zIHdyb25nIHJl c3VsdCBmb3Igbm9uLWV4aXN0ZW50IHJ1bnRpbWUKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBw b3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRz L0J1aWxkYm90SXRlcmF0aW9uLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBw b3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRz L0J1aWxkYm90SXRlcmF0aW9uLmpzCShyZXZpc2lvbiAxNzk3MDApCisrKyBUb29scy9CdWlsZFNs YXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQv U2NyaXB0cy9CdWlsZGJvdEl0ZXJhdGlvbi5qcwkod29ya2luZyBjb3B5KQpAQCAtNzEsNiArNzEs NyBAQCBCdWlsZGJvdEl0ZXJhdGlvbi5SRVRSWSA9IDU7CiBCdWlsZGJvdEl0ZXJhdGlvbi5Qcm9k dWN0aXZlU3RlcHMgPSB7CiAgICAgImNvbXBpbGUtd2Via2l0IjogMSwKICAgICAiYnVpbGQgYXJj aGl2ZSI6IDEsCisgICAgImJ1aWxkIEFTQU4gYXJjaGl2ZSI6IDEsCiAgICAgIkJ1aWxkIiA6IDEs CiAgICAgImxheW91dC10ZXN0IjogMSwKICAgICAianNjb3JlLXRlc3QiOiAxLAo=